Completed
Push — master ( 2b8b2c...7ca67f )
by
unknown
02:13
created
src/ConstraintCheck/DelegatingConstraintChecker.php 1 patch
Spacing   +146 added lines, -146 removed lines patch added patch discarded remove patch
@@ -144,20 +144,20 @@  discard block
 block discarded – undo
144 144
 		callable $defaultResultsPerEntity = null
145 145
 	) {
146 146
 		$checkResults = [];
147
-		$entity = $this->entityLookup->getEntity( $entityId );
147
+		$entity = $this->entityLookup->getEntity($entityId);
148 148
 
149
-		if ( $entity instanceof StatementListProvider ) {
150
-			$startTime = microtime( true );
149
+		if ($entity instanceof StatementListProvider) {
150
+			$startTime = microtime(true);
151 151
 
152 152
 			$checkResults = $this->checkEveryStatement(
153
-				$this->entityLookup->getEntity( $entityId ),
153
+				$this->entityLookup->getEntity($entityId),
154 154
 				$constraintIds,
155 155
 				$defaultResultsPerContext
156 156
 			);
157 157
 
158
-			$endTime = microtime( true );
158
+			$endTime = microtime(true);
159 159
 
160
-			if ( $constraintIds === null ) { // only log full constraint checks
160
+			if ($constraintIds === null) { // only log full constraint checks
161 161
 				$this->loggingHelper->logConstraintCheckOnEntity(
162 162
 					$entityId,
163 163
 					$checkResults,
@@ -167,11 +167,11 @@  discard block
 block discarded – undo
167 167
 			}
168 168
 		}
169 169
 
170
-		if ( $defaultResultsPerEntity !== null ) {
171
-			$checkResults = array_merge( $defaultResultsPerEntity( $entityId ), $checkResults );
170
+		if ($defaultResultsPerEntity !== null) {
171
+			$checkResults = array_merge($defaultResultsPerEntity($entityId), $checkResults);
172 172
 		}
173 173
 
174
-		return $this->sortResult( $checkResults );
174
+		return $this->sortResult($checkResults);
175 175
 	}
176 176
 
177 177
 	/**
@@ -193,19 +193,19 @@  discard block
 block discarded – undo
193 193
 		callable $defaultResults = null
194 194
 	) {
195 195
 
196
-		$parsedGuid = $this->statementGuidParser->parse( $guid );
196
+		$parsedGuid = $this->statementGuidParser->parse($guid);
197 197
 		$entityId = $parsedGuid->getEntityId();
198
-		$entity = $this->entityLookup->getEntity( $entityId );
199
-		if ( $entity instanceof StatementListProvider ) {
200
-			$statement = $entity->getStatements()->getFirstStatementWithGuid( $guid );
201
-			if ( $statement ) {
198
+		$entity = $this->entityLookup->getEntity($entityId);
199
+		if ($entity instanceof StatementListProvider) {
200
+			$statement = $entity->getStatements()->getFirstStatementWithGuid($guid);
201
+			if ($statement) {
202 202
 				$result = $this->checkStatement(
203 203
 					$entity,
204 204
 					$statement,
205 205
 					$constraintIds,
206 206
 					$defaultResults
207 207
 				);
208
-				$output = $this->sortResult( $result );
208
+				$output = $this->sortResult($result);
209 209
 				return $output;
210 210
 			}
211 211
 		}
@@ -213,8 +213,8 @@  discard block
 block discarded – undo
213 213
 		return [];
214 214
 	}
215 215
 
216
-	private function getAllowedContextTypes( Constraint $constraint ) {
217
-		if ( !array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
216
+	private function getAllowedContextTypes(Constraint $constraint) {
217
+		if (!array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
218 218
 			return [
219 219
 				Context::TYPE_STATEMENT,
220 220
 				Context::TYPE_QUALIFIER,
@@ -222,12 +222,12 @@  discard block
 block discarded – undo
222 222
 			];
223 223
 		}
224 224
 
225
-		return array_keys( array_filter(
225
+		return array_keys(array_filter(
226 226
 			$this->checkerMap[$constraint->getConstraintTypeItemId()]->getSupportedContextTypes(),
227
-			function ( $resultStatus ) {
227
+			function($resultStatus) {
228 228
 				return $resultStatus !== CheckResult::STATUS_NOT_IN_SCOPE;
229 229
 			}
230
-		) );
230
+		));
231 231
 	}
232 232
 
233 233
 	/**
@@ -238,32 +238,32 @@  discard block
 block discarded – undo
238 238
 	 *
239 239
 	 * @return ConstraintParameterException[]
240 240
 	 */
241
-	private function checkCommonConstraintParameters( Constraint $constraint ) {
241
+	private function checkCommonConstraintParameters(Constraint $constraint) {
242 242
 		$constraintParameters = $constraint->getConstraintParameters();
243 243
 		try {
244
-			$this->constraintParameterParser->checkError( $constraintParameters );
245
-		} catch ( ConstraintParameterException $e ) {
246
-			return [ $e ];
244
+			$this->constraintParameterParser->checkError($constraintParameters);
245
+		} catch (ConstraintParameterException $e) {
246
+			return [$e];
247 247
 		}
248 248
 
249 249
 		$problems = [];
250 250
 		try {
251
-			$this->constraintParameterParser->parseExceptionParameter( $constraintParameters );
252
-		} catch ( ConstraintParameterException $e ) {
251
+			$this->constraintParameterParser->parseExceptionParameter($constraintParameters);
252
+		} catch (ConstraintParameterException $e) {
253 253
 			$problems[] = $e;
254 254
 		}
255 255
 		try {
256
-			$this->constraintParameterParser->parseConstraintStatusParameter( $constraintParameters );
257
-		} catch ( ConstraintParameterException $e ) {
256
+			$this->constraintParameterParser->parseConstraintStatusParameter($constraintParameters);
257
+		} catch (ConstraintParameterException $e) {
258 258
 			$problems[] = $e;
259 259
 		}
260 260
 		try {
261 261
 			$this->constraintParameterParser->parseConstraintScopeParameter(
262 262
 				$constraintParameters,
263 263
 				$constraint->getConstraintTypeItemId(),
264
-				$this->getAllowedContextTypes( $constraint )
264
+				$this->getAllowedContextTypes($constraint)
265 265
 			);
266
-		} catch ( ConstraintParameterException $e ) {
266
+		} catch (ConstraintParameterException $e) {
267 267
 			$problems[] = $e;
268 268
 		}
269 269
 		return $problems;
@@ -276,16 +276,16 @@  discard block
 block discarded – undo
276 276
 	 * @return ConstraintParameterException[][] first level indexed by constraint ID,
277 277
 	 * second level like checkConstraintParametersOnConstraintId (but without possibility of null)
278 278
 	 */
279
-	public function checkConstraintParametersOnPropertyId( PropertyId $propertyId ) {
280
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
279
+	public function checkConstraintParametersOnPropertyId(PropertyId $propertyId) {
280
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
281 281
 		$result = [];
282 282
 
283
-		foreach ( $constraints as $constraint ) {
284
-			$problems = $this->checkCommonConstraintParameters( $constraint );
283
+		foreach ($constraints as $constraint) {
284
+			$problems = $this->checkCommonConstraintParameters($constraint);
285 285
 
286
-			if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
286
+			if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
287 287
 				$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
288
-				$problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) );
288
+				$problems = array_merge($problems, $checker->checkConstraintParameters($constraint));
289 289
 			}
290 290
 
291 291
 			$result[$constraint->getConstraintId()] = $problems;
@@ -302,17 +302,17 @@  discard block
 block discarded – undo
302 302
 	 * @return ConstraintParameterException[]|null list of constraint parameter exceptions
303 303
 	 * (empty means all parameters okay), or null if constraint is not found
304 304
 	 */
305
-	public function checkConstraintParametersOnConstraintId( $constraintId ) {
306
-		$propertyId = $this->statementGuidParser->parse( $constraintId )->getEntityId();
307
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
305
+	public function checkConstraintParametersOnConstraintId($constraintId) {
306
+		$propertyId = $this->statementGuidParser->parse($constraintId)->getEntityId();
307
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
308 308
 
309
-		foreach ( $constraints as $constraint ) {
310
-			if ( $constraint->getConstraintId() === $constraintId ) {
311
-				$problems = $this->checkCommonConstraintParameters( $constraint );
309
+		foreach ($constraints as $constraint) {
310
+			if ($constraint->getConstraintId() === $constraintId) {
311
+				$problems = $this->checkCommonConstraintParameters($constraint);
312 312
 
313
-				if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
313
+				if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
314 314
 					$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
315
-					$problems = array_merge( $problems, $checker->checkConstraintParameters( $constraint ) );
315
+					$problems = array_merge($problems, $checker->checkConstraintParameters($constraint));
316 316
 				}
317 317
 
318 318
 				return $problems;
@@ -337,14 +337,14 @@  discard block
 block discarded – undo
337 337
 		$result = [];
338 338
 
339 339
 		/** @var Statement $statement */
340
-		foreach ( $entity->getStatements() as $statement ) {
341
-			$result = array_merge( $result,
340
+		foreach ($entity->getStatements() as $statement) {
341
+			$result = array_merge($result,
342 342
 				$this->checkStatement(
343 343
 					$entity,
344 344
 					$statement,
345 345
 					$constraintIds,
346 346
 					$defaultResultsPerContext
347
-				) );
347
+				));
348 348
 		}
349 349
 
350 350
 		return $result;
@@ -366,32 +366,32 @@  discard block
 block discarded – undo
366 366
 	) {
367 367
 		$result = [];
368 368
 
369
-		$result = array_merge( $result,
369
+		$result = array_merge($result,
370 370
 			$this->checkConstraintsForMainSnak(
371 371
 				$entity,
372 372
 				$statement,
373 373
 				$constraintIds,
374 374
 				$defaultResultsPerContext
375
-			) );
375
+			));
376 376
 
377
-		if ( $this->checkQualifiers ) {
378
-			$result = array_merge( $result,
377
+		if ($this->checkQualifiers) {
378
+			$result = array_merge($result,
379 379
 				$this->checkConstraintsForQualifiers(
380 380
 					$entity,
381 381
 					$statement,
382 382
 					$constraintIds,
383 383
 					$defaultResultsPerContext
384
-				) );
384
+				));
385 385
 		}
386 386
 
387
-		if ( $this->checkReferences ) {
388
-			$result = array_merge( $result,
387
+		if ($this->checkReferences) {
388
+			$result = array_merge($result,
389 389
 				$this->checkConstraintsForReferences(
390 390
 					$entity,
391 391
 					$statement,
392 392
 					$constraintIds,
393 393
 					$defaultResultsPerContext
394
-				) );
394
+				));
395 395
 		}
396 396
 
397 397
 		return $result;
@@ -406,12 +406,12 @@  discard block
 block discarded – undo
406 406
 	 * @param string[]|null $constraintIds
407 407
 	 * @return Constraint[]
408 408
 	 */
409
-	private function getConstraintsToUse( PropertyId $propertyId, array $constraintIds = null ) {
410
-		$constraints = $this->constraintLookup->queryConstraintsForProperty( $propertyId );
411
-		if ( $constraintIds !== null ) {
409
+	private function getConstraintsToUse(PropertyId $propertyId, array $constraintIds = null) {
410
+		$constraints = $this->constraintLookup->queryConstraintsForProperty($propertyId);
411
+		if ($constraintIds !== null) {
412 412
 			$constraintsToUse = [];
413
-			foreach ( $constraints as $constraint ) {
414
-				if ( in_array( $constraint->getConstraintId(), $constraintIds ) ) {
413
+			foreach ($constraints as $constraint) {
414
+				if (in_array($constraint->getConstraintId(), $constraintIds)) {
415 415
 					$constraintsToUse[] = $constraint;
416 416
 				}
417 417
 			}
@@ -435,29 +435,29 @@  discard block
 block discarded – undo
435 435
 		array $constraintIds = null,
436 436
 		callable $defaultResults = null
437 437
 	) {
438
-		$context = new MainSnakContext( $entity, $statement );
438
+		$context = new MainSnakContext($entity, $statement);
439 439
 		$constraints = $this->getConstraintsToUse(
440 440
 			$statement->getPropertyId(),
441 441
 			$constraintIds
442 442
 		);
443
-		$result = $defaultResults !== null ? $defaultResults( $context ) : [];
443
+		$result = $defaultResults !== null ? $defaultResults($context) : [];
444 444
 
445
-		foreach ( $constraints as $constraint ) {
445
+		foreach ($constraints as $constraint) {
446 446
 			$parameters = $constraint->getConstraintParameters();
447 447
 			try {
448
-				$exceptions = $this->constraintParameterParser->parseExceptionParameter( $parameters );
449
-			} catch ( ConstraintParameterException $e ) {
450
-				$result[] = new CheckResult( $context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
448
+				$exceptions = $this->constraintParameterParser->parseExceptionParameter($parameters);
449
+			} catch (ConstraintParameterException $e) {
450
+				$result[] = new CheckResult($context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
451 451
 				continue;
452 452
 			}
453 453
 
454
-			if ( in_array( $entity->getId(), $exceptions ) ) {
455
-				$message = new ViolationMessage( 'wbqc-violation-message-exception' );
456
-				$result[] = new CheckResult( $context, $constraint, [], CheckResult::STATUS_EXCEPTION, $message );
454
+			if (in_array($entity->getId(), $exceptions)) {
455
+				$message = new ViolationMessage('wbqc-violation-message-exception');
456
+				$result[] = new CheckResult($context, $constraint, [], CheckResult::STATUS_EXCEPTION, $message);
457 457
 				continue;
458 458
 			}
459 459
 
460
-			$result[] = $this->getCheckResultFor( $context, $constraint );
460
+			$result[] = $this->getCheckResultFor($context, $constraint);
461 461
 		}
462 462
 
463 463
 		return $result;
@@ -479,24 +479,24 @@  discard block
 block discarded – undo
479 479
 	) {
480 480
 		$result = [];
481 481
 
482
-		if ( in_array(
482
+		if (in_array(
483 483
 			$statement->getPropertyId()->getSerialization(),
484 484
 			$this->propertiesWithViolatingQualifiers
485
-		) ) {
485
+		)) {
486 486
 			return $result;
487 487
 		}
488 488
 
489
-		foreach ( $statement->getQualifiers() as $qualifier ) {
490
-			$qualifierContext = new QualifierContext( $entity, $statement, $qualifier );
491
-			if ( $defaultResultsPerContext !== null ) {
492
-				$result = array_merge( $result, $defaultResultsPerContext( $qualifierContext ) );
489
+		foreach ($statement->getQualifiers() as $qualifier) {
490
+			$qualifierContext = new QualifierContext($entity, $statement, $qualifier);
491
+			if ($defaultResultsPerContext !== null) {
492
+				$result = array_merge($result, $defaultResultsPerContext($qualifierContext));
493 493
 			}
494 494
 			$qualifierConstraints = $this->getConstraintsToUse(
495 495
 				$qualifierContext->getSnak()->getPropertyId(),
496 496
 				$constraintIds
497 497
 			);
498
-			foreach ( $qualifierConstraints as $qualifierConstraint ) {
499
-				$result[] = $this->getCheckResultFor( $qualifierContext, $qualifierConstraint );
498
+			foreach ($qualifierConstraints as $qualifierConstraint) {
499
+				$result[] = $this->getCheckResultFor($qualifierContext, $qualifierConstraint);
500 500
 			}
501 501
 		}
502 502
 
@@ -520,19 +520,19 @@  discard block
 block discarded – undo
520 520
 		$result = [];
521 521
 
522 522
 		/** @var Reference $reference */
523
-		foreach ( $statement->getReferences() as $reference ) {
524
-			foreach ( $reference->getSnaks() as $snak ) {
523
+		foreach ($statement->getReferences() as $reference) {
524
+			foreach ($reference->getSnaks() as $snak) {
525 525
 				$referenceContext = new ReferenceContext(
526 526
 					$entity, $statement, $reference, $snak
527 527
 				);
528
-				if ( $defaultResultsPerContext !== null ) {
529
-					$result = array_merge( $result, $defaultResultsPerContext( $referenceContext ) );
528
+				if ($defaultResultsPerContext !== null) {
529
+					$result = array_merge($result, $defaultResultsPerContext($referenceContext));
530 530
 				}
531 531
 				$referenceConstraints = $this->getConstraintsToUse(
532 532
 					$referenceContext->getSnak()->getPropertyId(),
533 533
 					$constraintIds
534 534
 				);
535
-				foreach ( $referenceConstraints as $referenceConstraint ) {
535
+				foreach ($referenceConstraints as $referenceConstraint) {
536 536
 					$result[] = $this->getCheckResultFor(
537 537
 						$referenceContext,
538 538
 						$referenceConstraint
@@ -551,43 +551,43 @@  discard block
 block discarded – undo
551 551
 	 * @throws InvalidArgumentException
552 552
 	 * @return CheckResult
553 553
 	 */
554
-	private function getCheckResultFor( Context $context, Constraint $constraint ) {
555
-		if ( array_key_exists( $constraint->getConstraintTypeItemId(), $this->checkerMap ) ) {
554
+	private function getCheckResultFor(Context $context, Constraint $constraint) {
555
+		if (array_key_exists($constraint->getConstraintTypeItemId(), $this->checkerMap)) {
556 556
 			$checker = $this->checkerMap[$constraint->getConstraintTypeItemId()];
557
-			$result = $this->handleScope( $checker, $context, $constraint );
557
+			$result = $this->handleScope($checker, $context, $constraint);
558 558
 
559
-			if ( $result !== null ) {
560
-				$this->addMetadata( $context, $result );
559
+			if ($result !== null) {
560
+				$this->addMetadata($context, $result);
561 561
 				return $result;
562 562
 			}
563 563
 
564
-			$startTime = microtime( true );
564
+			$startTime = microtime(true);
565 565
 			try {
566
-				$result = $checker->checkConstraint( $context, $constraint );
567
-			} catch ( ConstraintParameterException $e ) {
568
-				$result = new CheckResult( $context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
569
-			} catch ( SparqlHelperException $e ) {
570
-				$message = new ViolationMessage( 'wbqc-violation-message-sparql-error' );
571
-				$result = new CheckResult( $context, $constraint, [], CheckResult::STATUS_TODO, $message );
566
+				$result = $checker->checkConstraint($context, $constraint);
567
+			} catch (ConstraintParameterException $e) {
568
+				$result = new CheckResult($context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
569
+			} catch (SparqlHelperException $e) {
570
+				$message = new ViolationMessage('wbqc-violation-message-sparql-error');
571
+				$result = new CheckResult($context, $constraint, [], CheckResult::STATUS_TODO, $message);
572 572
 			}
573
-			$endTime = microtime( true );
573
+			$endTime = microtime(true);
574 574
 
575
-			$this->addMetadata( $context, $result );
575
+			$this->addMetadata($context, $result);
576 576
 
577
-			$this->downgradeResultStatus( $context, $result );
577
+			$this->downgradeResultStatus($context, $result);
578 578
 
579 579
 			$this->loggingHelper->logConstraintCheck(
580 580
 				$context,
581 581
 				$constraint,
582 582
 				$result,
583
-				get_class( $checker ),
583
+				get_class($checker),
584 584
 				$endTime - $startTime,
585 585
 				__METHOD__
586 586
 			);
587 587
 
588 588
 			return $result;
589 589
 		} else {
590
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_TODO, null );
590
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_TODO, null);
591 591
 		}
592 592
 	}
593 593
 
@@ -601,61 +601,61 @@  discard block
 block discarded – undo
601 601
 				$constraint->getConstraintParameters(),
602 602
 				$constraint->getConstraintTypeItemId()
603 603
 			);
604
-		} catch ( ConstraintParameterException $e ) {
605
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
604
+		} catch (ConstraintParameterException $e) {
605
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
606 606
 		}
607
-		if ( $checkedContextTypes === null ) {
607
+		if ($checkedContextTypes === null) {
608 608
 			$checkedContextTypes = $checker->getDefaultContextTypes();
609 609
 		}
610
-		if ( !in_array( $context->getType(), $checkedContextTypes ) ) {
611
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE, null );
610
+		if (!in_array($context->getType(), $checkedContextTypes)) {
611
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_NOT_IN_SCOPE, null);
612 612
 		}
613
-		if ( $checker->getSupportedContextTypes()[$context->getType()] === CheckResult::STATUS_TODO ) {
614
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_TODO, null );
613
+		if ($checker->getSupportedContextTypes()[$context->getType()] === CheckResult::STATUS_TODO) {
614
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_TODO, null);
615 615
 		}
616 616
 		return null;
617 617
 	}
618 618
 
619
-	private function addMetadata( Context $context, CheckResult $result ) {
620
-		$result->withMetadata( Metadata::merge( [
619
+	private function addMetadata(Context $context, CheckResult $result) {
620
+		$result->withMetadata(Metadata::merge([
621 621
 			$result->getMetadata(),
622
-			Metadata::ofDependencyMetadata( DependencyMetadata::merge( [
623
-				DependencyMetadata::ofEntityId( $context->getEntity()->getId() ),
624
-				DependencyMetadata::ofEntityId( $result->getConstraint()->getPropertyId() ),
625
-			] ) ),
626
-		] ) );
622
+			Metadata::ofDependencyMetadata(DependencyMetadata::merge([
623
+				DependencyMetadata::ofEntityId($context->getEntity()->getId()),
624
+				DependencyMetadata::ofEntityId($result->getConstraint()->getPropertyId()),
625
+			])),
626
+		]));
627 627
 	}
628 628
 
629
-	private function downgradeResultStatus( Context $context, CheckResult &$result ) {
629
+	private function downgradeResultStatus(Context $context, CheckResult &$result) {
630 630
 		$constraint = $result->getConstraint();
631 631
 		try {
632 632
 			$constraintStatus = $this->constraintParameterParser
633
-				->parseConstraintStatusParameter( $constraint->getConstraintParameters() );
634
-		} catch ( ConstraintParameterException $e ) {
635
-			$result = new CheckResult( $context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage() );
633
+				->parseConstraintStatusParameter($constraint->getConstraintParameters());
634
+		} catch (ConstraintParameterException $e) {
635
+			$result = new CheckResult($context, $constraint, [], CheckResult::STATUS_BAD_PARAMETERS, $e->getViolationMessage());
636 636
 			$constraintStatus = null;
637 637
 		}
638
-		if ( $constraintStatus === null ) {
638
+		if ($constraintStatus === null) {
639 639
 			// downgrade violation to warning
640
-			if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) {
641
-				$result->setStatus( CheckResult::STATUS_WARNING );
640
+			if ($result->getStatus() === CheckResult::STATUS_VIOLATION) {
641
+				$result->setStatus(CheckResult::STATUS_WARNING);
642 642
 			}
643
-		} elseif ( $constraintStatus === 'suggestion' ) {
643
+		} elseif ($constraintStatus === 'suggestion') {
644 644
 			// downgrade violation to suggestion
645
-			if ( $result->getStatus() === CheckResult::STATUS_VIOLATION ) {
646
-				$result->setStatus( CheckResult::STATUS_SUGGESTION );
645
+			if ($result->getStatus() === CheckResult::STATUS_VIOLATION) {
646
+				$result->setStatus(CheckResult::STATUS_SUGGESTION);
647 647
 			}
648
-			$result->addParameter( 'constraint_status', $constraintStatus );
648
+			$result->addParameter('constraint_status', $constraintStatus);
649 649
 		} else {
650
-			if ( $constraintStatus !== 'mandatory' ) {
650
+			if ($constraintStatus !== 'mandatory') {
651 651
 				// @codeCoverageIgnoreStart
652 652
 				throw new LogicException(
653
-					"Unknown constraint status '$constraintStatus', " .
653
+					"Unknown constraint status '$constraintStatus', ".
654 654
 					"only known statuses are 'mandatory' and 'suggestion'"
655 655
 				);
656 656
 				// @codeCoverageIgnoreEnd
657 657
 			}
658
-			$result->addParameter( 'constraint_status', $constraintStatus );
658
+			$result->addParameter('constraint_status', $constraintStatus);
659 659
 		}
660 660
 	}
661 661
 
@@ -664,12 +664,12 @@  discard block
 block discarded – undo
664 664
 	 *
665 665
 	 * @return CheckResult[]
666 666
 	 */
667
-	private function sortResult( array $result ) {
668
-		if ( count( $result ) < 2 ) {
667
+	private function sortResult(array $result) {
668
+		if (count($result) < 2) {
669 669
 			return $result;
670 670
 		}
671 671
 
672
-		$sortFunction = function ( CheckResult $a, CheckResult $b ) {
672
+		$sortFunction = function(CheckResult $a, CheckResult $b) {
673 673
 			$orderNum = 0;
674 674
 			$order = [
675 675
 				CheckResult::STATUS_BAD_PARAMETERS => $orderNum++,
@@ -686,55 +686,55 @@  discard block
 block discarded – undo
686 686
 			$statusA = $a->getStatus();
687 687
 			$statusB = $b->getStatus();
688 688
 
689
-			$orderA = array_key_exists( $statusA, $order ) ? $order[ $statusA ] : $order[ 'other' ];
690
-			$orderB = array_key_exists( $statusB, $order ) ? $order[ $statusB ] : $order[ 'other' ];
689
+			$orderA = array_key_exists($statusA, $order) ? $order[$statusA] : $order['other'];
690
+			$orderB = array_key_exists($statusB, $order) ? $order[$statusB] : $order['other'];
691 691
 
692
-			if ( $orderA === $orderB ) {
692
+			if ($orderA === $orderB) {
693 693
 				$cursorA = $a->getContextCursor();
694 694
 				$cursorB = $b->getContextCursor();
695 695
 
696
-				if ( $cursorA instanceof EntityContextCursor ) {
696
+				if ($cursorA instanceof EntityContextCursor) {
697 697
 					return $cursorB instanceof EntityContextCursor ? 0 : -1;
698 698
 				}
699
-				if ( $cursorB instanceof EntityContextCursor ) {
699
+				if ($cursorB instanceof EntityContextCursor) {
700 700
 					return $cursorA instanceof EntityContextCursor ? 0 : 1;
701 701
 				}
702 702
 
703 703
 				$pidA = $cursorA->getSnakPropertyId();
704 704
 				$pidB = $cursorB->getSnakPropertyId();
705 705
 
706
-				if ( $pidA === $pidB ) {
706
+				if ($pidA === $pidB) {
707 707
 					$hashA = $cursorA->getSnakHash();
708 708
 					$hashB = $cursorB->getSnakHash();
709 709
 
710
-					if ( $hashA === $hashB ) {
711
-						if ( $a instanceof NullResult ) {
710
+					if ($hashA === $hashB) {
711
+						if ($a instanceof NullResult) {
712 712
 							return $b instanceof NullResult ? 0 : -1;
713 713
 						}
714
-						if ( $b instanceof NullResult ) {
714
+						if ($b instanceof NullResult) {
715 715
 							return $a instanceof NullResult ? 0 : 1;
716 716
 						}
717 717
 
718 718
 						$typeA = $a->getConstraint()->getConstraintTypeItemId();
719 719
 						$typeB = $b->getConstraint()->getConstraintTypeItemId();
720 720
 
721
-						if ( $typeA == $typeB ) {
721
+						if ($typeA == $typeB) {
722 722
 							return 0;
723 723
 						} else {
724
-							return ( $typeA > $typeB ) ? 1 : -1;
724
+							return ($typeA > $typeB) ? 1 : -1;
725 725
 						}
726 726
 					} else {
727
-						return ( $hashA > $hashB ) ? 1 : -1;
727
+						return ($hashA > $hashB) ? 1 : -1;
728 728
 					}
729 729
 				} else {
730
-					return ( $pidA > $pidB ) ? 1 : -1;
730
+					return ($pidA > $pidB) ? 1 : -1;
731 731
 				}
732 732
 			} else {
733
-				return ( $orderA > $orderB ) ? 1 : -1;
733
+				return ($orderA > $orderB) ? 1 : -1;
734 734
 			}
735 735
 		};
736 736
 
737
-		uasort( $result, $sortFunction );
737
+		uasort($result, $sortFunction);
738 738
 
739 739
 		return $result;
740 740
 	}
Please login to merge, or discard this patch.