Inspection of "Merge "Remove ConstraintReportFactory::getConstrai..." - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1143d9...c006ff )

unknown

created 2018-05-29 16:51 UTC

Status

Spacing +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -143,7 +143,7 @@  discard block
 block discarded – undo
 	public static function getDefaultInstance() {
 		static $instance = null;
 
-		if ( $instance === null ) {
+		if ($instance === null) {
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 			$config = MediaWikiServices::getInstance()->getMainConfig();
 			$titleParser = MediaWikiServices::getInstance()->getTitleParser();
@@ -206,21 +206,21 @@  discard block
 block discarded – undo
 	 * @return DelegatingConstraintChecker
 	 */
 	public function getConstraintChecker() {
-		if ( $this->delegatingConstraintChecker === null ) {
+		if ($this->delegatingConstraintChecker === null) {
 			$this->delegatingConstraintChecker = new DelegatingConstraintChecker(
 				$this->lookup,
 				$this->getConstraintCheckerMap(),
-				new CachingConstraintLookup( $this->getConstraintRepository() ),
+				new CachingConstraintLookup($this->getConstraintRepository()),
 				$this->constraintParameterParser,
 				$this->statementGuidParser,
 				new LoggingHelper(
 					$this->dataFactory,
-					LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
+					LoggerFactory::getInstance('WikibaseQualityConstraints'),
 					$this->config
 				),
-				$this->config->get( 'WBQualityConstraintsCheckQualifiers' ),
-				$this->config->get( 'WBQualityConstraintsCheckReferences' ),
-				$this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
+				$this->config->get('WBQualityConstraintsCheckQualifiers'),
+				$this->config->get('WBQualityConstraintsCheckReferences'),
+				$this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
 			);
 		}
 
@@ -231,10 +231,10 @@  discard block
 block discarded – undo
 	 * @return ConstraintChecker[]
 	 */
 	private function getConstraintCheckerMap() {
-		if ( $this->constraintCheckerMap === null ) {
+		if ($this->constraintCheckerMap === null) {
 			$connectionCheckerHelper = new ConnectionCheckerHelper();
-			$rangeCheckerHelper = new RangeCheckerHelper( $this->config, $this->unitConverter );
-			if ( $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ) !== '' ) {
+			$rangeCheckerHelper = new RangeCheckerHelper($this->config, $this->unitConverter);
+			if ($this->config->get('WBQualityConstraintsSparqlEndpoint') !== '') {
 				$sparqlHelper = new SparqlHelper(
 					$this->config,
 					$this->rdfVocabulary,
@@ -256,116 +256,116 @@  discard block
 block discarded – undo
 			);
 
 			$this->constraintCheckerMap = [
-				$this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
+				$this->config->get('WBQualityConstraintsConflictsWithConstraintId')
 					=> new ConflictsWithChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
+				$this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
 					=> new ItemChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
+				$this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
 					=> new TargetRequiredClaimChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsSymmetricConstraintId' )
+				$this->config->get('WBQualityConstraintsSymmetricConstraintId')
 					=> new SymmetricChecker(
 						$this->lookup,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsInverseConstraintId' )
+				$this->config->get('WBQualityConstraintsInverseConstraintId')
 					=> new InverseChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
 					=> new QualifierChecker(),
-				$this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
+				$this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
 					=> new QualifiersChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
+				$this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
 					=> new MandatoryQualifiersChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsRangeConstraintId' )
+				$this->config->get('WBQualityConstraintsRangeConstraintId')
 					=> new RangeChecker(
 						$this->propertyDataTypeLookup,
 						$this->constraintParameterParser,
 						$rangeCheckerHelper
 					),
-				$this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
+				$this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
 					=> new DiffWithinRangeChecker(
 						$this->constraintParameterParser,
 						$rangeCheckerHelper,
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsTypeConstraintId' )
+				$this->config->get('WBQualityConstraintsTypeConstraintId')
 					=> new TypeChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$typeCheckerHelper,
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' )
+				$this->config->get('WBQualityConstraintsValueTypeConstraintId')
 					=> new ValueTypeChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$typeCheckerHelper,
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsSingleValueConstraintId' )
-					=> new SingleValueChecker( $this->constraintParameterParser ),
-				$this->config->get( 'WBQualityConstraintsMultiValueConstraintId' )
-					=> new MultiValueChecker( $this->constraintParameterParser ),
-				$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
+				$this->config->get('WBQualityConstraintsSingleValueConstraintId')
+					=> new SingleValueChecker($this->constraintParameterParser),
+				$this->config->get('WBQualityConstraintsMultiValueConstraintId')
+					=> new MultiValueChecker($this->constraintParameterParser),
+				$this->config->get('WBQualityConstraintsDistinctValuesConstraintId')
 					=> new UniqueValueChecker(
 						$sparqlHelper
 					),
-				$this->config->get( 'WBQualityConstraintsFormatConstraintId' )
+				$this->config->get('WBQualityConstraintsFormatConstraintId')
 					=> new FormatChecker(
 						$this->constraintParameterParser,
 						$this->config,
 						$sparqlHelper
 					),
-				$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
+				$this->config->get('WBQualityConstraintsCommonsLinkConstraintId')
 					=> new CommonsLinkChecker(
 						$this->constraintParameterParser,
 						$this->titleParser
 					),
-				$this->config->get( 'WBQualityConstraintsOneOfConstraintId' )
+				$this->config->get('WBQualityConstraintsOneOfConstraintId')
 					=> new OneOfChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
 					=> new ValueOnlyChecker(),
-				$this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
 					=> new ReferenceChecker(),
-				$this->config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
+				$this->config->get('WBQualityConstraintsNoBoundsConstraintId')
 					=> new NoBoundsChecker(),
-				$this->config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
+				$this->config->get('WBQualityConstraintsAllowedUnitsConstraintId')
 					=> new AllowedUnitsChecker(
 						$this->constraintParameterParser,
 						$this->unitConverter
 					),
-				$this->config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
-					=> new SingleBestValueChecker( $this->constraintParameterParser ),
-				$this->config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
+				$this->config->get('WBQualityConstraintsSingleBestValueConstraintId')
+					=> new SingleBestValueChecker($this->constraintParameterParser),
+				$this->config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
 					=> new EntityTypeChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsNoneOfConstraintId' )
+				$this->config->get('WBQualityConstraintsNoneOfConstraintId')
 					=> new NoneOfChecker(
 						$this->constraintParameterParser
 					),
-				$this->config->get( 'WBQualityConstraintsIntegerConstraintId' )
+				$this->config->get('WBQualityConstraintsIntegerConstraintId')
 					=> new IntegerChecker(),
 			];
 		}
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
 	 * @return ConstraintRepository
 	 */
 	public function getConstraintRepository() {
-		if ( $this->constraintRepository === null ) {
+		if ($this->constraintRepository === null) {
 			$this->constraintRepository = new ConstraintRepository();
 		}
 

Please login to merge, or discard this patch.

		@@ -143,7 +143,7 @@ discard block
		block discarded – undo
143	143	public static function getDefaultInstance() {
144	144	static $instance = null;
145	145
146		- if ( $instance === null ) {
	146	+ if ($instance === null) {
147	147	$wikibaseRepo = WikibaseRepo::getDefaultInstance();
148	148	$config = MediaWikiServices::getInstance()->getMainConfig();
149	149	$titleParser = MediaWikiServices::getInstance()->getTitleParser();
		@@ -206,21 +206,21 @@ discard block
		block discarded – undo
206	206	* @return DelegatingConstraintChecker
207	207	*/
208	208	public function getConstraintChecker() {
209		- if ( $this->delegatingConstraintChecker === null ) {
	209	+ if ($this->delegatingConstraintChecker === null) {
210	210	$this->delegatingConstraintChecker = new DelegatingConstraintChecker(
211	211	$this->lookup,
212	212	$this->getConstraintCheckerMap(),
213		- new CachingConstraintLookup( $this->getConstraintRepository() ),
	213	+ new CachingConstraintLookup($this->getConstraintRepository()),
214	214	$this->constraintParameterParser,
215	215	$this->statementGuidParser,
216	216	new LoggingHelper(
217	217	$this->dataFactory,
218		- LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
	218	+ LoggerFactory::getInstance('WikibaseQualityConstraints'),
219	219	$this->config
220	220	),
221		- $this->config->get( 'WBQualityConstraintsCheckQualifiers' ),
222		- $this->config->get( 'WBQualityConstraintsCheckReferences' ),
223		- $this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
	221	+ $this->config->get('WBQualityConstraintsCheckQualifiers'),
	222	+ $this->config->get('WBQualityConstraintsCheckReferences'),
	223	+ $this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
224	224	);
225	225	}
226	226
		@@ -231,10 +231,10 @@ discard block
		block discarded – undo
231	231	* @return ConstraintChecker[]
232	232	*/
233	233	private function getConstraintCheckerMap() {
234		- if ( $this->constraintCheckerMap === null ) {
	234	+ if ($this->constraintCheckerMap === null) {
235	235	$connectionCheckerHelper = new ConnectionCheckerHelper();
236		- $rangeCheckerHelper = new RangeCheckerHelper( $this->config, $this->unitConverter );
237		- if ( $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ) !== '' ) {
	236	+ $rangeCheckerHelper = new RangeCheckerHelper($this->config, $this->unitConverter);
	237	+ if ($this->config->get('WBQualityConstraintsSparqlEndpoint') !== '') {
238	238	$sparqlHelper = new SparqlHelper(
239	239	$this->config,
240	240	$this->rdfVocabulary,
		@@ -256,116 +256,116 @@ discard block
		block discarded – undo
256	256	);
257	257
258	258	$this->constraintCheckerMap = [
259		- $this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
	259	+ $this->config->get('WBQualityConstraintsConflictsWithConstraintId')
260	260	=> new ConflictsWithChecker(
261	261	$this->lookup,
262	262	$this->constraintParameterParser,
263	263	$connectionCheckerHelper
264	264	),
265		- $this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
	265	+ $this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
266	266	=> new ItemChecker(
267	267	$this->lookup,
268	268	$this->constraintParameterParser,
269	269	$connectionCheckerHelper
270	270	),
271		- $this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
	271	+ $this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
272	272	=> new TargetRequiredClaimChecker(
273	273	$this->lookup,
274	274	$this->constraintParameterParser,
275	275	$connectionCheckerHelper
276	276	),
277		- $this->config->get( 'WBQualityConstraintsSymmetricConstraintId' )
	277	+ $this->config->get('WBQualityConstraintsSymmetricConstraintId')
278	278	=> new SymmetricChecker(
279	279	$this->lookup,
280	280	$connectionCheckerHelper
281	281	),
282		- $this->config->get( 'WBQualityConstraintsInverseConstraintId' )
	282	+ $this->config->get('WBQualityConstraintsInverseConstraintId')
283	283	=> new InverseChecker(
284	284	$this->lookup,
285	285	$this->constraintParameterParser,
286	286	$connectionCheckerHelper
287	287	),
288		- $this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
	288	+ $this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
289	289	=> new QualifierChecker(),
290		- $this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
	290	+ $this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
291	291	=> new QualifiersChecker(
292	292	$this->constraintParameterParser
293	293	),
294		- $this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
	294	+ $this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
295	295	=> new MandatoryQualifiersChecker(
296	296	$this->constraintParameterParser
297	297	),
298		- $this->config->get( 'WBQualityConstraintsRangeConstraintId' )
	298	+ $this->config->get('WBQualityConstraintsRangeConstraintId')
299	299	=> new RangeChecker(
300	300	$this->propertyDataTypeLookup,
301	301	$this->constraintParameterParser,
302	302	$rangeCheckerHelper
303	303	),
304		- $this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
	304	+ $this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
305	305	=> new DiffWithinRangeChecker(
306	306	$this->constraintParameterParser,
307	307	$rangeCheckerHelper,
308	308	$this->config
309	309	),
310		- $this->config->get( 'WBQualityConstraintsTypeConstraintId' )
	310	+ $this->config->get('WBQualityConstraintsTypeConstraintId')
311	311	=> new TypeChecker(
312	312	$this->lookup,
313	313	$this->constraintParameterParser,
314	314	$typeCheckerHelper,
315	315	$this->config
316	316	),
317		- $this->config->get( 'WBQualityConstraintsValueTypeConstraintId' )
	317	+ $this->config->get('WBQualityConstraintsValueTypeConstraintId')
318	318	=> new ValueTypeChecker(
319	319	$this->lookup,
320	320	$this->constraintParameterParser,
321	321	$typeCheckerHelper,
322	322	$this->config
323	323	),
324		- $this->config->get( 'WBQualityConstraintsSingleValueConstraintId' )
325		- => new SingleValueChecker( $this->constraintParameterParser ),
326		- $this->config->get( 'WBQualityConstraintsMultiValueConstraintId' )
327		- => new MultiValueChecker( $this->constraintParameterParser ),
328		- $this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
	324	+ $this->config->get('WBQualityConstraintsSingleValueConstraintId')
	325	+ => new SingleValueChecker($this->constraintParameterParser),
	326	+ $this->config->get('WBQualityConstraintsMultiValueConstraintId')
	327	+ => new MultiValueChecker($this->constraintParameterParser),
	328	+ $this->config->get('WBQualityConstraintsDistinctValuesConstraintId')
329	329	=> new UniqueValueChecker(
330	330	$sparqlHelper
331	331	),
332		- $this->config->get( 'WBQualityConstraintsFormatConstraintId' )
	332	+ $this->config->get('WBQualityConstraintsFormatConstraintId')
333	333	=> new FormatChecker(
334	334	$this->constraintParameterParser,
335	335	$this->config,
336	336	$sparqlHelper
337	337	),
338		- $this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
	338	+ $this->config->get('WBQualityConstraintsCommonsLinkConstraintId')
339	339	=> new CommonsLinkChecker(
340	340	$this->constraintParameterParser,
341	341	$this->titleParser
342	342	),
343		- $this->config->get( 'WBQualityConstraintsOneOfConstraintId' )
	343	+ $this->config->get('WBQualityConstraintsOneOfConstraintId')
344	344	=> new OneOfChecker(
345	345	$this->constraintParameterParser
346	346	),
347		- $this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
	347	+ $this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
348	348	=> new ValueOnlyChecker(),
349		- $this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
	349	+ $this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
350	350	=> new ReferenceChecker(),
351		- $this->config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
	351	+ $this->config->get('WBQualityConstraintsNoBoundsConstraintId')
352	352	=> new NoBoundsChecker(),
353		- $this->config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
	353	+ $this->config->get('WBQualityConstraintsAllowedUnitsConstraintId')
354	354	=> new AllowedUnitsChecker(
355	355	$this->constraintParameterParser,
356	356	$this->unitConverter
357	357	),
358		- $this->config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
359		- => new SingleBestValueChecker( $this->constraintParameterParser ),
360		- $this->config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
	358	+ $this->config->get('WBQualityConstraintsSingleBestValueConstraintId')
	359	+ => new SingleBestValueChecker($this->constraintParameterParser),
	360	+ $this->config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
361	361	=> new EntityTypeChecker(
362	362	$this->constraintParameterParser
363	363	),
364		- $this->config->get( 'WBQualityConstraintsNoneOfConstraintId' )
	364	+ $this->config->get('WBQualityConstraintsNoneOfConstraintId')
365	365	=> new NoneOfChecker(
366	366	$this->constraintParameterParser
367	367	),
368		- $this->config->get( 'WBQualityConstraintsIntegerConstraintId' )
	368	+ $this->config->get('WBQualityConstraintsIntegerConstraintId')
369	369	=> new IntegerChecker(),
370	370	];
371	371	}
		@@ -377,7 +377,7 @@ discard block
		block discarded – undo
377	377	* @return ConstraintRepository
378	378	*/
379	379	public function getConstraintRepository() {
380		- if ( $this->constraintRepository === null ) {
	380	+ if ($this->constraintRepository === null) {
381	381	$this->constraintRepository = new ConstraintRepository();
382	382	}
383	383

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( 1143d9...c006ff )

Status

Category

Spacing +40 added lines, -40 removed lines patch added patch discarded remove patch