View GitHub Repository mediawiki-extensions-WikibaseQualityConstraints

Schedule Inspection
Subscribe
Completed
Push — master ( 1143d9...c006ff )
by
unknown
04:01 queued 10s
created
Status
Category
Toggle Patches
src/ConstraintReportFactory.php 1 patch
Spacing   +40 added lines, -40 removed lines patch added patch discarded remove patch 
@@ -143,7 +143,7 @@  discard block
 
 block discarded – undo
143 143 
 	public static function getDefaultInstance() {
144 144 
 		static $instance = null;
145 145
146 
-		if ( $instance === null ) {
146 
+		if ($instance === null) {
147 147 
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
148 148 
 			$config = MediaWikiServices::getInstance()->getMainConfig();
149 149 
 			$titleParser = MediaWikiServices::getInstance()->getTitleParser();
 
@@ -206,21 +206,21 @@  discard block
 
 block discarded – undo
206 206 
 	 * @return DelegatingConstraintChecker
207 207 
 	 */
208 208 
 	public function getConstraintChecker() {
209 
-		if ( $this->delegatingConstraintChecker === null ) {
209 
+		if ($this->delegatingConstraintChecker === null) {
210 210 
 			$this->delegatingConstraintChecker = new DelegatingConstraintChecker(
211 211 
 				$this->lookup,
212 212 
 				$this->getConstraintCheckerMap(),
213 
-				new CachingConstraintLookup( $this->getConstraintRepository() ),
213 
+				new CachingConstraintLookup($this->getConstraintRepository()),
214 214 
 				$this->constraintParameterParser,
215 215 
 				$this->statementGuidParser,
216 216 
 				new LoggingHelper(
217 217 
 					$this->dataFactory,
218 
-					LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
218 
+					LoggerFactory::getInstance('WikibaseQualityConstraints'),
219 219 
 					$this->config
220 220 
 				),
221 
-				$this->config->get( 'WBQualityConstraintsCheckQualifiers' ),
222 
-				$this->config->get( 'WBQualityConstraintsCheckReferences' ),
223 
-				$this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
221 
+				$this->config->get('WBQualityConstraintsCheckQualifiers'),
222 
+				$this->config->get('WBQualityConstraintsCheckReferences'),
223 
+				$this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
224 224 
 			);
225 225 
 		}
226 226 
 
@@ -231,10 +231,10 @@  discard block
 
 block discarded – undo
231 231 
 	 * @return ConstraintChecker[]
232 232 
 	 */
233 233 
 	private function getConstraintCheckerMap() {
234 
-		if ( $this->constraintCheckerMap === null ) {
234 
+		if ($this->constraintCheckerMap === null) {
235 235 
 			$connectionCheckerHelper = new ConnectionCheckerHelper();
236 
-			$rangeCheckerHelper = new RangeCheckerHelper( $this->config, $this->unitConverter );
237 
-			if ( $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ) !== '' ) {
236 
+			$rangeCheckerHelper = new RangeCheckerHelper($this->config, $this->unitConverter);
237 
+			if ($this->config->get('WBQualityConstraintsSparqlEndpoint') !== '') {
238 238 
 				$sparqlHelper = new SparqlHelper(
239 239 
 					$this->config,
240 240 
 					$this->rdfVocabulary,
 
@@ -256,116 +256,116 @@  discard block
 
 block discarded – undo
256 256 
 			);
257 257
258 258 
 			$this->constraintCheckerMap = [
259 
-				$this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
259 
+				$this->config->get('WBQualityConstraintsConflictsWithConstraintId')
260 260 
 					=> new ConflictsWithChecker(
261 261 
 						$this->lookup,
262 262 
 						$this->constraintParameterParser,
263 263 
 						$connectionCheckerHelper
264 264 
 					),
265 
-				$this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
265 
+				$this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
266 266 
 					=> new ItemChecker(
267 267 
 						$this->lookup,
268 268 
 						$this->constraintParameterParser,
269 269 
 						$connectionCheckerHelper
270 270 
 					),
271 
-				$this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
271 
+				$this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
272 272 
 					=> new TargetRequiredClaimChecker(
273 273 
 						$this->lookup,
274 274 
 						$this->constraintParameterParser,
275 275 
 						$connectionCheckerHelper
276 276 
 					),
277 
-				$this->config->get( 'WBQualityConstraintsSymmetricConstraintId' )
277 
+				$this->config->get('WBQualityConstraintsSymmetricConstraintId')
278 278 
 					=> new SymmetricChecker(
279 279 
 						$this->lookup,
280 280 
 						$connectionCheckerHelper
281 281 
 					),
282 
-				$this->config->get( 'WBQualityConstraintsInverseConstraintId' )
282 
+				$this->config->get('WBQualityConstraintsInverseConstraintId')
283 283 
 					=> new InverseChecker(
284 284 
 						$this->lookup,
285 285 
 						$this->constraintParameterParser,
286 286 
 						$connectionCheckerHelper
287 287 
 					),
288 
-				$this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
288 
+				$this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
289 289 
 					=> new QualifierChecker(),
290 
-				$this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
290 
+				$this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
291 291 
 					=> new QualifiersChecker(
292 292 
 						$this->constraintParameterParser
293 293 
 					),
294 
-				$this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
294 
+				$this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
295 295 
 					=> new MandatoryQualifiersChecker(
296 296 
 						$this->constraintParameterParser
297 297 
 					),
298 
-				$this->config->get( 'WBQualityConstraintsRangeConstraintId' )
298 
+				$this->config->get('WBQualityConstraintsRangeConstraintId')
299 299 
 					=> new RangeChecker(
300 300 
 						$this->propertyDataTypeLookup,
301 301 
 						$this->constraintParameterParser,
302 302 
 						$rangeCheckerHelper
303 303 
 					),
304 
-				$this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
304 
+				$this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
305 305 
 					=> new DiffWithinRangeChecker(
306 306 
 						$this->constraintParameterParser,
307 307 
 						$rangeCheckerHelper,
308 308 
 						$this->config
309 309 
 					),
310 
-				$this->config->get( 'WBQualityConstraintsTypeConstraintId' )
310 
+				$this->config->get('WBQualityConstraintsTypeConstraintId')
311 311 
 					=> new TypeChecker(
312 312 
 						$this->lookup,
313 313 
 						$this->constraintParameterParser,
314 314 
 						$typeCheckerHelper,
315 315 
 						$this->config
316 316 
 					),
317 
-				$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' )
317 
+				$this->config->get('WBQualityConstraintsValueTypeConstraintId')
318 318 
 					=> new ValueTypeChecker(
319 319 
 						$this->lookup,
320 320 
 						$this->constraintParameterParser,
321 321 
 						$typeCheckerHelper,
322 322 
 						$this->config
323 323 
 					),
324 
-				$this->config->get( 'WBQualityConstraintsSingleValueConstraintId' )
325 
-					=> new SingleValueChecker( $this->constraintParameterParser ),
326 
-				$this->config->get( 'WBQualityConstraintsMultiValueConstraintId' )
327 
-					=> new MultiValueChecker( $this->constraintParameterParser ),
328 
-				$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
324 
+				$this->config->get('WBQualityConstraintsSingleValueConstraintId')
325 
+					=> new SingleValueChecker($this->constraintParameterParser),
326 
+				$this->config->get('WBQualityConstraintsMultiValueConstraintId')
327 
+					=> new MultiValueChecker($this->constraintParameterParser),
328 
+				$this->config->get('WBQualityConstraintsDistinctValuesConstraintId')
329 329 
 					=> new UniqueValueChecker(
330 330 
 						$sparqlHelper
331 331 
 					),
332 
-				$this->config->get( 'WBQualityConstraintsFormatConstraintId' )
332 
+				$this->config->get('WBQualityConstraintsFormatConstraintId')
333 333 
 					=> new FormatChecker(
334 334 
 						$this->constraintParameterParser,
335 335 
 						$this->config,
336 336 
 						$sparqlHelper
337 337 
 					),
338 
-				$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
338 
+				$this->config->get('WBQualityConstraintsCommonsLinkConstraintId')
339 339 
 					=> new CommonsLinkChecker(
340 340 
 						$this->constraintParameterParser,
341 341 
 						$this->titleParser
342 342 
 					),
343 
-				$this->config->get( 'WBQualityConstraintsOneOfConstraintId' )
343 
+				$this->config->get('WBQualityConstraintsOneOfConstraintId')
344 344 
 					=> new OneOfChecker(
345 345 
 						$this->constraintParameterParser
346 346 
 					),
347 
-				$this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
347 
+				$this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
348 348 
 					=> new ValueOnlyChecker(),
349 
-				$this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
349 
+				$this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
350 350 
 					=> new ReferenceChecker(),
351 
-				$this->config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
351 
+				$this->config->get('WBQualityConstraintsNoBoundsConstraintId')
352 352 
 					=> new NoBoundsChecker(),
353 
-				$this->config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
353 
+				$this->config->get('WBQualityConstraintsAllowedUnitsConstraintId')
354 354 
 					=> new AllowedUnitsChecker(
355 355 
 						$this->constraintParameterParser,
356 356 
 						$this->unitConverter
357 357 
 					),
358 
-				$this->config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
359 
-					=> new SingleBestValueChecker( $this->constraintParameterParser ),
360 
-				$this->config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
358 
+				$this->config->get('WBQualityConstraintsSingleBestValueConstraintId')
359 
+					=> new SingleBestValueChecker($this->constraintParameterParser),
360 
+				$this->config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
361 361 
 					=> new EntityTypeChecker(
362 362 
 						$this->constraintParameterParser
363 363 
 					),
364 
-				$this->config->get( 'WBQualityConstraintsNoneOfConstraintId' )
364 
+				$this->config->get('WBQualityConstraintsNoneOfConstraintId')
365 365 
 					=> new NoneOfChecker(
366 366 
 						$this->constraintParameterParser
367 367 
 					),
368 
-				$this->config->get( 'WBQualityConstraintsIntegerConstraintId' )
368 
+				$this->config->get('WBQualityConstraintsIntegerConstraintId')
369 369 
 					=> new IntegerChecker(),
370 370 
 			];
371 371 
 		}
 
@@ -377,7 +377,7 @@  discard block
 
 block discarded – undo
377 377 
 	 * @return ConstraintRepository
378 378 
 	 */
379 379 
 	public function getConstraintRepository() {
380 
-		if ( $this->constraintRepository === null ) {
380 
+		if ($this->constraintRepository === null) {
381 381 
 			$this->constraintRepository = new ConstraintRepository();
382 382 
 		}
383 383
Please login to merge, or discard this patch.