Inspection of "Merge "Add 'none of' constraint"" - wikimedia/mediawiki-extensions-WikibaseQualityConstraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 89292f...abf49f )

unknown

created 2018-05-03 18:18 UTC

Status

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -68,15 +68,15 @@  discard block
 block discarded – undo
 	 * @throws ConstraintParameterException
 	 * @return CheckResult
 	 */
-	public function checkConstraint( Context $context, Constraint $constraint ) {
-		if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
-			return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
+	public function checkConstraint(Context $context, Constraint $constraint) {
+		if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
+			return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
 		}
 
 		$parameters = [];
 		$constraintParameters = $constraint->getConstraintParameters();
 
-		$items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
+		$items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
 		$parameters['item'] = $items;
 
 		$snak = $context->getSnak();
@@ -84,25 +84,25 @@  discard block
 block discarded – undo
 		$message = null;
 		$status = CheckResult::STATUS_COMPLIANCE;
 
-		foreach ( $items as $item ) {
-			if ( $item->matchesSnak( $snak ) ) {
-				$message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
-					->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
-					->withItemIdSnakValueList( $items, Role::OBJECT );
+		foreach ($items as $item) {
+			if ($item->matchesSnak($snak)) {
+				$message = (new ViolationMessage('wbqc-violation-message-none-of'))
+					->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
+					->withItemIdSnakValueList($items, Role::OBJECT);
 				$status = CheckResult::STATUS_VIOLATION;
 				break;
 			}
 		}
 
-		return new CheckResult( $context, $constraint, $parameters, $status, $message );
+		return new CheckResult($context, $constraint, $parameters, $status, $message);
 	}
 
-	public function checkConstraintParameters( Constraint $constraint ) {
+	public function checkConstraintParameters(Constraint $constraint) {
 		$constraintParameters = $constraint->getConstraintParameters();
 		$exceptions = [];
 		try {
-			$this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
-		} catch ( ConstraintParameterException $e ) {
+			$this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
+		} catch (ConstraintParameterException $e) {
 			$exceptions[] = $e;
 		}
 		return $exceptions;

Please login to merge, or discard this patch.

src/ConstraintReportFactory.php 1 patch

Spacing +50 added lines, -50 removed lines patch added patch discarded remove patch

@@ -155,7 +155,7 @@  discard block
 block discarded – undo
 	public static function getDefaultInstance() {
 		static $instance = null;
 
-		if ( $instance === null ) {
+		if ($instance === null) {
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 			$entityIdFormatter = $wikibaseRepo->getEntityIdHtmlLinkFormatterFactory()->getEntityIdFormatter(
 				$wikibaseRepo->getLanguageFallbackLabelDescriptionLookupFactory()->newLabelDescriptionLookup(
@@ -236,21 +236,21 @@  discard block
 block discarded – undo
 	 * @return DelegatingConstraintChecker
 	 */
 	public function getConstraintChecker() {
-		if ( $this->delegatingConstraintChecker === null ) {
+		if ($this->delegatingConstraintChecker === null) {
 			$this->delegatingConstraintChecker = new DelegatingConstraintChecker(
 				$this->lookup,
 				$this->getConstraintCheckerMap(),
-				new CachingConstraintLookup( $this->getConstraintRepository() ),
+				new CachingConstraintLookup($this->getConstraintRepository()),
 				$this->constraintParameterParser,
 				$this->statementGuidParser,
 				new LoggingHelper(
 					$this->dataFactory,
-					LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
+					LoggerFactory::getInstance('WikibaseQualityConstraints'),
 					$this->config
 				),
-				$this->config->get( 'WBQualityConstraintsCheckQualifiers' ),
-				$this->config->get( 'WBQualityConstraintsCheckReferences' ),
-				$this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
+				$this->config->get('WBQualityConstraintsCheckQualifiers'),
+				$this->config->get('WBQualityConstraintsCheckReferences'),
+				$this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
 			);
 		}
 
@@ -261,10 +261,10 @@  discard block
 block discarded – undo
 	 * @return ConstraintChecker[]
 	 */
 	private function getConstraintCheckerMap() {
-		if ( $this->constraintCheckerMap === null ) {
+		if ($this->constraintCheckerMap === null) {
 			$connectionCheckerHelper = new ConnectionCheckerHelper();
-			$rangeCheckerHelper = new RangeCheckerHelper( $this->config, $this->unitConverter );
-			if ( $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ) !== '' ) {
+			$rangeCheckerHelper = new RangeCheckerHelper($this->config, $this->unitConverter);
+			if ($this->config->get('WBQualityConstraintsSparqlEndpoint') !== '') {
 				$sparqlHelper = new SparqlHelper(
 					$this->config,
 					$this->rdfVocabulary,
@@ -287,74 +287,74 @@  discard block
 block discarded – undo
 			);
 
 			$this->constraintCheckerMap = [
-				$this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
+				$this->config->get('WBQualityConstraintsConflictsWithConstraintId')
 					=> new ConflictsWithChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
+				$this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
 					=> new ItemChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
+				$this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
 					=> new TargetRequiredClaimChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsSymmetricConstraintId' )
+				$this->config->get('WBQualityConstraintsSymmetricConstraintId')
 					=> new SymmetricChecker(
 						$this->lookup,
 						$connectionCheckerHelper,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsInverseConstraintId' )
+				$this->config->get('WBQualityConstraintsInverseConstraintId')
 					=> new InverseChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$connectionCheckerHelper,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
 					=> new QualifierChecker(),
-				$this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
+				$this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
 					=> new QualifiersChecker(
 						$this->constraintParameterParser,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
+				$this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
 					=> new MandatoryQualifiersChecker(
 						$this->constraintParameterParser,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsRangeConstraintId' )
+				$this->config->get('WBQualityConstraintsRangeConstraintId')
 					=> new RangeChecker(
 						$this->propertyDataTypeLookup,
 						$this->constraintParameterParser,
 						$rangeCheckerHelper,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
+				$this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
 					=> new DiffWithinRangeChecker(
 						$this->constraintParameterParser,
 						$rangeCheckerHelper,
 						$this->constraintParameterRenderer,
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsTypeConstraintId' )
+				$this->config->get('WBQualityConstraintsTypeConstraintId')
 					=> new TypeChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
 						$typeCheckerHelper,
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsValueTypeConstraintId' )
+				$this->config->get('WBQualityConstraintsValueTypeConstraintId')
 					=> new ValueTypeChecker(
 						$this->lookup,
 						$this->constraintParameterParser,
@@ -362,52 +362,52 @@  discard block
 block discarded – undo
 						$typeCheckerHelper,
 						$this->config
 					),
-				$this->config->get( 'WBQualityConstraintsSingleValueConstraintId' )
+				$this->config->get('WBQualityConstraintsSingleValueConstraintId')
 					=> new SingleValueChecker(),
-				$this->config->get( 'WBQualityConstraintsMultiValueConstraintId' )
+				$this->config->get('WBQualityConstraintsMultiValueConstraintId')
 					=> new MultiValueChecker(),
-				$this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
+				$this->config->get('WBQualityConstraintsDistinctValuesConstraintId')
 					=> new UniqueValueChecker(
 						$this->constraintParameterRenderer,
 						$sparqlHelper
 					),
-				$this->config->get( 'WBQualityConstraintsFormatConstraintId' )
+				$this->config->get('WBQualityConstraintsFormatConstraintId')
 					=> new FormatChecker(
 						$this->constraintParameterParser,
 						$this->constraintParameterRenderer,
 						$this->config,
 						$sparqlHelper
 					),
-				$this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
+				$this->config->get('WBQualityConstraintsCommonsLinkConstraintId')
 					=> new CommonsLinkChecker(
 						$this->constraintParameterParser,
 						$this->constraintParameterRenderer,
 						$this->titleParser
 					),
-				$this->config->get( 'WBQualityConstraintsOneOfConstraintId' )
+				$this->config->get('WBQualityConstraintsOneOfConstraintId')
 					=> new OneOfChecker(
 						$this->constraintParameterParser,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
 					=> new ValueOnlyChecker(),
-				$this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
+				$this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
 					=> new ReferenceChecker(),
-				$this->config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
+				$this->config->get('WBQualityConstraintsNoBoundsConstraintId')
 					=> new NoBoundsChecker(),
-				$this->config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
+				$this->config->get('WBQualityConstraintsAllowedUnitsConstraintId')
 					=> new AllowedUnitsChecker(
 						$this->constraintParameterParser,
 						$this->unitConverter
 					),
-				$this->config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
+				$this->config->get('WBQualityConstraintsSingleBestValueConstraintId')
 					=> new SingleBestValueChecker(),
-				$this->config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
+				$this->config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
 					=> new EntityTypeChecker(
 						$this->constraintParameterParser,
 						$this->constraintParameterRenderer
 					),
-				$this->config->get( 'WBQualityConstraintsNoneOfConstraintId' )
+				$this->config->get('WBQualityConstraintsNoneOfConstraintId')
 					=> new NoneOfChecker(
 						$this->constraintParameterParser,
 						$this->constraintParameterRenderer
@@ -422,26 +422,26 @@  discard block
 block discarded – undo
 	 * @return array[]
 	 */
 	public function getConstraintParameterMap() {
-		if ( $this->constraintParameterMap === null ) {
+		if ($this->constraintParameterMap === null) {
 			$this->constraintParameterMap = [
-				'Commons link' => [ 'namespace' ],
-				'Conflicts with' => [ 'property', 'item' ],
-				'Diff within range' => [ 'property', 'minimum_quantity', 'maximum_quantity' ],
-				'Format' => [ 'pattern' ],
-				'Inverse' => [ 'property' ],
-				'Item' => [ 'property', 'item' ],
-				'Mandatory qualifiers' => [ 'property' ],
+				'Commons link' => ['namespace'],
+				'Conflicts with' => ['property', 'item'],
+				'Diff within range' => ['property', 'minimum_quantity', 'maximum_quantity'],
+				'Format' => ['pattern'],
+				'Inverse' => ['property'],
+				'Item' => ['property', 'item'],
+				'Mandatory qualifiers' => ['property'],
 				'Multi value' => [],
-				'One of' => [ 'item' ],
+				'One of' => ['item'],
 				'Qualifier' => [],
-				'Qualifiers' => [ 'property' ],
-				'Range' => [ 'minimum_quantity', 'maximum_quantity', 'minimum_date', 'maximum_date' ],
+				'Qualifiers' => ['property'],
+				'Range' => ['minimum_quantity', 'maximum_quantity', 'minimum_date', 'maximum_date'],
 				'Single value' => [],
 				'Symmetric' => [],
-				'Target required claim' => [ 'property', 'item' ],
-				'Type' => [ 'class', 'relation' ],
+				'Target required claim' => ['property', 'item'],
+				'Type' => ['class', 'relation'],
 				'Unique value' => [],
-				'Value type' => [ 'class', 'relation' ]
+				'Value type' => ['class', 'relation']
 			];
 		}
 
@@ -452,7 +452,7 @@  discard block
 block discarded – undo
 	 * @return ConstraintRepository
 	 */
 	public function getConstraintRepository() {
-		if ( $this->constraintRepository === null ) {
+		if ($this->constraintRepository === null) {
 			$this->constraintRepository = new ConstraintRepository();
 		}
 

Please login to merge, or discard this patch.

		@@ -68,15 +68,15 @@ discard block
		block discarded – undo
68	68	* @throws ConstraintParameterException
69	69	* @return CheckResult
70	70	*/
71		- public function checkConstraint( Context $context, Constraint $constraint ) {
72		- if ( $context->getSnakRank() === Statement::RANK_DEPRECATED ) {
73		- return new CheckResult( $context, $constraint, [], CheckResult::STATUS_DEPRECATED );
	71	+ public function checkConstraint(Context $context, Constraint $constraint) {
	72	+ if ($context->getSnakRank() === Statement::RANK_DEPRECATED) {
	73	+ return new CheckResult($context, $constraint, [], CheckResult::STATUS_DEPRECATED);
74	74	}
75	75
76	76	$parameters = [];
77	77	$constraintParameters = $constraint->getConstraintParameters();
78	78
79		- $items = $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
	79	+ $items = $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
80	80	$parameters['item'] = $items;
81	81
82	82	$snak = $context->getSnak();
		@@ -84,25 +84,25 @@ discard block
		block discarded – undo
84	84	$message = null;
85	85	$status = CheckResult::STATUS_COMPLIANCE;
86	86
87		- foreach ( $items as $item ) {
88		- if ( $item->matchesSnak( $snak ) ) {
89		- $message = ( new ViolationMessage( 'wbqc-violation-message-none-of' ) )
90		- ->withEntityId( $context->getSnak()->getPropertyId(), Role::PREDICATE )
91		- ->withItemIdSnakValueList( $items, Role::OBJECT );
	87	+ foreach ($items as $item) {
	88	+ if ($item->matchesSnak($snak)) {
	89	+ $message = (new ViolationMessage('wbqc-violation-message-none-of'))
	90	+ ->withEntityId($context->getSnak()->getPropertyId(), Role::PREDICATE)
	91	+ ->withItemIdSnakValueList($items, Role::OBJECT);
92	92	$status = CheckResult::STATUS_VIOLATION;
93	93	break;
94	94	}
95	95	}
96	96
97		- return new CheckResult( $context, $constraint, $parameters, $status, $message );
	97	+ return new CheckResult($context, $constraint, $parameters, $status, $message);
98	98	}
99	99
100		- public function checkConstraintParameters( Constraint $constraint ) {
	100	+ public function checkConstraintParameters(Constraint $constraint) {
101	101	$constraintParameters = $constraint->getConstraintParameters();
102	102	$exceptions = [];
103	103	try {
104		- $this->constraintParameterParser->parseItemsParameter( $constraintParameters, $constraint->getConstraintTypeItemId(), true );
105		- } catch ( ConstraintParameterException $e ) {
	104	+ $this->constraintParameterParser->parseItemsParameter($constraintParameters, $constraint->getConstraintTypeItemId(), true);
	105	+ } catch (ConstraintParameterException $e) {
106	106	$exceptions[] = $e;
107	107	}
108	108	return $exceptions;

		@@ -155,7 +155,7 @@ discard block
		block discarded – undo
155	155	public static function getDefaultInstance() {
156	156	static $instance = null;
157	157
158		- if ( $instance === null ) {
	158	+ if ($instance === null) {
159	159	$wikibaseRepo = WikibaseRepo::getDefaultInstance();
160	160	$entityIdFormatter = $wikibaseRepo->getEntityIdHtmlLinkFormatterFactory()->getEntityIdFormatter(
161	161	$wikibaseRepo->getLanguageFallbackLabelDescriptionLookupFactory()->newLabelDescriptionLookup(
		@@ -236,21 +236,21 @@ discard block
		block discarded – undo
236	236	* @return DelegatingConstraintChecker
237	237	*/
238	238	public function getConstraintChecker() {
239		- if ( $this->delegatingConstraintChecker === null ) {
	239	+ if ($this->delegatingConstraintChecker === null) {
240	240	$this->delegatingConstraintChecker = new DelegatingConstraintChecker(
241	241	$this->lookup,
242	242	$this->getConstraintCheckerMap(),
243		- new CachingConstraintLookup( $this->getConstraintRepository() ),
	243	+ new CachingConstraintLookup($this->getConstraintRepository()),
244	244	$this->constraintParameterParser,
245	245	$this->statementGuidParser,
246	246	new LoggingHelper(
247	247	$this->dataFactory,
248		- LoggerFactory::getInstance( 'WikibaseQualityConstraints' ),
	248	+ LoggerFactory::getInstance('WikibaseQualityConstraints'),
249	249	$this->config
250	250	),
251		- $this->config->get( 'WBQualityConstraintsCheckQualifiers' ),
252		- $this->config->get( 'WBQualityConstraintsCheckReferences' ),
253		- $this->config->get( 'WBQualityConstraintsPropertiesWithViolatingQualifiers' )
	251	+ $this->config->get('WBQualityConstraintsCheckQualifiers'),
	252	+ $this->config->get('WBQualityConstraintsCheckReferences'),
	253	+ $this->config->get('WBQualityConstraintsPropertiesWithViolatingQualifiers')
254	254	);
255	255	}
256	256
		@@ -261,10 +261,10 @@ discard block
		block discarded – undo
261	261	* @return ConstraintChecker[]
262	262	*/
263	263	private function getConstraintCheckerMap() {
264		- if ( $this->constraintCheckerMap === null ) {
	264	+ if ($this->constraintCheckerMap === null) {
265	265	$connectionCheckerHelper = new ConnectionCheckerHelper();
266		- $rangeCheckerHelper = new RangeCheckerHelper( $this->config, $this->unitConverter );
267		- if ( $this->config->get( 'WBQualityConstraintsSparqlEndpoint' ) !== '' ) {
	266	+ $rangeCheckerHelper = new RangeCheckerHelper($this->config, $this->unitConverter);
	267	+ if ($this->config->get('WBQualityConstraintsSparqlEndpoint') !== '') {
268	268	$sparqlHelper = new SparqlHelper(
269	269	$this->config,
270	270	$this->rdfVocabulary,
		@@ -287,74 +287,74 @@ discard block
		block discarded – undo
287	287	);
288	288
289	289	$this->constraintCheckerMap = [
290		- $this->config->get( 'WBQualityConstraintsConflictsWithConstraintId' )
	290	+ $this->config->get('WBQualityConstraintsConflictsWithConstraintId')
291	291	=> new ConflictsWithChecker(
292	292	$this->lookup,
293	293	$this->constraintParameterParser,
294	294	$connectionCheckerHelper,
295	295	$this->constraintParameterRenderer
296	296	),
297		- $this->config->get( 'WBQualityConstraintsItemRequiresClaimConstraintId' )
	297	+ $this->config->get('WBQualityConstraintsItemRequiresClaimConstraintId')
298	298	=> new ItemChecker(
299	299	$this->lookup,
300	300	$this->constraintParameterParser,
301	301	$connectionCheckerHelper,
302	302	$this->constraintParameterRenderer
303	303	),
304		- $this->config->get( 'WBQualityConstraintsValueRequiresClaimConstraintId' )
	304	+ $this->config->get('WBQualityConstraintsValueRequiresClaimConstraintId')
305	305	=> new TargetRequiredClaimChecker(
306	306	$this->lookup,
307	307	$this->constraintParameterParser,
308	308	$connectionCheckerHelper,
309	309	$this->constraintParameterRenderer
310	310	),
311		- $this->config->get( 'WBQualityConstraintsSymmetricConstraintId' )
	311	+ $this->config->get('WBQualityConstraintsSymmetricConstraintId')
312	312	=> new SymmetricChecker(
313	313	$this->lookup,
314	314	$connectionCheckerHelper,
315	315	$this->constraintParameterRenderer
316	316	),
317		- $this->config->get( 'WBQualityConstraintsInverseConstraintId' )
	317	+ $this->config->get('WBQualityConstraintsInverseConstraintId')
318	318	=> new InverseChecker(
319	319	$this->lookup,
320	320	$this->constraintParameterParser,
321	321	$connectionCheckerHelper,
322	322	$this->constraintParameterRenderer
323	323	),
324		- $this->config->get( 'WBQualityConstraintsUsedAsQualifierConstraintId' )
	324	+ $this->config->get('WBQualityConstraintsUsedAsQualifierConstraintId')
325	325	=> new QualifierChecker(),
326		- $this->config->get( 'WBQualityConstraintsAllowedQualifiersConstraintId' )
	326	+ $this->config->get('WBQualityConstraintsAllowedQualifiersConstraintId')
327	327	=> new QualifiersChecker(
328	328	$this->constraintParameterParser,
329	329	$this->constraintParameterRenderer
330	330	),
331		- $this->config->get( 'WBQualityConstraintsMandatoryQualifierConstraintId' )
	331	+ $this->config->get('WBQualityConstraintsMandatoryQualifierConstraintId')
332	332	=> new MandatoryQualifiersChecker(
333	333	$this->constraintParameterParser,
334	334	$this->constraintParameterRenderer
335	335	),
336		- $this->config->get( 'WBQualityConstraintsRangeConstraintId' )
	336	+ $this->config->get('WBQualityConstraintsRangeConstraintId')
337	337	=> new RangeChecker(
338	338	$this->propertyDataTypeLookup,
339	339	$this->constraintParameterParser,
340	340	$rangeCheckerHelper,
341	341	$this->constraintParameterRenderer
342	342	),
343		- $this->config->get( 'WBQualityConstraintsDifferenceWithinRangeConstraintId' )
	343	+ $this->config->get('WBQualityConstraintsDifferenceWithinRangeConstraintId')
344	344	=> new DiffWithinRangeChecker(
345	345	$this->constraintParameterParser,
346	346	$rangeCheckerHelper,
347	347	$this->constraintParameterRenderer,
348	348	$this->config
349	349	),
350		- $this->config->get( 'WBQualityConstraintsTypeConstraintId' )
	350	+ $this->config->get('WBQualityConstraintsTypeConstraintId')
351	351	=> new TypeChecker(
352	352	$this->lookup,
353	353	$this->constraintParameterParser,
354	354	$typeCheckerHelper,
355	355	$this->config
356	356	),
357		- $this->config->get( 'WBQualityConstraintsValueTypeConstraintId' )
	357	+ $this->config->get('WBQualityConstraintsValueTypeConstraintId')
358	358	=> new ValueTypeChecker(
359	359	$this->lookup,
360	360	$this->constraintParameterParser,
		@@ -362,52 +362,52 @@ discard block
		block discarded – undo
362	362	$typeCheckerHelper,
363	363	$this->config
364	364	),
365		- $this->config->get( 'WBQualityConstraintsSingleValueConstraintId' )
	365	+ $this->config->get('WBQualityConstraintsSingleValueConstraintId')
366	366	=> new SingleValueChecker(),
367		- $this->config->get( 'WBQualityConstraintsMultiValueConstraintId' )
	367	+ $this->config->get('WBQualityConstraintsMultiValueConstraintId')
368	368	=> new MultiValueChecker(),
369		- $this->config->get( 'WBQualityConstraintsDistinctValuesConstraintId' )
	369	+ $this->config->get('WBQualityConstraintsDistinctValuesConstraintId')
370	370	=> new UniqueValueChecker(
371	371	$this->constraintParameterRenderer,
372	372	$sparqlHelper
373	373	),
374		- $this->config->get( 'WBQualityConstraintsFormatConstraintId' )
	374	+ $this->config->get('WBQualityConstraintsFormatConstraintId')
375	375	=> new FormatChecker(
376	376	$this->constraintParameterParser,
377	377	$this->constraintParameterRenderer,
378	378	$this->config,
379	379	$sparqlHelper
380	380	),
381		- $this->config->get( 'WBQualityConstraintsCommonsLinkConstraintId' )
	381	+ $this->config->get('WBQualityConstraintsCommonsLinkConstraintId')
382	382	=> new CommonsLinkChecker(
383	383	$this->constraintParameterParser,
384	384	$this->constraintParameterRenderer,
385	385	$this->titleParser
386	386	),
387		- $this->config->get( 'WBQualityConstraintsOneOfConstraintId' )
	387	+ $this->config->get('WBQualityConstraintsOneOfConstraintId')
388	388	=> new OneOfChecker(
389	389	$this->constraintParameterParser,
390	390	$this->constraintParameterRenderer
391	391	),
392		- $this->config->get( 'WBQualityConstraintsUsedForValuesOnlyConstraintId' )
	392	+ $this->config->get('WBQualityConstraintsUsedForValuesOnlyConstraintId')
393	393	=> new ValueOnlyChecker(),
394		- $this->config->get( 'WBQualityConstraintsUsedAsReferenceConstraintId' )
	394	+ $this->config->get('WBQualityConstraintsUsedAsReferenceConstraintId')
395	395	=> new ReferenceChecker(),
396		- $this->config->get( 'WBQualityConstraintsNoBoundsConstraintId' )
	396	+ $this->config->get('WBQualityConstraintsNoBoundsConstraintId')
397	397	=> new NoBoundsChecker(),
398		- $this->config->get( 'WBQualityConstraintsAllowedUnitsConstraintId' )
	398	+ $this->config->get('WBQualityConstraintsAllowedUnitsConstraintId')
399	399	=> new AllowedUnitsChecker(
400	400	$this->constraintParameterParser,
401	401	$this->unitConverter
402	402	),
403		- $this->config->get( 'WBQualityConstraintsSingleBestValueConstraintId' )
	403	+ $this->config->get('WBQualityConstraintsSingleBestValueConstraintId')
404	404	=> new SingleBestValueChecker(),
405		- $this->config->get( 'WBQualityConstraintsAllowedEntityTypesConstraintId' )
	405	+ $this->config->get('WBQualityConstraintsAllowedEntityTypesConstraintId')
406	406	=> new EntityTypeChecker(
407	407	$this->constraintParameterParser,
408	408	$this->constraintParameterRenderer
409	409	),
410		- $this->config->get( 'WBQualityConstraintsNoneOfConstraintId' )
	410	+ $this->config->get('WBQualityConstraintsNoneOfConstraintId')
411	411	=> new NoneOfChecker(
412	412	$this->constraintParameterParser,
413	413	$this->constraintParameterRenderer
		@@ -422,26 +422,26 @@ discard block
		block discarded – undo
422	422	* @return array[]
423	423	*/
424	424	public function getConstraintParameterMap() {
425		- if ( $this->constraintParameterMap === null ) {
	425	+ if ($this->constraintParameterMap === null) {
426	426	$this->constraintParameterMap = [
427		- 'Commons link' => [ 'namespace' ],
428		- 'Conflicts with' => [ 'property', 'item' ],
429		- 'Diff within range' => [ 'property', 'minimum_quantity', 'maximum_quantity' ],
430		- 'Format' => [ 'pattern' ],
431		- 'Inverse' => [ 'property' ],
432		- 'Item' => [ 'property', 'item' ],
433		- 'Mandatory qualifiers' => [ 'property' ],
	427	+ 'Commons link' => ['namespace'],
	428	+ 'Conflicts with' => ['property', 'item'],
	429	+ 'Diff within range' => ['property', 'minimum_quantity', 'maximum_quantity'],
	430	+ 'Format' => ['pattern'],
	431	+ 'Inverse' => ['property'],
	432	+ 'Item' => ['property', 'item'],
	433	+ 'Mandatory qualifiers' => ['property'],
434	434	'Multi value' => [],
435		- 'One of' => [ 'item' ],
	435	+ 'One of' => ['item'],
436	436	'Qualifier' => [],
437		- 'Qualifiers' => [ 'property' ],
438		- 'Range' => [ 'minimum_quantity', 'maximum_quantity', 'minimum_date', 'maximum_date' ],
	437	+ 'Qualifiers' => ['property'],
	438	+ 'Range' => ['minimum_quantity', 'maximum_quantity', 'minimum_date', 'maximum_date'],
439	439	'Single value' => [],
440	440	'Symmetric' => [],
441		- 'Target required claim' => [ 'property', 'item' ],
442		- 'Type' => [ 'class', 'relation' ],
	441	+ 'Target required claim' => ['property', 'item'],
	442	+ 'Type' => ['class', 'relation'],
443	443	'Unique value' => [],
444		- 'Value type' => [ 'class', 'relation' ]
	444	+ 'Value type' => ['class', 'relation']
445	445	];
446	446	}
447	447
		@@ -452,7 +452,7 @@ discard block
		block discarded – undo
452	452	* @return ConstraintRepository
453	453	*/
454	454	public function getConstraintRepository() {
455		- if ( $this->constraintRepository === null ) {
	455	+ if ($this->constraintRepository === null) {
456	456	$this->constraintRepository = new ConstraintRepository();
457	457	}
458	458

wikimedia / mediawiki-extensions-WikibaseQualityConstraints

Push — master ( 89292f...abf49f )

Status

Category

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +50 added lines, -50 removed lines patch added patch discarded remove patch