wikimedia / mediawiki-extensions-WikibaseQualityConstraints

src/Specials/SpecialConstraintReport.php

Spacing +87 added lines, -87 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare( strict_types = 1 );
+declare(strict_types=1);
 
 namespace WikibaseQuality\ConstraintReport\Specials;
 
@@ -91,7 +91,7 @@ 
 		Config $config,
 		StatsFactory $statsFactory
 	) {
-		parent::__construct( 'ConstraintReport' );
+		parent::__construct('ConstraintReport');
 
 		$this->entityLookup = $entityLookup;
 		$this->entityTitleLookup = $entityTitleLookup;
@@ -111,7 +111,7 @@ 
 
 		$this->violationMessageRenderer = $violationMessageRendererFactory->getViolationMessageRenderer(
 			$language,
-			$languageFallbackChainFactory->newFromLanguage( $language ),
+			$languageFallbackChainFactory->newFromLanguage($language),
 			$this->getContext()
 		);
 
@@ -145,7 +145,7 @@ 
 	 * @inheritDoc
 	 */
 	public function getDescription() {
-		return $this->msg( 'wbqc-constraintreport' );
+		return $this->msg('wbqc-constraintreport');
 	}
 
 	/**
@@ -157,72 +157,72 @@ 
 	 * @throws EntityIdParsingException
 	 * @throws UnexpectedValueException
 	 */
-	public function execute( $subPage ) {
+	public function execute($subPage) {
 		$out = $this->getOutput();
 
-		$postRequest = $this->getContext()->getRequest()->getVal( 'entityid' );
-		if ( $postRequest ) {
+		$postRequest = $this->getContext()->getRequest()->getVal('entityid');
+		if ($postRequest) {
 			try {
-				$entityId = $this->entityIdParser->parse( $postRequest );
-				$out->redirect( $this->getPageTitle( $entityId->getSerialization() )->getLocalURL() );
+				$entityId = $this->entityIdParser->parse($postRequest);
+				$out->redirect($this->getPageTitle($entityId->getSerialization())->getLocalURL());
 				return;
-			} catch ( EntityIdParsingException ) {
+			} catch (EntityIdParsingException) {
 				// fall through, error is shown later
 			}
 		}
 
 		$out->enableOOUI();
-		$out->addModules( $this->getModules() );
+		$out->addModules($this->getModules());
 
 		$this->setHeaders();
 
-		$out->addHTML( $this->getExplanationText() );
+		$out->addHTML($this->getExplanationText());
 		$this->buildEntityIdForm();
 
-		if ( $postRequest ) {
+		if ($postRequest) {
 			// must be an invalid entity ID (otherwise we would have redirected and returned above)
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
 			);
 			return;
 		}
 
-		if ( !$subPage ) {
+		if (!$subPage) {
 			return;
 		}
 
 		try {
-			$entityId = $this->entityIdParser->parse( $subPage );
-		} catch ( EntityIdParsingException ) {
+			$entityId = $this->entityIdParser->parse($subPage);
+		} catch (EntityIdParsingException) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-invalid-entity-id', true )
+				$this->buildNotice('wbqc-constraintreport-invalid-entity-id', true)
 			);
 			return;
 		}
 
-		if ( !$this->entityLookup->hasEntity( $entityId ) ) {
+		if (!$this->entityLookup->hasEntity($entityId)) {
 			$out->addHTML(
-				$this->buildNotice( 'wbqc-constraintreport-not-existent-entity', true )
+				$this->buildNotice('wbqc-constraintreport-not-existent-entity', true)
 			);
 			return;
 		}
 
 		$baseKey = 'wikibase.quality.constraints.specials.specialConstraintReport.executeCheck';
-		$metric = $this->statsFactory->getCounter( 'special_constraint_report_execute_check_total' );
-		$metric->copyToStatsdAt( $baseKey )->increment();
-		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId( $entityId );
+		$metric = $this->statsFactory->getCounter('special_constraint_report_execute_check_total');
+		$metric->copyToStatsdAt($baseKey)->increment();
+		$results = $this->constraintChecker->checkAgainstConstraintsOnEntityId($entityId);
 
-		if ( !$results ) {
-			$out->addHTML( $this->buildResultHeader( $entityId ) .
-				$this->buildNotice( 'wbqc-constraintreport-empty-result' )
+		if (!$results) {
+			$out->addHTML($this->buildResultHeader($entityId).
+				$this->buildNotice('wbqc-constraintreport-empty-result')
 			);
 			return;
 		}
 
 		$out->addHTML(
-			$this->buildResultHeader( $entityId )
-			. $this->buildSummary( $results )
-			. $this->buildResultTable( $entityId, $results )
+			$this->buildResultHeader($entityId)
+			. $this->buildSummary($results)
+			. $this->buildResultTable($entityId, $results)
 		);
 	}
 
@@ -237,15 +237,15 @@ 
 				'name' => 'entityid',
 				'label-message' => 'wbqc-constraintreport-form-entityid-label',
 				'cssclass' => 'wbqc-constraintreport-form-entity-id',
-				'placeholder' => $this->msg( 'wbqc-constraintreport-form-entityid-placeholder' )->text(),
+				'placeholder' => $this->msg('wbqc-constraintreport-form-entityid-placeholder')->text(),
 				'required' => true,
 			],
 		];
-		$htmlForm = HTMLForm::factory( 'ooui', $formDescriptor, $this->getContext(),
+		$htmlForm = HTMLForm::factory('ooui', $formDescriptor, $this->getContext(),
 			'wbqc-constraintreport-form'
 		);
-		$htmlForm->setSubmitText( $this->msg( 'wbqc-constraintreport-form-submit-label' )->text() );
-		$htmlForm->setSubmitCallback( static fn () => false );
+		$htmlForm->setSubmitText($this->msg('wbqc-constraintreport-form-submit-label')->text());
+		$htmlForm->setSubmitCallback(static fn () => false);
 		$htmlForm->show();
 	}
 
@@ -259,16 +259,16 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildNotice( string $messageKey, bool $error = false ): string {
-		$cssClasses = [ 'wbqc-constraintreport-notice' ];
-		if ( $error ) {
+	private function buildNotice(string $messageKey, bool $error = false): string {
+		$cssClasses = ['wbqc-constraintreport-notice'];
+		if ($error) {
 			$cssClasses[] = ' wbqc-constraintreport-notice-error';
 		}
 
 		return Html::element(
 			'p',
-			[ 'class' => $cssClasses ],
-			$this->msg( $messageKey )->text()
+			['class' => $cssClasses],
+			$this->msg($messageKey)->text()
 		);
 	}
 
@@ -278,16 +278,16 @@ 
 	private function getExplanationText(): string {
 		return Html::rawElement(
 			'div',
-			[ 'class' => 'wbqc-explanation' ],
+			['class' => 'wbqc-explanation'],
 			Html::element(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-one' )->text()
+				$this->msg('wbqc-constraintreport-explanation-part-one')->text()
 			)
 			. Html::element(
 				'p',
 				[],
-				$this->msg( 'wbqc-constraintreport-explanation-part-two' )->text()
+				$this->msg('wbqc-constraintreport-explanation-part-two')->text()
 			)
 		);
 	}
@@ -298,31 +298,31 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function buildResultTable( EntityId $entityId, array $results ): string {
+	private function buildResultTable(EntityId $entityId, array $results): string {
 		// Set table headers
 		$table = new HtmlTableBuilder(
 			[
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-status' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-status')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-property' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-property')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-message' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-message')->text(),
 					true
 				),
 				new HtmlTableHeaderBuilder(
-					$this->msg( 'wbqc-constraintreport-result-table-header-constraint' )->text(),
+					$this->msg('wbqc-constraintreport-result-table-header-constraint')->text(),
 					true
 				),
 			]
 		);
 
-		foreach ( $results as $result ) {
-			$this->appendToResultTable( $table, $entityId, $result );
+		foreach ($results as $result) {
+			$this->appendToResultTable($table, $entityId, $result);
 		}
 
 		return $table->toHtml();
@@ -334,35 +334,35 @@ 
 		CheckResult $result
 	): void {
 		$message = $result->getMessage();
-		if ( !$message ) {
+		if (!$message) {
 			// no row for this result
 			return;
 		}
 
 		// Status column
-		$statusColumn = $this->formatStatus( $result->getStatus() );
+		$statusColumn = $this->formatStatus($result->getStatus());
 
 		// Property column
-		$propertyId = new NumericPropertyId( $result->getContextCursor()->getSnakPropertyId() );
+		$propertyId = new NumericPropertyId($result->getContextCursor()->getSnakPropertyId());
 		$propertyColumn = $this->getClaimLink(
 			$entityId,
 			$propertyId,
-			$this->entityIdLabelFormatter->formatEntityId( $propertyId )
+			$this->entityIdLabelFormatter->formatEntityId($propertyId)
 		);
 
 		// Message column
-		$messageColumn = $this->violationMessageRenderer->render( $message );
+		$messageColumn = $this->violationMessageRenderer->render($message);
 
 		// Constraint column
 		$constraintTypeItemId = $result->getConstraint()->getConstraintTypeItemId();
 		try {
-			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $constraintTypeItemId ) );
-		} catch ( InvalidArgumentException ) {
-			$constraintTypeLabel = htmlspecialchars( $constraintTypeItemId );
+			$constraintTypeLabel = $this->entityIdLabelFormatter->formatEntityId(new ItemId($constraintTypeItemId));
+		} catch (InvalidArgumentException) {
+			$constraintTypeLabel = htmlspecialchars($constraintTypeItemId);
 		}
 		$constraintColumn = $this->getClaimLink(
 			$propertyId,
-			new NumericPropertyId( $this->config->get( 'WBQualityConstraintsPropertyConstraintId' ) ),
+			new NumericPropertyId($this->config->get('WBQualityConstraintsPropertyConstraintId')),
 			$constraintTypeLabel
 		);
 
@@ -370,16 +370,16 @@ 
 		$table->appendRow(
 			[
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $statusColumn )
+					new HtmlArmor($statusColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $propertyColumn )
+					new HtmlArmor($propertyColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $messageColumn )
+					new HtmlArmor($messageColumn)
 				),
 				new HtmlTableCellBuilder(
-					new HtmlArmor( $constraintColumn )
+					new HtmlArmor($constraintColumn)
 				),
 			]
 		);
@@ -392,15 +392,15 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildResultHeader( EntityId $entityId ): string {
+	protected function buildResultHeader(EntityId $entityId): string {
 		return Html::rawElement(
 			'h3',
 			[],
-			$this->msg( 'wbqc-constraintreport-result-headline' )->escaped() .
-				$this->msg( 'word-separator' )->escaped() .
-				$this->entityIdLinkFormatter->formatEntityId( $entityId ) .
-				$this->msg( 'word-separator' )->escaped() .
-				$this->msg( 'parentheses', $entityId->getSerialization() )->escaped()
+			$this->msg('wbqc-constraintreport-result-headline')->escaped().
+				$this->msg('word-separator')->escaped().
+				$this->entityIdLinkFormatter->formatEntityId($entityId).
+				$this->msg('word-separator')->escaped().
+				$this->msg('parentheses', $entityId->getSerialization())->escaped()
 		);
 	}
 
@@ -411,23 +411,23 @@ 
 	 *
 	 * @return string HTML
 	 */
-	protected function buildSummary( array $results ): string {
+	protected function buildSummary(array $results): string {
 		$statuses = [];
-		foreach ( $results as $result ) {
-			$status = strtolower( $result->getStatus() );
+		foreach ($results as $result) {
+			$status = strtolower($result->getStatus());
 			$statuses[$status] ??= 0;
 			$statuses[$status]++;
 		}
 
 		$statusElements = [];
-		foreach ( $statuses as $status => $count ) {
-			$statusElements[] = $this->formatStatus( $status ) .
-				$this->msg( 'colon-separator' )->escaped() .
-				htmlspecialchars( $this->getLanguage()->formatNum( $count ) );
+		foreach ($statuses as $status => $count) {
+			$statusElements[] = $this->formatStatus($status).
+				$this->msg('colon-separator')->escaped().
+				htmlspecialchars($this->getLanguage()->formatNum($count));
 		}
 
-		return Html::rawElement( 'p', [],
-			implode( $this->msg( 'comma-separator' )->escaped(), $statusElements )
+		return Html::rawElement('p', [],
+			implode($this->msg('comma-separator')->escaped(), $statusElements)
 		);
 	}
 
@@ -440,8 +440,8 @@ 
 	 *
 	 * @return string HTML
 	 */
-	private function formatStatus( string $status ): string {
-		$messageName = "wbqc-constraintreport-status-" . strtolower( $status );
+	private function formatStatus(string $status): string {
+		$messageName = "wbqc-constraintreport-status-".strtolower($status);
 		$statusIcons = [
 			CheckResult::STATUS_SUGGESTION => [
 				'icon' => 'suggestion-constraint-violation',
@@ -458,21 +458,21 @@ 
 			],
 		];
 
-		if ( array_key_exists( $status, $statusIcons ) ) {
-			$iconHtml = new IconWidget( $statusIcons[$status] ) .
-				$this->msg( 'word-separator' )->escaped();
+		if (array_key_exists($status, $statusIcons)) {
+			$iconHtml = new IconWidget($statusIcons[$status]).
+				$this->msg('word-separator')->escaped();
 		} else {
 			$iconHtml = '';
 		}
 
-		$labelWidget = new LabelWidget( [ 'label' => $this->msg( $messageName )->text() ] );
+		$labelWidget = new LabelWidget(['label' => $this->msg($messageName)->text()]);
 
 		return Html::rawElement(
 			'span',
 			[
-				'class' => 'wbqc-status wbqc-status-' . $status,
+				'class' => 'wbqc-status wbqc-status-'.$status,
 			],
-			$iconHtml . $labelWidget
+			$iconHtml.$labelWidget
 		);
 	}
 
@@ -490,10 +490,10 @@ 
 		NumericPropertyId $propertyId,
 		string $text
 	): string {
-		$title = clone $this->entityTitleLookup->getTitleForId( $entityId );
-		$title->setFragment( $propertyId->getSerialization() );
+		$title = clone $this->entityTitleLookup->getTitleForId($entityId);
+		$title->setFragment($propertyId->getSerialization());
 
-		return Html::rawElement( 'a',
+		return Html::rawElement('a',
 			[
 				'href' => $title->getLinkURL(),
 				'target' => '_blank',