wikimedia / mediawiki-extensions-Wikibase

repo/tests/phpunit/includes/FederatedProperties/ApiEntitySearchHelperTest.php

Doc Comments +8 added lines, -4 removed lines

@@ -56,6 +56,9 @@ 
 		return new ApiEntitySearchHelper( $api, $dataTypes );
 	}
 
+	/**
+	 * @param string $responseDataFile
+	 */
 	private function setupTestApi( &$params, $langCode, $responseDataFile, $statusCode = 200 ) {
 		$params = array_merge( $params, [ 'language' => $langCode, 'uselang' => $langCode, 'format' => 'json' ] );
 		$api = $this->createMock( GenericActionApiClient::class );
@@ -152,8 +155,8 @@ 
 	/**
 	 * @dataProvider paramsAndExpectedResponseProvider
 	 * @param string $responseDataFile
-	 * @param int $expectedResultCount
-	 * @param array $expectedResultsEntityId
+	 * @param int $expectedResultsEntityIds
+	 * @param array $expectedResultsEntityIds
 	 * @throws ApiRequestException
 	 */
 	public function testGetRankedSearchResults( $langCode, $params, $responseDataFile, $expectedResultsEntityIds ) {
@@ -220,6 +223,9 @@ 
 		}
 	}
 
+	/**
+	 * @return string
+	 */
 	private function getResponseDataForId( array $searchResponses, $resultId ) {
 		$searchResponses = array_filter( $searchResponses, function ( $response ) use ( $resultId ) {
 			return $response->id === $resultId;
@@ -233,8 +239,6 @@ 
 	/**
 	 * @dataProvider invalidParamsAndUnexpectedResponseProvider
 	 * @param string $responseDataFile
-	 * @param int $expectedResultCount
-	 * @param array $expectedResultsEntityId
 	 */
 	public function testApiResponseStructureIsValid( $langCode, $params, $responseDataFile, $statusCode ) {
 		$api = $this->setupTestApi( $params, $langCode, $responseDataFile, $statusCode );

lib/includes/Store/Sql/Terms/PrefetchingEntityTermLookupBase.php

Doc Comments +3 added lines

@@ -133,6 +133,9 @@
 		return $this->getFromBuffer( $entityId, TermTypes::TYPE_ALIAS, $languageCode ) ?? false;
 	}
 
+	/**
+	 * @param string $languageCode
+	 */
 	private function getFromBuffer( EntityId $entityId, $termType, $languageCode ) {
 		if ( !( $entityId instanceof Int32EntityId ) ) {
 			throw new InvalidArgumentException( "Not an Int32EntityId: " . $entityId->getSerialization() );

repo/tests/phpunit/includes/HttpResponseMockerTrait.php

Doc Comments +1 added lines

@@ -14,6 +14,7 @@
 
 	/**
 	 * Some test appear to want to simulate null status codes, hence the type hint
+	 * @param integer $statusCode
 	 */
 	private function newMockResponse( $response, ?int $statusCode ): ResponseInterface {
 		$mockStream = $this->createMock( StreamInterface::class );

lib/tests/phpunit/EntityRevisionLookupTestCase.php

Doc Comments +3 added lines

@@ -56,6 +56,9 @@
 		];
 	}
 
+	/**
+	 * @param integer $revision
+	 */
 	protected function resolveLogicalRevision( $revision ) {
 		return $revision;
 	}

client/includes/Changes/AffectedPagesFinder.php

Doc Comments +1 added lines, -1 removed lines

@@ -355,7 +355,7 @@
 	}
 
 	/**
-	 * @param iterable<PageEntityUsages> $usages
+	 * @param Traversable $usages
 	 * @param EntityId $entityId
 	 * @param string[] $changedAspects
 	 *

client/includes/DataAccess/Scribunto/CachingFallbackBasedTermLookup.php

Doc Comments +1 added lines, -1 removed lines

@@ -139,7 +139,7 @@
 	/**
 	 * @param EntityId $entityId
 	 * @param Language $language
-	 * @param $termType
+	 * @param string $termType
 	 * @return TermFallback|null
 	 */
 	private function lookupWithoutCache( EntityId $entityId, Language $language, $termType ): ?TermFallback {

client/tests/phpunit/unit/includes/DataAccess/Scribunto/CachingFallbackBasedTermLookupTest.php

Doc Comments +21 added lines

@@ -110,6 +110,11 @@ 
 		);
 	}
 
+	/**
+	 * @param string $term
+	 * @param string $requestLanguageCode
+	 * @param string $actualLanguageCode
+	 */
 	private function getTermFallback( $term, $requestLanguageCode, $actualLanguageCode = null ): ?TermFallback {
 		if ( $term === null ) {
 			return null;
@@ -264,6 +269,9 @@ 
 		);
 	}
 
+	/**
+	 * @param ItemId $itemId
+	 */
 	private function mockCacheWithContent( string $term, $itemId ): void {
 		$termFallback = new TermFallback( 'en', $term, 'en', 'en' );
 		$this->revisionLookup->method( 'lookupLatestRevisionResolvingRedirect' )->willReturn( [ 1, $itemId ] );
@@ -284,6 +292,9 @@ 
 			->willReturn( [ self::ITEM_Q1_REVISION, $itemId ] );
 	}
 
+	/**
+	 * @param ItemId $itemId
+	 */
 	private function mockCacheEmpty( $itemId ): void {
 		$this->mockRevisionLookup( $itemId );
 
@@ -293,6 +304,12 @@ 
 			->willReturn( TermFallbackCacheFacade::NO_VALUE );
 	}
 
+	/**
+	 * @param TermFallback|null $termFallback
+	 * @param ItemId $targetEntityId
+	 * @param integer $revisionId
+	 * @param string $termType
+	 */
 	private function mockCacheSetExpectation(
 		$termFallback,
 		$targetEntityId,
@@ -307,6 +324,10 @@ 
 			->with( $termFallback, $targetEntityId, $revisionId, $languageCode, $termType );
 	}
 
+	/**
+	 * @param ItemId $itemId
+	 * @param TermFallback|null $termFallback
+	 */
 	private function mockInternalLookupWithContent(
 		$itemId,
 		?TermFallback $termFallback,