wikimedia / mediawiki-extensions-Wikibase

client/includes/DataAccess/Scribunto/CachingFallbackBasedTermLookup.php

Doc Comments +1 added lines, -1 removed lines

@@ -139,7 +139,7 @@
 	/**
 	 * @param EntityId $entityId
 	 * @param Language $language
-	 * @param $termType
+	 * @param string $termType
 	 * @return TermFallback|null
 	 */
 	private function lookupWithoutCache( EntityId $entityId, Language $language, $termType ): ?TermFallback {

client/tests/phpunit/unit/includes/DataAccess/Scribunto/CachingFallbackBasedTermLookupTest.php

Doc Comments +21 added lines

@@ -110,6 +110,11 @@ 
 		);
 	}
 
+	/**
+	 * @param string $term
+	 * @param string $requestLanguageCode
+	 * @param string $actualLanguageCode
+	 */
 	private function getTermFallback( $term, $requestLanguageCode, $actualLanguageCode = null ): ?TermFallback {
 		if ( $term === null ) {
 			return null;
@@ -264,6 +269,9 @@ 
 		);
 	}
 
+	/**
+	 * @param ItemId $itemId
+	 */
 	private function mockCacheWithContent( string $term, $itemId ): void {
 		$termFallback = new TermFallback( 'en', $term, 'en', 'en' );
 		$this->revisionLookup->method( 'lookupLatestRevisionResolvingRedirect' )->willReturn( [ 1, $itemId ] );
@@ -284,6 +292,9 @@ 
 			->willReturn( [ self::ITEM_Q1_REVISION, $itemId ] );
 	}
 
+	/**
+	 * @param ItemId $itemId
+	 */
 	private function mockCacheEmpty( $itemId ): void {
 		$this->mockRevisionLookup( $itemId );
 
@@ -293,6 +304,12 @@ 
 			->willReturn( TermFallbackCacheFacade::NO_VALUE );
 	}
 
+	/**
+	 * @param TermFallback|null $termFallback
+	 * @param ItemId $targetEntityId
+	 * @param integer $revisionId
+	 * @param string $termType
+	 */
 	private function mockCacheSetExpectation(
 		$termFallback,
 		$targetEntityId,
@@ -307,6 +324,10 @@ 
 			->with( $termFallback, $targetEntityId, $revisionId, $languageCode, $termType );
 	}
 
+	/**
+	 * @param ItemId $itemId
+	 * @param TermFallback|null $termFallback
+	 */
 	private function mockInternalLookupWithContent(
 		$itemId,
 		?TermFallback $termFallback,