wikimedia / mediawiki-extensions-Lingo

src/Backend.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 	 * Lingo\Backend constructor.
 	 * @param MessageLog|null $messages
 	 */
-	public function __construct( MessageLog &$messages = null ) {
+	public function __construct( MessageLog & $messages = null ) {
 
 		if ( !$messages ) {
 			$this->mMessageLog = new MessageLog();

src/Element.php

Spacing +7 added lines, -7 removed lines

@@ -48,7 +48,7 @@ 
 	const ELEMENT_LINK = 3;
 	const ELEMENT_STYLE = 4;
 
-	const ELEMENT_FIELDCOUNT = 5;  // number of fields stored for each element; (last field's index) + 1
+	const ELEMENT_FIELDCOUNT = 5; // number of fields stored for each element; (last field's index) + 1
 	static private $mLinkTemplate = null;
 	private $mFullDefinition = null;
 	private $mDefinitions = array();
@@ -73,14 +73,14 @@ 
 	 * @param $definition
 	 */
 	public function addDefinition( &$definition ) {
-		$this->mDefinitions[] = array_pad( $definition, self::ELEMENT_FIELDCOUNT, null );
+		$this->mDefinitions[ ] = array_pad( $definition, self::ELEMENT_FIELDCOUNT, null );
 	}
 
 	/**
 	 * @param DOMDocument $doc
 	 * @return DOMNode|DOMText
 	 */
-	public function getFullDefinition( DOMDocument &$doc ) {
+	public function getFullDefinition( DOMDocument & $doc ) {
 
 		global $wgexLingoDisplayOnce;
 
@@ -98,7 +98,7 @@ 
 	 * @param DOMDocument $doc
 	 * @return DOMDocument
 	 */
-	private function buildFullDefinition( DOMDocument &$doc ) {
+	private function buildFullDefinition( DOMDocument & $doc ) {
 
 		// only create if not yet created
 		if ( $this->mFullDefinition === null || $this->mFullDefinition->ownerDocument !== $doc ) {
@@ -126,7 +126,7 @@ 
 	 * @return DOMElement
 	 * @throws MWException
 	 */
-	protected function getFullDefinitionAsLink( DOMDocument &$doc ) {
+	protected function getFullDefinitionAsLink( DOMDocument & $doc ) {
 
 		// create Title object for target page
 		$target = Title::newFromText( $this->mDefinitions[ 0 ][ self::ELEMENT_LINK ] );
@@ -196,7 +196,7 @@ 
 	 * @return string
 	 * @throws MWException
 	 */
-	protected function getFullDefinitionAsTooltip( DOMDocument &$doc ) {
+	protected function getFullDefinitionAsTooltip( DOMDocument & $doc ) {
 
 		// Wrap term and definition in <span> tags
 		$span = $doc->createElement( 'span' );
@@ -239,7 +239,7 @@ 
 	 * @param DOMDocument $doc
 	 * @return DOMNode
 	 */
-	private function getLinkTemplate( DOMDocument &$doc ) {
+	private function getLinkTemplate( DOMDocument & $doc ) {
 		// create template if it does not yet exist
 		if ( !self::$mLinkTemplate || ( self::$mLinkTemplate->ownerDocument !== $doc ) ) {
 			global $wgScriptPath;

src/Tree.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -85,7 +85,7 @@ 
 	 * @param String $definition
 	 * @return Array the tree node the element was stored in
 	 */
-	protected function &addElement( Array &$path, &$term, &$definition ) {
+	protected function &addElement( array &$path, &$term, &$definition ) {
 
 		$tree = &$this->mTree;
 
@@ -142,7 +142,7 @@ 
 		}
 	}
 
-	public function findNextTermNoSkip( Array &$tree, &$lexemes, $index, $countLexemes ) {
+	public function findNextTermNoSkip( array &$tree, &$lexemes, $index, $countLexemes ) {
 
 		if ( $index + 1 < $countLexemes && array_key_exists( $currLex = $lexemes[ $index + 1 ][ 0 ], $tree ) ) {
 			$ret = $this->findNextTermNoSkip( $tree[ $currLex ], $lexemes, $index + 1, $countLexemes );

src/MessageLog.php

Spacing +4 added lines, -4 removed lines

@@ -53,7 +53,7 @@ 
 	 * @param int $severity
 	 */
 	public function addMessage( $message, $severity = self::MESSAGE_NOTICE ) {
-		$this->mMessages[] = array( $message, $severity );
+		$this->mMessages[ ] = array( $message, $severity );
 
 		// log errors and warnings in debug log
 		if ( $severity == self::MESSAGE_WARNING ||
@@ -67,7 +67,7 @@ 
 	 * @param $message
 	 */
 	public function addError( $message ) {
-		$this->mMessages[] = array( $message, self::MESSAGE_ERROR );
+		$this->mMessages[ ] = array( $message, self::MESSAGE_ERROR );
 		wfDebug( "Error: $message\n" );
 	}
 
@@ -75,7 +75,7 @@ 
 	 * @param $message
 	 */
 	public function addWarning( $message ) {
-		$this->mMessages[] = array( $message, self::MESSAGE_WARNING );
+		$this->mMessages[ ] = array( $message, self::MESSAGE_WARNING );
 		wfDebug( "Warning: $message\n" );
 	}
 
@@ -83,7 +83,7 @@ 
 	 * @param $message
 	 */
 	public function addNotice( $message ) {
-		$this->mMessages[] = array( $message, self::MESSAGE_NOTICE );
+		$this->mMessages[ ] = array( $message, self::MESSAGE_NOTICE );
 	}
 
 	/**

src/BasicBackend.php

Doc Comments -1 removed lines

@@ -50,7 +50,6 @@
 	/**
 	 * Lingo\BasicBackend constructor.
 	 * @param MessageLog|null $messages
-	 * @param LingoParser $lingoParser
 	 */
 	public function __construct( MessageLog &$messages = null ) {
 

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use ApprovedRevs;
 use ContentHandler;
 use Hooks;
-use Page;
 use Parser;
 use ParserOptions;
 use Revision;

Spacing +4 added lines, -4 removed lines

@@ -52,7 +52,7 @@ 
 	 * @param MessageLog|null $messages
 	 * @param LingoParser $lingoParser
 	 */
-	public function __construct( MessageLog &$messages = null ) {
+	public function __construct( MessageLog & $messages = null ) {
 
 		parent::__construct( $messages );
 
@@ -107,7 +107,7 @@ 
 					$term = null;
 				}
 
-				$definitions[] = trim( $chunks[ 1 ] );
+				$definitions[ ] = trim( $chunks[ 1 ] );
 			}
 
 			// found a new term?
@@ -117,7 +117,7 @@ 
 
 			if ( $term !== null ) {
 				foreach ( $definitions as $definition ) {
-					$ret[] = array(
+					$ret[ ] = array(
 						Element::ELEMENT_TERM       => $term,
 						Element::ELEMENT_DEFINITION => $definition,
 						Element::ELEMENT_LINK       => null,
@@ -158,7 +158,7 @@ 
 	 * @param WikiPage $wikipage
 	 * @return Bool
 	 */
-	public function purgeCache( WikiPage &$wikipage ) {
+	public function purgeCache( WikiPage & $wikipage ) {
 
 		$page = $this->getLingoPage();
 

src/LingoParser.php

Unused Use Statements -1 removed lines

@@ -29,7 +29,6 @@
 namespace Lingo;
 
 use DOMDocument;
-use DOMXPath;
 use Parser;
 
 /**

Spacing +4 added lines, -4 removed lines

@@ -57,7 +57,7 @@ 
 	 * Lingo\LingoParser constructor.
 	 * @param MessageLog|null $messages
 	 */
-	public function __construct( MessageLog &$messages = null ) {
+	public function __construct( MessageLog & $messages = null ) {
 		// The RegEx to split a chunk of text into words
 		// Words are: placeholders for stripped items, sequences of letters and numbers, single characters that are neither letter nor number
 		$this->regex = '/' . preg_quote( Parser::MARKER_PREFIX, '/' ) . '.*?' . preg_quote( Parser::MARKER_SUFFIX, '/' ) . '|[\p{L}\p{N}]+|[^\p{L}\p{N}]/u';
@@ -69,7 +69,7 @@ 
 	 * @param string $text
 	 * @return Boolean
 	 */
-	public function parse( Parser &$parser, &$text ) {
+	public function parse( Parser & $parser, &$text ) {
 
 		global $wgexLingoUseNamespaces;
 
@@ -172,7 +172,7 @@ 
 				} else {
 
 					wfDebug( "Cache miss: Lingo tree not found in cache.\n" );
-					$this->mLingoTree =& $this->buildLingo();
+					$this->mLingoTree = & $this->buildLingo();
 					wfDebug( "Cached lingo tree.\n" );
 				}
 
@@ -183,7 +183,7 @@ 
 
 			} else {
 				wfDebug( "Caching of lingo tree disabled.\n" );
-				$this->mLingoTree =& $this->buildLingo();
+				$this->mLingoTree = & $this->buildLingo();
 			}
 
 		}

src/Lingo.php

Spacing +4 added lines, -4 removed lines

@@ -44,7 +44,7 @@ 
 	 */
 	public static function initExtension() {
 
-		$GLOBALS[ 'wgExtensionFunctions' ][] = function () {
+		$GLOBALS[ 'wgExtensionFunctions' ][ ] = function() {
 
 			$parser = LingoParser::getInstance();
 
@@ -54,9 +54,9 @@ 
 
 			\Hooks::register( 'ParserAfterParse', array( $parser, 'parse' ) );
 
-			\Hooks::register( 'ParserFirstCallInit', function ( \Parser $parser ) {
+			\Hooks::register( 'ParserFirstCallInit', function( \Parser $parser ) {
 
-				$parser->setHook( 'noglossary', function ( $input, array $args, Parser $parser, PPFrame $frame ) {
+				$parser->setHook( 'noglossary', function( $input, array $args, Parser $parser, PPFrame $frame ) {
 					$output = $parser->recursiveTagParse( $input, $frame );
 					return '<span class="noglossary">' . $output . '</span>';
 				} );
@@ -64,7 +64,7 @@ 
 				return true;
 			} );
 
-			MagicWord::$mDoubleUnderscoreIDs[] = 'noglossary';
+			MagicWord::$mDoubleUnderscoreIDs[ ] = 'noglossary';
 
 			foreach ( $GLOBALS[ 'wgExtensionCredits' ][ 'parserhook' ] as $index => $description ) {