wikimedia / mediawiki-extensions-Lingo

src/Element.php

Spacing +10 added lines, -10 removed lines

@@ -48,14 +48,14 @@ 
 	const ELEMENT_LINK = 3;
 	const ELEMENT_STYLE = 4;
 
-	const ELEMENT_FIELDCOUNT = 5;  // number of fields stored for each element; (last field's index) + 1
+	const ELEMENT_FIELDCOUNT = 5; // number of fields stored for each element; (last field's index) + 1
 
 	const LINK_TEMPLATE_ID = 'LingoLink';
 
 	private $formattedTerm = null;
 	private $formattedDefinitions = null;
 
-	private $mDefinitions = [];
+	private $mDefinitions = [ ];
 	private $mTerm = null;
 
 	private $hasBeenDisplayed = false;
@@ -76,7 +76,7 @@ 
 	 * @param array $definition
 	 */
 	public function addDefinition( &$definition ) {
-		$this->mDefinitions[] = $definition + array_fill( 0, self::ELEMENT_FIELDCOUNT, null ) ;
+		$this->mDefinitions[ ] = $definition + array_fill( 0, self::ELEMENT_FIELDCOUNT, null );
 	}
 
 	/**
@@ -134,7 +134,7 @@ 
 		$descriptor = $this->getDescriptorFromLinkTarget( $linkTarget );
 
 		if ( $descriptor === null ) {
-			$this->mDefinitions = [];
+			$this->mDefinitions = [ ];
 			$this->addErrorMessageForInvalidLink( $linkTarget );
 			return $this->buildFormattedTermAsTooltip( $doc );
 		}
@@ -184,20 +184,20 @@ 
 		// set style
 		$classes = [ 'mw-lingo-term' ];
 
-		$classes[] = $this->mDefinitions[ 0 ][ self::ELEMENT_STYLE ];
+		$classes[ ] = $this->mDefinitions[ 0 ][ self::ELEMENT_STYLE ];
 
 		if ( array_key_exists( 'title', $descriptor ) && $descriptor[ 'title' ] instanceof Title ) {
 
-			if ( !$descriptor['title']->isKnown() ) {
-				$classes[] = 'new';
+			if ( !$descriptor[ 'title' ]->isKnown() ) {
+				$classes[ ] = 'new';
 			}
 
-			if ( $descriptor['title']->isExternal() ) {
-				$classes[] = 'extiw';
+			if ( $descriptor[ 'title' ]->isExternal() ) {
+				$classes[ ] = 'extiw';
 			}
 
 		} else {
-			$classes[] = 'ext';
+			$classes[ ] = 'ext';
 		}
 
 		return array_filter( $classes );

src/LingoParser.php

Spacing +4 added lines, -4 removed lines

@@ -155,7 +155,7 @@ 
 				} else {
 
 					wfDebug( "Cache miss: Lingo tree not found in cache.\n" );
-					$this->mLingoTree =& $this->buildLingo();
+					$this->mLingoTree = & $this->buildLingo();
 					wfDebug( "Cached lingo tree.\n" );
 				}
 
@@ -166,7 +166,7 @@ 
 
 			} else {
 				wfDebug( "Caching of lingo tree disabled.\n" );
-				$this->mLingoTree =& $this->buildLingo();
+				$this->mLingoTree = & $this->buildLingo();
 			}
 
 		}
@@ -231,7 +231,7 @@ 
 		// Iterate all HTML text matches
 		$numberOfTextElements = $textElements->length;
 
-		$definitions = [];
+		$definitions = [ ];
 
 		for ( $textElementIndex = 0; $textElementIndex < $numberOfTextElements; $textElementIndex++ ) {
 			$textElement = $textElements->item( $textElementIndex );
@@ -240,7 +240,7 @@ 
 				continue;
 			}
 
-			$matches = [];
+			$matches = [ ];
 			preg_match_all(
 				$this->regex,
 				$textElement->nodeValue,

tests/phpunit/Unit/ElementTest.php

Spacing +8 added lines, -8 removed lines

@@ -53,7 +53,7 @@ 
 	public function testCanConstruct() {
 
 		$term = 'someTerm';
-		$definition = [];
+		$definition = [ ];
 		$element = new Element( $term, $definition );
 
 		$this->assertInstanceOf( '\Lingo\Element', $element );
@@ -78,7 +78,7 @@ 
 
 		$GLOBALS[ 'wgexLingoDisplayOnce' ] = false;
 
-		$expectedAttributes = ['class' => [ 'mw-lingo-term' ], 'data-lingo-term-id' => '8ade40e10f35a32fbb1e06a4b54751d0' ];
+		$expectedAttributes = [ 'class' => [ 'mw-lingo-term' ], 'data-lingo-term-id' => '8ade40e10f35a32fbb1e06a4b54751d0' ];
 
 		// Run
 		$node = $element->getFormattedTerm( $this->doc );
@@ -102,12 +102,12 @@ 
 
 		// Setup
 		$term = 'someTerm';
-		$definition = [];
+		$definition = [ ];
 		$element = new Element( $term, $definition );
 
 		$GLOBALS[ 'wgexLingoDisplayOnce' ] = true;
 
-		$expectedAttributes = ['class' => 'mw-lingo-term', 'data-lingo-term-id' => '8ade40e10f35a32fbb1e06a4b54751d0' ];
+		$expectedAttributes = [ 'class' => 'mw-lingo-term', 'data-lingo-term-id' => '8ade40e10f35a32fbb1e06a4b54751d0' ];
 
 		// Run
 		$node = $element->getFormattedTerm( $this->doc );
@@ -146,7 +146,7 @@ 
 
 		$element = new Element( $term, $definition );
 
-		$expectedAttributes = [ 'class' => [ 'mw-lingo-term', 'new' ],  'title' => wfMessage( 'red-link-title', $title )->text()];
+		$expectedAttributes = [ 'class' => [ 'mw-lingo-term', 'new' ], 'title' => wfMessage( 'red-link-title', $title )->text() ];
 
 		$GLOBALS[ 'wgexLingoDisplayOnce' ] = false;
 
@@ -183,7 +183,7 @@ 
 
 		$element = new Element( $term, $definition );
 
-		$expectedAttributes = [ 'class' => [ 'mw-lingo-term' ],  'title' => $title ];
+		$expectedAttributes = [ 'class' => [ 'mw-lingo-term' ], 'title' => $title ];
 
 		$GLOBALS[ 'wgexLingoDisplayOnce' ] = false;
 
@@ -490,7 +490,7 @@ 
 	 * @param string[] $expectedAttributes
 	 * @param array $unexpectedAttributes
 	 */
-	protected function checkTermIsDomElement( $node, $tagName, $text, $expectedAttributes = [], $unexpectedAttributes = [] ) {
+	protected function checkTermIsDomElement( $node, $tagName, $text, $expectedAttributes = [ ], $unexpectedAttributes = [ ] ) {
 		$nodeText = $this->doc->saveHTML( $node );
 
 		$this->assertInstanceOf( 'DOMElement', $node );
@@ -502,7 +502,7 @@ 
 			$classes = array_flip( array_filter( explode( ' ', $node->getAttribute( 'class' ) ) ) );
 
 			foreach ( (array) $expectedAttributes[ 'class' ] as $expectedClass ) {
-				$this->assertTrue( array_key_exists( $expectedClass , $classes ) );
+				$this->assertTrue( array_key_exists( $expectedClass, $classes ) );
 			}
 
 			unset( $expectedAttributes[ 'class' ] );