wikimedia / mediawiki-extensions-Lingo

src/Backend.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 	 * Lingo\Backend constructor.
 	 * @param MessageLog|null $messages
 	 */
-	public function __construct( MessageLog &$messages = null ) {
+	public function __construct( MessageLog & $messages = null ) {
 
 		if ( !$messages ) {
 			$this->mMessageLog = new MessageLog();

src/Tree.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -85,7 +85,7 @@ 
 	 * @param String $definition
 	 * @return Array the tree node the element was stored in
 	 */
-	protected function &addElement( Array &$path, &$term, &$definition ) {
+	protected function &addElement( array &$path, &$term, &$definition ) {
 
 		$tree = &$this->mTree;
 
@@ -142,7 +142,7 @@ 
 		}
 	}
 
-	public function findNextTermNoSkip( Array &$tree, &$lexemes, $index, $countLexemes ) {
+	public function findNextTermNoSkip( array &$tree, &$lexemes, $index, $countLexemes ) {
 
 		if ( $index + 1 < $countLexemes && array_key_exists( $currLex = $lexemes[ $index + 1 ][ 0 ], $tree ) ) {
 			$ret = $this->findNextTermNoSkip( $tree[ $currLex ], $lexemes, $index + 1, $countLexemes );

src/MessageLog.php

Spacing +4 added lines, -4 removed lines

@@ -53,7 +53,7 @@ 
 	 * @param int $severity
 	 */
 	public function addMessage( $message, $severity = self::MESSAGE_NOTICE ) {
-		$this->mMessages[] = array( $message, $severity );
+		$this->mMessages[ ] = array( $message, $severity );
 
 		// log errors and warnings in debug log
 		if ( $severity == self::MESSAGE_WARNING ||
@@ -67,7 +67,7 @@ 
 	 * @param $message
 	 */
 	public function addError( $message ) {
-		$this->mMessages[] = array( $message, self::MESSAGE_ERROR );
+		$this->mMessages[ ] = array( $message, self::MESSAGE_ERROR );
 		wfDebug( "Error: $message\n" );
 	}
 
@@ -75,7 +75,7 @@ 
 	 * @param $message
 	 */
 	public function addWarning( $message ) {
-		$this->mMessages[] = array( $message, self::MESSAGE_WARNING );
+		$this->mMessages[ ] = array( $message, self::MESSAGE_WARNING );
 		wfDebug( "Warning: $message\n" );
 	}
 
@@ -83,7 +83,7 @@ 
 	 * @param $message
 	 */
 	public function addNotice( $message ) {
-		$this->mMessages[] = array( $message, self::MESSAGE_NOTICE );
+		$this->mMessages[ ] = array( $message, self::MESSAGE_NOTICE );
 	}
 
 	/**

src/Lingo.php

Spacing +4 added lines, -4 removed lines

@@ -44,7 +44,7 @@ 
 	 */
 	public static function initExtension() {
 
-		$GLOBALS[ 'wgExtensionFunctions' ][] = function () {
+		$GLOBALS[ 'wgExtensionFunctions' ][ ] = function() {
 
 			$parser = LingoParser::getInstance();
 
@@ -54,9 +54,9 @@ 
 
 			\Hooks::register( 'ParserAfterParse', array( $parser, 'parse' ) );
 
-			\Hooks::register( 'ParserFirstCallInit', function ( \Parser $parser ) {
+			\Hooks::register( 'ParserFirstCallInit', function( \Parser $parser ) {
 
-				$parser->setHook( 'noglossary', function ( $input, array $args, Parser $parser, PPFrame $frame ) {
+				$parser->setHook( 'noglossary', function( $input, array $args, Parser $parser, PPFrame $frame ) {
 					$output = $parser->recursiveTagParse( $input, $frame );
 					return '<span class="noglossary">' . $output . '</span>';
 				} );
@@ -64,7 +64,7 @@ 
 				return true;
 			} );
 
-			MagicWord::$mDoubleUnderscoreIDs[] = 'noglossary';
+			MagicWord::$mDoubleUnderscoreIDs[ ] = 'noglossary';
 
 			foreach ( $GLOBALS[ 'wgExtensionCredits' ][ 'parserhook' ] as $index => $description ) {
 

src/LingoParser.php

Spacing +5 added lines, -5 removed lines

@@ -57,7 +57,7 @@ 
 	 * Lingo\LingoParser constructor.
 	 * @param MessageLog|null $messages
 	 */
-	public function __construct( MessageLog &$messages = null ) {
+	public function __construct( MessageLog & $messages = null ) {
 		// The RegEx to split a chunk of text into words
 		// Words are: placeholders for stripped items, sequences of letters and numbers, single characters that are neither letter nor number
 		$this->regex = '/' . preg_quote( Parser::MARKER_PREFIX, '/' ) . '.*?' . preg_quote( Parser::MARKER_SUFFIX, '/' ) . '|[\p{L}\p{N}]+|[^\p{L}\p{N}]/u';
@@ -69,7 +69,7 @@ 
 	 * @param string $text
 	 * @return Boolean
 	 */
-	public function parse( Parser &$parser, &$text ) {
+	public function parse( Parser & $parser, &$text ) {
 
 		// parse if
 		if ( $this->shouldParse( $parser ) ) {
@@ -161,7 +161,7 @@ 
 				} else {
 
 					wfDebug( "Cache miss: Lingo tree not found in cache.\n" );
-					$this->mLingoTree =& $this->buildLingo();
+					$this->mLingoTree = & $this->buildLingo();
 					wfDebug( "Cached lingo tree.\n" );
 				}
 
@@ -172,7 +172,7 @@ 
 
 			} else {
 				wfDebug( "Caching of lingo tree disabled.\n" );
-				$this->mLingoTree =& $this->buildLingo();
+				$this->mLingoTree = & $this->buildLingo();
 			}
 
 		}
@@ -385,7 +385,7 @@ 
 	 * @param Parser $parser
 	 * @return bool
 	 */
-	protected function shouldParse( Parser &$parser ) {
+	protected function shouldParse( Parser & $parser ) {
 		global $wgexLingoUseNamespaces;
 
 		$title = $parser->getTitle();

Unused Use Statements -2 removed lines

@@ -28,8 +28,6 @@
  */
 namespace Lingo;
 
-use DOMDocument;
-use DOMXPath;
 use Parser;
 
 /**

src/Element.php

Doc Comments +4 added lines, -4 removed lines

@@ -58,8 +58,8 @@ 
 
 	/**
 	 * Lingo\Element constructor.
-	 * @param $term
-	 * @param $definition
+	 * @param string $term
+	 * @param string $definition
 	 */
 	public function __construct( &$term, &$definition = null ) {
 
@@ -152,7 +152,7 @@ 
 
 	/**
 	 * @param $target
-	 * @param $link
+	 * @param DOMElement $link
 	 * @return mixed
 	 */
 	protected function &addClassAttributeToLink( $target, &$link ) {
@@ -203,7 +203,7 @@ 
 
 	/**
 	 * @param StashingDOMDocument $doc
-	 * @return string
+	 * @return DOMElement
 	 * @throws \MWException
 	 */
 	protected function getFullDefinitionAsTooltip( StashingDOMDocument &$doc ) {

Spacing +7 added lines, -7 removed lines

@@ -47,7 +47,7 @@ 
 	const ELEMENT_LINK = 3;
 	const ELEMENT_STYLE = 4;
 
-	const ELEMENT_FIELDCOUNT = 5;  // number of fields stored for each element; (last field's index) + 1
+	const ELEMENT_FIELDCOUNT = 5; // number of fields stored for each element; (last field's index) + 1
 
 	const LINK_TEMPLATE_ID = 'LingoLink';
 
@@ -74,14 +74,14 @@ 
 	 * @param $definition
 	 */
 	public function addDefinition( &$definition ) {
-		$this->mDefinitions[] = array_pad( $definition, self::ELEMENT_FIELDCOUNT, null );
+		$this->mDefinitions[ ] = array_pad( $definition, self::ELEMENT_FIELDCOUNT, null );
 	}
 
 	/**
 	 * @param StashingDOMDocument $doc
 	 * @return DOMNode|DOMText
 	 */
-	public function getFullDefinition( StashingDOMDocument &$doc ) {
+	public function getFullDefinition( StashingDOMDocument & $doc ) {
 
 		global $wgexLingoDisplayOnce;
 
@@ -98,7 +98,7 @@ 
 	/**
 	 * @param StashingDOMDocument $doc
 	 */
-	private function buildFullDefinition( StashingDOMDocument &$doc ) {
+	private function buildFullDefinition( StashingDOMDocument & $doc ) {
 
 		// only create if not yet created
 		if ( $this->mFullDefinition === null || $this->mFullDefinition->ownerDocument !== $doc ) {
@@ -125,7 +125,7 @@ 
 	 * @return DOMElement
 	 * @throws \MWException
 	 */
-	protected function getFullDefinitionAsLink( StashingDOMDocument &$doc ) {
+	protected function getFullDefinitionAsLink( StashingDOMDocument & $doc ) {
 
 		// create Title object for target page
 		$target = Title::newFromText( $this->mDefinitions[ 0 ][ self::ELEMENT_LINK ] );
@@ -206,7 +206,7 @@ 
 	 * @return string
 	 * @throws \MWException
 	 */
-	protected function getFullDefinitionAsTooltip( StashingDOMDocument &$doc ) {
+	protected function getFullDefinitionAsTooltip( StashingDOMDocument & $doc ) {
 
 		// Wrap term and definition in <span> tags
 		$span = $doc->createElement( 'span' );
@@ -251,7 +251,7 @@ 
 	 * @param StashingDOMDocument $doc
 	 * @return DOMNode
 	 */
-	private function getLinkTemplate( StashingDOMDocument &$doc ) {
+	private function getLinkTemplate( StashingDOMDocument & $doc ) {
 
 		$mLinkTemplate = $doc->stashGet( self::LINK_TEMPLATE_ID );
 

src/StashingDOMDocument.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
 	 * @param $key
 	 * @return bool
 	 */
-	public function isStashed ( $key ) {
+	public function isStashed( $key ) {
 		return isset( $this->mStash[ $key ] );
 	}
 

src/BasicBackend.php

Doc Comments +2 added lines, -2 removed lines

@@ -128,8 +128,8 @@
 	}
 
 	/**
-	 * @param $definitions
-	 * @param $term
+	 * @param string[] $definitions
+	 * @param string $term
 	 * @return array
 	 */
 	protected function queueDefinitions( $definitions, $term ) {

Spacing +4 added lines, -4 removed lines

@@ -50,7 +50,7 @@ 
 	 * Lingo\BasicBackend constructor.
 	 * @param MessageLog|null $messages
 	 */
-	public function __construct( MessageLog &$messages = null ) {
+	public function __construct( MessageLog & $messages = null ) {
 
 		parent::__construct( $messages );
 
@@ -116,7 +116,7 @@ 
 				$term = null;
 			}
 
-			$definitions[] = trim( $chunks[ 1 ] );
+			$definitions[ ] = trim( $chunks[ 1 ] );
 		}
 
 		// found a new term?
@@ -136,7 +136,7 @@ 
 		$ret = array();
 
 		foreach ( $definitions as $definition ) {
-			$ret[] = array(
+			$ret[ ] = array(
 				Element::ELEMENT_TERM       => $term,
 				Element::ELEMENT_DEFINITION => $definition,
 				Element::ELEMENT_LINK       => null,
@@ -255,7 +255,7 @@ 
 	 * @param WikiPage $wikipage
 	 * @return Bool
 	 */
-	public function purgeCache( WikiPage &$wikipage ) {
+	public function purgeCache( WikiPage & $wikipage ) {
 
 		if ( !is_null( $wikipage ) && ( $wikipage->getTitle()->getText() === $this->getLingoPageName() ) ) {