Completed
Pull Request — master (#183)
by Konstantin
04:23
created
src/Pagerfanta/Adapter/SolariumAdapter.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -125,6 +125,10 @@
 block discarded – undo
125 125
         return $this->resultSet;
126 126
     }
127 127
 
128
+    /**
129
+     * @param integer|null $start
130
+     * @param integer|null $rows
131
+     */
128 132
     private function resultSetStartAndRowsAreNotNullAndChange($start, $rows)
129 133
     {
130 134
         return $this->resultSetStartAndRowsAreNotNull($start, $rows) &&
Please login to merge, or discard this patch.
tests/Pagerfanta/Tests/Adapter/DoctrineDbalTestCase.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -43,6 +43,9 @@  discard block
 block discarded – undo
43 43
         return DriverManager::getConnection($params);
44 44
     }
45 45
 
46
+    /**
47
+     * @param \Doctrine\DBAL\Connection $conn
48
+     */
46 49
     private function createSchema($conn)
47 50
     {
48 51
         $schema = new Schema();
@@ -66,6 +69,9 @@  discard block
 block discarded – undo
66 69
         }
67 70
     }
68 71
 
72
+    /**
73
+     * @param \Doctrine\DBAL\Connection $conn
74
+     */
69 75
     private function insertData($conn)
70 76
     {
71 77
         for ($i = 1; $i <= 50; $i++) {
Please login to merge, or discard this patch.
tests/Pagerfanta/Tests/Adapter/SolariumAdapterTest.php 1 patch
Doc Comments   +14 added lines patch added patch discarded remove patch
@@ -8,8 +8,19 @@  discard block
 block discarded – undo
8 8
 {
9 9
     abstract protected function getSolariumName();
10 10
 
11
+    /**
12
+     * @return string
13
+     */
11 14
     abstract protected function getClientClass();
15
+
16
+    /**
17
+     * @return string
18
+     */
12 19
     abstract protected function getQueryClass();
20
+
21
+    /**
22
+     * @return string
23
+     */
13 24
     abstract protected function getResultClass();
14 25
 
15 26
     public function setUp()
@@ -188,6 +199,9 @@  discard block
 block discarded – undo
188 199
         $this->doTestGetResultSet($query, $endPoint);
189 200
     }
190 201
 
202
+    /**
203
+     * @param null|string $endPoint
204
+     */
191 205
     private function doTestGetResultSet($query, $endPoint)
192 206
     {
193 207
         $client = $this->createClientMock();
Please login to merge, or discard this patch.
src/Pagerfanta/Pagerfanta.php 1 patch
Doc Comments   +16 added lines patch added patch discarded remove patch
@@ -106,6 +106,9 @@  discard block
 block discarded – undo
106 106
         return $this->normalizeOutOfRangePages;
107 107
     }
108 108
 
109
+    /**
110
+     * @param boolean $value
111
+     */
109 112
     private function filterBoolean($value)
110 113
     {
111 114
         if (!is_bool($value)) {
@@ -135,6 +138,9 @@  discard block
 block discarded – undo
135 138
         return $this;
136 139
     }
137 140
 
141
+    /**
142
+     * @param integer $maxPerPage
143
+     */
138 144
     private function filterMaxPerPage($maxPerPage)
139 145
     {
140 146
         $maxPerPage = $this->toInteger($maxPerPage);
@@ -215,6 +221,10 @@  discard block
 block discarded – undo
215 221
         $this->useDeprecatedBooleanArgument($arguments, $index, $method);
216 222
     }
217 223
 
224
+    /**
225
+     * @param integer $index
226
+     * @param string $method
227
+     */
218 228
     private function useDeprecatedBooleanArgument($arguments, $index, $method)
219 229
     {
220 230
         if (isset($arguments[$index])) {
@@ -222,6 +232,9 @@  discard block
 block discarded – undo
222 232
         }
223 233
     }
224 234
 
235
+    /**
236
+     * @param integer $currentPage
237
+     */
225 238
     private function filterCurrentPage($currentPage)
226 239
     {
227 240
         $currentPage = $this->toInteger($currentPage);
@@ -244,6 +257,9 @@  discard block
 block discarded – undo
244 257
         }
245 258
     }
246 259
 
260
+    /**
261
+     * @return integer
262
+     */
247 263
     private function filterOutOfRangeCurrentPage($currentPage)
248 264
     {
249 265
         if ($this->notAllowedCurrentPageOutOfRange($currentPage)) {
Please login to merge, or discard this patch.
tests/Pagerfanta/Tests/PagerfantaTest.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -33,11 +33,17 @@  discard block
 block discarded – undo
33 33
         $this->pagerfanta = new Pagerfanta($this->adapter);
34 34
     }
35 35
 
36
+    /**
37
+     * @param integer $nbResults
38
+     */
36 39
     private function setAdapterNbResultsAny($nbResults)
37 40
     {
38 41
         $this->setAdapterNbResults($this->any(), $nbResults);
39 42
     }
40 43
 
44
+    /**
45
+     * @param integer $nbResults
46
+     */
41 47
     private function setAdapterNbResultsOnce($nbResults)
42 48
     {
43 49
         $this->setAdapterNbResults($this->once(), $nbResults);
@@ -707,6 +713,9 @@  discard block
 block discarded – undo
707 713
         $pagerfanta->getCurrentPageResults();
708 714
     }
709 715
 
716
+    /**
717
+     * @param \Closure $callback
718
+     */
710 719
     private function assertResetCurrentPageResults($callback)
711 720
     {
712 721
         $this->setAdapterNbResultsAny(100);
Please login to merge, or discard this patch.