org.usfirst.frc.team3695.robot.commands.CyborgCommandGoToMid.initialize() - Code Metrics - Inspection of "8.2" - wh1ter0se/PowerUp-2018 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0672dd...74c8db )

by John

created 2018-02-17 03:06 UTC

initialize() A

↳ Parent: org.usfirst.frc.team3695.robot.commands.CyborgCommandGoToMid

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	3
rs	10
cc	1

package org.usfirst.frc.team3695.robot.commands;

import edu.wpi.first.wpilibj.DigitalInput;
import edu.wpi.first.wpilibj.DriverStation;

import org.usfirst.frc.team3695.robot.Robot;
import org.usfirst.frc.team3695.robot.enumeration.Position;

import edu.wpi.first.wpilibj.command.Command;

/**
 * toggles the state of the clamp
 */
public class CyborgCommandGoToMid extends Command {
	
	Boolean isFinished;

	
    public CyborgCommandGoToMid() {
        requires(Robot.SUB_MAST);
    }

    protected void initialize() {
    	DriverStation.reportWarning("MOVING TO MID POSITION", false);
    	isFinished = true;
    }

    protected void execute() {
    	if (!isFinished) {
    		isFinished = Robot.SUB_MAST.goToMiddle();
    	}
    }

    protected boolean isFinished() {
    	DriverStation.reportWarning("AT MID POSITION", false);
    	return isFinished; 
	}

    protected void end() {}

    protected void interrupted() {
    	end();
    }
}


1			package org.usfirst.frc.team3695.robot.commands;
2
3			import edu.wpi.first.wpilibj.DigitalInput;
4			import edu.wpi.first.wpilibj.DriverStation;
5
6			import org.usfirst.frc.team3695.robot.Robot;
7			import org.usfirst.frc.team3695.robot.enumeration.Position;
8
9			import edu.wpi.first.wpilibj.command.Command;
10
11			/**
12			* toggles the state of the clamp
13			*/
14			public class CyborgCommandGoToMid extends Command {
15
16			Boolean isFinished;
			0 ignored issues – show Comprehensibility introduced 2018-02-16 03:10 UTC by Report Bug Copy Issue Report Fields and methods should not have conflicting names like `isFinished`. While this is technically legal it can lead to misunderstandings and problems with serialization. Loading history...
17
18			public CyborgCommandGoToMid() {
19			requires(Robot.SUB_MAST);
20			}
21
22			protected void initialize() {
23			DriverStation.reportWarning("MOVING TO MID POSITION", false);
24			isFinished = true;
25			}
26
27			protected void execute() {
28			if (!isFinished) {
29			isFinished = Robot.SUB_MAST.goToMiddle();
30			}
31			}
32
33			protected boolean isFinished() {
34			DriverStation.reportWarning("AT MID POSITION", false);
35			return isFinished;
36			}
37
38			protected void end() {}
39
40			protected void interrupted() {
41			end();
42			}
43			}
44

wh1ter0se / PowerUp-2018

Push — master ( 0672dd...74c8db )

initialize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like