org.usfirst.frc.team3695.robot.util.Xbox.RIGHT_Y(Joystick) - Code Metrics - wh1ter0se/PowerUp-2018 - Measure and Improve Code Quality continuously with Scrutinizer

RIGHT_Y(Joystick) A
last analyzed 2018-03-21 15:27 UTC

↳ Parent: org.usfirst.frc.team3695.robot.util.Xbox

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	1
c	0
b	0
f	0
rs	10
cc	1

1			package org.usfirst.frc.team3695.robot.util;
2
3			import edu.wpi.first.wpilibj.Joystick;
4
5			/** all of the stuff you need to implement X360 controllers */
6			public class Xbox {
			0 ignored issues – show Best Practice introduced 2018-01-21 01:00 UTC by Report Bug Copy Issue Report This looks like a utility class. You may want to hide the implict public constructor behind a private one, so the class cannot be instantiated, Loading history...
7
8			public static final double DEADZONE = 0.25;
			0 ignored issues – show Comprehensibility introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Fields and methods should not have conflicting names like `DEADZONE`. While this is technically legal it can lead to misunderstandings and problems with serialization. Loading history...
9
10			public static final int
11			A = 1,
12			B = 2,
			0 ignored issues – show Coding Style introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Declaring several variables on the same line makes your code hard to read. Consider delaring `B` on a separate line. Loading history...
13			X = 3,
			0 ignored issues – show Coding Style introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Declaring several variables on the same line makes your code hard to read. Consider delaring `X` on a separate line. Loading history...
14			Y = 4,
			0 ignored issues – show Coding Style introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Declaring several variables on the same line makes your code hard to read. Consider delaring `Y` on a separate line. Loading history...
15			LB = 5,
			0 ignored issues – show Coding Style introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Declaring several variables on the same line makes your code hard to read. Consider delaring `LB` on a separate line. Loading history...
16			RB = 6,
			0 ignored issues – show Coding Style introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Declaring several variables on the same line makes your code hard to read. Consider delaring `RB` on a separate line. Loading history...
17			BACK = 7,
			0 ignored issues – show Coding Style introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Declaring several variables on the same line makes your code hard to read. Consider delaring `BACK` on a separate line. Loading history...
18			START = 8,
			0 ignored issues – show Coding Style introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Declaring several variables on the same line makes your code hard to read. Consider delaring `START` on a separate line. Loading history...
19			LSTICK = 9,
			0 ignored issues – show Coding Style introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Declaring several variables on the same line makes your code hard to read. Consider delaring `LSTICK` on a separate line. Loading history...
20			RSTICK = 10;
			0 ignored issues – show Coding Style introduced 2017-11-26 02:49 UTC by Report Bug Copy Issue Report Declaring several variables on the same line makes your code hard to read. Consider delaring `RSTICK` on a separate line. Loading history...
21
22			private static double deadzone(double rawAxis) { // deadzone value is in constants
23			boolean positive = rawAxis > 0.0;
24			rawAxis *= (positive ? 1.0 : -1.0); //flip if needed
25			rawAxis -= DEADZONE; //clip dead zone
26			if(rawAxis < 0.0) rawAxis = 0.0; //trim if less than 0
27			rawAxis /= (1.0 - DEADZONE); //scale back to 1.0
28			rawAxis *= (positive ? 1.0 : -1.0); //flip back
29			return rawAxis;
30			}
31
32			public static double LEFT_X(Joystick joy) {return deadzone(joy.getRawAxis(0));}
33			public static double LEFT_Y(Joystick joy) {return deadzone(joy.getRawAxis(1));}
34			public static double RIGHT_X(Joystick joy) {return deadzone(joy.getRawAxis(4));}
			0 ignored issues – show Comprehensibility introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Consider assigning this magic number 4 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
35			public static double RIGHT_Y(Joystick joy) {return deadzone(joy.getRawAxis(5));}
			0 ignored issues – show Comprehensibility introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Consider assigning this magic number 5 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
36			public static double LT(Joystick joy) {return joy.getRawAxis(2);}
			0 ignored issues – show Comprehensibility introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Consider assigning this magic number 2 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
37			public static double RT(Joystick joy) {return joy.getRawAxis(3);}
			0 ignored issues – show Comprehensibility introduced 2017-11-23 04:13 UTC by Report Bug Copy Issue Report Consider assigning this magic number 3 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
38			}
39

wh1ter0se / PowerUp-2018

RIGHT_Y(Joystick) A last analyzed 2018-03-21 15:27 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RIGHT_Y(Joystick) A
last analyzed 2018-03-21 15:27 UTC