org.usfirst.frc.team3695.robot.util.Field.getSwitch() - Code Metrics - wh1ter0se/PowerUp-2018 - Measure and Improve Code Quality continuously with Scrutinizer

getSwitch() A
last analyzed 2018-03-21 15:27 UTC

↳ Parent: org.usfirst.frc.team3695.robot.util.Field

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	5
rs	10
cc	2

package org.usfirst.frc.team3695.robot.util;

import edu.wpi.first.wpilibj.DriverStation;
import org.usfirst.frc.team3695.robot.enumeration.Position;

public class Field {

	public static Position getOurScale() {
		if (DriverStation.getInstance().getGameSpecificMessage().charAt(0) == 'L') {
			return Position.LEFT;
		} else {
			return Position.RIGHT;
		}
	}
	
	public static Position getThierScale() {
		if (DriverStation.getInstance().getGameSpecificMessage().charAt(2) == 'L') {

			return Position.LEFT;
		} else {
			return Position.RIGHT;
		}
	}
	
	public static Position getSwitch() {
		if (DriverStation.getInstance().getGameSpecificMessage().charAt(1) == 'L') {
			return Position.LEFT;
		} else {
			return Position.RIGHT;
		}
	}
}


1			package org.usfirst.frc.team3695.robot.util;
2
3			import edu.wpi.first.wpilibj.DriverStation;
4			import org.usfirst.frc.team3695.robot.enumeration.Position;
5
6			public class Field {
			0 ignored issues – show Best Practice introduced 2018-02-23 00:10 UTC by Report Bug Copy Issue Report This looks like a utility class. You may want to hide the implict public constructor behind a private one, so the class cannot be instantiated, Loading history...
7			public static Position getOurScale() {
8			if (DriverStation.getInstance().getGameSpecificMessage().charAt(0) == 'L') {
9			return Position.LEFT;
10			} else {
11			return Position.RIGHT;
12			}
13			}
14
15			public static Position getThierScale() {
16			if (DriverStation.getInstance().getGameSpecificMessage().charAt(2) == 'L') {
			0 ignored issues – show Comprehensibility introduced 2018-01-09 05:46 UTC by Report Bug Copy Issue Report Consider assigning this magic number 2 to a constant. Using constants for hard-coded numbers is a best practice. A constant’s name can explain the rationale behind this magic number. It is also easier to find if you ever need to change it. Loading history...
17			return Position.LEFT;
18			} else {
19			return Position.RIGHT;
20			}
21			}
22
23			public static Position getSwitch() {
24			if (DriverStation.getInstance().getGameSpecificMessage().charAt(1) == 'L') {
25			return Position.LEFT;
26			} else {
27			return Position.RIGHT;
28			}
29			}
30			}
31

wh1ter0se / PowerUp-2018

getSwitch() A last analyzed 2018-03-21 15:27 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

getSwitch() A
last analyzed 2018-03-21 15:27 UTC