org.usfirst.frc.team3695.robot.commands.CyborgCommandSpit.initialize() - Code Metrics - wh1ter0se/PowerUp-2018 - Measure and Improve Code Quality continuously with Scrutinizer

initialize() A
last analyzed 2018-03-21 15:27 UTC

↳ Parent: org.usfirst.frc.team3695.robot.commands.CyborgCommandSpit

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
cc	1
dl	0
loc	2
rs	10
c	3
b	0
f	1

package org.usfirst.frc.team3695.robot.commands;

import edu.wpi.first.wpilibj.command.Command;
import org.usfirst.frc.team3695.robot.Robot;

public class CyborgCommandSpit extends Command {

	Boolean isFinished;

    long runTime;
    long startTime;
    
    public CyborgCommandSpit(long runTime) {
    	isFinished = false;
        requires(Robot.SUB_MANIPULATOR);
        this.runTime = runTime;
    }

    protected void initialize() {
    	startTime = System.currentTimeMillis();
    }

    protected void execute() {
        if (startTime + runTime >= System.currentTimeMillis()){
            Robot.SUB_MANIPULATOR.spit();
        } else {
        	isFinished = true;
        }
    }

    protected boolean isFinished() { return isFinished; }

    protected void end() {
    	Robot.SUB_MANIPULATOR.stopSpinning();
    	isFinished = false;
    }

    protected void interrupted() {
        end();
    }
}


1			package org.usfirst.frc.team3695.robot.commands;
2
3			import edu.wpi.first.wpilibj.command.Command;
4			import org.usfirst.frc.team3695.robot.Robot;
5
6			public class CyborgCommandSpit extends Command {
7
8			Boolean isFinished;
			0 ignored issues – show Comprehensibility introduced 2018-03-04 21:20 UTC by Report Bug Copy Issue Report Fields and methods should not have conflicting names like `isFinished`. While this is technically legal it can lead to misunderstandings and problems with serialization. Loading history...
9			long runTime;
10			long startTime;
11
12			public CyborgCommandSpit(long runTime) {
13			isFinished = false;
14			requires(Robot.SUB_MANIPULATOR);
15			this.runTime = runTime;
16			}
17
18			protected void initialize() {
19			startTime = System.currentTimeMillis();
20			}
21
22			protected void execute() {
23			if (startTime + runTime >= System.currentTimeMillis()){
24			Robot.SUB_MANIPULATOR.spit();
25			} else {
26			isFinished = true;
27			}
28			}
29
30			protected boolean isFinished() { return isFinished; }
31
32			protected void end() {
33			Robot.SUB_MANIPULATOR.stopSpinning();
34			isFinished = false;
35			}
36
37			protected void interrupted() {
38			end();
39			}
40			}
41

wh1ter0se / PowerUp-2018

initialize() A last analyzed 2018-03-21 15:27 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

initialize() A
last analyzed 2018-03-21 15:27 UTC