Issues in HomePageBlock.php (master) - Issues in master - wernerkrauss/silverstripe-homepage - Measure and Improve Code Quality continuously with Scrutinizer

Issues (24)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/model/HomePageBlock.php (18 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Created by IntelliJ IDEA.
 * User: Werner M. Krauß <[email protected]>
 * Date: 28.10.2015
 * Time: 12:02
 */

/**
 * StartGeneratedWithDataObjectAnnotator
 * @property string Title
 * @property string Content
 * @property string LinkText
 * @property string ExternalLinkURL
 * @property boolean IsActive
 * @property int SortOrder
 * @property int HomePageID
 * @property int LinkToPageID
 * @method HomePage HomePage
 * @method Page LinkToPage
 * EndGeneratedWithDataObjectAnnotator
 */
class HomePageBlock extends DataObject
namespace YourVendor;

class YourClass { }
{

    private static $db = [

        'Title' => 'Varchar(64)',
        'Content' => 'HTMLText',
        'LinkText' => 'Varchar(64)',
        'ExternalLinkURL' => 'Varchar(255)',
        'IsActive' => 'Boolean',
        'SortOrder' => 'Int'
    ];

    private static $has_one = [

        'HomePage' => 'HomePage',
        'LinkToPage' => 'Page'
    ];

    private static $singular_name = 'Home page block';


    private static $plural_name = 'Home page blocks';


    private static $summary_fields = [

        'Title', 'IsActive'
    ];

    private static $default_sort = 'SortOrder';


    /**
     * for configuring fluent
     * @var array
     */
    private static $translate = [

        'Title',
        'Content',
        'LinkText',
        'ExternalLinkURL'
    ];

    public function getCMSFields()

    {
        $fields = parent::getCMSFields();

        $linkTo = $fields->dataFieldByName('LinkToPageID')->setEmptyString('-- bitte auswählen --');

        $fields->removeByName(['SortOrder', 'HomePageID', 'LinkToPageID']);

        $fields->insertAfter('LinkText', $linkTo);

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }

    public function getLink()

    {
        $link = $this->LinkToPageID && $this->LinkToPage()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ? $this->LinkToPage()->Link()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            : $this->ExternalLinkURL;

        $this->extend('updateLink', $link);

        return $link;
    }
}


1			<?php
2			/**
3			* Created by IntelliJ IDEA.
4			* User: Werner M. Krauß <[email protected]>
5			* Date: 28.10.2015
6			* Time: 12:02
7			*/
8
9			/**
10			* StartGeneratedWithDataObjectAnnotator
11			* @property string Title
12			* @property string Content
13			* @property string LinkText
14			* @property string ExternalLinkURL
15			* @property boolean IsActive
16			* @property int SortOrder
17			* @property int HomePageID
18			* @property int LinkToPageID
19			* @method HomePage HomePage
20			* @method Page LinkToPage
21			* EndGeneratedWithDataObjectAnnotator
22			*/
23			class HomePageBlock extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
24			{
25
26			private static $db = [
			0 ignored issues – show Comprehensibility introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
27			'Title' => 'Varchar(64)',
28			'Content' => 'HTMLText',
29			'LinkText' => 'Varchar(64)',
30			'ExternalLinkURL' => 'Varchar(255)',
31			'IsActive' => 'Boolean',
32			'SortOrder' => 'Int'
33			];
34
35			private static $has_one = [
			0 ignored issues – show Comprehensibility introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
36			'HomePage' => 'HomePage',
37			'LinkToPage' => 'Page'
38			];
39
40			private static $singular_name = 'Home page block';
			0 ignored issues – show Comprehensibility introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
41
42			private static $plural_name = 'Home page blocks';
			0 ignored issues – show Comprehensibility introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
43
44			private static $summary_fields = [
			0 ignored issues – show Comprehensibility introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
45			'Title', 'IsActive'
46			];
47
48			private static $default_sort = 'SortOrder';
			0 ignored issues – show Comprehensibility introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
49
50			/**
51			* for configuring fluent
52			* @var array
53			*/
54			private static $translate = [
			0 ignored issues – show Unused Code introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$translate` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
55			'Title',
56			'Content',
57			'LinkText',
58			'ExternalLinkURL'
59			];
60
61			public function getCMSFields()
			0 ignored issues – show Documentation introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
62			{
63			$fields = parent::getCMSFields();
64
65			$linkTo = $fields->dataFieldByName('LinkToPageID')->setEmptyString('-- bitte auswählen --');
66
67			$fields->removeByName(['SortOrder', 'HomePageID', 'LinkToPageID']);
68
69			$fields->insertAfter('LinkText', $linkTo);
70
71			$this->extend('updateCMSFields', $fields);
72
73			return $fields;
74			}
75
76			public function getLink()
			0 ignored issues – show Documentation introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
77			{
78			$link = $this->LinkToPageID && $this->LinkToPage()
			0 ignored issues – show Documentation Bug introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `LinkToPage` does not exist on `object<HomePageBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
79			? $this->LinkToPage()->Link()
			0 ignored issues – show Documentation Bug introduced 2016-03-23 17:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `LinkToPage` does not exist on `object<HomePageBlock>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
80			: $this->ExternalLinkURL;
81
82			$this->extend('updateLink', $link);
83
84			return $link;
85			}
86			}
87

wernerkrauss / silverstripe-homepage

Issues (24)

Security Analysis no request data

code/model/HomePageBlock.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like