HomePageBlock

Complexity

Total Complexity

4

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	14	1
A	getLink()	0	10	3

<?php
/**
 * Created by IntelliJ IDEA.
 * User: Werner M. Krauß <werner.krauss@netwerkstatt.at>
 * Date: 28.10.2015
 * Time: 12:02
 */

/**
 * StartGeneratedWithDataObjectAnnotator
 * @property string Title
 * @property string Content
 * @property string LinkText
 * @property string ExternalLinkURL
 * @property boolean IsActive
 * @property int SortOrder
 * @property int HomePageID
 * @property int LinkToPageID
 * @method HomePage HomePage
 * @method Page LinkToPage
 * EndGeneratedWithDataObjectAnnotator
 */
class HomePageBlock extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $db = [

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'Title' => 'Varchar(64)',
        'Content' => 'HTMLText',
        'LinkText' => 'Varchar(64)',
        'ExternalLinkURL' => 'Varchar(255)',
        'IsActive' => 'Boolean',
        'SortOrder' => 'Int'
    ];

    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'HomePage' => 'HomePage',
        'LinkToPage' => 'Page'
    ];

    private static $singular_name = 'Home page block';

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    private static $plural_name = 'Home page blocks';

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    private static $summary_fields = [

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'Title', 'IsActive'
    ];

    private static $default_sort = 'SortOrder';

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

    /**
     * for configuring fluent
     * @var array
     */
    private static $translate = [

The property $translate is not used and could be removed.

        'Title',
        'Content',
        'LinkText',
        'ExternalLinkURL'
    ];

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();

        $linkTo = $fields->dataFieldByName('LinkToPageID')->setEmptyString('-- bitte auswählen --');

        $fields->removeByName(['SortOrder', 'HomePageID', 'LinkToPageID']);

        $fields->insertAfter('LinkText', $linkTo);

        $this->extend('updateCMSFields', $fields);

        return $fields;
    }

    public function getLink()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $link = $this->LinkToPageID && $this->LinkToPage()

The method LinkToPage does not exist on object<HomePageBlock>? Since you implemented __call, maybe consider adding a @method annotation.

            ? $this->LinkToPage()->Link()

The method LinkToPage does not exist on object<HomePageBlock>? Since you implemented __call, maybe consider adding a @method annotation.

            : $this->ExternalLinkURL;

        $this->extend('updateLink', $link);

        return $link;
    }
}