WebServCo\Api\AbstractResponse::processResponseData()

Complexity

Conditions	7
Paths	7

Size

Total Lines	29
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function processResponseData()
    {
        $responseContent = $this->response->getContent();
        $contentType = $this->response->getHeader('Content-Type');
        $parts = explode(';', $contentType);

It seems like $contentType can also be of type false; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

        switch ($parts[0]) {
            case 'application/json':
            case 'text/json':
                return json_decode($responseContent, true);
                break;

break is not strictly necessary here and could be removed.

            case 'application/x-www-form-urlencoded':
                if (false === strpos($responseContent, '=')) {
                    /* Sometimes Discogs returns text/plain with this content type ... */
                    return $responseContent;
                }
                $data = [];
                parse_str($responseContent, $data);
                return $data;
                break;
            case 'text/plain':
            case 'text/html':
                return $responseContent;
                break;
            default:
                throw new \WebServCo\Api\Exceptions\ApiException(
                    sprintf('Api returned unsupported content type: %s.', $contentType)

It seems like $contentType can also be of type false; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

                );
                break;
        }