WebServCo\Api\AbstractResponse

Complexity

Total Complexity

12

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getStatus()	0	3	1
A	getMethod()	0	3	1
B	processResponseData()	0	29	7
A	getEndpoint()	0	3	1
A	__construct()	0	7	1
A	getData()	0	3	1

<?php
namespace WebServCo\Api;

abstract class AbstractResponse
{
    protected $endpoint;
    protected $data;
    protected $method;
    protected $response; // \WebServCo\Framework\Http\Response
    protected $status;

    public function __construct($endpoint, $method, \WebServCo\Framework\Http\Response $response)
    {
        $this->endpoint = $endpoint;
        $this->method = $method;
        $this->response = $response;
        $this->status = $this->response->getStatus();
        $this->data = $this->processResponseData();
    }

    public function getData()
    {
        return $this->data;
    }

    public function getEndpoint()
    {
        return $this->endpoint;
    }

    public function getMethod()
    {
        return $this->method;
    }

    public function getStatus()
    {
        return $this->status;
    }

    protected function processResponseData()
    {
        $responseContent = $this->response->getContent();
        $contentType = $this->response->getHeader('Content-Type');
        $parts = explode(';', $contentType);

It seems like $contentType can also be of type false; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

        switch ($parts[0]) {
            case 'application/json':
            case 'text/json':
                return json_decode($responseContent, true);
                break;

break is not strictly necessary here and could be removed.

            case 'application/x-www-form-urlencoded':
                if (false === strpos($responseContent, '=')) {
                    /* Sometimes Discogs returns text/plain with this content type ... */
                    return $responseContent;
                }
                $data = [];
                parse_str($responseContent, $data);
                return $data;
                break;
            case 'text/plain':
            case 'text/html':
                return $responseContent;
                break;
            default:
                throw new \WebServCo\Api\Exceptions\ApiException(
                    sprintf('Api returned unsupported content type: %s.', $contentType)

It seems like $contentType can also be of type false; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

                );
                break;
        }
    }
}