webonyx / graphql-php

Failed Conditions

Pull Request — master (#314)

by Jakub

created 2018-07-28 11:25 UTC

Changes

3 failure conditions met `project.metric_change("scrutinizer.test_coverage", < 0)` `issues.severity(>= MAJOR).new.exists` File Path Number of issues tests/Executor/OldExecutorTest.php 4 tests/Executor/ExecutorTest.php 2 src/Executor/ExecutionStrand.php 1 `elements.rating(<= C).new.exists` Name GraphQL\Executor\Collector Collector::doCollectFields() Executor\Collector::initialize() CollectorTest.php$0 ➔ testCollectFields() GraphQL\Executor\OldExecutor OldExecutor::completeValue() OldExecutor::buildExecutionContext() OldExecutor::collectFields() OldExecutor::defaultTypeResolver() GraphQL\Executor\Execution::run() more ...
	32 issues (7 major, 25 minor) were introduced. 4 issues were fixed.
	Test Coverage has decreased to 89% (-3%).
	95 added classes/operations
		F	OldExecutor added
		D	Collector added
		D	Collector::doCollectFields() added
		F	OldExecutor::buildExecutionContext() added
		F	Execution::run() added
		F	Execution::finishValue() added
		C	Collector::initialize() added
		C	CollectorTest.php$0 ➔ testCollectFields() added
		C	OldExecutor::completeValue() added
		C	OldExecutor::collectFields() added
F	↗	A	Executor improved
C	↗	A	Values::getArgumentValues() improved
A	↘	B	Executor::doExecute() got worse
view all

7.22

▶ ± 0

Test Coverage

89%

▼ -3% – Changes