webmarketingroi / optimizely-php

lib/WebMarketingROI/OptimizelyPHP/Exception.php

Doc Comments -2 removed lines

@@ -82,7 +82,6 @@ 
             
     /**
      * Set HTTP response code.
-     * @param integer $code
      */
     public function setHttpCode($httpCode)
     {
@@ -100,7 +99,6 @@ 
             
     /**
      * Set message
-     * @param string $message
      */
     public function setUuid($uuid)
     {

Braces +15 added lines, -10 removed lines

@@ -55,20 +55,25 @@
     {
         parent::__construct($message, $code);
         
-        if (isset($options['http_code']))
-            $this->setHttpCode($options['http_code']);
+        if (isset($options['http_code'])) {
+                    $this->setHttpCode($options['http_code']);
+        }
                 
-        if (isset($options['uuid']))
-            $this->setUuid($options['uuid']);
+        if (isset($options['uuid'])) {
+                    $this->setUuid($options['uuid']);
+        }
         
-        if (isset($options['rate_limit']))
-            $this->setRateLimit($options['rate_limit']);
+        if (isset($options['rate_limit'])) {
+                    $this->setRateLimit($options['rate_limit']);
+        }
         
-        if (isset($options['rate_limit_remaining']))
-            $this->setRateLimitRemaining($options['rate_limit_remaining']);
+        if (isset($options['rate_limit_remaining'])) {
+                    $this->setRateLimitRemaining($options['rate_limit_remaining']);
+        }
         
-        if (isset($options['rate_limit_reset']))
-            $this->setRateLimitReset($options['rate_limit_reset']);
+        if (isset($options['rate_limit_reset'])) {
+                    $this->setRateLimitReset($options['rate_limit_reset']);
+        }
     }
     
     /**

lib/WebMarketingROI/OptimizelyPHP/OptimizelyApiClient.php

Doc Comments +2 added lines, -2 removed lines

@@ -163,7 +163,7 @@ 
      * @param array $queryParams The list of query parameters.
      * @param string $method HTTP method (GET or POST).
      * @param array $postData Data send in request body (only for POST method).
-     * @return array Optimizely response in form of array.
+     * @return Result Optimizely response in form of array.
      * @throws Exception
      */
     public function sendApiRequest($url, $queryParams = array(), $method='GET', 
@@ -188,7 +188,7 @@ 
      * @param array $queryParams The list of query parameters.
      * @param string $method HTTP method (GET or POST).
      * @param array $postData Data send in request body (only for POST method).
-     * @return array Optimizely response in form of array.
+     * @return Result Optimizely response in form of array.
      * @throws Exception
      */
     private function sendHttpRequest($url, $queryParams = array(), $method='GET', 

Spacing +40 added lines, -40 removed lines

@@ -50,13 +50,13 @@ 
      * @param array $authCredentials Auth credentials.
      * @param string $apiVersion Optional. Currently supported 'v2' only.     
      */
-    public function __construct($authCredentials, $apiVersion='v2')
+    public function __construct($authCredentials, $apiVersion = 'v2')
     {
         if (!is_array($authCredentials)) {
             throw new Exception('Auth credentials must be an array');            
         }
         
-        if ($apiVersion!='v2') {
+        if ($apiVersion != 'v2') {
             throw new Exception('Invalid API version passed');
         }
         
@@ -85,7 +85,7 @@ 
      */
     public function setApiVersion($apiVersion)
     {
-        if ($apiVersion!='v2') {
+        if ($apiVersion != 'v2') {
             throw new Exception('Invalid API version passed');
         }
         
@@ -107,7 +107,7 @@ 
      */
     public function setAuthCredentials($authCredentials)
     {
-        if (!is_array($authCredentials) || count($authCredentials)==0) {
+        if (!is_array($authCredentials) || count($authCredentials) == 0) {
             throw new Exception('Auth credentials must be an array');            
         }
         
@@ -166,16 +166,16 @@ 
      * @return array Optimizely response in form of array.
      * @throws Exception
      */
-    public function sendApiRequest($url, $queryParams = array(), $method='GET', 
+    public function sendApiRequest($url, $queryParams = array(), $method = 'GET', 
             $postData = array())
     {
         // If access token has expired, try to get another one with refresh token.
-        if ($this->isAccessTokenExpired() && $this->getRefreshToken()!=null) {
+        if ($this->isAccessTokenExpired() && $this->getRefreshToken() != null) {
             $this->getAccessTokenByRefreshToken();
         }
         
         // Produce absolute URL
-        $url = 'https://api.optimizely.com/' . $this->apiVersion . $url;
+        $url = 'https://api.optimizely.com/'.$this->apiVersion.$url;
         
         $result = $this->sendHttpRequest($url, $queryParams, $method, $postData);
         
@@ -191,7 +191,7 @@ 
      * @return array Optimizely response in form of array.
      * @throws Exception
      */
-    private function sendHttpRequest($url, $queryParams = array(), $method='GET', 
+    private function sendHttpRequest($url, $queryParams = array(), $method = 'GET', 
             $postData = array())
     {
         // Reset diagnostics info.
@@ -199,41 +199,41 @@ 
         
         // Check if CURL is initialized (it should have been initialized in 
         // constructor).
-        if ($this->curlHandle==false) {
+        if ($this->curlHandle == false) {
             throw new Exception('CURL is not initialized', 
                     Exception::CODE_CURL_ERROR);
         }
         
-        if ($method!='GET' && $method!='POST' && $method!='PUT' && 
-            $method!='PATCH' && $method!='DELETE') {
-            throw new Exception('Invalid HTTP method passed: ' . $method);
+        if ($method != 'GET' && $method != 'POST' && $method != 'PUT' && 
+            $method != 'PATCH' && $method != 'DELETE') {
+            throw new Exception('Invalid HTTP method passed: '.$method);
         }
         
         if (!isset($this->authCredentials['access_token'])) {
-            throw new Exception('OAuth access token is not set. You should pass ' . 
+            throw new Exception('OAuth access token is not set. You should pass '. 
                     'it to the class constructor when initializing the Optimizely client.');
         }
                 
         // Append query parameters to URL.
-        if (count($queryParams)!=0) {            
+        if (count($queryParams) != 0) {            
             $query = http_build_query($queryParams);
-            $url .= '?' . $query;
+            $url .= '?'.$query;
         }
         
         $headers = array(
-            "Authorization: Bearer " . $this->authCredentials['access_token'],
+            "Authorization: Bearer ".$this->authCredentials['access_token'],
             "Content-Type: application/json"
             );
         $content = '';
-        if (count($postData)!=0) {
+        if (count($postData) != 0) {
             $content = json_encode($postData);            
         }
-        $headers[] = "Content-length:" . strlen($content);            
+        $headers[] = "Content-length:".strlen($content);            
         
         // Set HTTP options.
         curl_setopt($this->curlHandle, CURLOPT_URL, $url);
         curl_setopt($this->curlHandle, CURLOPT_CUSTOMREQUEST, $method);        
-        if (count($postData)!=0) {
+        if (count($postData) != 0) {
             curl_setopt($this->curlHandle, CURLOPT_POSTFIELDS, $content);            
         }
         curl_setopt($this->curlHandle, CURLOPT_RETURNTRANSFER, true);
@@ -251,7 +251,7 @@ 
         if ($result === false) {
             $code = curl_errno($this->curlHandle);
             $error = curl_error($this->curlHandle);
-            throw new Exception("Failed to send HTTP request $method '$url', " . 
+            throw new Exception("Failed to send HTTP request $method '$url', ". 
                     "the error code was $code, error message was: '$error'", 
                     Exception::CODE_CURL_ERROR, $code, $error);
         }        
@@ -265,12 +265,12 @@ 
         $headers = explode("\n", $headers);
         $parsedHeaders = array();
         foreach ($headers as $i=>$header) {
-            if ($i==0)
+            if ($i == 0)
                 continue; // Skip first line (http code).
             $pos = strpos($header, ':');
-            if ($pos!=false) {
+            if ($pos != false) {
                 $headerName = trim(strtolower(substr($header, 0, $pos)));
-                $headerValue = trim(substr($header, $pos+1));
+                $headerValue = trim(substr($header, $pos + 1));
                 $parsedHeaders[$headerName] = $headerValue;
             }
         }
@@ -302,21 +302,21 @@ 
         
         // JSON-decode payload.
         $decodedPayload = json_decode($body, true);
-        if ($decodedPayload===false) {
-            throw new Exception('Could not JSON-decode the Optimizely API response. Request was ' . 
-                    $method . ' "' . $url . '". The response was: "' . $body . '"',
+        if ($decodedPayload === false) {
+            throw new Exception('Could not JSON-decode the Optimizely API response. Request was '. 
+                    $method.' "'.$url.'". The response was: "'.$body.'"',
                     Exception::CODE_API_ERROR, array('http_code'=>$httpCode));
         }
         
         // Check HTTP response code.
-        if ($httpCode<200 || $httpCode>299) {
+        if ($httpCode < 200 || $httpCode > 299) {
             
             if (!isset($decodedPayload['message']) || 
                 !isset($decodedPayload['code']) ||
                 !isset($decodedPayload['uuid']) ||
                 $httpCode != !isset($decodedPayload['code'])) {
-                throw new Exception('Optimizely API responded with error code ' . $httpCode . 
-                    ', but response format was unexpected. Request was ' . $method . ' "' . $url . '". Response was "' . $body . '"',
+                throw new Exception('Optimizely API responded with error code '.$httpCode. 
+                    ', but response format was unexpected. Request was '.$method.' "'.$url.'". Response was "'.$body.'"',
                     Exception::CODE_API_ERROR, array(
                         'http_code' => $httpCode,
                         'rate_limit' => $rateLimit,
@@ -348,7 +348,7 @@ 
             $matched = preg_match_all('/<(.+)>;\s+rel=(\w+)(,|\z)/U', 
                     $parsedHeaders['link'], $matches, PREG_SET_ORDER);
             if (!$matched) {
-                throw new Exception('Error parsing LINK header: ' . 
+                throw new Exception('Error parsing LINK header: '. 
                         $parsedHeaders['link'], Exception::CODE_API_ERROR, $httpCode);
             }
             
@@ -358,22 +358,22 @@ 
                 $rel = $match[2];
                 
                 $matched = preg_match('/page=(\d+)/U', $url, $pageMatches);
-                if (!$matched || count($pageMatches)!=2) {
-                    throw new Exception('Error extracting page argument while parsing LINK header: ' . 
+                if (!$matched || count($pageMatches) != 2) {
+                    throw new Exception('Error extracting page argument while parsing LINK header: '. 
                             $parsedHeaders['link'], Exception::CODE_API_ERROR, 
                             array('http_code'=>$httpCode));
                 }
                 
                 $pageNumber = $pageMatches[1];
                 
-                if ($rel=='prev') {
+                if ($rel == 'prev') {
                     $result->setPrevPage($pageNumber);
-                } else if ($rel=='next') {
+                } else if ($rel == 'next') {
                     $result->setNextPage($pageNumber);
-                } else if ($rel=='last') {
+                } else if ($rel == 'last') {
                     $result->setLastPage($pageNumber);
                 } else {
-                    throw new Exception('Unexpected rel argument while parsing LINK header: ' . 
+                    throw new Exception('Unexpected rel argument while parsing LINK header: '. 
                             $parsedHeaders['link'], Exception::CODE_API_ERROR, 
                             array('http_code'=>$httpCode));
                 }
@@ -391,7 +391,7 @@ 
      */
     private function isAccessTokenExpired() 
     {
-        if(!isset($this->authCredentials['access_token'])) {
+        if (!isset($this->authCredentials['access_token'])) {
             return true; // We do not have access token.
         }
         
@@ -432,15 +432,15 @@ 
         $clientSecret = $this->authCredentials['client_secret'];
         $refreshToken = $this->authCredentials['refresh_token'];
         
-        $url = "https://app.optimizely.com/oauth2/token?refresh_token=$refreshToken" . 
+        $url = "https://app.optimizely.com/oauth2/token?refresh_token=$refreshToken". 
                 "&client_id=$clientId&client_secret=$clientSecret&grant_type=refresh_token";
         
         $response = $this->sendHttpRequest($url, array(), 'POST');
         $decodedJsonData = $response->getDecodedJsonData();
         
         if (!isset($decodedJsonData['access_token'])) {
-            throw new Exception('Not found access token in response. Request URL was "' . 
-                    $url. '". Response was "' . print_r(json_encode($decodedJsonData), true). '"',
+            throw new Exception('Not found access token in response. Request URL was "'. 
+                    $url.'". Response was "'.print_r(json_encode($decodedJsonData), true).'"',
                     Exception::CODE_API_ERROR, $response->getHttpCode());
         }
         

Braces +13 added lines, -8 removed lines

@@ -265,8 +265,10 @@ 
         $headers = explode("\n", $headers);
         $parsedHeaders = array();
         foreach ($headers as $i=>$header) {
-            if ($i==0)
-                continue; // Skip first line (http code).
+            if ($i==0) {
+                            continue;
+            }
+            // Skip first line (http code).
             $pos = strpos($header, ':');
             if ($pos!=false) {
                 $headerName = trim(strtolower(substr($header, 0, $pos)));
@@ -419,14 +421,17 @@ 
      */
     private function getAccessTokenByRefreshToken()
     {
-        if (!isset($this->authCredentials['client_id']))
-            throw new Exception('OAuth 2.0 client ID is not set');
+        if (!isset($this->authCredentials['client_id'])) {
+                    throw new Exception('OAuth 2.0 client ID is not set');
+        }
         
-        if (!isset($this->authCredentials['client_secret']))
-            throw new Exception('OAuth 2.0 client secret is not set');
+        if (!isset($this->authCredentials['client_secret'])) {
+                    throw new Exception('OAuth 2.0 client secret is not set');
+        }
         
-        if (!isset($this->authCredentials['refresh_token']))
-            throw new Exception('Refresh token is not set');
+        if (!isset($this->authCredentials['refresh_token'])) {
+                    throw new Exception('Refresh token is not set');
+        }
         
         $clientId = $this->authCredentials['client_id'];
         $clientSecret = $this->authCredentials['client_secret'];

lib/WebMarketingROI/OptimizelyPHP/Result.php

Doc Comments -3 removed lines

@@ -70,8 +70,6 @@ 
     /**
      * Constructor.
      * @param array $decodedJsonData
-     * @param string $rawHttpResponseData
-     * @param array[string] $rawHttpResponseHeaders
      */
     public function __construct($decodedJsonData, $httpCode)
     {
@@ -90,7 +88,6 @@ 
             
     /**
      * Set HTTP response code.
-     * @param integer $code
      */
     public function setHttpCode($httpCode)
     {

tests/OptimizelyPHPTest/Service/v2/ExperimentsTest.php

Indentation +179 added lines, -179 removed lines

@@ -23,20 +23,20 @@ 
                         array(
                             "project_id" => 1000,
                             "audience_ids" => array(
-                              1234,
-                              1212,
-                              1432
+                                1234,
+                                1212,
+                                1432
                             ),
                             "campaign_id" => 2000,
                             "changes" => array(
-                              array(
+                                array(
                                 "type" => "custom_code",
                                 "allow_additional_redirect" => true,
                                 "async" => true,
                                 "css_selector" => "a[href*=\"optimizely\"]",
                                 "dependencies" => array(
-                                  24,
-                                  26
+                                    24,
+                                    26
                                 ),
                                 "destination" => "https://app.optimizely.com/",
                                 "extension_id" => 1234,
@@ -44,37 +44,37 @@ 
                                 "src" => 524,
                                 "value" => "window.someGlobalFunction();",
                                 "id" => "string"
-                              )
+                                )
                             ),
                             "description" => "string",
                             "holdback" => 5000,
                             "key" => "home_page_experiment",
                             "metrics" => array(
-                              array(
+                                array(
                                 "kind" => "string",
                                 "id" => 0
-                              )
+                                )
                             ),
                             "name" => "Blue Button Experiment",
                             "schedule" => array(
-                              "start_time" => "2016-10-17T07:05:00.070Z",
-                              "stop_time" => "2016-10-17T07:05:00.070Z",
-                              "time_zone" => "UTC"
+                                "start_time" => "2016-10-17T07:05:00.070Z",
+                                "stop_time" => "2016-10-17T07:05:00.070Z",
+                                "time_zone" => "UTC"
                             ),
                             "status" => "active",
                             "variations" => array(
-                              array(
+                                array(
                                 "actions" => array(
-                                  array(
+                                    array(
                                     "changes" => array(
-                                      array(
+                                        array(
                                         "type" => "custom_code",
                                         "allow_additional_redirect" => true, 
                                         "async" => true,
                                         "css_selector" => "a[href*=\"optimizely\"]",
                                         "dependencies" => array(
-                                          24,
-                                          26
+                                            24,
+                                            26
                                         ),
                                         "destination" => "https://app.optimizely.com/",
                                         "extension_id" => 1234,
@@ -82,23 +82,23 @@ 
                                         "src" => 524,
                                         "value" => "window.someGlobalFunction();",
                                         "id" => "string"
-                                      )
+                                        )
                                     ),
                                     "page_id" => 0
-                                  )
+                                    )
                                 ),
                                 "archived"=> true,
                                 "key" => "blue_button_variation",
                                 "name" => "Blue Button",
                                 "variation_id" => 0,
                                 "weight" => 0
-                              )
+                                )
                             ),
                             "created" => "2016-10-17T07:05:00.070Z",
                             "id" => 3000,
                             "is_classic" => false,
                             "last_modified" => "2016-10-17T07:05:00.070Z"
-                          )
+                            )
                         ), 200);
         
         $optimizelyApiClientMock->method('sendApiRequest')
@@ -124,20 +124,20 @@ 
         $result = new Result(array(
                             "project_id" => 1000,
                             "audience_ids" => array(
-                              1234,
-                              1212,
-                              1432
+                                1234,
+                                1212,
+                                1432
                             ),
                             "campaign_id" => 2000,
                             "changes" => array(
-                              array(
+                                array(
                                 "type" => "custom_code",
                                 "allow_additional_redirect" => true,
                                 "async" => true,
                                 "css_selector" => "a[href*=\"optimizely\"]",
                                 "dependencies" => array(
-                                  24,
-                                  26
+                                    24,
+                                    26
                                 ),
                                 "destination" => "https://app.optimizely.com/",
                                 "extension_id" => 1234,
@@ -145,37 +145,37 @@ 
                                 "src" => 524,
                                 "value" => "window.someGlobalFunction();",
                                 "id" => "string"
-                              )
+                                )
                             ),
                             "description" => "string",
                             "holdback" => 5000,
                             "key" => "home_page_experiment",
                             "metrics" => array(
-                              array(
+                                array(
                                 "kind" => "string",
                                 "id" => 0
-                              )
+                                )
                             ),
                             "name" => "Blue Button Experiment",
                             "schedule" => array(
-                              "start_time" => "2016-10-17T07:05:00.070Z",
-                              "stop_time" => "2016-10-17T07:05:00.070Z",
-                              "time_zone" => "UTC"
+                                "start_time" => "2016-10-17T07:05:00.070Z",
+                                "stop_time" => "2016-10-17T07:05:00.070Z",
+                                "time_zone" => "UTC"
                             ),
                             "status" => "active",
                             "variations" => array(
-                              array(
+                                array(
                                 "actions" => array(
-                                  array(
+                                    array(
                                     "changes" => array(
-                                      array(
+                                        array(
                                         "type" => "custom_code",
                                         "allow_additional_redirect" => true, 
                                         "async" => true,
                                         "css_selector" => "a[href*=\"optimizely\"]",
                                         "dependencies" => array(
-                                          24,
-                                          26
+                                            24,
+                                            26
                                         ),
                                         "destination" => "https://app.optimizely.com/",
                                         "extension_id" => 1234,
@@ -183,23 +183,23 @@ 
                                         "src" => 524,
                                         "value" => "window.someGlobalFunction();",
                                         "id" => "string"
-                                      )
+                                        )
                                     ),
                                     "page_id" => 0
-                                  )
+                                    )
                                 ),
                                 "archived"=> true,
                                 "key" => "blue_button_variation",
                                 "name" => "Blue Button",
                                 "variation_id" => 0,
                                 "weight" => 0
-                              )
+                                )
                             ),
                             "created" => "2016-10-17T07:05:00.070Z",
                             "id" => 3000,
                             "is_classic" => false,
                             "last_modified" => "2016-10-17T07:05:00.070Z"
-                          ), 200);
+                            ), 200);
         
         $optimizelyApiClientMock->method('sendApiRequest')
                     ->willReturn($result);
@@ -225,7 +225,7 @@ 
                             "end_time" => "2016-10-17T07:05:00.089Z",
                             "experiment_id" => 3000,
                             "metrics" => array(
-                              array(
+                                array(
                                 "event" => "string",
                                 "event_name" => "string",
                                 "measure" => "conversions",
@@ -233,54 +233,54 @@ 
                                 "priority" => 1,
                                 "unit" => "session",
                                 "variation_results" => array(
-                                  "9000" => array(
+                                    "9000" => array(
                                     "experiment_id" => 0,
                                     "is_baseline" => true,
                                     "lift" => array(
-                                      "confidence_interval" => array(
+                                        "confidence_interval" => array(
                                         0.010399560300730457,
                                         0.0850821459929161
-                                      ),
-                                      "is_most_conclusive" => true,
-                                      "is_significant" => true,
-                                      "significance" => 0,
-                                      "value" => 0,
-                                      "visitors_remaining" => 0
+                                        ),
+                                        "is_most_conclusive" => true,
+                                        "is_significant" => true,
+                                        "significance" => 0,
+                                        "value" => 0,
+                                        "visitors_remaining" => 0
                                     ),
                                     "name" => "Blue Button",
                                     "rate" => 0,
                                     "scope" => "variation",
                                     "total_increase" => array(
-                                      "confidence_interval" => array(
+                                        "confidence_interval" => array(
                                         0.010399560300730457,
                                         0.0850821459929161
-                                      ),
-                                      "is_most_conclusive" => true,
-                                      "is_significant" => true,
-                                      "significance" => 0,
-                                      "value" => 0,
-                                      "visitors_remaining" => 0
+                                        ),
+                                        "is_most_conclusive" => true,
+                                        "is_significant" => true,
+                                        "significance" => 0,
+                                        "value" => 0,
+                                        "visitors_remaining" => 0
                                     ),
                                     "value" => 0,
                                     "variation_id" => "string"
-                                  )
+                                    )
+                                )
                                 )
-                              )
                             ),
                             "reach" => array(
-                              "baseline_count" => 0,
-                              "baseline_reach" => 0,
-                              "total_count" => 0,
-                              "treatment_count" => 0,
-                              "treatment_reach" => 0,
-                              "variations" => array(
+                                "baseline_count" => 0,
+                                "baseline_reach" => 0,
+                                "total_count" => 0,
+                                "treatment_count" => 0,
+                                "treatment_reach" => 0,
+                                "variations" => array(
                                 "9000" => array(
-                                  "count" => 0,
-                                  "name" => "Blue Button",
-                                  "variation_id" => "string",
-                                  "variation_reach" => 0
+                                    "count" => 0,
+                                    "name" => "Blue Button",
+                                    "variation_id" => "string",
+                                    "variation_reach" => 0
+                                )
                                 )
-                              )
                             ),
                             "start_time" => "2016-10-17T07:05:00.090Z"
                         ), 200);
@@ -307,20 +307,20 @@ 
         $result = new Result(array(
                             "project_id" => 1000,
                             "audience_ids" => array(
-                              1234,
-                              1212,
-                              1432
+                                1234,
+                                1212,
+                                1432
                             ),
                             "campaign_id" => 2000,
                             "changes" => array(
-                              array(
+                                array(
                                 "type" => "custom_code",
                                 "allow_additional_redirect" => true,
                                 "async" => true,
                                 "css_selector" => "a[href*=\"optimizely\"]",
                                 "dependencies" => array(
-                                  24,
-                                  26
+                                    24,
+                                    26
                                 ),
                                 "destination" => "https://app.optimizely.com/",
                                 "extension_id" => 1234,
@@ -328,37 +328,37 @@ 
                                 "src" => 524,
                                 "value" => "window.someGlobalFunction();",
                                 "id" => "string"
-                              )
+                                )
                             ),
                             "description" => "string",
                             "holdback" => 5000,
                             "key" => "home_page_experiment",
                             "metrics" => array(
-                              array(
+                                array(
                                 "kind" => "string",
                                 "id" => 0
-                              )
+                                )
                             ),
                             "name" => "Blue Button Experiment",
                             "schedule" => array(
-                              "start_time" => "2016-10-17T07:05:00.099Z",
-                              "stop_time" => "2016-10-17T07:05:00.099Z",
-                              "time_zone" => "UTC"
+                                "start_time" => "2016-10-17T07:05:00.099Z",
+                                "stop_time" => "2016-10-17T07:05:00.099Z",
+                                "time_zone" => "UTC"
                             ),
                             "status" => "active",
                             "variations" => array(
-                              array(
+                                array(
                                 "actions" => array(
-                                  array(
+                                    array(
                                     "changes" => array(
-                                      array(
+                                        array(
                                         "type" => "custom_code",
                                         "allow_additional_redirect" => true,
                                         "async" => true,
                                         "css_selector" => "a[href*=\"optimizely\"]",
                                         "dependencies" => array(
-                                          24,
-                                          26
+                                            24,
+                                            26
                                         ),
                                         "destination" => "https://app.optimizely.com/",
                                         "extension_id" => 1234,
@@ -366,17 +366,17 @@ 
                                         "src" => 524,
                                         "value" => "window.someGlobalFunction();",
                                         "id" => "string"
-                                      )
+                                        )
                                     ),
                                     "page_id" => 0
-                                  )
+                                    )
                                 ),
                                 "archived" => true,
                                 "key" => "blue_button_variation",
                                 "name" => "Blue Button",
                                 "variation_id" => 0,
                                 "weight" => 0
-                              )
+                                )
                             ),
                             "created" => "2016-10-17T07:05:00.099Z",
                             "id" => 3000,
@@ -392,73 +392,73 @@ 
         $experiment = new Experiment(array(
             "project_id" => 1000,
             "audience_ids" => array(
-              1234,
-              1212,
-              1432
+                1234,
+                1212,
+                1432
             ),
             "campaign_id" => 2000,
             "changes" => array(
-              array(
+                array(
                 "type" => "custom_code",
                 "allow_additional_redirect" => true,
                 "async" => true,
                 "css_selector" => "a[href*=\"optimizely\"]",
                 "dependencies" => array(
-                  24,
-                  26
+                    24,
+                    26
                 ),
                 "destination" => "https://app.optimizely.com/",
                 "extension_id" => 1234,
                 "preserve_parameters" => true,
                 "src" => 524,
                 "value" => "window.someGlobalFunction();"
-              )
+                )
             ),
             "description" => "string",
             "holdback" => 5000,
             "key" => "home_page_experiment",
             "metrics" => array(
-              array(
+                array(
                 "kind" => "string"
-              )
+                )
             ),
             "name" => "Blue Button Experiment",
             "schedule" => array(
-              "start_time" => "2016-10-17T07:04:59.724Z",
-              "stop_time" => "2016-10-17T07:04:59.724Z",
-              "time_zone" => "UTC"
+                "start_time" => "2016-10-17T07:04:59.724Z",
+                "stop_time" => "2016-10-17T07:04:59.724Z",
+                "time_zone" => "UTC"
             ),
             "status" => "active",
             "variations" => array(
-              array(
+                array(
                 "actions" => array(
-                  array(
+                    array(
                     "changes" => array(
-                      array(
+                        array(
                         "type" => "custom_code",
                         "allow_additional_redirect" => true,
                         "async" => true,
                         "css_selector" => "a[href*=\"optimizely\"]",
                         "dependencies" => array(
-                          24,
-                          26
+                            24,
+                            26
                         ),
                         "destination" => "https://app.optimizely.com/",
                         "extension_id" => 1234,
                         "preserve_parameters" => true,
                         "src" => 524,
                         "value" => "window.someGlobalFunction();"
-                      )
+                        )
                     ),
                     "page_id" => 0
-                  )
+                    )
                 ),
                 "archived" => true,
                 "key" => "blue_button_variation",
                 "name" => "Blue Button",
                 "variation_id" => 0,
                 "weight" => 0
-              )
+                )
             )
         ));
         
@@ -479,20 +479,20 @@ 
         $result = new Result(array(
                         "project_id" => 1000,
                         "audience_ids" => array(
-                          1234,
-                          1212,
-                          1432
+                            1234,
+                            1212,
+                            1432
                         ),
                         "campaign_id" => 2000,
                         "changes" => array(
-                          array(
+                            array(
                             "type" => "custom_code",
                             "allow_additional_redirect" => true,
                             "async" => true,
                             "css_selector" => "a[href*=\"optimizely\"]",
                             "dependencies" => array(
-                              24,
-                              26
+                                24,
+                                26
                             ),
                             "destination" => "https://app.optimizely.com/",
                             "extension_id" => 1234,
@@ -500,37 +500,37 @@ 
                             "src" => 524,
                             "value" => "window.someGlobalFunction();",
                             "id" => "string"
-                          )
+                            )
                         ),
                         "description" => "string",
                         "holdback" => 5000,
                         "key" => "home_page_experiment",
                         "metrics" => array(
-                          array(
+                            array(
                             "kind" => "string",
                             "id" => 0
-                          )
+                            )
                         ),
                         "name" => "Blue Button Experiment",
                         "schedule" => array(
-                          "start_time" => "2016-10-17T07:05:00.109Z",
-                          "stop_time" => "2016-10-17T07:05:00.109Z",
-                          "time_zone" => "UTC"
+                            "start_time" => "2016-10-17T07:05:00.109Z",
+                            "stop_time" => "2016-10-17T07:05:00.109Z",
+                            "time_zone" => "UTC"
                         ),
                         "status" => "active",
                         "variations" => array(
-                          array(
+                            array(
                             "actions" => array(
-                              array(
+                                array(
                                 "changes" => array(
-                                  array(
+                                    array(
                                     "type" => "custom_code",
                                     "allow_additional_redirect" => true,
                                     "async" => true,
                                     "css_selector" => "a[href*=\"optimizely\"]",
                                     "dependencies" => array(
-                                      24,
-                                      26
+                                        24,
+                                        26
                                     ),
                                     "destination" => "https://app.optimizely.com/",
                                     "extension_id" => 1234,
@@ -538,17 +538,17 @@ 
                                     "src" => 524,
                                     "value" => "window.someGlobalFunction();",
                                     "id" => "string"
-                                  )
+                                    )
                                 ),
                                 "page_id" => 0
-                              )
+                                )
                             ),
                             "archived" => true,
                             "key" => "blue_button_variation",
                             "name" => "Blue Button",
                             "variation_id" => 0,
                             "weight" => 0
-                          )
+                            )
                         ),
                         "created" => "2016-10-17T07:05:00.109Z",
                         "id" => 3000,
@@ -562,72 +562,72 @@ 
         $experimentsService = new Experiments($optimizelyApiClientMock);
         
         $experiment = new Experiment(array(
-              "audience_ids" => array(
+                "audience_ids" => array(
                 0
-              ),
-              "changes" => array(
+                ),
+                "changes" => array(
                 array(
-                  "type" => "custom_code",
-                  "allow_additional_redirect" => true,
-                  "async" => true,
-                  "css_selector" => "a[href*=\"optimizely\"]",
-                  "dependencies" => array(
+                    "type" => "custom_code",
+                    "allow_additional_redirect" => true,
+                    "async" => true,
+                    "css_selector" => "a[href*=\"optimizely\"]",
+                    "dependencies" => array(
                     24,
                     26
-                  ),
-                  "destination" => "https://app.optimizely.com/",
-                  "extension_id" => 1234,
-                  "preserve_parameters" => true,
-                  "src" => 524,
-                  "value" => "window.someGlobalFunction();"
+                    ),
+                    "destination" => "https://app.optimizely.com/",
+                    "extension_id" => 1234,
+                    "preserve_parameters" => true,
+                    "src" => 524,
+                    "value" => "window.someGlobalFunction();"
                 )
-              ),
-              "description" => "AB Test to see if the Blue Button converts more visitors",
-              "holdback" => 0,
-              "key" => "home_page_experiment",
-              "metrics" => array(
+                ),
+                "description" => "AB Test to see if the Blue Button converts more visitors",
+                "holdback" => 0,
+                "key" => "home_page_experiment",
+                "metrics" => array(
                 array(
-                  "kind" => "string"
+                    "kind" => "string"
                 )
-              ),
-              "name" => "Blue Button Experiment",
-              "schedule" => array(
+                ),
+                "name" => "Blue Button Experiment",
+                "schedule" => array(
                 "start_time" => "2016-10-17T07:04:59.731Z",
                 "stop_time" => "2016-10-17T07:04:59.731Z",
                 "time_zone" => "UTC"
-              ),
-              "status" => "active",
-              "variations" => array(
+                ),
+                "status" => "active",
+                "variations" => array(
                 array(
-                  "actions" => array(
+                    "actions" => array(
                     array(
-                      "changes" => array(
+                        "changes" => array(
                         array(
-                          "type" => "custom_code",
-                          "allow_additional_redirect" => true,
-                          "async" => true,
-                          "css_selector" => "a[href*=\"optimizely\"]",
-                          "dependencies" => array(
+                            "type" => "custom_code",
+                            "allow_additional_redirect" => true,
+                            "async" => true,
+                            "css_selector" => "a[href*=\"optimizely\"]",
+                            "dependencies" => array(
                             24,
                             26
-                          ),
-                          "destination" => "https://app.optimizely.com/",
-                          "extension_id" => 1234,
-                          "preserve_parameters" => true,
-                          "src" => 524,
-                          "value" => "window.someGlobalFunction();"
+                            ),
+                            "destination" => "https://app.optimizely.com/",
+                            "extension_id" => 1234,
+                            "preserve_parameters" => true,
+                            "src" => 524,
+                            "value" => "window.someGlobalFunction();"
                         )
-                      ),
-                      "page_id" => 0
+                        ),
+                        "page_id" => 0
                     )
-                  ),
-                  "archived" => true,
-                  "key" => "blue_button_variation",
-                  "name" => "Blue Button",
-                  "variation_id" => 0,
-                  "weight" => 0
+                    ),
+                    "archived" => true,
+                    "key" => "blue_button_variation",
+                    "name" => "Blue Button",
+                    "variation_id" => 0,
+                    "weight" => 0
+                )
                 )
-              )
         ));
         
         $result = $experimentsService->update(1000, $experiment, true, true);

tests/OptimizelyPHPTest/Service/v2/PagesTest.php

Spacing +4 added lines, -4 removed lines

@@ -42,9 +42,9 @@ 
         $result = $pagesService->listAll(1000);
         $pages = $result->getPayload();
         
-        $this->assertTrue(count($pages)==1);
+        $this->assertTrue(count($pages) == 1);
         $this->assertTrue($pages[0] instanceOf Page);
-        $this->assertTrue($pages[0]->getName()=='Home Page');        
+        $this->assertTrue($pages[0]->getName() == 'Home Page');        
     }
     
     public function testGet()
@@ -127,7 +127,7 @@ 
         $createdPage = $result->getPayload();
         
         $this->assertTrue($createdPage instanceOf Page);
-        $this->assertTrue($createdPage->getName()=='Home Page');                
+        $this->assertTrue($createdPage->getName() == 'Home Page');                
     }
     
     public function testUpdate()
@@ -175,7 +175,7 @@ 
         $updatedPage = $result->getPayload();
         
         $this->assertTrue($updatedPage instanceOf Page);
-        $this->assertTrue($updatedPage->getName()=='Home Page');                  
+        $this->assertTrue($updatedPage->getName() == 'Home Page');                  
     }
     
     public function testDelete()

tests/OptimizelyPHPTest/Service/v2/AudiencesTest.php

Spacing +5 added lines, -5 removed lines

@@ -49,9 +49,9 @@ 
         $result = $audiencesService->listAll(1000);
         $audiences = $result->getPayload();
         
-        $this->assertTrue(count($audiences)==1);
+        $this->assertTrue(count($audiences) == 1);
         $this->assertTrue($audiences[0] instanceOf Audience);
-        $this->assertTrue($audiences[0]->getName()=='Spanish speaking San Franciscans');        
+        $this->assertTrue($audiences[0]->getName() == 'Spanish speaking San Franciscans');        
     }
     
     public function testGet()
@@ -92,7 +92,7 @@ 
         $audience = $result->getPayload();
         
         $this->assertTrue($audience instanceOf Audience);
-        $this->assertTrue($audience->getName()=='Spanish speaking San Franciscans');        
+        $this->assertTrue($audience->getName() == 'Spanish speaking San Franciscans');        
     }
     
     public function testCreate()
@@ -152,7 +152,7 @@ 
         $createdAudience = $result->getPayload();
         
         $this->assertTrue($createdAudience instanceOf Audience);
-        $this->assertTrue($createdAudience->getName()=='Spanish speaking San Franciscans');                
+        $this->assertTrue($createdAudience->getName() == 'Spanish speaking San Franciscans');                
     }
     
     public function testUpdate()
@@ -212,7 +212,7 @@ 
         $createdAudience = $result->getPayload();
         
         $this->assertTrue($createdAudience instanceOf Audience);
-        $this->assertTrue($createdAudience->getName()=='Spanish speaking San Franciscans');                
+        $this->assertTrue($createdAudience->getName() == 'Spanish speaking San Franciscans');                
     }
 }
 

tests/OptimizelyPHPTest/Service/v2/ProjectsTest.php

Spacing +11 added lines, -11 removed lines

@@ -50,9 +50,9 @@ 
         $result = $projectsService->listAll();
         $projects = $result->getPayload();
         
-        $this->assertTrue(count($projects)==1);
+        $this->assertTrue(count($projects) == 1);
         $this->assertTrue($projects[0] instanceOf Project);
-        $this->assertTrue($projects[0]->getName()=='Some Optimizely Project');        
+        $this->assertTrue($projects[0]->getName() == 'Some Optimizely Project');        
     }
     
     public function testGet()
@@ -95,7 +95,7 @@ 
         $project = $result->getPayload();
         
         $this->assertTrue($project instanceOf Project);
-        $this->assertTrue($project->getName()=='Some Optimizely Project');        
+        $this->assertTrue($project->getName() == 'Some Optimizely Project');        
     }
     
     public function testCreate()
@@ -160,8 +160,8 @@ 
         $createdProject = $result->getPayload();
         
         $this->assertTrue($createdProject instanceOf Project);
-        $this->assertTrue($createdProject->getName()=='Test Project');        
-        $this->assertTrue($createdProject->getAccountId()==12345);        
+        $this->assertTrue($createdProject->getName() == 'Test Project');        
+        $this->assertTrue($createdProject->getAccountId() == 12345);        
     }
     
     public function testUpdate()
@@ -225,8 +225,8 @@ 
         $updatedProject = $result->getPayload();
         
         $this->assertTrue($updatedProject instanceOf Project);
-        $this->assertTrue($updatedProject->getName()=='Test Project');        
-        $this->assertTrue($updatedProject->getAccountId()==12345);        
+        $this->assertTrue($updatedProject->getName() == 'Test Project');        
+        $this->assertTrue($updatedProject->getAccountId() == 12345);        
     }
     
     public function testIntegration()
@@ -237,7 +237,7 @@ 
         $credentials = $this->loadCredentialsFromFile();
         
         $optimizelyClient = new OptimizelyApiClient($credentials, 'v2');
-        $this->assertTrue($optimizelyClient!=null);
+        $this->assertTrue($optimizelyClient != null);
         
         // Create new project
         $curDate = date('Y-m-d H:i:s');
@@ -277,17 +277,17 @@ 
             $projects = $result->getPayload();
 
             foreach ($projects as $project) {
-                if ($project->getName()=="Test Project $curDate") {
+                if ($project->getName() == "Test Project $curDate") {
                     $projectId = $project->getId();
                     $found = true;
                     break;
                 }
             }
 
-            if ($result->getNextPage()==null)
+            if ($result->getNextPage() == null)
                 break;
 
-            $page ++;
+            $page++;
         }
         
         $this->assertTrue($projectFound);

Braces +6 added lines, -4 removed lines

@@ -231,8 +231,9 @@ 
     
     public function testIntegration()
     {
-        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) 
-            $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        if (!getenv('OPTIMIZELY_PHP_TEST_INTEGRATION')) {
+                    $this->markTestSkipped('OPTIMIZELY_PHP_TEST_INTEGRATION env var is not set');
+        }
         
         $credentials = $this->loadCredentialsFromFile();
         
@@ -284,8 +285,9 @@ 
                 }
             }
 
-            if ($result->getNextPage()==null)
-                break;
+            if ($result->getNextPage()==null) {
+                            break;
+            }
 
             $page ++;
         }

examples/Projects/GetProjects.php

Spacing +13 added lines, -13 removed lines

@@ -16,10 +16,10 @@ 
 use WebMarketingROI\OptimizelyPHP\Exception;
 
 // Init class autloading.
-include dirname(__FILE__) . '/../../vendor/autoload.php';
+include dirname(__FILE__).'/../../vendor/autoload.php';
 
 // Include Utils.php - a file containing helper functions
-include dirname(__FILE__) . '/../Utils.php';
+include dirname(__FILE__).'/../Utils.php';
 
 // Get OAuth 2.0 credentials from auth_credentials.json and access_token.json files.
 $credentials = load_credentials_from_file();
@@ -42,24 +42,24 @@ 
         $projects = $result->getPayload();
         
         foreach ($projects as $project) {
-            echo "ID: " . $project->getId() . "\n";
-            echo "Name: " . $project->getName() . "\n";
-            echo "Account ID: " . $project->getAccountId() . "\n";
-            echo "Platform: " . $project->getPlatform() . "\n";
-            echo "Status: " . $project->getStatus() . "\n";
-            echo "Is Classic: " . ($project->getIsClassic()?"true":"false") . "\n";
-            echo "Created: " . $project->getCreated() . "\n";
-            echo "Last Modified: " . $project->getLastModified() . "\n";
+            echo "ID: ".$project->getId()."\n";
+            echo "Name: ".$project->getName()."\n";
+            echo "Account ID: ".$project->getAccountId()."\n";
+            echo "Platform: ".$project->getPlatform()."\n";
+            echo "Status: ".$project->getStatus()."\n";
+            echo "Is Classic: ".($project->getIsClassic() ? "true" : "false")."\n";
+            echo "Created: ".$project->getCreated()."\n";
+            echo "Last Modified: ".$project->getLastModified()."\n";
             
             echo "\n";
         }
         
         // Determine if there are more projects.
-        if ($result->getNextPage()==null)
+        if ($result->getNextPage() == null)
             break;
         
         // Increment page counter.
-        $page ++;
+        $page++;
     }
         
 } catch (Exception $e) {
@@ -73,6 +73,6 @@ 
 
 // Save access token for later use
 $accessToken = $optimizelyClient->getAccessToken();
-file_put_contents(dirname(__FILE__) . '/../access_token.json', json_encode($accessToken));
+file_put_contents(dirname(__FILE__).'/../access_token.json', json_encode($accessToken));
 
 echo "Done!\n";
\ No newline at end of file

Braces +3 added lines, -2 removed lines

@@ -55,8 +55,9 @@
         }
         
         // Determine if there are more projects.
-        if ($result->getNextPage()==null)
-            break;
+        if ($result->getNextPage()==null) {
+                    break;
+        }
         
         // Increment page counter.
         $page ++;

examples/Projects/CreateProject.php

Spacing +5 added lines, -5 removed lines

@@ -17,14 +17,14 @@ 
 use WebMarketingROI\OptimizelyPHP\Resource\v2\Project;
 
 // Init class autloading.
-include dirname(__FILE__) . '/../../vendor/autoload.php';
+include dirname(__FILE__).'/../../vendor/autoload.php';
 
 // Include Utils.php - a file containing helper functions
-include dirname(__FILE__) . '/../Utils.php';
+include dirname(__FILE__).'/../Utils.php';
 
 // Read project ID from command line.
-if ($argc!=2) {
-    die('Expected 1 command-line argument, while got ' . $argc-1);
+if ($argc != 2) {
+    die('Expected 1 command-line argument, while got '.$argc - 1);
 }
 $projectId = $argv[1];
 
@@ -56,6 +56,6 @@ 
 
 // Save access token for later use
 $accessToken = $optimizelyClient->getAccessToken();
-file_put_contents(dirname(__FILE__) . '/../access_token.json', json_encode($accessToken));
+file_put_contents(dirname(__FILE__).'/../access_token.json', json_encode($accessToken));
 
 echo "Done!\n";
\ No newline at end of file