webmarketingroi / optimizely-php

examples/Experiments/CreateExperiment.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
  */
 
 use WebMarketingROI\OptimizelyPHP\OptimizelyApiClient;
-use WebMarketingROI\OptimizelyPHP\Resource\v2\Project;
 
 // Init class autloading.
 include dirname(__FILE__) . '/../../vendor/autoload.php';

Indentation +20 added lines, -20 removed lines

@@ -32,73 +32,73 @@
     $project = new Experiment(array(
             "project_id" => 1000,
             "audience_ids" => array(
-              1234,
-              1212,
-              1432
+                1234,
+                1212,
+                1432
             ),
             "campaign_id" => 2000,
             "changes" => array(
-              array(
+                array(
                 "type" => "custom_code",
                 "allow_additional_redirect" => true,
                 "async" => true,
                 "css_selector" => "a[href*=\"optimizely\"]",
                 "dependencies" => array(
-                  24,
-                  26
+                    24,
+                    26
                 ),
                 "destination" => "https://app.optimizely.com/",
                 "extension_id" => 1234,
                 "preserve_parameters" => true,
                 "src" => 524,
                 "value" => "window.someGlobalFunction();"
-              )
+                )
             ),
             "description" => "string",
             "holdback" => 5000,
             "key" => "home_page_experiment",
             "metrics" => array(
-              array(
+                array(
                 "kind" => "string"
-              )
+                )
             ),
             "name" => "Blue Button Experiment",
             "schedule" => array(
-              "start_time" => "2016-10-17T07:04:59.724Z",
-              "stop_time" => "2016-10-17T07:04:59.724Z",
-              "time_zone" => "UTC"
+                "start_time" => "2016-10-17T07:04:59.724Z",
+                "stop_time" => "2016-10-17T07:04:59.724Z",
+                "time_zone" => "UTC"
             ),
             "status" => "active",
             "variations" => array(
-              array(
+                array(
                 "actions" => array(
-                  array(
+                    array(
                     "changes" => array(
-                      array(
+                        array(
                         "type" => "custom_code",
                         "allow_additional_redirect" => true,
                         "async" => true,
                         "css_selector" => "a[href*=\"optimizely\"]",
                         "dependencies" => array(
-                          24,
-                          26
+                            24,
+                            26
                         ),
                         "destination" => "https://app.optimizely.com/",
                         "extension_id" => 1234,
                         "preserve_parameters" => true,
                         "src" => 524,
                         "value" => "window.someGlobalFunction();"
-                      )
+                        )
                     ),
                     "page_id" => 0
-                  )
+                    )
                 ),
                 "archived" => true,
                 "key" => "blue_button_variation",
                 "name" => "Blue Button",
                 "variation_id" => 0,
                 "weight" => 0
-              )
+                )
             )
         ));
         

Spacing +4 added lines, -4 removed lines

@@ -16,10 +16,10 @@ 
 use WebMarketingROI\OptimizelyPHP\Resource\v2\Project;
 
 // Init class autloading.
-include dirname(__FILE__) . '/../../vendor/autoload.php';
+include dirname(__FILE__).'/../../vendor/autoload.php';
 
 // Include Utils.php - a file containing helper functions
-include dirname(__FILE__) . '/../Utils.php';
+include dirname(__FILE__).'/../Utils.php';
 
 // Get OAuth 2.0 credentials from auth_credentials.json and access_token.json files.
 $credentials = load_credentials_from_file();
@@ -105,11 +105,11 @@ 
     $createdExperiment = $optimizelyClient->experiments()->create($experiment);
                 
 } catch (\Exception $e) {
-    echo "Exception caught: " . $e->getMessage() . "\n";    
+    echo "Exception caught: ".$e->getMessage()."\n";    
 }    
 
 // Save access token for later use
 $accessToken = $optimizelyClient->getAccessToken();
-file_put_contents(dirname(__FILE__) . '/../access_token.json', json_encode($accessToken));
+file_put_contents(dirname(__FILE__).'/../access_token.json', json_encode($accessToken));
 
 echo "Done!\n";
\ No newline at end of file

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Audiences.php

Doc Comments +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
     
     /**
      * Get metadata for a single Audience.
-     * @param type $audienceId
+     * @param integer $audienceId
      * @return Audience
      * @throws \Exception
      */

Spacing +3 added lines, -3 removed lines

@@ -35,13 +35,13 @@
      * @return array[Audience]
      * @throws \Exception
      */
-    public function listAll($projectId, $page=0, $perPage=10)
+    public function listAll($projectId, $page = 0, $perPage = 10)
     {
-        if ($page<0) {
+        if ($page < 0) {
             throw new \Exception('Invalid page number passed');
         }
         
-        if ($perPage<0) {
+        if ($perPage < 0) {
             throw new \Exception('Invalid page size passed');
         }
         

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Campaigns.php

Doc Comments +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
     /**
      * Get campaign results
      * @param integer $campaignId The id for the campaign you want results for
-     * @param string $starTime The earliest time to count events in results. Defaults to the time that the campaign was first activated.
+     * @param string $startTime The earliest time to count events in results. Defaults to the time that the campaign was first activated.
      * @param string $endTime The latest time to count events in results. Defaults to the time the campaign was last active or the current time if the campaign is still running.
      * @throws \Exception
      */

Spacing +5 added lines, -5 removed lines

@@ -36,21 +36,21 @@ 
      * @return array[Campaign]
      * @throws \Exception
      */
-    public function listAll($projectId, $page=0, $perPage=10)
+    public function listAll($projectId, $page = 0, $perPage = 10)
     {
         if (!is_int($projectId)) {
             throw new \Exception("Integer project ID expected, while got '$projectId'");
         }
         
-        if ($projectId<0) {
+        if ($projectId < 0) {
             throw new \Exception("Expected positive integer project ID");
         }
         
-        if ($page<0) {
+        if ($page < 0) {
             throw new \Exception('Invalid page number passed');
         }
         
-        if ($perPage<0) {
+        if ($perPage < 0) {
             throw new \Exception('Invalid page size passed');
         }
         
@@ -102,7 +102,7 @@ 
             throw new \Exception("Integer campaign ID expected, while got '$campaignId'");
         }
         
-        if ($campaignId<0) {
+        if ($campaignId < 0) {
             throw new \Exception("Expected positive integer campaign ID");
         }
         

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Events.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     
     /**
      * Get Event by ID
-     * @param type $eventId
+     * @param integer $eventId
      * @return Event
      * @throws \Exception
      */

Spacing +3 added lines, -3 removed lines

@@ -38,13 +38,13 @@
      * @return array[Event]
      * @throws \Exception
      */
-    public function listAll($projectId, $includeClassic, $page=0, $perPage=10)
+    public function listAll($projectId, $includeClassic, $page = 0, $perPage = 10)
     {
-        if ($page<0) {
+        if ($page < 0) {
             throw new \Exception('Invalid page number passed');
         }
         
-        if ($perPage<0) {
+        if ($perPage < 0) {
             throw new \Exception('Invalid page size passed');
         }
         

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Pages.php

Doc Comments +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
     /**
      * Update a Page in a provided Project
      * @param integer $pageId
-     * @param Audience $page
+     * @param Page $page
      * @throws \Exception
      */
     public function update($pageId, $page) 

Spacing +3 added lines, -3 removed lines

@@ -35,13 +35,13 @@
      * @return array[Page]
      * @throws \Exception
      */
-    public function listAll($projectId, $page=0, $perPage=10)
+    public function listAll($projectId, $page = 0, $perPage = 10)
     {
-        if ($page<0) {
+        if ($page < 0) {
             throw new \Exception('Invalid page number passed');
         }
         
-        if ($perPage<0) {
+        if ($perPage < 0) {
             throw new \Exception('Invalid page size passed');
         }
         

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Experiments.php

Spacing +2 added lines, -2 removed lines

@@ -38,7 +38,7 @@ 
      * @return array
      * @throws \Exception
      */
-    public function listAll($projectId, $campaignId=null, $includeClassic=false, $page=1, $perPage=10)
+    public function listAll($projectId, $campaignId = null, $includeClassic = false, $page = 1, $perPage = 10)
     {
         if (empty($projectId) && empty($campaignId)) {
             throw new \Exception('Project ID or Campaign ID must be non-empty');
@@ -148,7 +148,7 @@ 
             throw new \Exception("Expected argument of type Experiment");
         }
         
-        if ($experimentId<0) {
+        if ($experimentId < 0) {
             throw new \Exception("Expected positive experiment ID argument");
         }
         

lib/WebMarketingROI/OptimizelyPHP/Service/v2/Projects.php

Spacing +5 added lines, -5 removed lines

@@ -34,13 +34,13 @@ 
      * @return array
      * @throws \Exception
      */
-    public function listAll($page=0, $perPage=10)
+    public function listAll($page = 0, $perPage = 10)
     {
-        if ($page<0) {
+        if ($page < 0) {
             throw new \Exception('Invalid page number passed');
         }
         
-        if ($perPage<0 || $perPage>100) {
+        if ($perPage < 0 || $perPage > 100) {
             throw new \Exception('Invalid page size passed');
         }
         
@@ -71,7 +71,7 @@ 
             throw new \Exception("Integer project ID expected, while got '$projectId'");
         }
         
-        if ($projectId<0) {
+        if ($projectId < 0) {
             throw new \Exception("A positive project ID expected");
         }
         
@@ -116,7 +116,7 @@ 
             throw new \Exception("Integer project ID expected, while got '$projectId'");
         }
         
-        if ($projectId<0) {
+        if ($projectId < 0) {
             throw new \Exception("A positive project ID expected");
         }
         

lib/WebMarketingROI/OptimizelyPHP/OptimizelyApiClient.php

Braces +9 added lines, -6 removed lines

@@ -289,14 +289,17 @@
      */
     private function getAccessTokenByRefreshToken()
     {
-        if (!isset($this->authCredentials['client_id']))
-            throw new \Exception('OAuth 2.0 client ID is not set');
+        if (!isset($this->authCredentials['client_id'])) {
+                    throw new \Exception('OAuth 2.0 client ID is not set');
+        }
         
-        if (!isset($this->authCredentials['client_secret']))
-            throw new \Exception('OAuth 2.0 client secret is not set');
+        if (!isset($this->authCredentials['client_secret'])) {
+                    throw new \Exception('OAuth 2.0 client secret is not set');
+        }
         
-        if (!isset($this->authCredentials['refresh_token']))
-            throw new \Exception('Refresh token is not set');
+        if (!isset($this->authCredentials['refresh_token'])) {
+                    throw new \Exception('Refresh token is not set');
+        }
         
         $clientId = $this->authCredentials['client_id'];
         $clientSecret = $this->authCredentials['client_secret'];

Spacing +25 added lines, -25 removed lines

@@ -41,13 +41,13 @@ 
      * @param array $authCredentials Auth credentials.
      * @param string $apiVersion Optional. Currently supported 'v2' only.
      */
-    public function __construct($authCredentials, $apiVersion='v2')
+    public function __construct($authCredentials, $apiVersion = 'v2')
     {
         if (!is_array($authCredentials)) {
             throw new \Exception('Auth credentials must be an array');            
         }
         
-        if ($apiVersion!='v2') {
+        if ($apiVersion != 'v2') {
             throw new \Exception('Invalid API version passed');
         }
         
@@ -75,7 +75,7 @@ 
      */
     public function setApiVersion($apiVersion)
     {
-        if ($apiVersion!='v2') {
+        if ($apiVersion != 'v2') {
             throw new \Exception('Invalid API version passed');
         }
         
@@ -97,7 +97,7 @@ 
      */
     public function setAuthCredentials($authCredentials)
     {
-        if (!is_array($authCredentials) || count($authCredentials)==0) {
+        if (!is_array($authCredentials) || count($authCredentials) == 0) {
             throw new \Exception('Auth credentials must be an array');            
         }
         
@@ -157,16 +157,16 @@ 
      * @return array Optimizely response in form of array.
      * @throws \Exception
      */
-    public function sendApiRequest($url, $queryParams = array(), $method='GET', 
+    public function sendApiRequest($url, $queryParams = array(), $method = 'GET', 
             $postData = array(), $expectedResponseCodes = array(200))
     {
         // If access token has expired, try to get another one with refresh token.
-        if ($this->isAccessTokenExpired() && $this->getRefreshToken()!=null) {
+        if ($this->isAccessTokenExpired() && $this->getRefreshToken() != null) {
             $this->getAccessTokenByRefreshToken();
         }
         
         // Produce absolute URL
-        $url = 'https://api.optimizely.com/' . $this->apiVersion . $url;
+        $url = 'https://api.optimizely.com/'.$this->apiVersion.$url;
         
         $result = $this->sendHttpRequest($url, $queryParams, $method, 
                 $postData, $expectedResponseCodes);
@@ -184,45 +184,45 @@ 
      * @return array Optimizely response in form of array.
      * @throws \Exception
      */
-    private function sendHttpRequest($url, $queryParams = array(), $method='GET', 
+    private function sendHttpRequest($url, $queryParams = array(), $method = 'GET', 
             $postData = array(), $expectedResponseCodes = array(200))
     {
         // Check if CURL is initialized (it should have been initialized in 
         // constructor).
-        if ($this->curlHandle==false) {
+        if ($this->curlHandle == false) {
             throw new \Exception('CURL is not initialized', -1);
         }
         
-        if ($method!='GET' && $method!='POST' && $method!='PUT' && 
-            $method!='PATCH' && $method!='DELETE') {
-            throw new \Exception('Invalid HTTP method passed: ' . $method, -1);
+        if ($method != 'GET' && $method != 'POST' && $method != 'PUT' && 
+            $method != 'PATCH' && $method != 'DELETE') {
+            throw new \Exception('Invalid HTTP method passed: '.$method, -1);
         }
         
         if (!isset($this->authCredentials['access_token'])) {
-            throw new \Exception('OAuth access token is not set. You should pass ' . 
+            throw new \Exception('OAuth access token is not set. You should pass '. 
                     'it to the class constructor when initializing the Optimizely client.', -1);
         }
                 
         // Append query parameters to URL.
-        if (count($queryParams)!=0) {            
+        if (count($queryParams) != 0) {            
             $query = http_build_query($queryParams);
-            $url .= '?' . $query;
+            $url .= '?'.$query;
         }
         
         $headers = array(
-            "Authorization: Bearer " . $this->authCredentials['access_token'],
+            "Authorization: Bearer ".$this->authCredentials['access_token'],
             "Content-Type: application/json"
             );
         $content = '';
-        if (count($postData)!=0) {
+        if (count($postData) != 0) {
             $content = json_encode($postData);            
         }
-        $headers[] = "Content-length:" . strlen($content);            
+        $headers[] = "Content-length:".strlen($content);            
         
         // Set HTTP options.
         curl_setopt($this->curlHandle, CURLOPT_URL, $url);
         curl_setopt($this->curlHandle, CURLOPT_CUSTOMREQUEST, $method);        
-        if (count($postData)!=0) {
+        if (count($postData) != 0) {
             curl_setopt($this->curlHandle, CURLOPT_POSTFIELDS, $content);            
         }
         curl_setopt($this->curlHandle, CURLOPT_RETURNTRANSFER, true);
@@ -240,16 +240,16 @@ 
         // Check HTTP response code.
         $info = curl_getinfo($this->curlHandle);
         if (!in_array($info['http_code'], $expectedResponseCodes)) {
-            throw new \Exception('Unexpected HTTP response code: ' . $info['http_code'] . 
-                    '. Request was ' . $method . ' "' . $url . '". Response was "' . $result . '"',
+            throw new \Exception('Unexpected HTTP response code: '.$info['http_code']. 
+                    '. Request was '.$method.' "'.$url.'". Response was "'.$result.'"',
                     $info['http_code']);
         }
         
         // JSON-decode response.
         $decodedResult = json_decode($result, true);
         if (!is_array($decodedResult)) {
-            throw new \Exception('Could not JSON-decode the Optimizely response. Request was ' . 
-                    $method . ' "' . $url . '". The response was: "' . $result . '"',
+            throw new \Exception('Could not JSON-decode the Optimizely response. Request was '. 
+                    $method.' "'.$url.'". The response was: "'.$result.'"',
                     $info['http_code']);
         }
         
@@ -264,7 +264,7 @@ 
      */
     private function isAccessTokenExpired() 
     {
-        if(!isset($this->authCredentials['access_token'])) {
+        if (!isset($this->authCredentials['access_token'])) {
             return true; // We do not have access token.
         }
         
@@ -309,7 +309,7 @@ 
         $response = $this->sendHttpRequest($url, array(), 'POST');
         
         if (!isset($response['access_token'])) {
-            throw new \Exception('Not found access token in response. Request URL was "' . $url. '". Response was "' . print_r($response, true). '"');
+            throw new \Exception('Not found access token in response. Request URL was "'.$url.'". Response was "'.print_r($response, true).'"');
         }
         
         $this->authCredentials['access_token'] = $response['access_token'];

lib/WebMarketingROI/OptimizelyPHP/Resource/v2/CampaignResults.php

Spacing +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
                 }
                 case 'start_time': $this->setStartTime($value); break;
                 default:
-                    throw new \Exception('Unknown option: ' . $name);
+                    throw new \Exception('Unknown option: '.$name);
             }
         }
     }
@@ -91,7 +91,7 @@ 
         // Remove options with empty values
         $cleanedOptions = array();
         foreach ($options as $name=>$value) {
-            if ($value!==null)
+            if ($value !== null)
                 $cleanedOptions[$name] = $value;
         }
         

Braces +3 added lines, -2 removed lines

@@ -91,8 +91,9 @@
         // Remove options with empty values
         $cleanedOptions = array();
         foreach ($options as $name=>$value) {
-            if ($value!==null)
-                $cleanedOptions[$name] = $value;
+            if ($value!==null) {
+                            $cleanedOptions[$name] = $value;
+            }
         }
         
         return $cleanedOptions;