NavigationTreeTest::testConstructor() - Code Metrics - Inspection of "Update Scrutinizer" - webeweb/core-library - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 03e47f...db33ac )

by WEBEWEB

created 2017-12-28 08:03 UTC

NavigationTreeTest::testConstructor() A

↳ Parent: NavigationTreeTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	0

<?php

/**
 * This file is part of the core-library package.
 *
 * (c) 2017 NdC/WBW
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace WBW\Library\Core\Tests\Navigation\Tree;

use PHPUnit_Framework_TestCase;
use WBW\Library\Core\Navigation\Node\NavigationNode;
use WBW\Library\Core\Navigation\Tree\NavigationTree;

/**
 * Navigation tree test.
 *
 * @author NdC/WBW <https://github.com/webeweb/>
 * @package WBW\Library\Core\Tests\Navigation\Node
 * @final
 */
final class NavigationTreeTest extends PHPUnit_Framework_TestCase {

	/**
	 * Tests the __construct() method.
	 *
	 * @return void
	 */
	public function testConstructor() {

		$obj = new NavigationTree();

		$obj->addNode(new NavigationNode("main level"));
		$obj->getLastNode()->setActive(true);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		$obj->getLastNode()->addNode(new NavigationNode("sub-level1"));
		$obj->getLastNode()->getLastNode()->setActive(true);

		$res = $obj->getBreadcrumbs();
		$this->assertCount(2, $res);
	}

}


1			<?php
2
3			/**
4			* This file is part of the core-library package.
5			*
6			* (c) 2017 NdC/WBW
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace WBW\Library\Core\Tests\Navigation\Tree;
13
14			use PHPUnit_Framework_TestCase;
15			use WBW\Library\Core\Navigation\Node\NavigationNode;
16			use WBW\Library\Core\Navigation\Tree\NavigationTree;
17
18			/**
19			* Navigation tree test.
20			*
21			* @author NdC/WBW <https://github.com/webeweb/>
22			* @package WBW\Library\Core\Tests\Navigation\Node
23			* @final
24			*/
25			final class NavigationTreeTest extends PHPUnit_Framework_TestCase {
26
27			/**
28			* Tests the __construct() method.
29			*
30			* @return void
31			*/
32			public function testConstructor() {
33
34			$obj = new NavigationTree();
35
36			$obj->addNode(new NavigationNode("main level"));
37			$obj->getLastNode()->setActive(true);
			0 ignored issues – show Bug introduced 2017-12-23 13:41 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `WBW\Library\Core\Node\AbstractNode` as the method `setActive()` does only exist in the following sub-classes of `WBW\Library\Core\Node\AbstractNode`: `WBW\Library\Core\Navigat...\AbstractNavigationNode`, `WBW\Library\Core\Navigation\Node\BreadcrumbNode`, `WBW\Library\Core\Navigation\Node\NavigationNode`, `WBW\Library\Core\Navigation\Tree\NavigationTree`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
38			$obj->getLastNode()->addNode(new NavigationNode("sub-level1"));
39			$obj->getLastNode()->getLastNode()->setActive(true);
40
41			$res = $obj->getBreadcrumbs();
42			$this->assertCount(2, $res);
43			}
44
45			}
46

webeweb / core-library

Push — master ( 03e47f...db33ac )

NavigationTreeTest::testConstructor() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like