Completed
Push — master ( 03e47f...db33ac )
by WEBEWEB
06:42 queued 01:35
created

NavigationTreeTest   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 21
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 3

Importance

Changes 0
Metric Value
wmc 1
lcom 0
cbo 3
dl 0
loc 21
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A testConstructor() 0 12 1
1
<?php
2
3
/**
4
 * This file is part of the core-library package.
5
 *
6
 * (c) 2017 NdC/WBW
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace WBW\Library\Core\Tests\Navigation\Tree;
13
14
use PHPUnit_Framework_TestCase;
15
use WBW\Library\Core\Navigation\Node\NavigationNode;
16
use WBW\Library\Core\Navigation\Tree\NavigationTree;
17
18
/**
19
 * Navigation tree test.
20
 *
21
 * @author NdC/WBW <https://github.com/webeweb/>
22
 * @package WBW\Library\Core\Tests\Navigation\Node
23
 * @final
24
 */
25
final class NavigationTreeTest extends PHPUnit_Framework_TestCase {
26
27
	/**
28
	 * Tests the __construct() method.
29
	 *
30
	 * @return void
31
	 */
32
	public function testConstructor() {
33
34
		$obj = new NavigationTree();
35
36
		$obj->addNode(new NavigationNode("main level"));
37
		$obj->getLastNode()->setActive(true);
0 ignored issues
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class WBW\Library\Core\Node\AbstractNode as the method setActive() does only exist in the following sub-classes of WBW\Library\Core\Node\AbstractNode: WBW\Library\Core\Navigat...\AbstractNavigationNode, WBW\Library\Core\Navigation\Node\BreadcrumbNode, WBW\Library\Core\Navigation\Node\NavigationNode, WBW\Library\Core\Navigation\Tree\NavigationTree. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
38
		$obj->getLastNode()->addNode(new NavigationNode("sub-level1"));
39
		$obj->getLastNode()->getLastNode()->setActive(true);
40
41
		$res = $obj->getBreadcrumbs();
42
		$this->assertCount(2, $res);
43
	}
44
45
}
46