webNeat / lumen-generators

src/Commands/ResourceCommand.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php namespace Wn\Generators\Commands;
 
 
-use InvalidArgumentException;
 use Illuminate\Support\Str;
 
 class ResourceCommand extends BaseCommand {

Spacing +12 added lines, -12 removed lines

@@ -62,7 +62,7 @@ 
         ]);
 
         // generating REST actions trait if doesn't exist
-        if(! $this->fs->exists('./app/Http/Controllers/RESTActions.php')){
+        if (!$this->fs->exists('./app/Http/Controllers/RESTActions.php')) {
             $this->call('wn:controller:rest-actions');
         }
         // generating the controller and routes
@@ -94,10 +94,10 @@ 
     protected function parseFields()
     {
         $fields = $this->argument('fields');
-        if($this->option('parsed')){
+        if ($this->option('parsed')) {
             $this->fields = $fields;
         } else {
-            if(! $fields){
+            if (!$fields) {
                 $this->fields = [];
             } else {
                 $this->fields = $this->getArgumentParser('fields')
@@ -121,7 +121,7 @@ 
 
     protected function fieldsHavingTag($tag)
     {
-        return array_map(function($field){
+        return array_map(function($field) {
             return $field['name'];
         }, array_filter($this->fields, function($field) use($tag){
             return in_array($tag, $field['tags']);
@@ -130,19 +130,19 @@ 
 
     protected function rules()
     {
-        return array_map(function($field){
+        return array_map(function($field) {
             return [
                 'name' => $field['name'],
                 'rule' => $field['rules']
             ];
-        }, array_filter($this->fields, function($field){
+        }, array_filter($this->fields, function($field) {
             return !empty($field['rules']);
         }));
     }
 
     protected function schema()
     {
-        return array_map(function($field){
+        return array_map(function($field) {
             return array_merge([[
                 'name' => $field['name'],
                 'args' => []
@@ -153,14 +153,14 @@ 
     protected function foreignKeys()
     {
         $belongsTo = $this->option('belongs-to');
-        if(! $belongsTo) {
+        if (!$belongsTo) {
             return [];
         }
         $relations = $this->getArgumentParser('relations')->parse($belongsTo);
-        return array_map(function($relation){
+        return array_map(function($relation) {
             $name = $relation['model'] ? $relation['model'] : $relation['name'];
             $index = strrpos($name, "\\");
-            if($index) {
+            if ($index) {
                 $name = substr($name, $index + 1);
             }
             return Str::snake(Str::singular($name)) . '_id';
@@ -181,12 +181,12 @@ 
 
     protected function factoryFields()
     {
-        return array_map(function($field){
+        return array_map(function($field) {
             return [
                 'name' => $field['name'],
                 'type' => $field['factory']
             ];
-        }, array_filter($this->fields, function($field){
+        }, array_filter($this->fields, function($field) {
             return isset($field['factory']) && $field['factory'];
         }));
     }

src/Commands/ResourcesCommand.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php namespace Wn\Generators\Commands;
 
-use InvalidArgumentException;
 use Symfony\Component\Yaml\Yaml;
 use Illuminate\Support\Str;
 

Indentation +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
 
     protected function getResourceParams($modelName, $i)
     {
-       $i['name'] = Str::snake($modelName);
+        $i['name'] = Str::snake($modelName);
 
         foreach(['hasMany', 'hasOne', 'add', 'belongsTo', 'belongsToMany'] as $relation){
             if(isset($i[$relation])){

Spacing +12 added lines, -12 removed lines

@@ -24,10 +24,10 @@ 
         $content = Yaml::parse($content);
 
         $modelIndex = 0;
-        foreach ($content as $model => $i){
+        foreach ($content as $model => $i) {
             $i = $this->getResourceParams($model, $i);
-            $migrationName = 'Create' .  ucwords(Str::plural($i['name']));
-            $migrationFile = date('Y_m_d_His') . '-' . str_pad($modelIndex , 3, 0, STR_PAD_LEFT) . '_' . Str::snake($migrationName) . '_table';
+            $migrationName = 'Create' . ucwords(Str::plural($i['name']));
+            $migrationFile = date('Y_m_d_His') . '-' . str_pad($modelIndex, 3, 0, STR_PAD_LEFT) . '_' . Str::snake($migrationName) . '_table';
             
             $options = [
                 'name' => $i['name'],
@@ -77,34 +77,34 @@ 
     {
        $i['name'] = Str::snake($modelName);
 
-        foreach(['hasMany', 'hasOne', 'add', 'belongsTo', 'belongsToMany'] as $relation){
-            if(isset($i[$relation])){
+        foreach (['hasMany', 'hasOne', 'add', 'belongsTo', 'belongsToMany'] as $relation) {
+            if (isset($i[$relation])) {
                 $i[$relation] = $this->convertArray($i[$relation], ' ', ',');
             } else {
                 $i[$relation] = false;
             }
         }
 
-        if($i['belongsToMany']){
+        if ($i['belongsToMany']) {
             $relations = $this->getArgumentParser('relations')->parse($i['belongsToMany']);
-            foreach ($relations as $relation){
+            foreach ($relations as $relation) {
                 $table = '';
 
-                if(! $relation['model']){
+                if (!$relation['model']) {
                     $table = Str::snake($relation['name']);
                 } else {
                     $names = array_reverse(explode("\\", $relation['model']));
                     $table = Str::snake($names[0]);
                 }
 
-                $tables = [ Str::singular($table), $i['name'] ];
+                $tables = [Str::singular($table), $i['name']];
                 sort($tables);
                 $this->pivotTables[] = $tables;
             }
         }
 
         $fields = [];
-        foreach($i['fields'] as $name => $value) {
+        foreach ($i['fields'] as $name => $value) {
             $value['name'] = $name;
             $fields[] = $this->serializeField($value);
         }
@@ -125,7 +125,7 @@ 
 
         $string = "{$name};{$schema};{$rules};{$tags}";
 
-        if(isset($field['factory']) && !empty($field['factory'])){
+        if (isset($field['factory']) && !empty($field['factory'])) {
             $string .= ';' . $field['factory'];
         }
 
@@ -134,7 +134,7 @@ 
 
     protected function convertArray($list, $old, $new)
     {
-        return implode($new, array_filter(explode($old, $list), function($item){
+        return implode($new, array_filter(explode($old, $list), function($item) {
             return !empty($item);
         }));
     }

src/Commands/RouteCommand.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     protected function getController()
     {
         $controller = $this->option('controller');
-        if(! $controller){
+        if (!$controller) {
             $controller = ucwords(\Illuminate\Support\Str::plural(\Illuminate\Support\Str::camel($this->argument('resource')))) . 'Controller';
         }
         return $controller;

src/Commands/PivotSeederCommand.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
     }
 
     protected function getSeederName($resources) {
-        $resources = array_map(function($resource){
+        $resources = array_map(function($resource) {
             return ucwords(\Illuminate\Support\Str::camel($resource));
         }, $resources);
         return implode('', $resources) . 'TableSeeder';

src/Commands/ModelCommand.php

Spacing +9 added lines, -9 removed lines

@@ -45,12 +45,12 @@ 
     protected function getAsArrayFields($arg, $isOption = true)
     {
     	$arg = ($isOption) ? $this->option($arg) : $this->argument($arg);
-        if(is_string($arg)){
+        if (is_string($arg)) {
         	$arg = explode(',', $arg);
-        } else if(! is_array($arg)) {
+        } else if (!is_array($arg)) {
             $arg = [];
         }
-        return implode(', ', array_map(function($item){
+        return implode(', ', array_map(function($item) {
             return '"' . $item . '"';
         }, $arg));
     }
@@ -69,7 +69,7 @@ 
             $this->getRelationsByType('belongsToMany', 'belongs-to-many', true)
         );
 
-        if(empty($relations)){
+        if (empty($relations)) {
             return "    // Relationships";
         }
 
@@ -80,7 +80,7 @@ 
     {
         $relations = [];
         $option = $this->option($option);
-        if($option){
+        if ($option) {
 
             $items = $this->getArgumentParser('relations')->parse($option);
 
@@ -88,9 +88,9 @@ 
             $template = $this->getTemplate($template);
             foreach ($items as $item) {
                 $item['type'] = $type;
-                if(! $item['model']){
+                if (!$item['model']) {
                     $item['model'] = $this->getNamespace() . '\\' . ucwords(\Illuminate\Support\Str::singular($item['name']));
-                } else if(strpos($item['model'], '\\') === false ){
+                } else if (strpos($item['model'], '\\') === false) {
                     $item['model'] = $this->getNamespace() . '\\' . $item['model'];
                 }
                 $relations[] = $template->with($item)->get();
@@ -102,11 +102,11 @@ 
     protected function getRules()
     {
         $rules = $this->option('rules');
-        if(! $rules){
+        if (!$rules) {
             return "        // Validation rules";
         }
         $items = $rules;
-        if(! $this->option('parsed')){
+        if (!$this->option('parsed')) {
             $items = $this->getArgumentParser('rules')->parse($rules);
         }
         $rules = [];

Indentation +5 added lines, -5 removed lines

@@ -3,7 +3,7 @@ 
 
 class ModelCommand extends BaseCommand {
 
-	protected $signature = 'wn:model
+    protected $signature = 'wn:model
         {name : Name of the model.}
         {--fillable= : the fillable fields.}
         {--guarded= : the guarded fields.}
@@ -20,7 +20,7 @@ 
         {--force= : override the existing files}
     ';
 
-	protected $description = 'Generates a model class for a RESTfull resource';
+    protected $description = 'Generates a model class for a RESTfull resource';
 
     public function handle()
     {
@@ -46,9 +46,9 @@ 
 
     protected function getAsArrayFields($arg, $isOption = true)
     {
-    	$arg = ($isOption) ? $this->option($arg) : $this->argument($arg);
+        $arg = ($isOption) ? $this->option($arg) : $this->argument($arg);
         if(is_string($arg)){
-        	$arg = explode(',', $arg);
+            $arg = explode(',', $arg);
         } else if(! is_array($arg)) {
             $arg = [];
         }
@@ -59,7 +59,7 @@ 
 
     protected function getNamespace()
     {
-    	return str_replace(' ', '\\', ucwords(str_replace('/', ' ', $this->option('path'))));
+        return str_replace(' ', '\\', ucwords(str_replace('/', ' ', $this->option('path'))));
     }
 
     protected function getRelations()

Doc Comments +7 added lines

@@ -44,6 +44,9 @@ 
         $this->save($content, "./App/Models/{$name}.php", "{$name} model");
     }
 
+    /**
+     * @param string $arg
+     */
     protected function getAsArrayFields($arg, $isOption = true)
     {
     	$arg = ($isOption) ? $this->option($arg) : $this->argument($arg);
@@ -78,6 +81,10 @@ 
         return implode(PHP_EOL, $relations);
     }
 
+    /**
+     * @param string $type
+     * @param string $option
+     */
     protected function getRelationsByType($type, $option, $withTimestamps = false)
     {
         $relations = [];

src/Commands/ControllerCommand.php

Indentation +16 added lines, -16 removed lines

@@ -5,33 +5,33 @@
 
 class ControllerCommand extends BaseCommand {
 
-	protected $signature = 'wn:controller
+    protected $signature = 'wn:controller
         {model : Name of the model (with namespace if not App)}
 		{--no-routes= : without routes}
         {--force= : override the existing files}
         {--laravel : Use Laravel style route definitions}
     ';
 
-	protected $description = 'Generates RESTful controller using the RESTActions trait';
+    protected $description = 'Generates RESTful controller using the RESTActions trait';
 
     public function handle()
     {
-    	$model = $this->argument('model');
-    	$name = '';
-    	if(strrpos($model, "\\") === false){
-    		$name = $model;
-    		$model = "App\\" . $model;
-    	} else {
-    		$name = explode("\\", $model);
-    		$name = $name[count($name) - 1];
-    	}
+        $model = $this->argument('model');
+        $name = '';
+        if(strrpos($model, "\\") === false){
+            $name = $model;
+            $model = "App\\" . $model;
+        } else {
+            $name = explode("\\", $model);
+            $name = $name[count($name) - 1];
+        }
         $controller = ucwords(\Illuminate\Support\Str::plural($name)) . 'Controller';
         $content = $this->getTemplate('controller')
-        	->with([
-        		'name' => $controller,
-        		'model' => $model
-        	])
-        	->get();
+            ->with([
+                'name' => $controller,
+                'model' => $model
+            ])
+            ->get();
 
         $this->save($content, "./app/Http/Controllers/{$controller}.php", "{$controller}");
         if(! $this->option('no-routes')){

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
     {
     	$model = $this->argument('model');
     	$name = '';
-    	if(strrpos($model, "\\") === false){
+    	if (strrpos($model, "\\") === false) {
     		$name = $model;
     		$model = "App\\" . $model;
     	} else {
@@ -34,7 +34,7 @@ 
         	->get();
 
         $this->save($content, "./app/Http/Controllers/{$controller}.php", "{$controller}");
-        if(! $this->option('no-routes')){
+        if (!$this->option('no-routes')) {
             $options = [
                 'resource' => \Illuminate\Support\Str::snake($name, '-'),
                 '--controller' => $controller,

src/Commands/MigrationCommand.php

Spacing +14 added lines, -14 removed lines

@@ -34,10 +34,10 @@ 
             ->get();
 
         $file = $this->option('file');
-        if(! $file){
+        if (!$file) {
             $file = date('Y_m_d_His_') . $snakeName . '_table';
             $this->deleteOldMigration($snakeName);
-        }else{
+        } else {
             $this->deleteOldMigration($file);
         }
 
@@ -46,10 +46,10 @@ 
 
     protected function deleteOldMigration($fileName)
     {
-        foreach (new \DirectoryIterator("./database/migrations/") as $fileInfo){
-            if($fileInfo->isDot()) continue;
+        foreach (new \DirectoryIterator("./database/migrations/") as $fileInfo) {
+            if ($fileInfo->isDot()) continue;
 
-            if(strpos($fileInfo->getFilename(), $fileName) !== FALSE){
+            if (strpos($fileInfo->getFilename(), $fileName) !== FALSE) {
                 unlink($fileInfo->getPathname());
             }
         }
@@ -58,12 +58,12 @@ 
     protected function getSchema()
     {
         $schema = $this->option('schema');
-        if(! $schema){
+        if (!$schema) {
             return $this->spaces(12) . "// Schema declaration";
         }
 
         $items = $schema;
-        if( ! $this->option('parsed')){
+        if (!$this->option('parsed')) {
             $items = $this->getArgumentParser('schema')->parse($schema);
         }
 
@@ -97,7 +97,7 @@ 
         $name = $parts[0]['name'];
         $parts[1]['args'] = array_merge(["'{$name}'"], $parts[1]['args']);
         unset($parts[0]);
-        $parts = array_map(function($part){
+        $parts = array_map(function($part) {
             return '->' . $part['name'] . '(' . implode(', ', $part['args']) . ')';
         }, $parts);
         return "            \$table" . implode('', $parts) . ';';
@@ -106,12 +106,12 @@ 
     protected function getConstraints()
     {
         $keys = $this->option('keys');
-        if(! $keys){
+        if (!$keys) {
             return $this->spaces(12) . "// Constraints declaration";
         }
 
         $items = $keys;
-        if(! $this->option('parsed')){
+        if (!$this->option('parsed')) {
             $items = $this->getArgumentParser('foreign-keys')->parse($keys);
         }
 
@@ -125,10 +125,10 @@ 
 
     protected function getConstraintDeclaration($key)
     {
-        if(! $key['column']){
+        if (!$key['column']) {
             $key['column'] = 'id';
         }
-        if(! $key['table']){
+        if (!$key['table']) {
             $key['table'] = \Illuminate\Support\Str::plural(substr($key['name'], 0, strlen($key['name']) - 3));
         }
 
@@ -140,7 +140,7 @@ 
             ])
             ->get();
 
-        if($key['on_delete']){
+        if ($key['on_delete']) {
             $constraint .= PHP_EOL . $this->getTemplate('migration/on-constraint')
                     ->with([
                         'event' => 'Delete',
@@ -149,7 +149,7 @@ 
                     ->get();
         }
 
-        if($key['on_update']){
+        if ($key['on_update']) {
             $constraint .= PHP_EOL . $this->getTemplate('migration/on-constraint')
                     ->with([
                         'event' => 'Update',