App\Middleware\Redirect::process()

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function process(ServerRequestInterface $request, DelegateInterface $delegate)
    {
        $path = substr($request->getUri()->getPath(), 1);
        $redirect = RedirectModel::where('hash', $path)->first();
        if ($redirect) {
            $redirect->increment('count');
            return new RedirectResponse($redirect->redirect_to, 301);

The expression return new Zend\Diactoros\Response\RedirectResponse($redirect->redirect_to, 301) returns the type Zend\Diactoros\Response\RedirectResponse which is incompatible with the documented return type App\Middleware\Psr\Http\Message\ServerRequestInterface.

The property redirect_to does not seem to exist on App\Models\Redirect. Are you sure there is no database migration missing?

        }
        return new HtmlResponse(view('404.php'), 404);

The expression return new Zend\Diactoros\Response\HtmlResponse(view('404.php'), 404) returns the type Zend\Diactoros\Response\HtmlResponse which is incompatible with the documented return type App\Middleware\Psr\Http\Message\ServerRequestInterface.

Are you sure the usage of view('404.php') is correct as it seems to always return null.

view('404.php') of type void is incompatible with the type string|Psr\Http\Message\StreamInterface expected by parameter $html of Zend\Diactoros\Response\HtmlResponse::__construct().

    }