App\Middleware\Redirect

Complexity

Total Complexity

2

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	process()	0	9	2

<?php

namespace App\Middleware;

use Zend\Diactoros\Response\HtmlResponse;
use App\Models\Redirect as RedirectModel;
use Psr\Http\Message\ServerRequestInterface;
use Zend\Diactoros\Response\RedirectResponse;
use Interop\Http\ServerMiddleware\DelegateInterface;
use Interop\Http\ServerMiddleware\MiddlewareInterface;

class Redirect implements MiddlewareInterface
{
    /**
     * PSR-15 middleware callback
     *
     * @param ServerRequestInterface $request
     * @param DelegateInterface $delegate
     * @return Psr\Http\Message\ServerRequestInterface

The type App\Middleware\Psr\Http\Message\ServerRequestInterface was not found. Did you mean Psr\Http\Message\ServerRequestInterface? If so, make sure to prefix the type with \.

     */
    public function process(ServerRequestInterface $request, DelegateInterface $delegate)
    {
        $path = substr($request->getUri()->getPath(), 1);
        $redirect = RedirectModel::where('hash', $path)->first();
        if ($redirect) {
            $redirect->increment('count');
            return new RedirectResponse($redirect->redirect_to, 301);

The expression return new Zend\Diactoros\Response\RedirectResponse($redirect->redirect_to, 301) returns the type Zend\Diactoros\Response\RedirectResponse which is incompatible with the documented return type App\Middleware\Psr\Http\Message\ServerRequestInterface.

The property redirect_to does not seem to exist on App\Models\Redirect. Are you sure there is no database migration missing?

        }
        return new HtmlResponse(view('404.php'), 404);

The expression return new Zend\Diactoros\Response\HtmlResponse(view('404.php'), 404) returns the type Zend\Diactoros\Response\HtmlResponse which is incompatible with the documented return type App\Middleware\Psr\Http\Message\ServerRequestInterface.

Are you sure the usage of view('404.php') is correct as it seems to always return null.

view('404.php') of type void is incompatible with the type string|Psr\Http\Message\StreamInterface expected by parameter $html of Zend\Diactoros\Response\HtmlResponse::__construct().

    }
}