wapmorgan\UnifiedArchive\Commands\TestCommand::execute()

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $archive = $this->getArchive($input, $output);
        $test_result = $archive->test($input->getArgument('filter'));

It seems like $input->getArgument('filter') can also be of type string[]; however, parameter $filter of wapmorgan\UnifiedArchive\UnifiedArchive::test() does only seem to accept null|string, maybe add an additional type check?

        if ($test_result === true) {

The condition $test_result === true is always true.

            $output->writeln('<info>Archive is ok!</info>');
        } else {
            $output->writeln('<error>Failed:</error>:');
            array_walk($test_result, static function ($file) use ($output) {
                $output->writeln('- ' . $file);
            });
        }
        return 0;
    }