wapmorgan\UnifiedArchive\Commands\TestCommand

Complexity

Total Complexity

3

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	execute()	0	13	2
A	configure()	0	7	1

<?php

namespace wapmorgan\UnifiedArchive\Commands;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class TestCommand extends BaseArchiveCommand
{
    protected static $defaultName = 'files:test';

    protected function configure()
    {
        parent::configure();
        $this
            ->setDescription('Tests archive contents')
            ->setHelp('Tests archive contents.')
            ->addArgument('filter', InputArgument::OPTIONAL, 'Files filter (as for fnmatch). If no * passed in filter, it will be added at the end of filter')
        ;
    }

    public function execute(InputInterface $input, OutputInterface $output)
    {
        $archive = $this->getArchive($input, $output);
        $test_result = $archive->test($input->getArgument('filter'));

It seems like $input->getArgument('filter') can also be of type string[]; however, parameter $filter of wapmorgan\UnifiedArchive\UnifiedArchive::test() does only seem to accept null|string, maybe add an additional type check?

        if ($test_result === true) {

The condition $test_result === true is always true.

            $output->writeln('<info>Archive is ok!</info>');
        } else {
            $output->writeln('<error>Failed:</error>:');
            array_walk($test_result, static function ($file) use ($output) {
                $output->writeln('- ' . $file);
            });
        }
        return 0;
    }
}