Passed
Push — 0.1.x ( 3e3fb7...4a45f6 )
by f
02:35
created
src/UnifiedArchive.php 1 patch
Braces   +70 added lines, -46 removed lines patch added patch discarded remove patch
@@ -76,8 +76,9 @@  discard block
 block discarded – undo
76 76
     {
77 77
         self::checkRequirements();
78 78
 
79
-        if (!file_exists($fileName) || !is_readable($fileName))
80
-            throw new Exception('Could not open file: '.$fileName);
79
+        if (!file_exists($fileName) || !is_readable($fileName)) {
80
+                    throw new Exception('Could not open file: '.$fileName);
81
+        }
81 82
 
82 83
         $type = self::detectArchiveType($fileName);
83 84
         if (!self::canOpenType($type)) {
@@ -220,8 +221,9 @@  discard block
 block discarded – undo
220 221
         $this->type = $type;
221 222
         $this->archiveSize = filesize($fileName);
222 223
 
223
-        if (!isset(static::$formatHandlers[$type]))
224
-            throw new Exception('Unsupported archive type: '.$type.' of archive '.$fileName);
224
+        if (!isset(static::$formatHandlers[$type])) {
225
+                    throw new Exception('Unsupported archive type: '.$type.' of archive '.$fileName);
226
+        }
225 227
 
226 228
         $handler_class = __NAMESPACE__.'\\Formats\\'.static::$formatHandlers[$type];
227 229
 
@@ -259,8 +261,9 @@  discard block
 block discarded – undo
259 261
      */
260 262
     public function getPclZipInterface()
261 263
     {
262
-        if ($this->type !== self::ZIP)
263
-            throw new UnsupportedOperationException();
264
+        if ($this->type !== self::ZIP) {
265
+                    throw new UnsupportedOperationException();
266
+        }
264 267
 
265 268
         return new $this->archive->getPclZip();
266 269
     }
@@ -336,8 +339,9 @@  discard block
 block discarded – undo
336 339
      */
337 340
     public function getFileData($fileName)
338 341
     {
339
-        if (!in_array($fileName, $this->files, true))
340
-            return false;
342
+        if (!in_array($fileName, $this->files, true)) {
343
+                    return false;
344
+        }
341 345
 
342 346
         return $this->archive->getFileData($fileName);
343 347
     }
@@ -352,8 +356,9 @@  discard block
 block discarded – undo
352 356
      */
353 357
     public function getFileContent($fileName)
354 358
     {
355
-        if (!in_array($fileName, $this->files, true))
356
-            return false;
359
+        if (!in_array($fileName, $this->files, true)) {
360
+                    return false;
361
+        }
357 362
 
358 363
         return $this->archive->getFileContent($fileName);
359 364
     }
@@ -365,8 +370,9 @@  discard block
 block discarded – undo
365 370
      */
366 371
     public function getFileResource($fileName)
367 372
     {
368
-        if (!in_array($fileName, $this->files, true))
369
-            return false;
373
+        if (!in_array($fileName, $this->files, true)) {
374
+                    return false;
375
+        }
370 376
 
371 377
         return $this->archive->getFileResource($fileName);
372 378
     }
@@ -382,10 +388,13 @@  discard block
 block discarded – undo
382 388
     public function extractFiles($outputFolder, $files = null, $expandFilesList = false)
383 389
     {
384 390
         if ($files !== null) {
385
-            if (is_string($files)) $files = [$files];
391
+            if (is_string($files)) {
392
+             $files = [$files];
393
+            }
386 394
 
387
-            if ($expandFilesList)
388
-                $files = self::expandFileList($this->files, $files);
395
+            if ($expandFilesList) {
396
+                            $files = self::expandFileList($this->files, $files);
397
+            }
389 398
 
390 399
             return $this->archive->extractFiles($outputFolder, $files);
391 400
         } else {
@@ -406,8 +415,9 @@  discard block
 block discarded – undo
406 415
     {
407 416
         $fileOrFiles = is_string($fileOrFiles) ? [$fileOrFiles] : $fileOrFiles;
408 417
 
409
-        if ($expandFilesList && $fileOrFiles !== null)
410
-            $fileOrFiles = self::expandFileList($this->files, $fileOrFiles);
418
+        if ($expandFilesList && $fileOrFiles !== null) {
419
+                    $fileOrFiles = self::expandFileList($this->files, $fileOrFiles);
420
+        }
411 421
 
412 422
         $result = $this->archive->deleteFiles($fileOrFiles);
413 423
         $this->scanArchive();
@@ -437,8 +447,9 @@  discard block
 block discarded – undo
437 447
      */
438 448
     public function addFile($file, $inArchiveName = null)
439 449
     {
440
-        if (!is_file($file))
441
-            throw new \InvalidArgumentException($file.' is not a valid file to add in archive');
450
+        if (!is_file($file)) {
451
+                    throw new \InvalidArgumentException($file.' is not a valid file to add in archive');
452
+        }
442 453
 
443 454
         return ($inArchiveName !== null
444 455
                 ? $this->addFiles([$file => $inArchiveName])
@@ -454,8 +465,9 @@  discard block
 block discarded – undo
454 465
      */
455 466
     public function addDirectory($directory, $inArchivePath = null)
456 467
     {
457
-        if (!is_dir($directory) || !is_readable($directory))
458
-            throw new \InvalidArgumentException($directory.' is not a valid directory to add in archive');
468
+        if (!is_dir($directory) || !is_readable($directory)) {
469
+                    throw new \InvalidArgumentException($directory.' is not a valid directory to add in archive');
470
+        }
459 471
 
460 472
         return ($inArchivePath !== null
461 473
                 ? $this->addFiles([$directory => $inArchivePath])
@@ -491,23 +503,27 @@  discard block
 block discarded – undo
491 503
      */
492 504
     public static function archiveFiles($fileOrFiles, $archiveName, $emulate = false)
493 505
     {
494
-        if (file_exists($archiveName))
495
-            throw new Exception('Archive '.$archiveName.' already exists!');
506
+        if (file_exists($archiveName)) {
507
+                    throw new Exception('Archive '.$archiveName.' already exists!');
508
+        }
496 509
 
497 510
         self::checkRequirements();
498 511
 
499 512
         $archiveType = self::detectArchiveType($archiveName, false);
500 513
         //        if (in_array($archiveType, [TarArchive::TAR, TarArchive::TAR_GZIP, TarArchive::TAR_BZIP, TarArchive::TAR_LZMA, TarArchive::TAR_LZW], true))
501 514
         //            return TarArchive::archiveFiles($fileOrFiles, $archiveName, $emulate);
502
-        if ($archiveType === false)
503
-            return false;
515
+        if ($archiveType === false) {
516
+                    return false;
517
+        }
504 518
 
505 519
         $files_list = self::createFilesList($fileOrFiles);
506 520
 
507 521
         // fake creation: return archive data
508 522
         if ($emulate) {
509 523
             $totalSize = 0;
510
-            foreach ($files_list as $fn) $totalSize += filesize($fn);
524
+            foreach ($files_list as $fn) {
525
+             $totalSize += filesize($fn);
526
+            }
511 527
 
512 528
             return array(
513 529
                 'totalSize' => $totalSize,
@@ -517,8 +533,9 @@  discard block
 block discarded – undo
517 533
             );
518 534
         }
519 535
 
520
-        if (!isset(static::$formatHandlers[$archiveType]))
521
-            throw new Exception('Unsupported archive type: '.$archiveType.' of archive '.$archiveName);
536
+        if (!isset(static::$formatHandlers[$archiveType])) {
537
+                    throw new Exception('Unsupported archive type: '.$archiveType.' of archive '.$archiveName);
538
+        }
522 539
 
523 540
         $handler_class = __NAMESPACE__.'\\Formats\\'.static::$formatHandlers[$archiveType];
524 541
 
@@ -534,8 +551,9 @@  discard block
 block discarded – undo
534 551
      */
535 552
     public static function archiveFile($file, $archiveName)
536 553
     {
537
-        if (!is_file($file))
538
-            throw new \InvalidArgumentException($file.' is not a valid file to archive');
554
+        if (!is_file($file)) {
555
+                    throw new \InvalidArgumentException($file.' is not a valid file to archive');
556
+        }
539 557
 
540 558
         return static::archiveFiles($file, $archiveName) === 1;
541 559
     }
@@ -549,8 +567,9 @@  discard block
 block discarded – undo
549 567
      */
550 568
     public static function archiveDirectory($directory, $archiveName)
551 569
     {
552
-        if (!is_dir($directory) || !is_readable($directory))
553
-            throw new \InvalidArgumentException($directory.' is not a valid directory to archive');
570
+        if (!is_dir($directory) || !is_readable($directory)) {
571
+                    throw new \InvalidArgumentException($directory.' is not a valid directory to archive');
572
+        }
554 573
 
555 574
         return static::archiveFiles($directory, $archiveName) > 0;
556 575
     }
@@ -616,8 +635,9 @@  discard block
 block discarded – undo
616 635
         $newFiles = [];
617 636
         foreach ($files as $file) {
618 637
             foreach ($archiveFiles as $archiveFile) {
619
-                if (fnmatch($file.'*', $archiveFile))
620
-                    $newFiles[] = $archiveFile;
638
+                if (fnmatch($file.'*', $archiveFile)) {
639
+                                    $newFiles[] = $archiveFile;
640
+                }
621 641
             }
622 642
         }
623 643
         return $newFiles;
@@ -634,26 +654,29 @@  discard block
 block discarded – undo
634 654
         // passed an extended list
635 655
         if (is_array($nodes)) {
636 656
             foreach ($nodes as $source => $destination) {
637
-                if (is_numeric($source))
638
-                    $source = $destination;
657
+                if (is_numeric($source)) {
658
+                                    $source = $destination;
659
+                }
639 660
 
640 661
                 $destination = rtrim($destination, '/\\*');
641 662
 
642 663
                 // if is directory
643
-                if (is_dir($source))
644
-                    self::importFilesFromDir(rtrim($source, '/\\*').'/*',
664
+                if (is_dir($source)) {
665
+                                    self::importFilesFromDir(rtrim($source, '/\\*').'/*',
645 666
                         !empty($destination) ? $destination.'/' : null, true, $files);
646
-                else if (is_file($source))
647
-                    $files[$destination] = $source;
667
+                } else if (is_file($source)) {
668
+                                    $files[$destination] = $source;
669
+                }
648 670
             }
649 671
 
650 672
         } else if (is_string($nodes)) { // passed one file or directory
651 673
             // if is directory
652
-            if (is_dir($nodes))
653
-                self::importFilesFromDir(rtrim($nodes, '/\\*').'/*', null, true,
674
+            if (is_dir($nodes)) {
675
+                            self::importFilesFromDir(rtrim($nodes, '/\\*').'/*', null, true,
654 676
                     $files);
655
-            else if (is_file($nodes))
656
-                $files[basename($nodes)] = $nodes;
677
+            } else if (is_file($nodes)) {
678
+                            $files[basename($nodes)] = $nodes;
679
+            }
657 680
         }
658 681
 
659 682
         return $files;
@@ -670,8 +693,9 @@  discard block
 block discarded – undo
670 693
         // $map[$destination] = rtrim($source, '/*');
671 694
         // do not map root archive folder
672 695
 
673
-        if ($destination !== null)
674
-            $map[$destination] = null;
696
+        if ($destination !== null) {
697
+                    $map[$destination] = null;
698
+        }
675 699
 
676 700
         foreach (glob($source, GLOB_MARK) as $node) {
677 701
             if (in_array(substr($node, -1), ['/', '\\'], true) && $recursive) {
Please login to merge, or discard this patch.
src/PclzipZipInterface.php 2 patches
Spacing   +37 added lines, -38 removed lines patch added patch discarded remove patch
@@ -147,8 +147,8 @@  discard block
 block discarded – undo
147 147
             }
148 148
         } else {
149 149
             $options = array_combine(
150
-                array_filter($options, function ($v) {return (bool) $v&2;}),
151
-                array_filter($options, function ($v) {return (bool) ($v-1)&2;})
150
+                array_filter($options, function($v) {return (bool) $v & 2; }),
151
+                array_filter($options, function($v) {return (bool) ($v - 1) & 2; })
152 152
             );
153 153
         }
154 154
 
@@ -156,12 +156,12 @@  discard block
 block discarded – undo
156 156
         $filters = array();
157 157
         if (isset($options[PCLZIP_OPT_REMOVE_PATH])
158 158
             && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
159
-            $filters[] = function (&$key, &$value) use ($options) {
159
+            $filters[] = function(&$key, &$value) use ($options) {
160 160
                 $key = str_replace($key, null, $key); };
161 161
         if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
162
-            $filters[] = function (&$key, &$value) { $key = basename($key); };
162
+            $filters[] = function(&$key, &$value) { $key = basename($key); };
163 163
         if (isset($options[PCLZIP_OPT_ADD_PATH]))
164
-            $filters[] = function (&$key, &$value) use ($options) {
164
+            $filters[] = function(&$key, &$value) use ($options) {
165 165
                 $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/').'/'.
166 166
                     ltrim($key, '/');
167 167
             };
@@ -169,12 +169,12 @@  discard block
 block discarded – undo
169 169
         if (isset($options[PCLZIP_CB_PRE_ADD])
170 170
             && is_callable($options[PCLZIP_CB_PRE_ADD]))
171 171
             $preAddCallback = $options[PCLZIP_CB_PRE_ADD];
172
-        else $preAddCallback = function () { return 1; };
172
+        else $preAddCallback = function() { return 1; };
173 173
 
174 174
         if (isset($options[PCLZIP_CB_POST_ADD])
175 175
             && is_callable($options[PCLZIP_CB_POST_ADD]))
176 176
             $postAddCallback = $options[PCLZIP_CB_POST_ADD];
177
-        else $postAddCallback = function () { return 1; };
177
+        else $postAddCallback = function() { return 1; };
178 178
 
179 179
         if (isset($options[PCLZIP_OPT_COMMENT]))
180 180
             $this->archive->setArchiveComment($options[PCLZIP_OPT_COMMENT]);
@@ -248,8 +248,7 @@  discard block
 block discarded – undo
248 248
                 'size' => $statIndex['size'],
249 249
                 'compressed_size' => $statIndex['comp_size'],
250 250
                 'mtime' => $statIndex,
251
-                'comment' => ($comment = $this->archive->getCommentIndex
252
-                    ($statIndex['index']) !== false) ? $comment : null,
251
+                'comment' => ($comment = $this->archive->getCommentIndex($statIndex['index']) !== false) ? $comment : null,
253 252
                 'folder' => in_array(substr($statIndex['name'], -1),
254 253
                     array('/', '\\')),
255 254
                 'index' => $statIndex['index'],
@@ -279,8 +278,8 @@  discard block
 block discarded – undo
279 278
             }
280 279
         } else {
281 280
             $options = array_combine(
282
-                array_filter($options, function ($v) {return (bool) $v&2;}),
283
-                array_filter($options, function ($v) {return (bool) ($v-1)&2;})
281
+                array_filter($options, function($v) {return (bool) $v & 2; }),
282
+                array_filter($options, function($v) {return (bool) ($v - 1) & 2; })
284 283
             );
285 284
         }
286 285
 
@@ -292,13 +291,13 @@  discard block
 block discarded – undo
292 291
         $filters = array();
293 292
         if (isset($options[PCLZIP_OPT_REMOVE_PATH])
294 293
             && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
295
-            $filters[] = function (&$key, &$value) use ($options) {
294
+            $filters[] = function(&$key, &$value) use ($options) {
296 295
                 $key = str_replace($key, null, $key);
297 296
             };
298 297
         if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
299
-            $filters[] = function (&$key, &$value) { $key = basename($key); };
298
+            $filters[] = function(&$key, &$value) { $key = basename($key); };
300 299
         if (isset($options[PCLZIP_OPT_ADD_PATH]))
301
-            $filters[] = function (&$key, &$value) use ($options) {
300
+            $filters[] = function(&$key, &$value) use ($options) {
302 301
                 $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/').'/'.
303 302
                     ltrim($key, '/');
304 303
             };
@@ -306,16 +305,16 @@  discard block
 block discarded – undo
306 305
         if (isset($options[PCLZIP_CB_PRE_EXTRACT])
307 306
             && is_callable($options[PCLZIP_CB_PRE_EXTRACT]))
308 307
             $preExtractCallback = $options[PCLZIP_CB_PRE_EXTRACT];
309
-        else $preExtractCallback = function () { return 1; };
308
+        else $preExtractCallback = function() { return 1; };
310 309
 
311 310
         if (isset($options[PCLZIP_CB_POST_EXTRACT])
312 311
             && is_callable($options[PCLZIP_CB_POST_EXTRACT]))
313 312
             $postExtractCallback = $options[PCLZIP_CB_POST_EXTRACT];
314
-        else $postExtractCallback = function () { return 1; };
313
+        else $postExtractCallback = function() { return 1; };
315 314
 
316 315
         // exact matching
317 316
         if (isset($options[PCLZIP_OPT_BY_NAME]))
318
-            $selectFilter = function ($key, $value) use ($options) {
317
+            $selectFilter = function($key, $value) use ($options) {
319 318
                 $allowedNames = is_array($options[PCLZIP_OPT_BY_NAME])
320 319
                     ? $options[PCLZIP_OPT_BY_NAME]
321 320
                     : explode(',', $options[PCLZIP_OPT_BY_NAME]);
@@ -340,21 +339,21 @@  discard block
 block discarded – undo
340 339
             };
341 340
         // <ereg> rule
342 341
         else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg'))
343
-            $selectFilter = function ($key, $value) use ($options) {
342
+            $selectFilter = function($key, $value) use ($options) {
344 343
                 return (ereg($options[PCLZIP_OPT_BY_EREG], $key) !== false)
345 344
                     ? self::SELECT_FILTER_PASS
346 345
                     : self::SELECT_FILTER_REFUSE;
347 346
             };
348 347
         // <preg_match> rule
349 348
         else if (isset($options[PCLZIP_OPT_BY_PREG]))
350
-            $selectFilter = function ($key, $value) use ($options) {
349
+            $selectFilter = function($key, $value) use ($options) {
351 350
                 return preg_match($options[PCLZIP_OPT_BY_PREG], $key)
352 351
                     ? self::SELECT_FILTER_PASS
353 352
                     : self::SELECT_FILTER_REFUSE;
354 353
             };
355 354
         // index rule
356 355
         else if (isset($options[PCLZIP_OPT_BY_INDEX]))
357
-            $selectFilter = function ($key, $value, $index) use ($options) {
356
+            $selectFilter = function($key, $value, $index) use ($options) {
358 357
                 $allowedIndexes = array();
359 358
                 foreach ($options[PCLZIP_OPT_BY_INDEX] as $rule) {
360 359
                     $parts = explode('-', $rule);
@@ -368,7 +367,7 @@  discard block
 block discarded – undo
368 367
             };
369 368
         // no rule
370 369
         else
371
-            $selectFilter = function () { return self::SELECT_FILTER_PASS; };
370
+            $selectFilter = function() { return self::SELECT_FILTER_PASS; };
372 371
 
373 372
         if (isset($options[PCLZIP_OPT_EXTRACT_AS_STRING]))
374 373
             $anotherOutputFormat = PCLZIP_OPT_EXTRACT_AS_STRING;
@@ -560,8 +559,8 @@  discard block
 block discarded – undo
560 559
             }
561 560
         } else {
562 561
             $options = array_combine(
563
-                array_filter($options, function ($v) {return (bool) $v&2;}),
564
-                array_filter($options, function ($v) {return (bool) ($v-1)&2;})
562
+                array_filter($options, function($v) {return (bool) $v & 2; }),
563
+                array_filter($options, function($v) {return (bool) ($v - 1) & 2; })
565 564
             );
566 565
         }
567 566
 
@@ -569,13 +568,13 @@  discard block
 block discarded – undo
569 568
         $filters = array();
570 569
         if (isset($options[PCLZIP_OPT_REMOVE_PATH])
571 570
             && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
572
-            $filters[] = function (&$key, &$value) use ($options) {
571
+            $filters[] = function(&$key, &$value) use ($options) {
573 572
                 $key = str_replace($key, null, $key);
574 573
             };
575 574
         if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
576
-            $filters[] = function (&$key, &$value) { $key = basename($key); };
575
+            $filters[] = function(&$key, &$value) { $key = basename($key); };
577 576
         if (isset($options[PCLZIP_OPT_ADD_PATH]))
578
-            $filters[] = function (&$key, &$value) use ($options) {
577
+            $filters[] = function(&$key, &$value) use ($options) {
579 578
                 $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/').'/'.
580 579
                     ltrim($key, '/');
581 580
             };
@@ -583,12 +582,12 @@  discard block
 block discarded – undo
583 582
         if (isset($options[PCLZIP_CB_PRE_ADD])
584 583
             && is_callable($options[PCLZIP_CB_PRE_ADD]))
585 584
             $preAddCallback = $options[PCLZIP_CB_PRE_ADD];
586
-        else $preAddCallback = function () { return 1; };
585
+        else $preAddCallback = function() { return 1; };
587 586
 
588 587
         if (isset($options[PCLZIP_CB_POST_ADD])
589 588
             && is_callable($options[PCLZIP_CB_POST_ADD]))
590 589
             $postAddCallback = $options[PCLZIP_CB_POST_ADD];
591
-        else $postAddCallback = function () { return 1; };
590
+        else $postAddCallback = function() { return 1; };
592 591
 
593 592
         if (isset($options[PCLZIP_OPT_COMMENT]))
594 593
             $this->archive->setArchiveComment($options[PCLZIP_OPT_COMMENT]);
@@ -597,14 +596,14 @@  discard block
 block discarded – undo
597 596
                 ($comment = $this->archive->getArchiveComment() !== false)
598 597
                     ? $comment : null;
599 598
             $this->archive->setArchiveComment(
600
-                $comment . $options[PCLZIP_OPT_ADD_COMMENT]);
599
+                $comment.$options[PCLZIP_OPT_ADD_COMMENT]);
601 600
         }
602 601
         if (isset($options[PCLZIP_OPT_PREPEND_COMMENT])) {
603 602
             $comment =
604 603
                 ($comment = $this->archive->getArchiveComment() !== false)
605 604
                     ? $comment : null;
606 605
             $this->archive->setArchiveComment(
607
-                $options[PCLZIP_OPT_PREPEND_COMMENT] . $comment);
606
+                $options[PCLZIP_OPT_PREPEND_COMMENT].$comment);
608 607
         }
609 608
 
610 609
 
@@ -640,13 +639,13 @@  discard block
 block discarded – undo
640 639
         $report = array();
641 640
         $options = func_get_args();
642 641
         $options = array_combine(
643
-            array_filter($options, function ($v) {return (bool) $v&2;}),
644
-            array_filter($options, function ($v) {return (bool) ($v-1)&2;})
642
+            array_filter($options, function($v) {return (bool) $v & 2; }),
643
+            array_filter($options, function($v) {return (bool) ($v - 1) & 2; })
645 644
         );
646 645
 
647 646
         // exact matching
648 647
         if (isset($options[PCLZIP_OPT_BY_NAME]))
649
-            $selectFilter = function ($key, $value) use ($options) {
648
+            $selectFilter = function($key, $value) use ($options) {
650 649
                 $allowedNames = is_array($options[PCLZIP_OPT_BY_NAME])
651 650
                     ? $options[PCLZIP_OPT_BY_NAME]
652 651
                     : explode(',', $options[PCLZIP_OPT_BY_NAME]);
@@ -671,21 +670,21 @@  discard block
 block discarded – undo
671 670
             };
672 671
         // <ereg> rule
673 672
         else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg'))
674
-            $selectFilter = function ($key, $value) use ($options) {
673
+            $selectFilter = function($key, $value) use ($options) {
675 674
                 return (ereg($options[PCLZIP_OPT_BY_EREG], $key) !== false)
676 675
                     ? self::SELECT_FILTER_PASS
677 676
                     : self::SELECT_FILTER_REFUSE;
678 677
             };
679 678
         // <preg_match> rule
680 679
         else if (isset($options[PCLZIP_OPT_BY_PREG]))
681
-            $selectFilter = function ($key, $value) use ($options) {
680
+            $selectFilter = function($key, $value) use ($options) {
682 681
                 return preg_match($options[PCLZIP_OPT_BY_PREG], $key)
683 682
                     ? self::SELECT_FILTER_PASS
684 683
                     : self::SELECT_FILTER_REFUSE;
685 684
             };
686 685
         // index rule
687 686
         else if (isset($options[PCLZIP_OPT_BY_INDEX]))
688
-            $selectFilter = function ($key, $value, $index) use ($options) {
687
+            $selectFilter = function($key, $value, $index) use ($options) {
689 688
                 $allowedIndexes = array();
690 689
                 foreach ($options[PCLZIP_OPT_BY_INDEX] as $rule) {
691 690
                     $parts = explode('-', $rule);
@@ -700,7 +699,7 @@  discard block
 block discarded – undo
700 699
             };
701 700
         // no rule
702 701
         else
703
-            $selectFilter = function () { return self::SELECT_FILTER_PASS; };
702
+            $selectFilter = function() { return self::SELECT_FILTER_PASS; };
704 703
 
705 704
         foreach ($this->listContent() as $file_header) {
706 705
             // select by select rule
@@ -780,7 +779,7 @@  discard block
 block discarded – undo
780 779
             }
781 780
         }
782 781
 
783
-        call_user_func(function ($directory) {
782
+        call_user_func(function($directory) {
784 783
             foreach (glob($directory.'/*') as $f) {
785 784
                 if (is_dir($f)) call_user_func(__FUNCTION__, $f);
786 785
                 else unlink($f);
Please login to merge, or discard this patch.
Braces   +173 added lines, -96 removed lines patch added patch discarded remove patch
@@ -132,8 +132,11 @@  discard block
 block discarded – undo
132 132
      */
133 133
     public function create($content)
134 134
     {
135
-        if (is_array($content)) $paths_list = $content;
136
-        else $paths_list = explode(',', $content);
135
+        if (is_array($content)) {
136
+         $paths_list = $content;
137
+        } else {
138
+         $paths_list = explode(',', $content);
139
+        }
137 140
         $report = array();
138 141
 
139 142
         $options = func_get_args();
@@ -155,29 +158,41 @@  discard block
 block discarded – undo
155 158
         // filters initiation
156 159
         $filters = array();
157 160
         if (isset($options[PCLZIP_OPT_REMOVE_PATH])
158
-            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
159
-            $filters[] = function (&$key, &$value) use ($options) {
160
-                $key = str_replace($key, null, $key); };
161
-        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
162
-            $filters[] = function (&$key, &$value) { $key = basename($key); };
163
-        if (isset($options[PCLZIP_OPT_ADD_PATH]))
164
-            $filters[] = function (&$key, &$value) use ($options) {
161
+            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
162
+                    $filters[] = function (&$key, &$value) use ($options) {
163
+                $key = str_replace($key, null, $key);
164
+        }
165
+        };
166
+        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
167
+                    $filters[] = function (&$key, &$value) { $key = basename($key);
168
+        }
169
+        };
170
+        if (isset($options[PCLZIP_OPT_ADD_PATH])) {
171
+                    $filters[] = function (&$key, &$value) use ($options) {
165 172
                 $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/').'/'.
166 173
                     ltrim($key, '/');
174
+        }
167 175
             };
168 176
 
169 177
         if (isset($options[PCLZIP_CB_PRE_ADD])
170
-            && is_callable($options[PCLZIP_CB_PRE_ADD]))
171
-            $preAddCallback = $options[PCLZIP_CB_PRE_ADD];
172
-        else $preAddCallback = function () { return 1; };
178
+            && is_callable($options[PCLZIP_CB_PRE_ADD])) {
179
+                    $preAddCallback = $options[PCLZIP_CB_PRE_ADD];
180
+        } else {
181
+         $preAddCallback = function () { return 1;
182
+        }
183
+        };
173 184
 
174 185
         if (isset($options[PCLZIP_CB_POST_ADD])
175
-            && is_callable($options[PCLZIP_CB_POST_ADD]))
176
-            $postAddCallback = $options[PCLZIP_CB_POST_ADD];
177
-        else $postAddCallback = function () { return 1; };
186
+            && is_callable($options[PCLZIP_CB_POST_ADD])) {
187
+                    $postAddCallback = $options[PCLZIP_CB_POST_ADD];
188
+        } else {
189
+         $postAddCallback = function () { return 1;
190
+        }
191
+        };
178 192
 
179
-        if (isset($options[PCLZIP_OPT_COMMENT]))
180
-            $this->archive->setArchiveComment($options[PCLZIP_OPT_COMMENT]);
193
+        if (isset($options[PCLZIP_OPT_COMMENT])) {
194
+                    $this->archive->setArchiveComment($options[PCLZIP_OPT_COMMENT]);
195
+        }
181 196
 
182 197
         // scan filesystem for files list
183 198
         $files_list = array();
@@ -208,20 +223,23 @@  discard block
 block discarded – undo
208 223
             // apply filters to a file
209 224
             $localname = $file_to_add;
210 225
             $filename = $file_to_add;
211
-            foreach ($filters as $filter)
212
-                call_user_func($filter, $localname, $filename);
226
+            foreach ($filters as $filter) {
227
+                            call_user_func($filter, $localname, $filename);
228
+            }
213 229
             $file_header = $this->createFileHeader($localname, $filename);
214 230
             if (call_user_func($preAddCallback, $file_header) == 1) {
215 231
                 //
216 232
                 // Check for max length > 255
217 233
                 //
218
-                if (strlen(basename($file_header->stored_filename)) > 255)
219
-                    $file_header->status = 'filename_too_long';
220
-                if (is_file($filename))
221
-                    $this->archive->addFile($file_header->filename,
234
+                if (strlen(basename($file_header->stored_filename)) > 255) {
235
+                                    $file_header->status = 'filename_too_long';
236
+                }
237
+                if (is_file($filename)) {
238
+                                    $this->archive->addFile($file_header->filename,
222 239
                         $file_header->stored_filename);
223
-                else if (is_dir($filename))
224
-                    $this->archive->addEmptyDir($file_header->stored_filename);
240
+                } else if (is_dir($filename)) {
241
+                                    $this->archive->addEmptyDir($file_header->stored_filename);
242
+                }
225 243
             } else {
226 244
                 //
227 245
                 // File was skipped
@@ -285,40 +303,53 @@  discard block
 block discarded – undo
285 303
         }
286 304
 
287 305
         // filters initiation
288
-        if (isset($options[PCLZIP_OPT_PATH]))
289
-            $extractPath = rtrim($options[PCLZIP_OPT_PATH], '/');
290
-        else $extractPath = rtrim(getcwd(), '/');
306
+        if (isset($options[PCLZIP_OPT_PATH])) {
307
+                    $extractPath = rtrim($options[PCLZIP_OPT_PATH], '/');
308
+        } else {
309
+         $extractPath = rtrim(getcwd(), '/');
310
+        }
291 311
 
292 312
         $filters = array();
293 313
         if (isset($options[PCLZIP_OPT_REMOVE_PATH])
294
-            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
295
-            $filters[] = function (&$key, &$value) use ($options) {
314
+            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
315
+                    $filters[] = function (&$key, &$value) use ($options) {
296 316
                 $key = str_replace($key, null, $key);
317
+        }
297 318
             };
298
-        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
299
-            $filters[] = function (&$key, &$value) { $key = basename($key); };
300
-        if (isset($options[PCLZIP_OPT_ADD_PATH]))
301
-            $filters[] = function (&$key, &$value) use ($options) {
319
+        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
320
+                    $filters[] = function (&$key, &$value) { $key = basename($key);
321
+        }
322
+        };
323
+        if (isset($options[PCLZIP_OPT_ADD_PATH])) {
324
+                    $filters[] = function (&$key, &$value) use ($options) {
302 325
                 $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/').'/'.
303 326
                     ltrim($key, '/');
327
+        }
304 328
             };
305 329
 
306 330
         if (isset($options[PCLZIP_CB_PRE_EXTRACT])
307
-            && is_callable($options[PCLZIP_CB_PRE_EXTRACT]))
308
-            $preExtractCallback = $options[PCLZIP_CB_PRE_EXTRACT];
309
-        else $preExtractCallback = function () { return 1; };
331
+            && is_callable($options[PCLZIP_CB_PRE_EXTRACT])) {
332
+                    $preExtractCallback = $options[PCLZIP_CB_PRE_EXTRACT];
333
+        } else {
334
+         $preExtractCallback = function () { return 1;
335
+        }
336
+        };
310 337
 
311 338
         if (isset($options[PCLZIP_CB_POST_EXTRACT])
312
-            && is_callable($options[PCLZIP_CB_POST_EXTRACT]))
313
-            $postExtractCallback = $options[PCLZIP_CB_POST_EXTRACT];
314
-        else $postExtractCallback = function () { return 1; };
339
+            && is_callable($options[PCLZIP_CB_POST_EXTRACT])) {
340
+                    $postExtractCallback = $options[PCLZIP_CB_POST_EXTRACT];
341
+        } else {
342
+         $postExtractCallback = function () { return 1;
343
+        }
344
+        };
315 345
 
316 346
         // exact matching
317
-        if (isset($options[PCLZIP_OPT_BY_NAME]))
318
-            $selectFilter = function ($key, $value) use ($options) {
347
+        if (isset($options[PCLZIP_OPT_BY_NAME])) {
348
+                    $selectFilter = function ($key, $value) use ($options) {
319 349
                 $allowedNames = is_array($options[PCLZIP_OPT_BY_NAME])
320 350
                     ? $options[PCLZIP_OPT_BY_NAME]
321 351
                     : explode(',', $options[PCLZIP_OPT_BY_NAME]);
352
+        }
322 353
                 foreach ($allowedNames as $name) {
323 354
                     // select directory with nested files
324 355
                     if (in_array(substr($name, -1), array('/', '\\'))) {
@@ -339,50 +370,64 @@  discard block
 block discarded – undo
339 370
                 return self::SELECT_FILTER_REFUSE;
340 371
             };
341 372
         // <ereg> rule
342
-        else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg'))
343
-            $selectFilter = function ($key, $value) use ($options) {
373
+        else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg')) {
374
+                    $selectFilter = function ($key, $value) use ($options) {
344 375
                 return (ereg($options[PCLZIP_OPT_BY_EREG], $key) !== false)
345 376
                     ? self::SELECT_FILTER_PASS
346 377
                     : self::SELECT_FILTER_REFUSE;
378
+        }
347 379
             };
348 380
         // <preg_match> rule
349
-        else if (isset($options[PCLZIP_OPT_BY_PREG]))
350
-            $selectFilter = function ($key, $value) use ($options) {
381
+        else if (isset($options[PCLZIP_OPT_BY_PREG])) {
382
+                    $selectFilter = function ($key, $value) use ($options) {
351 383
                 return preg_match($options[PCLZIP_OPT_BY_PREG], $key)
352 384
                     ? self::SELECT_FILTER_PASS
353 385
                     : self::SELECT_FILTER_REFUSE;
386
+        }
354 387
             };
355 388
         // index rule
356
-        else if (isset($options[PCLZIP_OPT_BY_INDEX]))
357
-            $selectFilter = function ($key, $value, $index) use ($options) {
389
+        else if (isset($options[PCLZIP_OPT_BY_INDEX])) {
390
+                    $selectFilter = function ($key, $value, $index) use ($options) {
358 391
                 $allowedIndexes = array();
392
+        }
359 393
                 foreach ($options[PCLZIP_OPT_BY_INDEX] as $rule) {
360 394
                     $parts = explode('-', $rule);
361
-                    if (count($parts) == 1) $allowedIndexes[] = $rule;
362
-                    else $allowedIndexes = array_merge(
395
+                    if (count($parts) == 1) {
396
+                     $allowedIndexes[] = $rule;
397
+                    } else {
398
+                     $allowedIndexes = array_merge(
363 399
                         range($parts[0], $parts[1]), $allowedIndexes);
400
+                    }
364 401
                 }
365 402
 
366 403
                 return in_array($index, $allowedIndexes) ? self::SELECT_FILTER_PASS
367 404
                     : self::SELECT_FILTER_REFUSE;
368 405
             };
369 406
         // no rule
370
-        else
371
-            $selectFilter = function () { return self::SELECT_FILTER_PASS; };
407
+        else {
408
+                    $selectFilter = function () { return self::SELECT_FILTER_PASS;
409
+        }
410
+        };
372 411
 
373
-        if (isset($options[PCLZIP_OPT_EXTRACT_AS_STRING]))
374
-            $anotherOutputFormat = PCLZIP_OPT_EXTRACT_AS_STRING;
375
-        else if (isset($options[PCLZIP_OPT_EXTRACT_IN_OUTPUT]))
376
-            $anotherOutputFormat = PCLZIP_OPT_EXTRACT_IN_OUTPUT;
377
-        else $anotherOutputFormat = false;
412
+        if (isset($options[PCLZIP_OPT_EXTRACT_AS_STRING])) {
413
+                    $anotherOutputFormat = PCLZIP_OPT_EXTRACT_AS_STRING;
414
+        } else if (isset($options[PCLZIP_OPT_EXTRACT_IN_OUTPUT])) {
415
+                    $anotherOutputFormat = PCLZIP_OPT_EXTRACT_IN_OUTPUT;
416
+        } else {
417
+         $anotherOutputFormat = false;
418
+        }
378 419
 
379
-        if (isset($options[PCLZIP_OPT_REPLACE_NEWER]))
380
-            $doNotReplaceNewer = false;
381
-        else $doNotReplaceNewer = true;
420
+        if (isset($options[PCLZIP_OPT_REPLACE_NEWER])) {
421
+                    $doNotReplaceNewer = false;
422
+        } else {
423
+         $doNotReplaceNewer = true;
424
+        }
382 425
 
383
-        if (isset($options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION]))
384
-            $restrictExtractDir = $options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION];
385
-        else $restrictExtractDir = false;
426
+        if (isset($options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION])) {
427
+                    $restrictExtractDir = $options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION];
428
+        } else {
429
+         $restrictExtractDir = false;
430
+        }
386 431
 
387 432
         $report = array();
388 433
         foreach ($this->listContent() as $file_header) {
@@ -452,8 +497,10 @@  discard block
 block discarded – undo
452 497
             // extract content
453 498
             else if ($anotherOutputFormat === false) {
454 499
                 // apply path filters
455
-                foreach ($filters as $filter) call_user_func($filter,
500
+                foreach ($filters as $filter) {
501
+                 call_user_func($filter,
456 502
                     $file_header->stored_filename, $file_header->filename);
503
+                }
457 504
                 // dir extraction process
458 505
                 if ($file_header->folder) {
459 506
                     // if dir doesn't exist
@@ -545,8 +592,11 @@  discard block
 block discarded – undo
545 592
      */
546 593
     public function add($content)
547 594
     {
548
-        if (is_array($content)) $paths_list = $content;
549
-        else $paths_list = array_map(explode(',', $content));
595
+        if (is_array($content)) {
596
+         $paths_list = $content;
597
+        } else {
598
+         $paths_list = array_map(explode(',', $content));
599
+        }
550 600
         $report = array();
551 601
 
552 602
         $options = func_get_args();
@@ -568,30 +618,41 @@  discard block
 block discarded – undo
568 618
         // filters initiation
569 619
         $filters = array();
570 620
         if (isset($options[PCLZIP_OPT_REMOVE_PATH])
571
-            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
572
-            $filters[] = function (&$key, &$value) use ($options) {
621
+            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
622
+                    $filters[] = function (&$key, &$value) use ($options) {
573 623
                 $key = str_replace($key, null, $key);
624
+        }
574 625
             };
575
-        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
576
-            $filters[] = function (&$key, &$value) { $key = basename($key); };
577
-        if (isset($options[PCLZIP_OPT_ADD_PATH]))
578
-            $filters[] = function (&$key, &$value) use ($options) {
626
+        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
627
+                    $filters[] = function (&$key, &$value) { $key = basename($key);
628
+        }
629
+        };
630
+        if (isset($options[PCLZIP_OPT_ADD_PATH])) {
631
+                    $filters[] = function (&$key, &$value) use ($options) {
579 632
                 $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/').'/'.
580 633
                     ltrim($key, '/');
634
+        }
581 635
             };
582 636
 
583 637
         if (isset($options[PCLZIP_CB_PRE_ADD])
584
-            && is_callable($options[PCLZIP_CB_PRE_ADD]))
585
-            $preAddCallback = $options[PCLZIP_CB_PRE_ADD];
586
-        else $preAddCallback = function () { return 1; };
638
+            && is_callable($options[PCLZIP_CB_PRE_ADD])) {
639
+                    $preAddCallback = $options[PCLZIP_CB_PRE_ADD];
640
+        } else {
641
+         $preAddCallback = function () { return 1;
642
+        }
643
+        };
587 644
 
588 645
         if (isset($options[PCLZIP_CB_POST_ADD])
589
-            && is_callable($options[PCLZIP_CB_POST_ADD]))
590
-            $postAddCallback = $options[PCLZIP_CB_POST_ADD];
591
-        else $postAddCallback = function () { return 1; };
646
+            && is_callable($options[PCLZIP_CB_POST_ADD])) {
647
+                    $postAddCallback = $options[PCLZIP_CB_POST_ADD];
648
+        } else {
649
+         $postAddCallback = function () { return 1;
650
+        }
651
+        };
592 652
 
593
-        if (isset($options[PCLZIP_OPT_COMMENT]))
594
-            $this->archive->setArchiveComment($options[PCLZIP_OPT_COMMENT]);
653
+        if (isset($options[PCLZIP_OPT_COMMENT])) {
654
+                    $this->archive->setArchiveComment($options[PCLZIP_OPT_COMMENT]);
655
+        }
595 656
         if (isset($options[PCLZIP_OPT_ADD_COMMENT])) {
596 657
             $comment =
597 658
                 ($comment = $this->archive->getArchiveComment() !== false)
@@ -645,11 +706,12 @@  discard block
 block discarded – undo
645 706
         );
646 707
 
647 708
         // exact matching
648
-        if (isset($options[PCLZIP_OPT_BY_NAME]))
649
-            $selectFilter = function ($key, $value) use ($options) {
709
+        if (isset($options[PCLZIP_OPT_BY_NAME])) {
710
+                    $selectFilter = function ($key, $value) use ($options) {
650 711
                 $allowedNames = is_array($options[PCLZIP_OPT_BY_NAME])
651 712
                     ? $options[PCLZIP_OPT_BY_NAME]
652 713
                     : explode(',', $options[PCLZIP_OPT_BY_NAME]);
714
+        }
653 715
                 foreach ($allowedNames as $name) {
654 716
                     // select directory with nested files
655 717
                     if (in_array(substr($name, -1), array('/', '\\'))) {
@@ -670,28 +732,34 @@  discard block
 block discarded – undo
670 732
                 return self::SELECT_FILTER_REFUSE;
671 733
             };
672 734
         // <ereg> rule
673
-        else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg'))
674
-            $selectFilter = function ($key, $value) use ($options) {
735
+        else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg')) {
736
+                    $selectFilter = function ($key, $value) use ($options) {
675 737
                 return (ereg($options[PCLZIP_OPT_BY_EREG], $key) !== false)
676 738
                     ? self::SELECT_FILTER_PASS
677 739
                     : self::SELECT_FILTER_REFUSE;
740
+        }
678 741
             };
679 742
         // <preg_match> rule
680
-        else if (isset($options[PCLZIP_OPT_BY_PREG]))
681
-            $selectFilter = function ($key, $value) use ($options) {
743
+        else if (isset($options[PCLZIP_OPT_BY_PREG])) {
744
+                    $selectFilter = function ($key, $value) use ($options) {
682 745
                 return preg_match($options[PCLZIP_OPT_BY_PREG], $key)
683 746
                     ? self::SELECT_FILTER_PASS
684 747
                     : self::SELECT_FILTER_REFUSE;
748
+        }
685 749
             };
686 750
         // index rule
687
-        else if (isset($options[PCLZIP_OPT_BY_INDEX]))
688
-            $selectFilter = function ($key, $value, $index) use ($options) {
751
+        else if (isset($options[PCLZIP_OPT_BY_INDEX])) {
752
+                    $selectFilter = function ($key, $value, $index) use ($options) {
689 753
                 $allowedIndexes = array();
754
+        }
690 755
                 foreach ($options[PCLZIP_OPT_BY_INDEX] as $rule) {
691 756
                     $parts = explode('-', $rule);
692
-                    if (count($parts) == 1) $allowedIndexes[] = $rule;
693
-                    else $allowedIndexes = array_merge(
757
+                    if (count($parts) == 1) {
758
+                     $allowedIndexes[] = $rule;
759
+                    } else {
760
+                     $allowedIndexes = array_merge(
694 761
                         range($parts[0], $parts[1]), $allowedIndexes);
762
+                    }
695 763
                 }
696 764
 
697 765
                 return in_array($index, $allowedIndexes)
@@ -699,8 +767,10 @@  discard block
 block discarded – undo
699 767
                     : self::SELECT_FILTER_REFUSE;
700 768
             };
701 769
         // no rule
702
-        else
703
-            $selectFilter = function () { return self::SELECT_FILTER_PASS; };
770
+        else {
771
+                    $selectFilter = function () { return self::SELECT_FILTER_PASS;
772
+        }
773
+        };
704 774
 
705 775
         foreach ($this->listContent() as $file_header) {
706 776
             // select by select rule
@@ -752,8 +822,12 @@  discard block
 block discarded – undo
752 822
         }
753 823
 
754 824
         $tempDir = tempnam(PCLZIP_TEMPORARY_DIR, 'merging');
755
-        if (file_exists($tempDir)) unlink($tempDir);
756
-        if (!mkdir($tempDir)) return 0;
825
+        if (file_exists($tempDir)) {
826
+         unlink($tempDir);
827
+        }
828
+        if (!mkdir($tempDir)) {
829
+         return 0;
830
+        }
757 831
 
758 832
         // go through archive content list and copy all files
759 833
         foreach ($a->getFileNames() as $filename) {
@@ -782,8 +856,11 @@  discard block
 block discarded – undo
782 856
 
783 857
         call_user_func(function ($directory) {
784 858
             foreach (glob($directory.'/*') as $f) {
785
-                if (is_dir($f)) call_user_func(__FUNCTION__, $f);
786
-                else unlink($f);
859
+                if (is_dir($f)) {
860
+                 call_user_func(__FUNCTION__, $f);
861
+                } else {
862
+                 unlink($f);
863
+                }
787 864
             }
788 865
         }, $tempDir);
789 866
 
Please login to merge, or discard this patch.