FirstNamesDeclension - Code Metrics - Inspection of "Restructure" - wapmorgan/Morphos - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.1.x ( 7ab7e8 )

by f

created 2017-01-28 18:09 UTC

FirstNamesDeclension C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	204
Duplicated Lines	14.71 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	30
loc	204
rs	6.3005
c	0
b	0
f	0
wmc	58
lcom	1
cbo	2

5 Methods

Rating	Name	Duplication	Size	Complexity
C	hasForms()	0	22	9
D	getForms()	0	144	44
A	getFormsForLev()	10	10	1
A	getFormsForPavel()	10	10	1
A	getForm()	10	10	3

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like FirstNamesDeclension often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use FirstNamesDeclension, and based on these observations, apply Extract Interface, too.

<?php
namespace morphos\Russian;

class FirstNamesDeclension extends \morphos\NamesDeclension implements Cases {
	use RussianLanguage;

	public function hasForms($name, $gender) {
		//var_dump(upper(slice($name, -1)));
		$name = lower($name);
		// man rules
		if ($gender === self::MAN) {
			// soft consonant
			if (lower(slice($name, -1)) == 'ь' && in_array(upper(slice($name, -2, -1)), self::$consonants)) {
				return true;
			} else if (in_array(upper(slice($name, -1)), array_diff(self::$consonants, array('Й', /*'Ч', 'Щ'*/)))) { // hard consonant
				return true;
			} else if (slice($name, -1) == 'й') {
				return true;
			}
		}

		// common rules
		if ((in_array(slice($name, -1), array('а', 'я')) && !in_array(upper(slice($name, -2, -1)), self::$vowels)) || in_array(slice($name, -2), array('ия', 'ья', 'ея'))) {
			return true;
		}

		return false;
	}

	public function getForms($name, $gender) {
		$name = lower($name);
		if ($gender == self::MAN) {
			if (in_array(upper(slice($name, -1)), array_diff(self::$consonants, array('Й', /*'Ч', 'Щ'*/)))) { // hard consonant
				$prefix = name($name);
				// special cases for Лев, Павел
				if ($name == 'лев')
					return $this->getFormsForLev();
				else if ($name == 'павел')
					return $this->getFormsForPavel();
				else {
					return array(
						self::IMENIT_1 => $prefix,
						self::RODIT_2 => $prefix.'а',
						self::DAT_3 => $prefix.'у',
						self::VINIT_4 => $prefix.'а',
						self::TVORIT_5 => $this->isHissingConsonant(slice($name, -1)) || slice($name, -1) == 'ц' ? $prefix.'ем' : $prefix.'ом',
						self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
					);
				}
			} else if (slice($name, -1) == 'ь' && in_array(upper(slice($name, -2, -1)), self::$consonants)) { // soft consonant
				$prefix = name(slice($name, 0, -1));
				return array(
					self::IMENIT_1 => $prefix.'ь',
					self::RODIT_2 => $prefix.'я',
					self::DAT_3 => $prefix.'ю',
					self::VINIT_4 => $prefix.'я',
					self::TVORIT_5 => $prefix.'ем',
					self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
				);
			} else if (in_array(slice($name, -2), array('ай', 'ей', 'ой', 'уй', 'яй', 'юй', 'ий'))) {
				$prefix = name(slice($name, 0, -1));
				$postfix = slice($name, -2) == 'ий' ? 'и' : 'е';
				return array(
					self::IMENIT_1 => $prefix.'й',
					self::RODIT_2 => $prefix.'я',
					self::DAT_3 => $prefix.'ю',
					self::VINIT_4 => $prefix.'я',
					self::TVORIT_5 => $prefix.'ем',
					self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.$postfix : 'о '.$prefix.$postfix,
				);
			} else if (slice($name, -1) == 'а' && ($before = slice($name, -2, -1)) && $this->isConsonant($before) && !in_array($before, array(/*'г', 'к', 'х', */'ц'))) {
				$prefix = name(slice($name, 0, -1));
				$postfix = ($this->isHissingConsonant($before) || in_array($before, array('г', 'к', 'х'))) ? 'и' : 'ы';
				return array(
					self::IMENIT_1 => $prefix.'а',
					self::RODIT_2 => $prefix.$postfix,
					self::DAT_3 => $prefix.'е',
					self::VINIT_4 => $prefix.'у',
					self::TVORIT_5 => $prefix.'ой',
					self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
				);
			} else if (slice($name, -2) == 'ия') {
				$prefix = name(slice($name, 0, -1));
				return array(
					self::IMENIT_1 => $prefix.'я',
					self::RODIT_2 => $prefix.'и',
					self::DAT_3 => $prefix.'и',
					self::VINIT_4 => $prefix.'ю',
					self::TVORIT_5 => $prefix.'ей',
					self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'и' : 'о '.$prefix.'и',
				);
			} else if (slice($name, -2) == 'ло' || slice($name, -2) == 'ко') {
				$prefix = name(slice($name, 0, -1));
				$postfix = slice($name, -2, -1) == 'к' ? 'и' : 'ы';
				return array(
					self::IMENIT_1 => $prefix.'о',
					self::RODIT_2 =>  $prefix.$postfix,
					self::DAT_3 => $prefix.'е',
					self::VINIT_4 => $prefix.'у',
					self::TVORIT_5 => $prefix.'ой',
					self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
				);
			} else {
				return false;
			}
		} else {
			if (slice($name, -1) == 'а' && ($before = (slice($name, -2, -1)))) {
				$prefix = name(slice($name, 0, -1));
				if ($before != 'ц') {
					$postfix = ($this->isHissingConsonant($before) || in_array($before, array('г', 'к', 'х'))) ? 'и' : 'ы';
					return array(
						self::IMENIT_1 => $prefix.'а',
						self::RODIT_2 => $prefix.$postfix,
						self::DAT_3 => $prefix.'е',
						self::VINIT_4 => $prefix.'у',
						self::TVORIT_5 => $prefix.'ой',
						self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
					);
				} else {
					return array(
						self::IMENIT_1 => $prefix.'а',
						self::RODIT_2 => $prefix.'ы',
						self::DAT_3 => $prefix.'е',
						self::VINIT_4 => $prefix.'у',
						self::TVORIT_5 => $prefix.'ей',
						self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
					);
				}
			} else if (slice($name, -1) == 'я' and slice($name, -2, -1) != 'и') {
				$prefix = name(slice($name, 0, -1));
				return array(
					self::IMENIT_1 => $prefix.'я',
					self::RODIT_2 => $prefix.'и',
					self::DAT_3 => $prefix.'е',
					self::VINIT_4 => $prefix.'ю',
					self::TVORIT_5 => $prefix.'ей',
					self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
				);
			} else if (slice($name, -2) == 'ия') {
				$prefix = name(slice($name, 0, -1));
				return array(
					self::IMENIT_1 => $prefix.'я',
					self::RODIT_2 => $prefix.'и',
					self::DAT_3 => $prefix.'и',
					self::VINIT_4 => $prefix.'ю',
					self::TVORIT_5 => $prefix.'ей',
					self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'и' : 'о '.$prefix.'и',
				);
			} else if (slice($name, -1) == 'ь' && $this->isConsonant(slice($name, -2, -1))) {
				$prefix = name(slice($name, 0, -1));
				return array(
					self::IMENIT_1 => $prefix.'ь',
					self::RODIT_2 => $prefix.'и',
					self::DAT_3 => $prefix.'и',
					self::VINIT_4 => $prefix.'ь',
					self::TVORIT_5 => $prefix.'ью',
					self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'и' : 'о '.$prefix.'и',
				);
			} else if ($this->isHissingConsonant(slice($name, -1))) {
				$prefix = name($name);
				return array(
					self::IMENIT_1 => $prefix,
					self::RODIT_2 => $prefix.'и',
					self::DAT_3 => $prefix.'и',
					self::VINIT_4 => $prefix,
					self::TVORIT_5 => $prefix.'ью',
					self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'и' : 'о '.$prefix.'и',
				);
			} else {
				return false;
			}
		}
	}

	private function getFormsForLev() {

		return array(
			self::IMENIT_1 => 'Лев',
			self::RODIT_2 => 'Льва',
			self::DAT_3 => 'Льву',
			self::VINIT_4 => 'Льва',
			self::TVORIT_5 => 'Львом',
			self::PREDLOJ_6 => 'о Льве',
		);
	}

	private function getFormsForPavel() {

		return array(
			self::IMENIT_1 => 'Павел',
			self::RODIT_2 => 'Павла',
			self::DAT_3 => 'Павлу',
			self::VINIT_4 => 'Павла',
			self::TVORIT_5 => 'Павлом',
			self::PREDLOJ_6 => 'о Павле',
		);
	}

	public function getForm($name, $form, $gender) {

		$forms = $this->getForms($name, $gender);
		if ($forms !== false)
			if (isset($forms[$form]))
				return $forms[$form];
			else
				return false;
		else
			return false;
	}
}


1		<?php
2		namespace morphos\Russian;
3
4		class FirstNamesDeclension extends \morphos\NamesDeclension implements Cases {
5		use RussianLanguage;
6
7		public function hasForms($name, $gender) {
8		//var_dump(upper(slice($name, -1)));
9		$name = lower($name);
10		// man rules
11		if ($gender === self::MAN) {
12		// soft consonant
13		if (lower(slice($name, -1)) == 'ь' && in_array(upper(slice($name, -2, -1)), self::$consonants)) {
14		return true;
15		} else if (in_array(upper(slice($name, -1)), array_diff(self::$consonants, array('Й', /'Ч', 'Щ'/)))) { // hard consonant
16		return true;
17		} else if (slice($name, -1) == 'й') {
18		return true;
19		}
20		}
21
22		// common rules
23		if ((in_array(slice($name, -1), array('а', 'я')) && !in_array(upper(slice($name, -2, -1)), self::$vowels)) \|\| in_array(slice($name, -2), array('ия', 'ья', 'ея'))) {
24		return true;
25		}
26
27		return false;
28		}
29
30		public function getForms($name, $gender) {
31		$name = lower($name);
32		if ($gender == self::MAN) {
33		if (in_array(upper(slice($name, -1)), array_diff(self::$consonants, array('Й', /'Ч', 'Щ'/)))) { // hard consonant
34		$prefix = name($name);
35		// special cases for Лев, Павел
36		if ($name == 'лев')
37		return $this->getFormsForLev();
38		else if ($name == 'павел')
39		return $this->getFormsForPavel();
40		else {
41		return array(
42		self::IMENIT_1 => $prefix,
43		self::RODIT_2 => $prefix.'а',
44		self::DAT_3 => $prefix.'у',
45		self::VINIT_4 => $prefix.'а',
46		self::TVORIT_5 => $this->isHissingConsonant(slice($name, -1)) \|\| slice($name, -1) == 'ц' ? $prefix.'ем' : $prefix.'ом',
47		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
48		);
49		}
50		} else if (slice($name, -1) == 'ь' && in_array(upper(slice($name, -2, -1)), self::$consonants)) { // soft consonant
51		$prefix = name(slice($name, 0, -1));
52		return array(
53		self::IMENIT_1 => $prefix.'ь',
54		self::RODIT_2 => $prefix.'я',
55		self::DAT_3 => $prefix.'ю',
56		self::VINIT_4 => $prefix.'я',
57		self::TVORIT_5 => $prefix.'ем',
58		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
59		);
60		} else if (in_array(slice($name, -2), array('ай', 'ей', 'ой', 'уй', 'яй', 'юй', 'ий'))) {
61		$prefix = name(slice($name, 0, -1));
62		$postfix = slice($name, -2) == 'ий' ? 'и' : 'е';
63		return array(
64		self::IMENIT_1 => $prefix.'й',
65		self::RODIT_2 => $prefix.'я',
66		self::DAT_3 => $prefix.'ю',
67		self::VINIT_4 => $prefix.'я',
68		self::TVORIT_5 => $prefix.'ем',
69		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.$postfix : 'о '.$prefix.$postfix,
70		);
71		} else if (slice($name, -1) == 'а' && ($before = slice($name, -2, -1)) && $this->isConsonant($before) && !in_array($before, array(/'г', 'к', 'х', /'ц'))) {
72		$prefix = name(slice($name, 0, -1));
73		$postfix = ($this->isHissingConsonant($before) \|\| in_array($before, array('г', 'к', 'х'))) ? 'и' : 'ы';
74		return array(
75		self::IMENIT_1 => $prefix.'а',
76		self::RODIT_2 => $prefix.$postfix,
77		self::DAT_3 => $prefix.'е',
78		self::VINIT_4 => $prefix.'у',
79		self::TVORIT_5 => $prefix.'ой',
80		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
81		);
82		} else if (slice($name, -2) == 'ия') {
83		$prefix = name(slice($name, 0, -1));
84		return array(
85		self::IMENIT_1 => $prefix.'я',
86		self::RODIT_2 => $prefix.'и',
87		self::DAT_3 => $prefix.'и',
88		self::VINIT_4 => $prefix.'ю',
89		self::TVORIT_5 => $prefix.'ей',
90		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'и' : 'о '.$prefix.'и',
91		);
92		} else if (slice($name, -2) == 'ло' \|\| slice($name, -2) == 'ко') {
93		$prefix = name(slice($name, 0, -1));
94		$postfix = slice($name, -2, -1) == 'к' ? 'и' : 'ы';
95		return array(
96		self::IMENIT_1 => $prefix.'о',
97		self::RODIT_2 => $prefix.$postfix,
98		self::DAT_3 => $prefix.'е',
99		self::VINIT_4 => $prefix.'у',
100		self::TVORIT_5 => $prefix.'ой',
101		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
102		);
103		} else {
104		return false;
105		}
106		} else {
107		if (slice($name, -1) == 'а' && ($before = (slice($name, -2, -1)))) {
108		$prefix = name(slice($name, 0, -1));
109		if ($before != 'ц') {
110		$postfix = ($this->isHissingConsonant($before) \|\| in_array($before, array('г', 'к', 'х'))) ? 'и' : 'ы';
111		return array(
112		self::IMENIT_1 => $prefix.'а',
113		self::RODIT_2 => $prefix.$postfix,
114		self::DAT_3 => $prefix.'е',
115		self::VINIT_4 => $prefix.'у',
116		self::TVORIT_5 => $prefix.'ой',
117		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
118		);
119		} else {
120		return array(
121		self::IMENIT_1 => $prefix.'а',
122		self::RODIT_2 => $prefix.'ы',
123		self::DAT_3 => $prefix.'е',
124		self::VINIT_4 => $prefix.'у',
125		self::TVORIT_5 => $prefix.'ей',
126		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
127		);
128		}
129		} else if (slice($name, -1) == 'я' and slice($name, -2, -1) != 'и') {
130		$prefix = name(slice($name, 0, -1));
131		return array(
132		self::IMENIT_1 => $prefix.'я',
133		self::RODIT_2 => $prefix.'и',
134		self::DAT_3 => $prefix.'е',
135		self::VINIT_4 => $prefix.'ю',
136		self::TVORIT_5 => $prefix.'ей',
137		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'е' : 'о '.$prefix.'е',
138		);
139		} else if (slice($name, -2) == 'ия') {
140		$prefix = name(slice($name, 0, -1));
141		return array(
142		self::IMENIT_1 => $prefix.'я',
143		self::RODIT_2 => $prefix.'и',
144		self::DAT_3 => $prefix.'и',
145		self::VINIT_4 => $prefix.'ю',
146		self::TVORIT_5 => $prefix.'ей',
147		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'и' : 'о '.$prefix.'и',
148		);
149		} else if (slice($name, -1) == 'ь' && $this->isConsonant(slice($name, -2, -1))) {
150		$prefix = name(slice($name, 0, -1));
151		return array(
152		self::IMENIT_1 => $prefix.'ь',
153		self::RODIT_2 => $prefix.'и',
154		self::DAT_3 => $prefix.'и',
155		self::VINIT_4 => $prefix.'ь',
156		self::TVORIT_5 => $prefix.'ью',
157		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'и' : 'о '.$prefix.'и',
158		);
159		} else if ($this->isHissingConsonant(slice($name, -1))) {
160		$prefix = name($name);
161		return array(
162		self::IMENIT_1 => $prefix,
163		self::RODIT_2 => $prefix.'и',
164		self::DAT_3 => $prefix.'и',
165		self::VINIT_4 => $prefix,
166		self::TVORIT_5 => $prefix.'ью',
167		self::PREDLOJ_6 => in_array(upper(slice($name, 0, 1)), self::$vowels) ? 'об '.$prefix.'и' : 'о '.$prefix.'и',
168		);
169		} else {
170		return false;
171		}
172		}
173		}
174
175	View Code Duplication	private function getFormsForLev() {
		0 ignored issues – show Duplication introduced 2016-12-07 14:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
176		return array(
177		self::IMENIT_1 => 'Лев',
178		self::RODIT_2 => 'Льва',
179		self::DAT_3 => 'Льву',
180		self::VINIT_4 => 'Льва',
181		self::TVORIT_5 => 'Львом',
182		self::PREDLOJ_6 => 'о Льве',
183		);
184		}
185
186	View Code Duplication	private function getFormsForPavel() {
		0 ignored issues – show Duplication introduced 2016-12-07 14:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
187		return array(
188		self::IMENIT_1 => 'Павел',
189		self::RODIT_2 => 'Павла',
190		self::DAT_3 => 'Павлу',
191		self::VINIT_4 => 'Павла',
192		self::TVORIT_5 => 'Павлом',
193		self::PREDLOJ_6 => 'о Павле',
194		);
195		}
196
197	View Code Duplication	public function getForm($name, $form, $gender) {
		0 ignored issues – show Duplication introduced 2017-01-28 02:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
198		$forms = $this->getForms($name, $gender);
199		if ($forms !== false)
200		if (isset($forms[$form]))
201		return $forms[$form];
202		else
203		return false;
204		else
205		return false;
206		}
207		}
208

wapmorgan / Morphos