GeographicalNamesInflection - Code Metrics - Inspection of "Update rules for Geographical Names." - wapmorgan/Morphos - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a85940...3d0bce )

by f

created 2018-06-20 17:31 UTC

GeographicalNamesInflection C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	388
Duplicated Lines	9.02 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

87.44%

Importance

Changes

Metric	Value
dl	35
loc	388
ccs	174
cts	199
cp	0.8744
rs	6.5957
c	0
b	0
f	0
wmc	56
lcom	1
cbo	5

3 Methods

Rating	Name	Duplication	Size	Complexity
C	isMutable()	0	48	11
D	getCases()	35	287	44
A	getCase()	0	6	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like GeographicalNamesInflection often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use GeographicalNamesInflection, and based on these observations, apply Extract Interface, too.

<?php
namespace morphos\Russian;

use morphos\S;

/**
 * Rules are from: https://ru.wikipedia.org/wiki/%D0%A1%D0%BA%D0%BB%D0%BE%D0%BD%D0%B5%D0%BD%D0%B8%D0%B5_%D0%B3%D0%B5%D0%BE%D0%B3%D1%80%D0%B0%D1%84%D0%B8%D1%87%D0%B5%D1%81%D0%BA%D0%B8%D1%85_%D0%BD%D0%B0%D0%B7%D0%B2%D0%B0%D0%BD%D0%B8%D0%B9_%D0%B2_%D1%80%D1%83%D1%81%D1%81%D0%BA%D0%BE%D0%BC_%D1%8F%D0%B7%D1%8B%D0%BA%D0%B5
 */
class GeographicalNamesInflection extends \morphos\BaseInflection implements Cases
{
    use RussianLanguage, CasesHelper;

    protected static $abbreviations = [
        'сша',
        'оаэ',
        'ссср',
        'юар',
    ];

    protected static $delimiters = [
        ' ',
        '-на-',
        '-',
    ];

    protected static $ovAbnormalExceptions = [
        'осташков',
    ];

    protected static $immutableParts = [
        'санкт',
    ];

    /**
     * Проверяет, склоняемо ли название
     * @param string $name Название
     * @return bool
     */
    public static function isMutable($name)
    {
        $name = S::lower($name);

        // // ends with 'ы' or 'и': plural form
        // if (in_array(S::slice($name, -1), array('и', 'ы')))
        //     return false;

        if (in_array($name, self::$abbreviations) || in_array($name, self::$immutableParts)) {
            return false;
        }

        // N край
        if (S::slice($name, -5) == ' край') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return static::isMutable(S::slice($name, 0, -5));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
        }

        // N область
        if (S::slice($name, -8) == ' область') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return true;
        }

        // город N
        if (S::slice($name, 0, 6) == 'город ') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return true;
        }

        // село N
        if (S::slice($name, 0, 5) == 'село ') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return true;
        }

        // хутор N
        if (S::slice($name, 0, 6) == 'хутор ') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return true;
        }

        // пгт N
        if (S::slice($name, 0, 4) == 'пгт ') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return false;
        }

        // ends with 'е' or 'о', but not with 'ово/ёво/ево/ино/ыно'
        if (in_array(S::slice($name, -1), ['е', 'о']) && !in_array(S::slice($name, -3, -1), ['ов', 'ёв', 'ев', 'ин', 'ын'])) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return false;
        }
        return true;
    }

    /**
     * Получение всех форм названия
     * @param string $name
     * @return array
     * @throws \Exception
     */
    public static function getCases($name)
    {
        $name = S::lower($name);

        if (in_array($name, self::$immutableParts)) {
            return array_fill_keys([self::IMENIT, self::RODIT, self::DAT, self::VINIT, self::TVORIT, self::PREDLOJ], S::name($name));
        }

        // N край
        if (S::slice($name, -5) == ' край') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return self::composeCasesFromWords([static::getCases(S::slice($name, 0, -5)), NounDeclension::getCases('край')]);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
        }

        // N область
        if (S::slice($name, -8) == ' область') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return self::composeCasesFromWords([static::getCases(S::slice($name, 0, -8)), NounDeclension::getCases('область')]);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
        }

        // город N
        if (S::slice($name, 0, 6) == 'город ') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return self::composeCasesFromWords([
                NounDeclension::getCases('город'),
                array_fill_keys(self::getAllCases(), S::name(S::slice($name, 6)))
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            ]);
        }

        // село N
        if (S::slice($name, 0, 5) == 'село ') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return self::composeCasesFromWords([
                NounDeclension::getCases('село'),
                array_fill_keys(self::getAllCases(), S::name(S::slice($name, 5)))
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            ]);
        }

        // хутор N
        if (S::slice($name, 0, 6) == 'хутор ') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return self::composeCasesFromWords([
                NounDeclension::getCases('хутор'),
                array_fill_keys(self::getAllCases(), S::name(S::slice($name, 6)))
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            ]);
        }

        // пгт N
        if (S::slice($name, 0, 4) == 'пгт ') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return self::composeCasesFromWords([
                array_fill_keys([self::IMENIT, self::RODIT, self::DAT, self::VINIT, self::TVORIT, self::PREDLOJ], 'пгт '.S::name(S::slice($name, 4)))
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            ]);
        }

        // Сложное название через пробел, '-' или '-на-'
        foreach (self::$delimiters as $delimiter) {
            if (strpos($name, $delimiter) !== false) {
                $parts = explode($delimiter, $name);
                $result = [];
                foreach ($parts as $i => $part) {
                    $result[$i] = static::getCases($part);
                }
                return self::composeCasesFromWords($result, $delimiter);
            }
        }

        if (!in_array($name, self::$abbreviations)) {
            switch (S::slice($name, -2)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                // Нижний, Русский
                case 'ий':
                    $prefix = S::name(S::slice($name, 0, -2));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'ий',
                        self::RODIT => $prefix . (self::isVelarConsonant(S::slice($name, -3, -2)) ? 'ого' : 'его'),
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                        self::DAT => $prefix . (self::isVelarConsonant(S::slice($name, -3, -2)) ? 'ому' : 'ему'),
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                        self::VINIT => $prefix . 'ий',
                        self::TVORIT => $prefix . 'им',
                        self::PREDLOJ => $prefix . (self::chooseEndingBySonority($prefix, 'ем', 'ом')),
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    ];

                // Ростовская
                case 'ая':
                    $prefix = S::name(S::slice($name, 0, -2));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'ая',
                        self::RODIT => $prefix . 'ой',
                        self::DAT => $prefix . 'ой',
                        self::VINIT => $prefix . 'ую',
                        self::TVORIT => $prefix . 'ой',
                        self::PREDLOJ => $prefix . 'ой',
                    ];

                // Грозный, Благодарный
                case 'ый':
                    $prefix = S::name(S::slice($name, 0, -2));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'ый',
                        self::RODIT => $prefix . 'ого',
                        self::DAT => $prefix . 'ому',
                        self::VINIT => $prefix . 'ый',
                        self::TVORIT => $prefix . 'ым',
                        self::PREDLOJ => $prefix . 'ом',
                    ];

                // Ставрополь, Ярославль
                case 'ль':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'ь',
                        self::RODIT => $prefix . 'я',
                        self::DAT => $prefix . 'ю',
                        self::VINIT => $prefix . 'ь',
                        self::TVORIT => $prefix . 'ем',
                        self::PREDLOJ => $prefix . 'е',
                    ];

                // Тверь, Анадырь
                case 'рь':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    $last_vowel = S::slice($prefix, -2, -1);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'ь',
                        self::RODIT => $prefix . (self::isBinaryVowel($last_vowel) ? 'и' : 'я'),
                        self::DAT => $prefix . (self::isBinaryVowel($last_vowel) ? 'и' : 'ю'),
                        self::VINIT => $prefix . 'ь',
                        self::TVORIT => $prefix . (self::isBinaryVowel($last_vowel) ? 'ью' : 'ем'),
                        self::PREDLOJ => $prefix . (self::isBinaryVowel($last_vowel) ? 'и' : 'е'),
                    ];

                // Березники, Ессентуки
                case 'ки':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'и',
                        self::RODIT => $name == 'луки' ? $prefix : $prefix . 'ов',
                        self::DAT => $prefix . 'ам',
                        self::VINIT => $prefix . 'и',
                        self::TVORIT => $prefix . 'ами',
                        self::PREDLOJ => $prefix . 'ах',
                    ];

                // Пермь, Кемь
                case 'мь':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'ь',
                        self::RODIT => $prefix . 'и',
                        self::DAT => $prefix . 'и',
                        self::VINIT => $prefix . 'ь',
                        self::TVORIT => $prefix . 'ью',
                        self::PREDLOJ => $prefix . 'и',
                    ];

                // Рязань, Назрань
                case 'нь':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'ь',
                        self::RODIT => $prefix . 'и',
                        self::DAT => $prefix . 'и',
                        self::VINIT => $prefix . 'ь',
                        self::TVORIT => $prefix . 'ью',
                        self::PREDLOJ => $prefix . 'и',
                    ];

                // Набережные
                case 'ые':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'е',
                        self::RODIT => $prefix . 'х',
                        self::DAT => $prefix . 'м',
                        self::VINIT => $prefix . 'е',
                        self::TVORIT => $prefix . 'ми',
                        self::PREDLOJ => $prefix . 'х',
                    ];

                // Челны
                case 'ны':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'ы',
                        self::RODIT => $prefix . 'ов',
                        self::DAT => $prefix . 'ам',
                        self::VINIT => $prefix . 'ы',
                        self::TVORIT => $prefix . 'ами',
                        self::PREDLOJ => $prefix . 'ах',
                    ];

                // Великие
                case 'ие':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix.'е',
                        self::RODIT => $prefix.'х',
                        self::DAT => $prefix.'м',
                        self::VINIT => $prefix.'е',
                        self::TVORIT => $prefix.'ми',
                        self::PREDLOJ => $prefix.'х',
                    ];

                // Керчь
                case 'чь':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix.'ь',
                        self::RODIT => $prefix.'и',
                        self::DAT => $prefix.'и',
                        self::VINIT => $prefix.'ь',
                        self::TVORIT => $prefix.'ью',
                        self::PREDLOJ => $prefix.'и',
                    ];
            }


            switch (S::slice($name, -1)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                // Азия
                case 'я':
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => S::name($name),
                        self::RODIT => $prefix.'и',
                        self::DAT => $prefix.'и',
                        self::VINIT => $prefix.'ю',
                        self::TVORIT => $prefix.'ей',
                        self::PREDLOJ => $prefix.'и',
                    ];

                case 'а':

                    // Москва, Рига
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix.'а',
                        self::RODIT => $prefix.(self::isVelarConsonant(S::slice($name, -2, -1)) ? 'и' : 'ы'),
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                        self::DAT => $prefix.'е',
                        self::VINIT => $prefix.'у',
                        self::TVORIT => $prefix.'ой',
                        self::PREDLOJ => $prefix.'е',
                    ];

                case 'й':
                    // Ишимбай
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => $prefix . 'й',
                        self::RODIT => $prefix . 'я',
                        self::DAT => $prefix . 'ю',
                        self::VINIT => $prefix . 'й',
                        self::TVORIT => $prefix . 'ем',
                        self::PREDLOJ => $prefix . 'е',
                    ];
            }

            if (self::isConsonant(S::slice($name,  -1)) && !in_array($name, self::$ovAbnormalExceptions, true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                // Париж, Валаам, Киев
                $prefix = S::name($name);
                return [
                    self::IMENIT => $prefix,
                    self::RODIT => $prefix . 'а',
                    self::DAT => $prefix . 'у',
                    self::VINIT => $prefix,
                    self::TVORIT => $prefix . (self::isVelarConsonant(S::slice($name, -2, -1)) ? 'ем' : 'ом'),
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    self::PREDLOJ => $prefix . 'е',
                ];
            }

            // ов, ово, ёв, ёво, ев, ево, ...
            $suffixes = ['ов', 'ёв', 'ев', 'ин', 'ын'];
            if ((in_array(S::slice($name, -1), ['е', 'о']) && in_array(S::slice($name, -3, -1), $suffixes)) || in_array(S::slice($name, -2), $suffixes)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                // ово, ёво, ...
                if (in_array(S::slice($name, -3, -1), $suffixes)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                }
                // ов, её, ...
                elseif (in_array(S::slice($name, -2), $suffixes)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    $prefix = S::name($name);
                }
                return [
                    self::IMENIT => S::name($name),
                    self::RODIT => $prefix.'а',
                    self::DAT => $prefix.'у',
                    self::VINIT => S::name($name),
                    self::TVORIT => $prefix.'ым',
                    self::PREDLOJ => $prefix.'е',
                ];
            }
        }

        // if no rules matches or name is immutable
        $name = in_array($name, self::$abbreviations) ? S::upper($name) : S::name($name);
        return array_fill_keys([self::IMENIT, self::RODIT, self::DAT, self::VINIT, self::TVORIT, self::PREDLOJ], $name);
    }

    /**
     * Получение одной формы (падежа) названия.
     * @param string $name  Название
     * @param integer $case Падеж. Одна из констант \morphos\Russian\Cases или \morphos\Cases.
     * @see \morphos\Russian\Cases
     * @return string
     * @throws \Exception
     */
    public static function getCase($name, $case)
    {
        $case = self::canonizeCase($case);
        $forms = self::getCases($name);
        return $forms[$case];
    }
}


1		<?php
2		namespace morphos\Russian;
3
4		use morphos\S;
5
6		/**
7		* Rules are from: https://ru.wikipedia.org/wiki/%D0%A1%D0%BA%D0%BB%D0%BE%D0%BD%D0%B5%D0%BD%D0%B8%D0%B5_%D0%B3%D0%B5%D0%BE%D0%B3%D1%80%D0%B0%D1%84%D0%B8%D1%87%D0%B5%D1%81%D0%BA%D0%B8%D1%85_%D0%BD%D0%B0%D0%B7%D0%B2%D0%B0%D0%BD%D0%B8%D0%B9_%D0%B2_%D1%80%D1%83%D1%81%D1%81%D0%BA%D0%BE%D0%BC_%D1%8F%D0%B7%D1%8B%D0%BA%D0%B5
8		*/
9		class GeographicalNamesInflection extends \morphos\BaseInflection implements Cases
10		{
11		use RussianLanguage, CasesHelper;
12
13		protected static $abbreviations = [
14		'сша',
15		'оаэ',
16		'ссср',
17		'юар',
18		];
19
20		protected static $delimiters = [
21		' ',
22		'-на-',
23		'-',
24		];
25
26		protected static $ovAbnormalExceptions = [
27		'осташков',
28		];
29
30		protected static $immutableParts = [
31		'санкт',
32		];
33
34		/**
35		* Проверяет, склоняемо ли название
36		* @param string $name Название
37		* @return bool
38		*/
39	2	public static function isMutable($name)
40		{

wapmorgan / Morphos