functions.php ➔ inflectName() - Code Metrics - Inspection of "Remove 'о' from all inflections" - wapmorgan/Morphos - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dd6397...5d0bef )

by f

created 2017-09-20 20:58 UTC

functions.php ➔ inflectName() D

↳ Parent: Project

Complexity

Conditions	10
Paths	28

Size

Total Lines	37
Code Lines	29

Duplication

Lines	10
Ratio	27.03 %

Importance

Changes

Metric	Value
cc	10
eloc	29
nc	28
nop	3
dl	10
loc	37
rs	4.8196
c	0
b	0
f	0

How to fix Complexity

<?php
namespace morphos\Russian;

use morphos\S;

/**
 * Inflects the name to all cases / one case.
 * @param string      $fullname Name in format: "L F" o "L M F", where L - last name, M - middl name, F - first name
 * @param null|string $case     Case to inflect to. If null, result will contain inflection to all cases.
 *                              Should be one of {@link morphos\Cases} or {@link morphos\Russian\Cases} constants.
 * @param null|tring  $gender   Gender of name owner. If null, auto detection will be used.
 *                              Should be one of {@link morphos\Gender} constants.
 * @return string|array         Returns string containing the inflection of name to a case, if `$case` is not null.
 *                              Returns an array will inflection to all cases.
 */
function inflectName($fullname, $case = null, $gender = null)
{
    if (in_array($case, array('m', 'f'))) {
        $gender = $case;
        $case = null;
    }
    if ($gender === null) $gender = detectGender($fullname);
    $fullname = normalizeFullName($fullname);

    $name = explode(' ', $fullname);
    if (count($name) < 2 || count($name) > 3) {
        return false;
    }
    if ($case === null) {
        $result = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (count($name) == 2) {
            $name[0] = LastNamesInflection::getCases($name[0], $gender);
            $name[1] = FirstNamesInflection::getCases($name[1], $gender);
        } elseif (count($name) == 3) {

            $name[0] = LastNamesInflection::getCases($name[0], $gender);
            $name[1] = FirstNamesInflection::getCases($name[1], $gender);
            $name[2] = MiddleNamesInflection::getCases($name[2], $gender);
        }
        return CasesHelper::composeCasesFromWords($name);
    } else {
        $case = CasesHelper::canonizeCase($case);
        if (count($name) == 2) {
            $name[0] = LastNamesInflection::getCase($name[0], $case, $gender);
            $name[1] = FirstNamesInflection::getCase($name[1], $case, $gender);
        } elseif (count($name) == 3) {

            $name[0] = LastNamesInflection::getCase($name[0], $case, $gender);
            $name[1] = FirstNamesInflection::getCase($name[1], $case, $gender);
            $name[2] = MiddleNamesInflection::getCase($name[2], $case, $gender);
        }
    	return implode(' ', $name);
    }
}

/**
 * Guesses the gender of name owner.
 * @param string $fullname
 * @return null|string     Null if not detected. One of {@link morphos\Gender} constants.
 */
function detectGender($fullname)
{
    static $first, $middle, $last;
    $name = explode(' ', S::lower($fullname));
    if (count($name) < 2 || count($name) > 3) {
        return false;
    }

    return (isset($name[2]) ? MiddleNamesInflection::detectGender($name[2]) : null) ?:
        LastNamesInflection::detectGender($name[0]) ?:
        FirstNamesInflection::detectGender($name[1]);
}

/**
 * Normalizes a full name. Swaps name parts to make "L F" or "L M F" scheme.
 * @param string $name Input name
 * @return string      Normalized name
 */
function normalizeFullName($name)
{
    $name = preg_replace('~[ ]{2,}~', null, trim($name));
    return $name;
}

/*
 * @param string $word
 * @param int $count
 * @param bool $animateness
 * @return string
 */
function pluralize($count, $word, $animateness = false)
{
    return $count.' '.NounPluralization::pluralize($word, $count, $animateness);
}


1		<?php
2		namespace morphos\Russian;
3
4		use morphos\S;
5
6		/**
7		* Inflects the name to all cases / one case.
8		* @param string $fullname Name in format: "L F" o "L M F", where L - last name, M - middl name, F - first name
9		* @param null\|string $case Case to inflect to. If null, result will contain inflection to all cases.
10		* Should be one of {@link morphos\Cases} or {@link morphos\Russian\Cases} constants.
11		* @param null\|tring $gender Gender of name owner. If null, auto detection will be used.
12		* Should be one of {@link morphos\Gender} constants.
13		* @return string\|array Returns string containing the inflection of name to a case, if `$case` is not null.
14		* Returns an array will inflection to all cases.
15		*/
16		function inflectName($fullname, $case = null, $gender = null)
17		{
18		if (in_array($case, array('m', 'f'))) {
19		$gender = $case;
20		$case = null;
21		}
22		if ($gender === null) $gender = detectGender($fullname);
23		$fullname = normalizeFullName($fullname);
24
25		$name = explode(' ', $fullname);
26		if (count($name) < 2 \|\| count($name) > 3) {
27		return false;
28		}
29		if ($case === null) {
30		$result = array();
		0 ignored issues – show Unused Code introduced 2017-09-20 21:00 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
31		if (count($name) == 2) {
32		$name[0] = LastNamesInflection::getCases($name[0], $gender);
33		$name[1] = FirstNamesInflection::getCases($name[1], $gender);
34	View Code Duplication	} elseif (count($name) == 3) {
		0 ignored issues – show Duplication introduced 2017-09-20 21:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		$name[0] = LastNamesInflection::getCases($name[0], $gender);
36		$name[1] = FirstNamesInflection::getCases($name[1], $gender);
37		$name[2] = MiddleNamesInflection::getCases($name[2], $gender);
38		}
39		return CasesHelper::composeCasesFromWords($name);
40		} else {
41		$case = CasesHelper::canonizeCase($case);
42		if (count($name) == 2) {
43		$name[0] = LastNamesInflection::getCase($name[0], $case, $gender);
44		$name[1] = FirstNamesInflection::getCase($name[1], $case, $gender);
45	View Code Duplication	} elseif (count($name) == 3) {
		0 ignored issues – show Duplication introduced 2017-09-20 21:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		$name[0] = LastNamesInflection::getCase($name[0], $case, $gender);
47		$name[1] = FirstNamesInflection::getCase($name[1], $case, $gender);
48		$name[2] = MiddleNamesInflection::getCase($name[2], $case, $gender);
49		}
50		return implode(' ', $name);
51		}
52		}
53
54		/**
55		* Guesses the gender of name owner.
56		* @param string $fullname
57		* @return null\|string Null if not detected. One of {@link morphos\Gender} constants.
58		*/
59		function detectGender($fullname)
60		{
61		static $first, $middle, $last;
62		$name = explode(' ', S::lower($fullname));
63		if (count($name) < 2 \|\| count($name) > 3) {
64		return false;
65		}
66
67		return (isset($name[2]) ? MiddleNamesInflection::detectGender($name[2]) : null) ?:
68		LastNamesInflection::detectGender($name[0]) ?:
69		FirstNamesInflection::detectGender($name[1]);
70		}
71
72		/**
73		* Normalizes a full name. Swaps name parts to make "L F" or "L M F" scheme.
74		* @param string $name Input name
75		* @return string Normalized name
76		*/
77		function normalizeFullName($name)
78		{
79		$name = preg_replace('~[ ]{2,}~', null, trim($name));
80		return $name;
81		}
82
83		/*
84		* @param string $word
85		* @param int $count
86		* @param bool $animateness
87		* @return string
88		*/
89		function pluralize($count, $word, $animateness = false)
90		{
91		return $count.' '.NounPluralization::pluralize($word, $count, $animateness);
92		}
93

wapmorgan / Morphos

Push — master ( dd6397...5d0bef )

functions.php ➔ inflectName() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like