Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like LastNamesInflection often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LastNamesInflection, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
9 | class LastNamesInflection extends \morphos\NamesInflection implements Cases |
||
10 | { |
||
11 | use RussianLanguage, CasesHelper; |
||
12 | |||
13 | /** @var string[] */ |
||
14 | protected static $womenPostfixes = ['ва', 'на', 'ая', 'яя']; |
||
15 | /** @var string[] */ |
||
16 | protected static $menPostfixes = ['ов', 'ев' ,'ин' ,'ын', 'ой', 'ий']; |
||
17 | |||
18 | /** |
||
19 | * @param string $name |
||
20 | * @param string|null $gender |
||
21 | * @return bool |
||
22 | */ |
||
23 | 66 | public static function isMutable($name, $gender = null) |
|
80 | |||
81 | /** |
||
82 | * @param string $name |
||
83 | * @return null|string |
||
84 | */ |
||
85 | 25 | public static function detectGender($name) |
|
97 | |||
98 | /** |
||
99 | * @param string $name |
||
100 | * @param null|string $gender |
||
101 | * @return string[] |
||
102 | * @phpstan-return array<string, string> |
||
103 | */ |
||
104 | 39 | public static function getCases($name, $gender = null) |
|
105 | { |
||
106 | 39 | $name = S::lower($name); |
|
107 | 39 | if ($gender === null) { |
|
108 | $gender = static::detectGender($name); |
||
109 | } |
||
110 | |||
111 | // составная фамилия - разбить на части и склонять по отдельности |
||
112 | 39 | if (strpos($name, '-') !== false) { |
|
113 | 3 | $parts = explode('-', $name); |
|
114 | 3 | $cases = []; |
|
115 | 3 | foreach ($parts as $i => $part) { |
|
116 | 3 | $parts[$i] = static::getCases($part, $gender); |
|
117 | } |
||
118 | |||
119 | 3 | return static::composeCasesFromWords($parts, '-'); |
|
120 | } |
||
121 | |||
122 | 39 | if (static::isMutable($name, $gender)) { |
|
123 | 38 | if ($gender == static::MALE) { |
|
124 | 24 | if (in_array(S::slice($name, -2), ['ов', 'ев', 'ин', 'ын', 'ёв'], true)) { |
|
125 | 5 | $prefix = S::name($name); |
|
126 | return [ |
||
127 | 5 | static::IMENIT => $prefix, |
|
128 | 5 | static::RODIT => $prefix.'а', |
|
129 | 5 | static::DAT => $prefix.'у', |
|
130 | 5 | static::VINIT => $prefix.'а', |
|
131 | 5 | static::TVORIT => $prefix.'ым', |
|
132 | 5 | static::PREDLOJ => $prefix.'е' |
|
133 | ]; |
||
134 | 19 | View Code Duplication | } elseif (in_array(S::slice($name, -4), ['ский', 'ской', 'цкий', 'цкой'], true)) { |
135 | 1 | $prefix = S::name(S::slice($name, 0, -2)); |
|
136 | return [ |
||
137 | 1 | static::IMENIT => S::name($name), |
|
138 | 1 | static::RODIT => $prefix.'ого', |
|
139 | 1 | static::DAT => $prefix.'ому', |
|
140 | 1 | static::VINIT => $prefix.'ого', |
|
141 | 1 | static::TVORIT => $prefix.'им', |
|
142 | 1 | static::PREDLOJ => $prefix.'ом' |
|
143 | ]; |
||
144 | // Верхний / Убогий / Толстой |
||
145 | // Верхнего / Убогого / Толстого |
||
146 | // Верхнему / Убогому / Толстому |
||
147 | // Верхним / Убогим / Толстым |
||
148 | // О Верхнем / Об Убогом / О Толстом |
||
149 | 18 | } else if (in_array(S::slice($name, -2), ['ой', 'ый', 'ий'], true)) { |
|
150 | 3 | $prefix = S::name(S::slice($name, 0, -2)); |
|
151 | return [ |
||
152 | 3 | static::IMENIT => S::name($name), |
|
153 | 3 | static::RODIT => $prefix.'ого', |
|
154 | 3 | static::DAT => $prefix.'ому', |
|
155 | 3 | static::VINIT => $prefix.'ого', |
|
156 | 3 | static::TVORIT => $prefix.'ым', |
|
157 | 18 | static::PREDLOJ => $prefix.'ом' |
|
158 | ]; |
||
159 | } |
||
160 | |||
161 | } else { |
||
162 | 14 | View Code Duplication | if (in_array(S::slice($name, -3), ['ова', 'ева', 'ина', 'ына', 'ёва'], true)) { |
163 | 5 | $prefix = S::name(S::slice($name, 0, -1)); |
|
164 | return [ |
||
165 | 5 | static::IMENIT => S::name($name), |
|
166 | 5 | static::RODIT => $prefix.'ой', |
|
167 | 5 | static::DAT => $prefix.'ой', |
|
168 | 5 | static::VINIT => $prefix.'у', |
|
169 | 5 | static::TVORIT => $prefix.'ой', |
|
170 | 5 | static::PREDLOJ => $prefix.'ой' |
|
171 | ]; |
||
172 | } |
||
173 | |||
174 | 9 | if (in_array(S::slice($name, -2), ['ая'], true)) { |
|
175 | 3 | $prefix = S::name(S::slice($name, 0, -2)); |
|
176 | return [ |
||
177 | 3 | static::IMENIT => S::name($name), |
|
178 | 3 | static::RODIT => $prefix.'ой', |
|
179 | 3 | static::DAT => $prefix.'ой', |
|
180 | 3 | static::VINIT => $prefix.'ую', |
|
181 | 3 | static::TVORIT => $prefix.'ой', |
|
182 | 3 | static::PREDLOJ => $prefix.'ой' |
|
183 | ]; |
||
184 | } |
||
185 | |||
186 | 6 | if (in_array(S::slice($name, -2), ['яя'], true)) { |
|
187 | 1 | $prefix = S::name(S::slice($name, 0, -2)); |
|
188 | return [ |
||
189 | 1 | static::IMENIT => S::name($name), |
|
190 | 1 | static::RODIT => $prefix.'ей', |
|
191 | 1 | static::DAT => $prefix.'ей', |
|
192 | 1 | static::VINIT => $prefix.'юю', |
|
193 | 1 | static::TVORIT => $prefix.'ей', |
|
194 | 1 | static::PREDLOJ => $prefix.'ей' |
|
195 | ]; |
||
196 | } |
||
197 | } |
||
198 | |||
199 | 20 | if (S::slice($name, -1) == 'я') { |
|
200 | 1 | $prefix = S::name(S::slice($name, 0, -1)); |
|
201 | return [ |
||
202 | 1 | static::IMENIT => S::name($name), |
|
203 | 1 | static::RODIT => $prefix.'и', |
|
204 | 1 | static::DAT => $prefix.'е', |
|
205 | 1 | static::VINIT => $prefix.'ю', |
|
206 | 1 | static::TVORIT => $prefix.'ей', |
|
207 | 1 | static::PREDLOJ => $prefix.'е' |
|
208 | ]; |
||
209 | 19 | } elseif (S::slice($name, -1) == 'а') { |
|
210 | 7 | $prefix = S::name(S::slice($name, 0, -1)); |
|
211 | return [ |
||
212 | 7 | static::IMENIT => S::name($name), |
|
213 | 7 | static::RODIT => $prefix.((static::isDeafConsonant(S::slice($name, -2, -1)) && S::slice($name, -2, -1) !== 'п') |
|
214 | 7 | || S::slice($name, -2) === 'га' ? 'и' : 'ы'), |
|
215 | 7 | static::DAT => $prefix.'е', |
|
216 | 7 | static::VINIT => $prefix.'у', |
|
217 | 7 | static::TVORIT => $prefix.'ой', |
|
218 | 7 | static::PREDLOJ => $prefix.'е' |
|
219 | ]; |
||
220 | 12 | } elseif (static::isConsonant(S::slice($name, -1)) && S::slice($name, -2) !== 'ых') { |
|
221 | 9 | $prefix = S::name($name); |
|
222 | return [ |
||
223 | 9 | static::IMENIT => S::name($name), |
|
224 | 9 | static::RODIT => $prefix.'а', |
|
225 | 9 | static::DAT => $prefix.'у', |
|
226 | 9 | static::VINIT => $prefix.'а', |
|
227 | 9 | static::TVORIT => $prefix.'ом', |
|
228 | 9 | static::PREDLOJ => $prefix.'е' |
|
229 | ]; |
||
230 | 3 | } elseif (S::slice($name, -1) == 'ь' && $gender == static::MALE) { |
|
231 | 3 | $prefix = S::name(S::slice($name, 0, -1)); |
|
232 | return [ |
||
233 | 3 | static::IMENIT => S::name($name), |
|
234 | 3 | static::RODIT => $prefix.'я', |
|
235 | 3 | static::DAT => $prefix.'ю', |
|
236 | 3 | static::VINIT => $prefix.'я', |
|
237 | 3 | static::TVORIT => $prefix.'ем', |
|
238 | 3 | static::PREDLOJ => $prefix.'е' |
|
239 | ]; |
||
240 | } |
||
241 | } |
||
242 | |||
243 | 2 | $name = S::name($name); |
|
244 | 2 | return array_fill_keys([static::IMENIT, static::RODIT, static::DAT, static::VINIT, static::TVORIT, static::PREDLOJ], $name); |
|
245 | } |
||
246 | |||
247 | /** |
||
248 | * @param string $name |
||
249 | * @param string $case |
||
250 | * @param null $gender |
||
251 | * @return string |
||
252 | * @throws \Exception |
||
253 | */ |
||
254 | 6 | public static function getCase($name, $case, $gender = null) |
|
264 | } |
||
265 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.