Inspection of "Fix website URL" - w3designweb/laravel-qapla - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4fce34...402a34 )

by Michele

created 2018-04-18 12:04 UTC

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -40,13 +40,13 @@  discard block
 block discarded – undo
 	public function getTrack($tracking_or_reference = 'trackingNumber', $value, $lang = 'ita')
 	{
 		$client = new GuzzleHttp\Client();
-		$res = $client->get(config('qapla.url').'getTrack/', ['query' =>  [
+		$res = $client->get(config('qapla.url').'getTrack/', [ 'query' =>  [
 			'apiKey' => $this->privateApiKey,
 			$tracking_or_reference => $value,
-			'lang' => $lang]
+			'lang' => $lang ]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getTrack->result == 'KO') return $result->getTrack->error;
+		if ($result->getTrack->result == 'KO') return $result->getTrack->error;
 		return $result->getTrack;
 	}
 
@@ -58,14 +58,14 @@  discard block
 block discarded – undo
 	 */
 	public function pushTrack($data)
 	{
-		$json ='{
+		$json = '{
 		    "apiKey": "'.$this->privateApiKey.'",
 		    "pushTrack": '.json_encode($data).'
 		}';
 
 		$client = new GuzzleHttp\Client();
 		$res = $client->post(config('qapla.url').'pushTrack/', [
-			'headers' => ['content-type' => 'application/json'],
+			'headers' => [ 'content-type' => 'application/json' ],
 			'body' => $json
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
@@ -82,15 +82,15 @@  discard block
 block discarded – undo
 	{
 		$param_name = 'dateFrom';
 		$date_or_days ?: $date_or_days = config('qapla.orders.default_fromDate');
-		if(strtotime($date_or_days) === false) $param_name = 'days';
+		if (strtotime($date_or_days) === false) $param_name = 'days';
 
 		$client = new GuzzleHttp\Client();
-		$res = $client->get(config('qapla.url').'getTracks/', ['query' =>  [
+		$res = $client->get(config('qapla.url').'getTracks/', [ 'query' =>  [
 			'apiKey'    => $this->privateApiKey,
-			$param_name => $date_or_days]
+			$param_name => $date_or_days ]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getTracks->result == 'KO') return $result->getTracks->error;
+		if ($result->getTracks->result == 'KO') return $result->getTracks->error;
 		return $result->getTracks->tracks;
 	}
 
@@ -103,12 +103,12 @@  discard block
 block discarded – undo
 	public function deleteTrack($trackingNumber)
 	{
 		$client = new GuzzleHttp\Client();
-		$res = $client->get(config('qapla.url').'deleteTrack/', ['query' =>  [
+		$res = $client->get(config('qapla.url').'deleteTrack/', [ 'query' =>  [
 			'apiKey'            => $this->privateApiKey,
-			'trackingNumber'    => $trackingNumber]
+			'trackingNumber'    => $trackingNumber ]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->deleteTrack->result == 'KO') return $result->deleteTrack->error;
+		if ($result->deleteTrack->result == 'KO') return $result->deleteTrack->error;
 		return true;
 	}
 
@@ -122,15 +122,15 @@  discard block
 block discarded – undo
 	{
 		$param_name = 'dateFrom';
 		$date_or_days ?: $date_or_days = config('qapla.orders.default_fromDate');
-		if(strtotime($date_or_days) === false) $param_name = 'days';
+		if (strtotime($date_or_days) === false) $param_name = 'days';
 
 		$client = new GuzzleHttp\Client();
-		$res = $client->get(config('qapla.url').'getOrders/', ['query' =>  [
+		$res = $client->get(config('qapla.url').'getOrders/', [ 'query' =>  [
 			'apiKey'    => $this->privateApiKey,
-			$param_name => $date_or_days]
+			$param_name => $date_or_days ]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getOrders->result == 'KO') return $result->getOrders->error;
+		if ($result->getOrders->result == 'KO') return $result->getOrders->error;
 		return $result->getOrders->orders;
 	}
 
@@ -142,18 +142,18 @@  discard block
 block discarded – undo
 	 */
 	public function pushOrder($data)
 	{
-		$json ='{
+		$json = '{
 		    "apiKey": "'.$this->privateApiKey.'",
 		    "pushOrder": '.json_encode($data).'
 		}';
 
 		$client = new GuzzleHttp\Client();
 		$res = $client->post(config('qapla.url').'pushOrder/', [
-			'headers' => ['content-type' => 'application/json'],
+			'headers' => [ 'content-type' => 'application/json' ],
 			'body' => $json
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->pushOrder->result == 'KO') return $result->pushOrder->error;
+		if ($result->pushOrder->result == 'KO') return $result->pushOrder->error;
 		return true;
 	}
 
@@ -164,11 +164,11 @@  discard block
 block discarded – undo
 	public function getCredits()
 	{
 		$client = new GuzzleHttp\Client();
-		$res = $client->get(config('qapla.url').'getCredits/', ['query' =>  [
-			'apiKey' => $this->privateApiKey]
+		$res = $client->get(config('qapla.url').'getCredits/', [ 'query' =>  [
+			'apiKey' => $this->privateApiKey ]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getCredits->result == 'KO') return $result->getCredits->error;
+		if ($result->getCredits->result == 'KO') return $result->getCredits->error;
 		return $result->getCredits->credits;
 	}
 
@@ -181,12 +181,12 @@  discard block
 block discarded – undo
 	public function getCouriers($country = null)
 	{
 		$client = new GuzzleHttp\Client();
-		$res = $client->get(config('qapla.url').'getCouriers/', ['query' =>  [
+		$res = $client->get(config('qapla.url').'getCouriers/', [ 'query' =>  [
 			'apiKey'    => $this->privateApiKey,
-			'country'   => $country ?: config('qapla.couriers.default_country')]
+			'country'   => $country ?: config('qapla.couriers.default_country') ]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getCouriers->result == 'KO') return $result->getCouriers->error;
+		if ($result->getCouriers->result == 'KO') return $result->getCouriers->error;
 		return $result->getCouriers->courier;
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

Braces +27 added lines, -9 removed lines patch added patch discarded remove patch

@@ -46,7 +46,9 @@  discard block
 block discarded – undo
 			'lang' => $lang]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getTrack->result == 'KO') return $result->getTrack->error;
+		if($result->getTrack->result == 'KO') {
+			return $result->getTrack->error;
+		}
 		return $result->getTrack;
 	}
 
@@ -82,7 +84,9 @@  discard block
 block discarded – undo
 	{
 		$param_name = 'dateFrom';
 		$date_or_days ?: $date_or_days = config('qapla.orders.default_fromDate');
-		if(strtotime($date_or_days) === false) $param_name = 'days';
+		if(strtotime($date_or_days) === false) {
+			$param_name = 'days';
+		}
 
 		$client = new GuzzleHttp\Client();
 		$res = $client->get(config('qapla.url').'getTracks/', ['query' =>  [
@@ -90,7 +94,9 @@  discard block
 block discarded – undo
 			$param_name => $date_or_days]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getTracks->result == 'KO') return $result->getTracks->error;
+		if($result->getTracks->result == 'KO') {
+			return $result->getTracks->error;
+		}
 		return $result->getTracks->tracks;
 	}
 
@@ -108,7 +114,9 @@  discard block
 block discarded – undo
 			'trackingNumber'    => $trackingNumber]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->deleteTrack->result == 'KO') return $result->deleteTrack->error;
+		if($result->deleteTrack->result == 'KO') {
+			return $result->deleteTrack->error;
+		}
 		return true;
 	}
 
@@ -122,7 +130,9 @@  discard block
 block discarded – undo
 	{
 		$param_name = 'dateFrom';
 		$date_or_days ?: $date_or_days = config('qapla.orders.default_fromDate');
-		if(strtotime($date_or_days) === false) $param_name = 'days';
+		if(strtotime($date_or_days) === false) {
+			$param_name = 'days';
+		}
 
 		$client = new GuzzleHttp\Client();
 		$res = $client->get(config('qapla.url').'getOrders/', ['query' =>  [
@@ -130,7 +140,9 @@  discard block
 block discarded – undo
 			$param_name => $date_or_days]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getOrders->result == 'KO') return $result->getOrders->error;
+		if($result->getOrders->result == 'KO') {
+			return $result->getOrders->error;
+		}
 		return $result->getOrders->orders;
 	}
 
@@ -153,7 +165,9 @@  discard block
 block discarded – undo
 			'body' => $json
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->pushOrder->result == 'KO') return $result->pushOrder->error;
+		if($result->pushOrder->result == 'KO') {
+			return $result->pushOrder->error;
+		}
 		return true;
 	}
 
@@ -168,7 +182,9 @@  discard block
 block discarded – undo
 			'apiKey' => $this->privateApiKey]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getCredits->result == 'KO') return $result->getCredits->error;
+		if($result->getCredits->result == 'KO') {
+			return $result->getCredits->error;
+		}
 		return $result->getCredits->credits;
 	}
 
@@ -186,7 +202,9 @@  discard block
 block discarded – undo
 			'country'   => $country ?: config('qapla.couriers.default_country')]
 		]);
 		$result = GuzzleHttp\json_decode($res->getBody());
-		if($result->getCouriers->result == 'KO') return $result->getCouriers->error;
+		if($result->getCouriers->result == 'KO') {
+			return $result->getCouriers->error;
+		}
 		return $result->getCouriers->courier;
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

config/config.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -11,7 +11,7 @@  discard block
 block discarded – undo
 	 * Config parameters
 	 */
 	'tracks' => [
-		'default_fromDate'  => '1970-01-01 00:00:00',   // Get shipments from 1970 to today = ALL
+		'default_fromDate'  => '1970-01-01 00:00:00', // Get shipments from 1970 to today = ALL
 	],
 
 	/*
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
 	 * Config parameters
 	 */
 	'orders' => [
-		'default_fromDate'  => '1970-01-01 00:00:00',   // Get orders from 1970 to today = ALL
+		'default_fromDate'  => '1970-01-01 00:00:00', // Get orders from 1970 to today = ALL
 	],
 
 	/*

Please login to merge, or discard this patch.

		@@ -40,13 +40,13 @@ discard block
		block discarded – undo
40	40	public function getTrack($tracking_or_reference = 'trackingNumber', $value, $lang = 'ita')
41	41	{
42	42	$client = new GuzzleHttp\Client();
43		- $res = $client->get(config('qapla.url').'getTrack/', ['query' => [
	43	+ $res = $client->get(config('qapla.url').'getTrack/', [ 'query' => [
44	44	'apiKey' => $this->privateApiKey,
45	45	$tracking_or_reference => $value,
46		- 'lang' => $lang]
	46	+ 'lang' => $lang ]
47	47	]);
48	48	$result = GuzzleHttp\json_decode($res->getBody());
49		- if($result->getTrack->result == 'KO') return $result->getTrack->error;
	49	+ if ($result->getTrack->result == 'KO') return $result->getTrack->error;
50	50	return $result->getTrack;
51	51	}
52	52
		@@ -58,14 +58,14 @@ discard block
		block discarded – undo
58	58	*/
59	59	public function pushTrack($data)
60	60	{
61		- $json ='{
	61	+ $json = '{
62	62	"apiKey": "'.$this->privateApiKey.'",
63	63	"pushTrack": '.json_encode($data).'
64	64	}';
65	65
66	66	$client = new GuzzleHttp\Client();
67	67	$res = $client->post(config('qapla.url').'pushTrack/', [
68		- 'headers' => ['content-type' => 'application/json'],
	68	+ 'headers' => [ 'content-type' => 'application/json' ],
69	69	'body' => $json
70	70	]);
71	71	$result = GuzzleHttp\json_decode($res->getBody());
		@@ -82,15 +82,15 @@ discard block
		block discarded – undo
82	82	{
83	83	$param_name = 'dateFrom';
84	84	$date_or_days ?: $date_or_days = config('qapla.orders.default_fromDate');
85		- if(strtotime($date_or_days) === false) $param_name = 'days';
	85	+ if (strtotime($date_or_days) === false) $param_name = 'days';
86	86
87	87	$client = new GuzzleHttp\Client();
88		- $res = $client->get(config('qapla.url').'getTracks/', ['query' => [
	88	+ $res = $client->get(config('qapla.url').'getTracks/', [ 'query' => [
89	89	'apiKey' => $this->privateApiKey,
90		- $param_name => $date_or_days]
	90	+ $param_name => $date_or_days ]
91	91	]);
92	92	$result = GuzzleHttp\json_decode($res->getBody());
93		- if($result->getTracks->result == 'KO') return $result->getTracks->error;
	93	+ if ($result->getTracks->result == 'KO') return $result->getTracks->error;
94	94	return $result->getTracks->tracks;
95	95	}
96	96
		@@ -103,12 +103,12 @@ discard block
		block discarded – undo
103	103	public function deleteTrack($trackingNumber)
104	104	{
105	105	$client = new GuzzleHttp\Client();
106		- $res = $client->get(config('qapla.url').'deleteTrack/', ['query' => [
	106	+ $res = $client->get(config('qapla.url').'deleteTrack/', [ 'query' => [
107	107	'apiKey' => $this->privateApiKey,
108		- 'trackingNumber' => $trackingNumber]
	108	+ 'trackingNumber' => $trackingNumber ]
109	109	]);
110	110	$result = GuzzleHttp\json_decode($res->getBody());
111		- if($result->deleteTrack->result == 'KO') return $result->deleteTrack->error;
	111	+ if ($result->deleteTrack->result == 'KO') return $result->deleteTrack->error;
112	112	return true;
113	113	}
114	114
		@@ -122,15 +122,15 @@ discard block
		block discarded – undo
122	122	{
123	123	$param_name = 'dateFrom';
124	124	$date_or_days ?: $date_or_days = config('qapla.orders.default_fromDate');
125		- if(strtotime($date_or_days) === false) $param_name = 'days';
	125	+ if (strtotime($date_or_days) === false) $param_name = 'days';
126	126
127	127	$client = new GuzzleHttp\Client();
128		- $res = $client->get(config('qapla.url').'getOrders/', ['query' => [
	128	+ $res = $client->get(config('qapla.url').'getOrders/', [ 'query' => [
129	129	'apiKey' => $this->privateApiKey,
130		- $param_name => $date_or_days]
	130	+ $param_name => $date_or_days ]
131	131	]);
132	132	$result = GuzzleHttp\json_decode($res->getBody());
133		- if($result->getOrders->result == 'KO') return $result->getOrders->error;
	133	+ if ($result->getOrders->result == 'KO') return $result->getOrders->error;
134	134	return $result->getOrders->orders;
135	135	}
136	136
		@@ -142,18 +142,18 @@ discard block
		block discarded – undo
142	142	*/
143	143	public function pushOrder($data)
144	144	{
145		- $json ='{
	145	+ $json = '{
146	146	"apiKey": "'.$this->privateApiKey.'",
147	147	"pushOrder": '.json_encode($data).'
148	148	}';
149	149
150	150	$client = new GuzzleHttp\Client();
151	151	$res = $client->post(config('qapla.url').'pushOrder/', [
152		- 'headers' => ['content-type' => 'application/json'],
	152	+ 'headers' => [ 'content-type' => 'application/json' ],
153	153	'body' => $json
154	154	]);
155	155	$result = GuzzleHttp\json_decode($res->getBody());
156		- if($result->pushOrder->result == 'KO') return $result->pushOrder->error;
	156	+ if ($result->pushOrder->result == 'KO') return $result->pushOrder->error;
157	157	return true;
158	158	}
159	159
		@@ -164,11 +164,11 @@ discard block
		block discarded – undo
164	164	public function getCredits()
165	165	{
166	166	$client = new GuzzleHttp\Client();
167		- $res = $client->get(config('qapla.url').'getCredits/', ['query' => [
168		- 'apiKey' => $this->privateApiKey]
	167	+ $res = $client->get(config('qapla.url').'getCredits/', [ 'query' => [
	168	+ 'apiKey' => $this->privateApiKey ]
169	169	]);
170	170	$result = GuzzleHttp\json_decode($res->getBody());
171		- if($result->getCredits->result == 'KO') return $result->getCredits->error;
	171	+ if ($result->getCredits->result == 'KO') return $result->getCredits->error;
172	172	return $result->getCredits->credits;
173	173	}
174	174
		@@ -181,12 +181,12 @@ discard block
		block discarded – undo
181	181	public function getCouriers($country = null)
182	182	{
183	183	$client = new GuzzleHttp\Client();
184		- $res = $client->get(config('qapla.url').'getCouriers/', ['query' => [
	184	+ $res = $client->get(config('qapla.url').'getCouriers/', [ 'query' => [
185	185	'apiKey' => $this->privateApiKey,
186		- 'country' => $country ?: config('qapla.couriers.default_country')]
	186	+ 'country' => $country ?: config('qapla.couriers.default_country') ]
187	187	]);
188	188	$result = GuzzleHttp\json_decode($res->getBody());
189		- if($result->getCouriers->result == 'KO') return $result->getCouriers->error;
	189	+ if ($result->getCouriers->result == 'KO') return $result->getCouriers->error;
190	190	return $result->getCouriers->courier;
191	191	}
192	192	}
193	193	\ No newline at end of file

		@@ -46,7 +46,9 @@ discard block
		block discarded – undo
46	46	'lang' => $lang]
47	47	]);
48	48	$result = GuzzleHttp\json_decode($res->getBody());
49		- if($result->getTrack->result == 'KO') return $result->getTrack->error;
	49	+ if($result->getTrack->result == 'KO') {
	50	+ return $result->getTrack->error;
	51	+ }
50	52	return $result->getTrack;
51	53	}
52	54
		@@ -82,7 +84,9 @@ discard block
		block discarded – undo
82	84	{
83	85	$param_name = 'dateFrom';
84	86	$date_or_days ?: $date_or_days = config('qapla.orders.default_fromDate');
85		- if(strtotime($date_or_days) === false) $param_name = 'days';
	87	+ if(strtotime($date_or_days) === false) {
	88	+ $param_name = 'days';
	89	+ }
86	90
87	91	$client = new GuzzleHttp\Client();
88	92	$res = $client->get(config('qapla.url').'getTracks/', ['query' => [
		@@ -90,7 +94,9 @@ discard block
		block discarded – undo
90	94	$param_name => $date_or_days]
91	95	]);
92	96	$result = GuzzleHttp\json_decode($res->getBody());
93		- if($result->getTracks->result == 'KO') return $result->getTracks->error;
	97	+ if($result->getTracks->result == 'KO') {
	98	+ return $result->getTracks->error;
	99	+ }
94	100	return $result->getTracks->tracks;
95	101	}
96	102
		@@ -108,7 +114,9 @@ discard block
		block discarded – undo
108	114	'trackingNumber' => $trackingNumber]
109	115	]);
110	116	$result = GuzzleHttp\json_decode($res->getBody());
111		- if($result->deleteTrack->result == 'KO') return $result->deleteTrack->error;
	117	+ if($result->deleteTrack->result == 'KO') {
	118	+ return $result->deleteTrack->error;
	119	+ }
112	120	return true;
113	121	}
114	122
		@@ -122,7 +130,9 @@ discard block
		block discarded – undo
122	130	{
123	131	$param_name = 'dateFrom';
124	132	$date_or_days ?: $date_or_days = config('qapla.orders.default_fromDate');
125		- if(strtotime($date_or_days) === false) $param_name = 'days';
	133	+ if(strtotime($date_or_days) === false) {
	134	+ $param_name = 'days';
	135	+ }
126	136
127	137	$client = new GuzzleHttp\Client();
128	138	$res = $client->get(config('qapla.url').'getOrders/', ['query' => [
		@@ -130,7 +140,9 @@ discard block
		block discarded – undo
130	140	$param_name => $date_or_days]
131	141	]);
132	142	$result = GuzzleHttp\json_decode($res->getBody());
133		- if($result->getOrders->result == 'KO') return $result->getOrders->error;
	143	+ if($result->getOrders->result == 'KO') {
	144	+ return $result->getOrders->error;
	145	+ }
134	146	return $result->getOrders->orders;
135	147	}
136	148
		@@ -153,7 +165,9 @@ discard block
		block discarded – undo
153	165	'body' => $json
154	166	]);
155	167	$result = GuzzleHttp\json_decode($res->getBody());
156		- if($result->pushOrder->result == 'KO') return $result->pushOrder->error;
	168	+ if($result->pushOrder->result == 'KO') {
	169	+ return $result->pushOrder->error;
	170	+ }
157	171	return true;
158	172	}
159	173
		@@ -168,7 +182,9 @@ discard block
		block discarded – undo
168	182	'apiKey' => $this->privateApiKey]
169	183	]);
170	184	$result = GuzzleHttp\json_decode($res->getBody());
171		- if($result->getCredits->result == 'KO') return $result->getCredits->error;
	185	+ if($result->getCredits->result == 'KO') {
	186	+ return $result->getCredits->error;
	187	+ }
172	188	return $result->getCredits->credits;
173	189	}
174	190
		@@ -186,7 +202,9 @@ discard block
		block discarded – undo
186	202	'country' => $country ?: config('qapla.couriers.default_country')]
187	203	]);
188	204	$result = GuzzleHttp\json_decode($res->getBody());
189		- if($result->getCouriers->result == 'KO') return $result->getCouriers->error;
	205	+ if($result->getCouriers->result == 'KO') {
	206	+ return $result->getCouriers->error;
	207	+ }
190	208	return $result->getCouriers->courier;
191	209	}
192	210	}
193	211	\ No newline at end of file

		@@ -11,7 +11,7 @@ discard block
		block discarded – undo
11	11	* Config parameters
12	12	*/
13	13	'tracks' => [
14		- 'default_fromDate' => '1970-01-01 00:00:00', // Get shipments from 1970 to today = ALL
	14	+ 'default_fromDate' => '1970-01-01 00:00:00', // Get shipments from 1970 to today = ALL
15	15	],
16	16
17	17	/*
		@@ -19,7 +19,7 @@ discard block
		block discarded – undo
19	19	* Config parameters
20	20	*/
21	21	'orders' => [
22		- 'default_fromDate' => '1970-01-01 00:00:00', // Get orders from 1970 to today = ALL
	22	+ 'default_fromDate' => '1970-01-01 00:00:00', // Get orders from 1970 to today = ALL
23	23	],
24	24
25	25	/*

w3designweb / laravel-qapla

Push — master ( 4fce34...402a34 )

Category

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

Braces +27 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch