OrderByBuilder::build() - Code Metrics - vuongxuongminh/yii2-searchable - Measure and Improve Code Quality continuously with Scrutinizer

OrderByBuilder::build() A
last analyzed 2019-04-16 16:05 UTC

↳ Parent: OrderByBuilder

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	5
cts	5
cp	1
rs	9.8666
c	0
b	0
f	0
cc	3
nc	2
nop	2
crap	3

<?php
/**
 * @link https://github.com/vuongxuongminh/yii2-searchable
 * @copyright Copyright (c) 2019 Vuong Xuong Minh
 * @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
 */

namespace vxm\searchable\expression;

use yii\db\ExpressionBuilderInterface;
use yii\db\ExpressionBuilderTrait;
use yii\db\ExpressionInterface;

/**
 * Class OrderByBuilder for build the [[OrderBy]].
 *
 * @author Vuong Minh <[email protected]>
 * @since 1.0.0
 */
class OrderByBuilder implements ExpressionBuilderInterface
{

    use ExpressionBuilderTrait;

    /**
     * @param ExpressionInterface|OrderBy $expression
     * @inheritDoc
     */
    public function build(ExpressionInterface $expression, array &$params = [])
    {
        $orderBy = $expression->query->orderBy;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        if ($orderBy[0] === $expression && count($orderBy) === 1) {

            return $this->queryBuilder->buildExpression($expression->getExpression());
        } else { // user choice

            return '(SELECT NULL)';
        }
    }
}


1		<?php
2		/**
3		* @link https://github.com/vuongxuongminh/yii2-searchable
4		* @copyright Copyright (c) 2019 Vuong Xuong Minh
5		* @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
6		*/
7
8		namespace vxm\searchable\expression;
9
10		use yii\db\ExpressionBuilderInterface;
11		use yii\db\ExpressionBuilderTrait;
12		use yii\db\ExpressionInterface;
13
14		/**
15		* Class OrderByBuilder for build the [[OrderBy]].
16		*
17		* @author Vuong Minh <[email protected]>
18		* @since 1.0.0
19		*/
20		class OrderByBuilder implements ExpressionBuilderInterface
21		{
22
23		use ExpressionBuilderTrait;
24
25		/**
26		* @param ExpressionInterface\|OrderBy $expression
27		* @inheritDoc
28		*/
29	4	public function build(ExpressionInterface $expression, array &$params = [])
30		{
31	4	$orderBy = $expression->query->orderBy;
		0 ignored issues – show Bug introduced 2019-04-16 04:58 UTC by Report Bug Copy Issue Report Accessing `query` on the interface `yii\db\ExpressionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
32
33	4	if ($orderBy[0] === $expression && count($orderBy) === 1) {
34
35	4	return $this->queryBuilder->buildExpression($expression->getExpression());
36		} else { // user choice
37
38	1	return '(SELECT NULL)';
39		}
40		}
41		}
42

vuongxuongminh / yii2-searchable

OrderByBuilder::build() A last analyzed 2019-04-16 16:05 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

OrderByBuilder::build() A
last analyzed 2019-04-16 16:05 UTC