vxm\searchable\expression\OrderByBuilder

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	build()	0	12	3

<?php
/**
 * @link https://github.com/vuongxuongminh/yii2-searchable
 * @copyright Copyright (c) 2019 Vuong Xuong Minh
 * @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
 */

namespace vxm\searchable\expression;

use yii\db\ExpressionBuilderInterface;
use yii\db\ExpressionBuilderTrait;
use yii\db\ExpressionInterface;

/**
 * Class OrderByBuilder for build the [[OrderBy]].
 *
 * @author Vuong Minh <vuongxuongminh@gmail.com>
 * @since 1.0.0
 */
class OrderByBuilder implements ExpressionBuilderInterface
{

    use ExpressionBuilderTrait;

    /**
     * @param ExpressionInterface|OrderBy $expression
     * @inheritDoc
     */
    public function build(ExpressionInterface $expression, array &$params = [])
    {
        $orderBy = $expression->query->orderBy;

Accessing query on the interface yii\db\ExpressionInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($orderBy[0] === $expression && count($orderBy) === 1) {

            return $this->queryBuilder->buildExpression($expression->getExpression());
        } else { // user choice

            return '(SELECT NULL)';
        }
    }
}