Inspection of "Merge pull request #21 from voku/analysis-XWnK0N" - voku/simple_html_dom - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8d9f33...475fcb )

by Lars

created 2018-10-07 00:32 UTC

Status

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -15,7 +15,7 @@  discard block
 block discarded – undo
 HTML;
 
 $html = HtmlDomParser::str_get_html($str);
-echo $html->find('div div div', 0)->innertext . '<br>'; // result: "ok"
+echo $html->find('div div div', 0)->innertext.'<br>'; // result: "ok"
 
 // -----------------------------------------------------------------------------
 // nested selector
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 $html = HtmlDomParser::str_get_html($str);
 foreach ($html->find('ul') as $ul) {
   foreach ($ul->find('li') as $li) {
-    echo $li->innertext . '<br>';
+    echo $li->innertext.'<br>';
   }
 }
 
@@ -50,8 +50,8 @@  discard block
 block discarded – undo
 $html = HtmlDomParser::str_get_html($str);
 foreach ($html->find('input[type=checkbox]') as $checkbox) {
   if ($checkbox->checked) {
-    echo $checkbox->name . ' is checked<br>';
+    echo $checkbox->name.' is checked<br>';
   } else {
-    echo $checkbox->name . ' is not checked<br>';
+    echo $checkbox->name.' is not checked<br>';
   }
 }

Please login to merge, or discard this patch.

example/example_basic_selector.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -9,36 +9,36 @@
 block discarded – undo
 
 // find all link
 foreach ($html->find('a') as $e) {
-  echo $e->href . '<br>';
+  echo $e->href.'<br>';
 }
 
 // find all image
 foreach ($html->find('img') as $e) {
-  echo $e->src . '<br>';
+  echo $e->src.'<br>';
 }
 
 // find all image with full tag
 foreach ($html->find('img') as $e) {
-  echo $e->outertext . '<br>';
+  echo $e->outertext.'<br>';
 }
 
 // find all div tags with id=gbar
 foreach ($html->find('div#gbar') as $e) {
-  echo $e->innertext . '<br>';
+  echo $e->innertext.'<br>';
 }
 
 // find all span tags with class=gb1
 foreach ($html->find('span.gb1') as $e) {
-  echo $e->outertext . '<br>';
+  echo $e->outertext.'<br>';
 }
 
 // find all td tags with attribite align=center
 foreach ($html->find('td[align=center]') as $e) {
-  echo $e->innertext . '<br>';
+  echo $e->innertext.'<br>';
 }
 
 // extract text from table
-echo $html->find('td[align="center"]', 1)->plaintext . '<br><hr>';
+echo $html->find('td[align="center"]', 1)->plaintext.'<br><hr>';
 
 // extract text from HTML
 echo $html->plaintext;

Please login to merge, or discard this patch.

src/voku/helper/SimpleHtmlDom.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -701,7 +701,7 @@
 block discarded – undo
    *
    * @param string $name <p>The name of the html-attribute.</p>
    *
-   * @return mixed
+   * @return SimpleHtmlDom
    */
   public function removeAttribute(string $name)
   {

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -580,7 +580,7 @@
 block discarded – undo
         $string = \str_replace(['<head>', '</head>'], '', $string);
       }
     } else {
-      $string = (string)$input;
+      $string = (string) $input;
     }
 
     return

Please login to merge, or discard this patch.

src/voku/helper/HtmlDomParser.php 2 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -430,10 +430,10 @@
 block discarded – undo
         '/(?<start>.*)<(?<element_start>[a-z]+)(?<element_start_addon> [^>]*)?>(?<value>.*?)<\/(?<element_end>\2)>(?<end>.*)/sui',
         function ($matches) {
           return $matches['start'] .
-                 '°lt_simple_html_dom__voku_°' . $matches['element_start'] . $matches['element_start_addon'] . '°gt_simple_html_dom__voku_°' .
-                 $matches['value'] .
-                 '°lt/_simple_html_dom__voku_°' . $matches['element_end'] . '°gt_simple_html_dom__voku_°' .
-                 $matches['end'];
+                  '°lt_simple_html_dom__voku_°' . $matches['element_start'] . $matches['element_start_addon'] . '°gt_simple_html_dom__voku_°' .
+                  $matches['value'] .
+                  '°lt/_simple_html_dom__voku_°' . $matches['element_end'] . '°gt_simple_html_dom__voku_°' .
+                  $matches['end'];
         },
         $html
       );

Please login to merge, or discard this patch.

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
    * @var string[][]
    */
   protected static $domLinkReplaceHelper = [
-    'orig' => ['[', ']', '{', '}',],
+    'orig' => ['[', ']', '{', '}', ],
     'tmp'  => [
       '____SIMPLE_HTML_DOM__VOKU__SQUARE_BRACKET_LEFT____',
       '____SIMPLE_HTML_DOM__VOKU__SQUARE_BRACKET_RIGHT____',
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
       return \call_user_func_array([$this, self::$functionAliases[$name]], $arguments);
     }
 
-    throw new \BadMethodCallException('Method does not exist: ' . $name);
+    throw new \BadMethodCallException('Method does not exist: '.$name);
   }
 
   /**
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
 
       if (!empty($linksOld[1])) {
         $linksOld = $linksOld[1];
-        foreach ((array)$linksOld as $linkKey => $linkOld) {
+        foreach ((array) $linksOld as $linkKey => $linkOld) {
           $linksNew[$linkKey] = \str_replace(
             self::$domLinkReplaceHelper['orig'],
             self::$domLinkReplaceHelper['tmp'],
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
       $xmlHackUsed = false;
       if (\stripos('<?xml', $html) !== 0) {
         $xmlHackUsed = true;
-        $html = '<?xml encoding="' . $this->getEncoding() . '" ?>' . $html;
+        $html = '<?xml encoding="'.$this->getEncoding().'" ?>'.$html;
       }
 
       $html = self::replaceToPreserveHtmlEntities($html);
@@ -426,13 +426,13 @@  discard block
 block discarded – undo
     do {
       $original = $html;
 
-      $html = (string)preg_replace_callback(
+      $html = (string) preg_replace_callback(
         '/(?<start>.*)<(?<element_start>[a-z]+)(?<element_start_addon> [^>]*)?>(?<value>.*?)<\/(?<element_end>\2)>(?<end>.*)/sui',
-        function ($matches) {
-          return $matches['start'] .
-                 '°lt_simple_html_dom__voku_°' . $matches['element_start'] . $matches['element_start_addon'] . '°gt_simple_html_dom__voku_°' .
-                 $matches['value'] .
-                 '°lt/_simple_html_dom__voku_°' . $matches['element_end'] . '°gt_simple_html_dom__voku_°' .
+        function($matches) {
+          return $matches['start'].
+                 '°lt_simple_html_dom__voku_°'.$matches['element_start'].$matches['element_start_addon'].'°gt_simple_html_dom__voku_°'.
+                 $matches['value'].
+                 '°lt/_simple_html_dom__voku_°'.$matches['element_end'].'°gt_simple_html_dom__voku_°'.
                  $matches['end'];
         },
         $html
@@ -446,9 +446,9 @@  discard block
 block discarded – undo
     do {
       $original = $html;
 
-      $html = (string)preg_replace_callback(
+      $html = (string) preg_replace_callback(
         '/(?<start>[^<]*)?(?<broken>(?:(?:<\/\w+(?:\s+\w+=\\"[^\"]+\\")*+)(?:[^<]+)>)+)(?<end>.*)/u',
-        function ($matches) {
+        function($matches) {
 
           $matches['broken'] = str_replace(
             array('°lt/_simple_html_dom__voku_°', '°lt_simple_html_dom__voku_°', '°gt_simple_html_dom__voku_°'),
@@ -459,9 +459,9 @@  discard block
 block discarded – undo
           //var_dump($matches['broken']);
 
           self::$domBrokenReplaceHelper['orig'][] = $matches['broken'];
-          self::$domBrokenReplaceHelper['tmp'][] = $matchesHash = '____simple_html_dom__voku__broken_html____' . crc32($matches['broken']);
+          self::$domBrokenReplaceHelper['tmp'][] = $matchesHash = '____simple_html_dom__voku__broken_html____'.crc32($matches['broken']);
 
-          return $matches['start'] . $matchesHash . $matches['end'];
+          return $matches['start'].$matchesHash.$matches['end'];
         },
         $html
       );
@@ -478,7 +478,7 @@  discard block
 block discarded – undo
     );
 
     if ($backup !== $html) {
-      $html = '<____simple_html_dom__voku__broken_html_wrapper____>' . $html . '</____simple_html_dom__voku__broken_html_wrapper____>';
+      $html = '<____simple_html_dom__voku__broken_html_wrapper____>'.$html.'</____simple_html_dom__voku__broken_html_wrapper____>';
     }
 
     return $html;
@@ -647,8 +647,8 @@  discard block
 block discarded – undo
     }
 
     if ($this->isDOMDocumentCreatedWithoutWrapper === true) {
-      $content = (string)\preg_replace('/^<p>/', '', $content);
-      $content = (string)\preg_replace('/<\/p>/', '', $content);
+      $content = (string) \preg_replace('/^<p>/', '', $content);
+      $content = (string) \preg_replace('/<\/p>/', '', $content);
     }
 
     if ($this->isDOMDocumentCreatedWithoutHtml === true) {
@@ -809,7 +809,7 @@  discard block
 block discarded – undo
     $xml = $this->document->saveXML(null, \LIBXML_NOEMPTYTAG);
 
     // remove the XML-header
-    $xml = \ltrim((string)\preg_replace('/<\?xml.*\?>/', '', $xml));
+    $xml = \ltrim((string) \preg_replace('/<\?xml.*\?>/', '', $xml));
 
     return $this->fixHtmlOutput($xml, $multiDecodeNewHtmlEntity);
   }

Please login to merge, or discard this patch.

		@@ -701,7 +701,7 @@
		block discarded – undo
701	701	*
702	702	* @param string $name <p>The name of the html-attribute.</p>
703	703	*
704		- * @return mixed
	704	+ * @return SimpleHtmlDom
705	705	*/
706	706	public function removeAttribute(string $name)
707	707	{

		@@ -580,7 +580,7 @@
		block discarded – undo
580	580	$string = \str_replace(['<head>', '</head>'], '', $string);
581	581	}
582	582	} else {
583		- $string = (string)$input;
	583	+ $string = (string) $input;
584	584	}
585	585
586	586	return

		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	* @var string[][]
45	45	*/
46	46	protected static $domLinkReplaceHelper = [
47		- 'orig' => ['[', ']', '{', '}',],
	47	+ 'orig' => ['[', ']', '{', '}', ],
48	48	'tmp' => [
49	49	'____SIMPLE_HTML_DOM__VOKU__SQUARE_BRACKET_LEFT____',
50	50	'____SIMPLE_HTML_DOM__VOKU__SQUARE_BRACKET_RIGHT____',
		@@ -161,7 +161,7 @@ discard block
		block discarded – undo
161	161	return \call_user_func_array([$this, self::$functionAliases[$name]], $arguments);
162	162	}
163	163
164		- throw new \BadMethodCallException('Method does not exist: ' . $name);
	164	+ throw new \BadMethodCallException('Method does not exist: '.$name);
165	165	}
166	166
167	167	/**
		@@ -270,7 +270,7 @@ discard block
		block discarded – undo
270	270
271	271	if (!empty($linksOld[1])) {
272	272	$linksOld = $linksOld[1];
273		- foreach ((array)$linksOld as $linkKey => $linkOld) {
	273	+ foreach ((array) $linksOld as $linkKey => $linkOld) {
274	274	$linksNew[$linkKey] = \str_replace(
275	275	self::$domLinkReplaceHelper['orig'],
276	276	self::$domLinkReplaceHelper['tmp'],
		@@ -385,7 +385,7 @@ discard block
		block discarded – undo
385	385	$xmlHackUsed = false;
386	386	if (\stripos('<?xml', $html) !== 0) {
387	387	$xmlHackUsed = true;
388		- $html = '<?xml encoding="' . $this->getEncoding() . '" ?>' . $html;
	388	+ $html = '<?xml encoding="'.$this->getEncoding().'" ?>'.$html;
389	389	}
390	390
391	391	$html = self::replaceToPreserveHtmlEntities($html);
		@@ -426,13 +426,13 @@ discard block
		block discarded – undo
426	426	do {
427	427	$original = $html;
428	428
429		- $html = (string)preg_replace_callback(
	429	+ $html = (string) preg_replace_callback(
430	430	'/(?<start>.)<(?<element_start>[a-z]+)(?<element_start_addon> [^>])?>(?<value>.?)<\/(?<element_end>\2)>(?<end>.)/sui',
431		- function ($matches) {
432		- return $matches['start'] .
433		- '°lt_simple_html_dom__voku_°' . $matches['element_start'] . $matches['element_start_addon'] . '°gt_simple_html_dom__voku_°' .
434		- $matches['value'] .
435		- '°lt/_simple_html_dom__voku_°' . $matches['element_end'] . '°gt_simple_html_dom__voku_°' .
	431	+ function($matches) {
	432	+ return $matches['start'].
	433	+ '°lt_simple_html_dom__voku_°'.$matches['element_start'].$matches['element_start_addon'].'°gt_simple_html_dom__voku_°'.
	434	+ $matches['value'].
	435	+ '°lt/_simple_html_dom__voku_°'.$matches['element_end'].'°gt_simple_html_dom__voku_°'.
436	436	$matches['end'];
437	437	},
438	438	$html
		@@ -446,9 +446,9 @@ discard block
		block discarded – undo
446	446	do {
447	447	$original = $html;
448	448
449		- $html = (string)preg_replace_callback(
	449	+ $html = (string) preg_replace_callback(
450	450	'/(?<start>[^<])?(?<broken>(?:(?:<\/\w+(?:\s+\w+=\\"[^\"]+\\")+)(?:[^<]+)>)+)(?<end>.*)/u',
451		- function ($matches) {
	451	+ function($matches) {
452	452
453	453	$matches['broken'] = str_replace(
454	454	array('°lt/_simple_html_dom__voku_°', '°lt_simple_html_dom__voku_°', '°gt_simple_html_dom__voku_°'),
		@@ -459,9 +459,9 @@ discard block
		block discarded – undo
459	459	//var_dump($matches['broken']);
460	460
461	461	self::$domBrokenReplaceHelper['orig'][] = $matches['broken'];
462		- self::$domBrokenReplaceHelper['tmp'][] = $matchesHash = '____simple_html_dom__voku__broken_html____' . crc32($matches['broken']);
	462	+ self::$domBrokenReplaceHelper['tmp'][] = $matchesHash = '____simple_html_dom__voku__broken_html____'.crc32($matches['broken']);
463	463
464		- return $matches['start'] . $matchesHash . $matches['end'];
	464	+ return $matches['start'].$matchesHash.$matches['end'];
465	465	},
466	466	$html
467	467	);
		@@ -478,7 +478,7 @@ discard block
		block discarded – undo
478	478	);
479	479
480	480	if ($backup !== $html) {
481		- $html = '<____simple_html_dom__voku__broken_html_wrapper____>' . $html . '</____simple_html_dom__voku__broken_html_wrapper____>';
	481	+ $html = '<____simple_html_dom__voku__broken_html_wrapper____>'.$html.'</____simple_html_dom__voku__broken_html_wrapper____>';
482	482	}
483	483
484	484	return $html;
		@@ -647,8 +647,8 @@ discard block
		block discarded – undo
647	647	}
648	648
649	649	if ($this->isDOMDocumentCreatedWithoutWrapper === true) {
650		- $content = (string)\preg_replace('/^<p>/', '', $content);
651		- $content = (string)\preg_replace('/<\/p>/', '', $content);
	650	+ $content = (string) \preg_replace('/^<p>/', '', $content);
	651	+ $content = (string) \preg_replace('/<\/p>/', '', $content);
652	652	}
653	653
654	654	if ($this->isDOMDocumentCreatedWithoutHtml === true) {
		@@ -809,7 +809,7 @@ discard block
		block discarded – undo
809	809	$xml = $this->document->saveXML(null, \LIBXML_NOEMPTYTAG);
810	810
811	811	// remove the XML-header
812		- $xml = \ltrim((string)\preg_replace('/<\?xml.*\?>/', '', $xml));
	812	+ $xml = \ltrim((string) \preg_replace('/<\?xml.*\?>/', '', $xml));
813	813
814	814	return $this->fixHtmlOutput($xml, $multiDecodeNewHtmlEntity);
815	815	}

		@@ -15,7 +15,7 @@ discard block
		block discarded – undo
15	15	HTML;
16	16
17	17	$html = HtmlDomParser::str_get_html($str);
18		-echo $html->find('div div div', 0)->innertext . '<br>'; // result: "ok"
	18	+echo $html->find('div div div', 0)->innertext.'<br>'; // result: "ok"
19	19
20	20	// -----------------------------------------------------------------------------
21	21	// nested selector
		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	$html = HtmlDomParser::str_get_html($str);
34	34	foreach ($html->find('ul') as $ul) {
35	35	foreach ($ul->find('li') as $li) {
36		- echo $li->innertext . '<br>';
	36	+ echo $li->innertext.'<br>';
37	37	}
38	38	}
39	39
		@@ -50,8 +50,8 @@ discard block
		block discarded – undo
50	50	$html = HtmlDomParser::str_get_html($str);
51	51	foreach ($html->find('input[type=checkbox]') as $checkbox) {
52	52	if ($checkbox->checked) {
53		- echo $checkbox->name . ' is checked<br>';
	53	+ echo $checkbox->name.' is checked<br>';
54	54	} else {
55		- echo $checkbox->name . ' is not checked<br>';
	55	+ echo $checkbox->name.' is not checked<br>';
56	56	}
57	57	}

		@@ -9,36 +9,36 @@
		block discarded – undo
9	9
10	10	// find all link
11	11	foreach ($html->find('a') as $e) {
12		- echo $e->href . '<br>';
	12	+ echo $e->href.'<br>';
13	13	}
14	14
15	15	// find all image
16	16	foreach ($html->find('img') as $e) {
17		- echo $e->src . '<br>';
	17	+ echo $e->src.'<br>';
18	18	}
19	19
20	20	// find all image with full tag
21	21	foreach ($html->find('img') as $e) {
22		- echo $e->outertext . '<br>';
	22	+ echo $e->outertext.'<br>';
23	23	}
24	24
25	25	// find all div tags with id=gbar
26	26	foreach ($html->find('div#gbar') as $e) {
27		- echo $e->innertext . '<br>';
	27	+ echo $e->innertext.'<br>';
28	28	}
29	29
30	30	// find all span tags with class=gb1
31	31	foreach ($html->find('span.gb1') as $e) {
32		- echo $e->outertext . '<br>';
	32	+ echo $e->outertext.'<br>';
33	33	}
34	34
35	35	// find all td tags with attribite align=center
36	36	foreach ($html->find('td[align=center]') as $e) {
37		- echo $e->innertext . '<br>';
	37	+ echo $e->innertext.'<br>';
38	38	}
39	39
40	40	// extract text from table
41		-echo $html->find('td[align="center"]', 1)->plaintext . '<br><hr>';
	41	+echo $html->find('td[align="center"]', 1)->plaintext.'<br><hr>';
42	42
43	43	// extract text from HTML
44	44	echo $html->plaintext;

		@@ -430,10 +430,10 @@
		block discarded – undo
430	430	'/(?<start>.)<(?<element_start>[a-z]+)(?<element_start_addon> [^>])?>(?<value>.?)<\/(?<element_end>\2)>(?<end>.)/sui',
431	431	function ($matches) {
432	432	return $matches['start'] .
433		- '°lt_simple_html_dom__voku_°' . $matches['element_start'] . $matches['element_start_addon'] . '°gt_simple_html_dom__voku_°' .
434		- $matches['value'] .
435		- '°lt/_simple_html_dom__voku_°' . $matches['element_end'] . '°gt_simple_html_dom__voku_°' .
436		- $matches['end'];
	433	+ '°lt_simple_html_dom__voku_°' . $matches['element_start'] . $matches['element_start_addon'] . '°gt_simple_html_dom__voku_°' .
	434	+ $matches['value'] .
	435	+ '°lt/_simple_html_dom__voku_°' . $matches['element_end'] . '°gt_simple_html_dom__voku_°' .
	436	+ $matches['end'];
437	437	},
438	438	$html
439	439	);

voku / simple_html_dom

Push — master ( 8d9f33...475fcb )

Status

Category

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch