Completed
Push — master ( 1c6413...a10a3f )
by Lars
03:32
created
src/voku/db/DB.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -239,15 +239,15 @@  discard block
 block discarded – undo
239 239
     ) {
240 240
 
241 241
       if (!$this->hostname) {
242
-        throw new \InvalidArgumentException ('no-sql-hostname');
242
+        throw new \InvalidArgumentException('no-sql-hostname');
243 243
       }
244 244
 
245 245
       if (!$this->username) {
246
-        throw new \InvalidArgumentException ('no-sql-username');
246
+        throw new \InvalidArgumentException('no-sql-username');
247 247
       }
248 248
 
249 249
       if (!$this->database) {
250
-        throw new \InvalidArgumentException ('no-sql-database');
250
+        throw new \InvalidArgumentException('no-sql-database');
251 251
       }
252 252
 
253 253
       return false;
@@ -288,14 +288,14 @@  discard block
 block discarded – undo
288 288
           $this->socket
289 289
       );
290 290
     } catch (\Exception $e) {
291
-      $error = 'Error connecting to mysql server: ' . $e->getMessage();
291
+      $error = 'Error connecting to mysql server: '.$e->getMessage();
292 292
       $this->_debug->displayError($error, false);
293 293
       throw new DBConnectException($error, 100, $e);
294 294
     }
295 295
     \mysqli_report(MYSQLI_REPORT_OFF);
296 296
 
297 297
     if (!$this->connected) {
298
-      $error = 'Error connecting to mysql server: ' . \mysqli_connect_error();
298
+      $error = 'Error connecting to mysql server: '.\mysqli_connect_error();
299 299
       $this->_debug->displayError($error, false);
300 300
       /** @noinspection ThrowRawExceptionInspection */
301 301
       throw new DBConnectException($error, 101);
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
     static $firstInstance = null;
394 394
 
395 395
     if (
396
-        $hostname . $username . $password . $database . $port . $charset == ''
396
+        $hostname.$username.$password.$database.$port.$charset == ''
397 397
         &&
398 398
         null !== $firstInstance
399 399
     ) {
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
     }
402 402
 
403 403
     $connection = md5(
404
-        $hostname . $username . $password . $database . $port . $charset . (int)$exit_on_error . (int)$echo_on_error . $logger_class_name . $logger_level . (int)$session_to_db
404
+        $hostname.$username.$password.$database.$port.$charset.(int)$exit_on_error.(int)$echo_on_error.$logger_class_name.$logger_level.(int)$session_to_db
405 405
     );
406 406
 
407 407
     if (!isset($instance[$connection])) {
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
     $var = $this->escape($var, false, false, null);
616 616
 
617 617
     if (is_string($var)) {
618
-      $var = "'" . trim($var, "'") . "'";
618
+      $var = "'".trim($var, "'")."'";
619 619
     }
620 620
 
621 621
     return $var;
@@ -802,11 +802,11 @@  discard block
 block discarded – undo
802 802
 
803 803
       // exit if we have more then 3 "DB server has gone away"-errors
804 804
       if ($RECONNECT_COUNTER > 3) {
805
-        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMsg . ":\n<br />" . $sql, 5);
805
+        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMsg.":\n<br />".$sql, 5);
806 806
         throw new DBGoneAwayException($errorMsg);
807 807
       }
808 808
 
809
-      $this->_debug->mailToAdmin('DB-Error', $errorMsg . ":\n<br />" . $sql);
809
+      $this->_debug->mailToAdmin('DB-Error', $errorMsg.":\n<br />".$sql);
810 810
 
811 811
       // reconnect
812 812
       $RECONNECT_COUNTER++;
@@ -816,10 +816,10 @@  discard block
 block discarded – undo
816 816
       return $this->query($sql, $sqlParams);
817 817
     }
818 818
 
819
-    $this->_debug->mailToAdmin('SQL-Error', $errorMsg . ":\n<br />" . $sql);
819
+    $this->_debug->mailToAdmin('SQL-Error', $errorMsg.":\n<br />".$sql);
820 820
 
821 821
     // this query returned an error, we must display it (only for dev) !!!
822
-    $this->_debug->displayError($errorMsg . ' | ' . $sql);
822
+    $this->_debug->displayError($errorMsg.' | '.$sql);
823 823
 
824 824
     return false;
825 825
   }
@@ -889,7 +889,7 @@  discard block
 block discarded – undo
889 889
 
890 890
     if ($useCache === true) {
891 891
       $cache = new Cache(null, null, false, $useCache);
892
-      $cacheKey = 'sql-' . md5($query);
892
+      $cacheKey = 'sql-'.md5($query);
893 893
 
894 894
       if (
895 895
           $cache->getCacheIsReady() === true
@@ -1006,10 +1006,10 @@  discard block
 block discarded – undo
1006 1006
     $return = mysqli_set_charset($this->link, $charset);
1007 1007
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
1008 1008
     /** @noinspection UsageOfSilenceOperatorInspection */
1009
-    @\mysqli_query($this->link, 'SET CHARACTER SET ' . $charset);
1009
+    @\mysqli_query($this->link, 'SET CHARACTER SET '.$charset);
1010 1010
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
1011 1011
     /** @noinspection UsageOfSilenceOperatorInspection */
1012
-    @\mysqli_query($this->link, "SET NAMES '" . $charset . "'");
1012
+    @\mysqli_query($this->link, "SET NAMES '".$charset."'");
1013 1013
 
1014 1014
     return $return;
1015 1015
   }
@@ -1096,10 +1096,10 @@  discard block
 block discarded – undo
1096 1096
 
1097 1097
       if ($this->_debug->checkForDev() === true) {
1098 1098
         echo "Info: maybe you have to increase your 'max_allowed_packet = 30M' in the config: 'my.conf' \n<br />";
1099
-        echo 'Error:' . $errorMsg;
1099
+        echo 'Error:'.$errorMsg;
1100 1100
       }
1101 1101
 
1102
-      $this->_debug->mailToAdmin('SQL-Error in mysqli_multi_query', $errorMsg . ":\n<br />" . $sql);
1102
+      $this->_debug->mailToAdmin('SQL-Error in mysqli_multi_query', $errorMsg.":\n<br />".$sql);
1103 1103
     }
1104 1104
 
1105 1105
     // return the result only if there was a "SELECT"-query
@@ -1138,7 +1138,7 @@  discard block
 block discarded – undo
1138 1138
     }
1139 1139
 
1140 1140
     if (\mysqli_connect_errno()) {
1141
-      $this->_debug->displayError('Error connecting to mysql server: ' . \mysqli_connect_error(), false);
1141
+      $this->_debug->displayError('Error connecting to mysql server: '.\mysqli_connect_error(), false);
1142 1142
 
1143 1143
       return false;
1144 1144
     }
@@ -1249,10 +1249,10 @@  discard block
 block discarded – undo
1249 1249
     $SET = $this->_parseArrayPair($data);
1250 1250
 
1251 1251
     if ($databaseName) {
1252
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1252
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1253 1253
     }
1254 1254
 
1255
-    $sql = 'INSERT INTO ' . $databaseName . $this->quote_string($table) . " SET $SET;";
1255
+    $sql = 'INSERT INTO '.$databaseName.$this->quote_string($table)." SET $SET;";
1256 1256
 
1257 1257
     return $this->query($sql);
1258 1258
   }
@@ -1353,9 +1353,9 @@  discard block
 block discarded – undo
1353 1353
         }
1354 1354
 
1355 1355
         if ($_connector === 'NOT IN' || $_connector === 'IN') {
1356
-          $_value = '(' . implode(',', $_value) . ')';
1356
+          $_value = '('.implode(',', $_value).')';
1357 1357
         } elseif ($_connector === 'NOT BETWEEN' || $_connector === 'BETWEEN') {
1358
-          $_value = '(' . implode(' AND ', $_value) . ')';
1358
+          $_value = '('.implode(' AND ', $_value).')';
1359 1359
         }
1360 1360
 
1361 1361
       } else {
@@ -1400,7 +1400,7 @@  discard block
 block discarded – undo
1400 1400
           $_glueHelperInner = 'AND ('; // inner-loop "OR"-query glue
1401 1401
         }
1402 1402
 
1403
-        $sql .= ' ' . $_glueHelperInner . ' ' . $quoteString . ' ' . $_connector . ' ' . $valueInner . " \n";
1403
+        $sql .= ' '.$_glueHelperInner.' '.$quoteString.' '.$_connector.' '.$valueInner." \n";
1404 1404
         $tmpCounter++;
1405 1405
       }
1406 1406
 
@@ -1432,7 +1432,7 @@  discard block
 block discarded – undo
1432 1432
         )
1433 1433
     );
1434 1434
 
1435
-    return '`' . $str . '`';
1435
+    return '`'.$str.'`';
1436 1436
   }
1437 1437
 
1438 1438
   /**
@@ -1488,10 +1488,10 @@  discard block
 block discarded – undo
1488 1488
     $values = implode(',', $data);
1489 1489
 
1490 1490
     if ($databaseName) {
1491
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1491
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1492 1492
     }
1493 1493
 
1494
-    $sql = 'REPLACE INTO ' . $databaseName . $this->quote_string($table) . " ($columns) VALUES ($values);";
1494
+    $sql = 'REPLACE INTO '.$databaseName.$this->quote_string($table)." ($columns) VALUES ($values);";
1495 1495
 
1496 1496
     return $this->query($sql);
1497 1497
   }
@@ -1534,10 +1534,10 @@  discard block
 block discarded – undo
1534 1534
     }
1535 1535
 
1536 1536
     if ($databaseName) {
1537
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1537
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1538 1538
     }
1539 1539
 
1540
-    $sql = 'UPDATE ' . $databaseName . $this->quote_string($table) . " SET $SET WHERE ($WHERE);";
1540
+    $sql = 'UPDATE '.$databaseName.$this->quote_string($table)." SET $SET WHERE ($WHERE);";
1541 1541
 
1542 1542
     return $this->query($sql);
1543 1543
   }
@@ -1571,10 +1571,10 @@  discard block
 block discarded – undo
1571 1571
     }
1572 1572
 
1573 1573
     if ($databaseName) {
1574
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1574
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1575 1575
     }
1576 1576
 
1577
-    $sql = 'DELETE FROM ' . $databaseName . $this->quote_string($table) . " WHERE ($WHERE);";
1577
+    $sql = 'DELETE FROM '.$databaseName.$this->quote_string($table)." WHERE ($WHERE);";
1578 1578
 
1579 1579
     return $this->query($sql);
1580 1580
   }
@@ -1608,10 +1608,10 @@  discard block
 block discarded – undo
1608 1608
     }
1609 1609
 
1610 1610
     if ($databaseName) {
1611
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1611
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1612 1612
     }
1613 1613
 
1614
-    $sql = 'SELECT * FROM ' . $databaseName . $this->quote_string($table) . " WHERE ($WHERE);";
1614
+    $sql = 'SELECT * FROM '.$databaseName.$this->quote_string($table)." WHERE ($WHERE);";
1615 1615
 
1616 1616
     return $this->query($sql);
1617 1617
   }
Please login to merge, or discard this patch.
src/voku/db/Prepare.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
     foreach ($this->_boundParams as $param) {
83 83
       $arguments[0] .= $param['type'];
84
-      $arguments[] =& $param['value'];
84
+      $arguments[] = & $param['value'];
85 85
     }
86 86
 
87 87
     return $arguments;
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     $value = $this->_db->escape($value);
105 105
 
106 106
     if ($type === 's') {
107
-      $valueForSqlWithBoundParameters = "'" . $value . "'";
107
+      $valueForSqlWithBoundParameters = "'".$value."'";
108 108
     } elseif ($type === 'i') {
109 109
       $valueForSqlWithBoundParameters = (int)$value;
110 110
     } elseif ($type === 'd') {
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
       $trace = debug_backtrace();
186 186
     }
187 187
 
188
-    $args =& $trace[0]['args'];
188
+    $args = & $trace[0]['args'];
189 189
     $types = str_split($types);
190 190
 
191 191
     $args_count = count($args) - 1;
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 
200 200
     $arg = 1;
201 201
     foreach ($types as $typeInner) {
202
-      $val =& $args[$arg];
202
+      $val = & $args[$arg];
203 203
       $this->_boundParams[] = array(
204 204
           'type'  => $typeInner,
205 205
           'value' => &$val,
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
     $bool = parent::prepare($query);
336 336
 
337 337
     if ($bool === false) {
338
-      $this->_debug->displayError('Can not prepare query: ' . $query . ' | ' . $this->error, false);
338
+      $this->_debug->displayError('Can not prepare query: '.$query.' | '.$this->error, false);
339 339
     }
340 340
 
341 341
     return $bool;
@@ -423,11 +423,11 @@  discard block
 block discarded – undo
423 423
 
424 424
       // exit if we have more then 3 "DB server has gone away"-errors
425 425
       if ($RECONNECT_COUNTER > 3) {
426
-        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMsg . ":\n<br />" . $sql, 5);
426
+        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMsg.":\n<br />".$sql, 5);
427 427
         throw new DBGoneAwayException($errorMsg);
428 428
       }
429 429
 
430
-      $this->_debug->mailToAdmin('DB-Error', $errorMsg . ":\n<br />" . $sql);
430
+      $this->_debug->mailToAdmin('DB-Error', $errorMsg.":\n<br />".$sql);
431 431
 
432 432
       // reconnect
433 433
       $RECONNECT_COUNTER++;
@@ -437,10 +437,10 @@  discard block
 block discarded – undo
437 437
       return $this->execute();
438 438
     }
439 439
 
440
-    $this->_debug->mailToAdmin('SQL-Error', $errorMsg . ":\n<br />" . $sql);
440
+    $this->_debug->mailToAdmin('SQL-Error', $errorMsg.":\n<br />".$sql);
441 441
 
442 442
     // this query returned an error, we must display it (only for dev) !!!
443
-    $this->_debug->displayError($errorMsg . ' | ' . $sql);
443
+    $this->_debug->displayError($errorMsg.' | '.$sql);
444 444
 
445 445
     return false;
446 446
   }
Please login to merge, or discard this patch.