Completed
Push — master ( 6895c9...01f26e )
by Lars
08:35 queued 56s
created
src/voku/db/Prepare.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -170,7 +170,7 @@
 block discarded – undo
170 170
    * @param mixed  $v34
171 171
    * @param mixed  $v35
172 172
    *
173
-   * @return mixed
173
+   * @return boolean
174 174
    */
175 175
   public function bind_param_debug($types, &$v1 = null, &$v2 = null, &$v3 = null, &$v4 = null, &$v5 = null, &$v6 = null, &$v7 = null, &$v8 = null, &$v9 = null, &$v10 = null, &$v11 = null, &$v12 = null, &$v13 = null, &$v14 = null, &$v15 = null, &$v16 = null, &$v17 = null, &$v18 = null, &$v19 = null, &$v20 = null, &$v21 = null, &$v22 = null, &$v23 = null, &$v24 = null, &$v25 = null, &$v26 = null, &$v27 = null, &$v28 = null, &$v29 = null, &$v30 = null, &$v31 = null, &$v32 = null, &$v33 = null, &$v34 = null, &$v35 = null)
176 176
   {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 
80 80
     foreach ($this->_boundParams as $param) {
81 81
       $arguments[0] .= $param['type'];
82
-      $arguments[] =& $param['value'];
82
+      $arguments[] = & $param['value'];
83 83
     }
84 84
 
85 85
     return $arguments;
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     $value = $this->_db->escape($value);
103 103
 
104 104
     if ($type === 's') {
105
-      $valueForSqlWithBoundParameters = "'" . $value . "'";
105
+      $valueForSqlWithBoundParameters = "'".$value."'";
106 106
     } elseif ($type === 'i') {
107 107
       $valueForSqlWithBoundParameters = (int)$value;
108 108
     } elseif ($type === 'd') {
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
       $trace = debug_backtrace();
184 184
     }
185 185
 
186
-    $args =& $trace[0]['args'];
186
+    $args = & $trace[0]['args'];
187 187
     $types = str_split($types);
188 188
 
189 189
     $args_count = count($args) - 1;
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 
198 198
     $arg = 1;
199 199
     foreach ($types as $typeInner) {
200
-      $val =& $args[$arg];
200
+      $val = & $args[$arg];
201 201
       $this->_boundParams[] = array(
202 202
           'type'  => $typeInner,
203 203
           'value' => &$val,
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
     $bool = parent::prepare($query);
334 334
 
335 335
     if ($bool === false) {
336
-      $this->_debug->displayError('Can\'t prepare Query: ' . $query . ' | ' . $this->error, false);
336
+      $this->_debug->displayError('Can\'t prepare Query: '.$query.' | '.$this->error, false);
337 337
     }
338 338
 
339 339
     return true;
@@ -420,11 +420,11 @@  discard block
 block discarded – undo
420 420
 
421 421
       // exit if we have more then 3 "DB server has gone away"-errors
422 422
       if ($reconnectCounter > 3) {
423
-        $this->_debug->mailToAdmin('SQL-Fatal-Error', $errorMsg . ":\n<br />" . $sql, 5);
423
+        $this->_debug->mailToAdmin('SQL-Fatal-Error', $errorMsg.":\n<br />".$sql, 5);
424 424
         throw new \Exception($errorMsg);
425 425
       }
426 426
 
427
-      $this->_debug->mailToAdmin('SQL-Error', $errorMsg . ":\n<br />" . $sql);
427
+      $this->_debug->mailToAdmin('SQL-Error', $errorMsg.":\n<br />".$sql);
428 428
 
429 429
       // reconnect
430 430
       $reconnectCounter++;
@@ -434,10 +434,10 @@  discard block
 block discarded – undo
434 434
       return $this->execute();
435 435
     }
436 436
 
437
-    $this->_debug->mailToAdmin('SQL-Warning', $errorMsg . ":\n<br />" . $sql);
437
+    $this->_debug->mailToAdmin('SQL-Warning', $errorMsg.":\n<br />".$sql);
438 438
 
439 439
     // this query returned an error, we must display it (only for dev) !!!
440
-    $this->_debug->displayError($errorMsg . ' | ' . $sql);
440
+    $this->_debug->displayError($errorMsg.' | '.$sql);
441 441
 
442 442
     return false;
443 443
   }
Please login to merge, or discard this patch.
src/voku/db/Debug.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -133,9 +133,9 @@  discard block
 block discarded – undo
133 133
     $this->logger(
134 134
         array(
135 135
             'error',
136
-            '<strong>' . date(
136
+            '<strong>'.date(
137 137
                 'd. m. Y G:i:s'
138
-            ) . ' (' . $fileInfo['file'] . ' line: ' . $fileInfo['line'] . ') (sql-error):</strong> ' . $error . '<br>',
138
+            ).' ('.$fileInfo['file'].' line: '.$fileInfo['line'].') (sql-error):</strong> '.$error.'<br>',
139 139
         )
140 140
     );
141 141
 
@@ -148,11 +148,11 @@  discard block
 block discarded – undo
148 148
         $box_bg = $this->css_mysql_box_bg;
149 149
 
150 150
         echo '
151
-        <div class="OBJ-mysql-box" style="border:' . $box_border . '; background:' . $box_bg . '; padding:10px; margin:10px;">
151
+        <div class="OBJ-mysql-box" style="border:' . $box_border.'; background:'.$box_bg.'; padding:10px; margin:10px;">
152 152
           <b style="font-size:14px;">MYSQL Error:</b>
153 153
           <code style="display:block;">
154
-            file / line: ' . $fileInfo['file'] . ' / ' . $fileInfo['line'] . '
155
-            ' . $error . '
154
+            file / line: ' . $fileInfo['file'].' / '.$fileInfo['line'].'
155
+            ' . $error.'
156 156
           </code>
157 157
         </div>
158 158
         ';
@@ -293,21 +293,21 @@  discard block
 block discarded – undo
293 293
     // get extra info
294 294
     $infoExtra = \mysqli_info($this->_db->getLink());
295 295
     if ($infoExtra) {
296
-      $infoExtra = ' | info => ' . $infoExtra;
296
+      $infoExtra = ' | info => '.$infoExtra;
297 297
     }
298 298
 
299 299
     //
300 300
     // logging
301 301
     //
302 302
 
303
-    $info = 'time => ' . round($duration, 5) . ' | results => ' . (int)$results . $infoExtra . ' | SQL => ' . UTF8::htmlentities($sql);
303
+    $info = 'time => '.round($duration, 5).' | results => '.(int)$results.$infoExtra.' | SQL => '.UTF8::htmlentities($sql);
304 304
 
305 305
     $fileInfo = $this->getFileAndLineFromSql();
306 306
 
307 307
     return $this->logger(
308 308
         array(
309 309
             $logLevel,
310
-            '<strong>' . date('d. m. Y G:i:s') . ' (' . $fileInfo['file'] . ' line: ' . $fileInfo['line'] . '):</strong> ' . $info . '<br>',
310
+            '<strong>'.date('d. m. Y G:i:s').' ('.$fileInfo['file'].' line: '.$fileInfo['line'].'):</strong> '.$info.'<br>',
311 311
             'sql',
312 312
         )
313 313
     );
@@ -373,21 +373,21 @@  discard block
 block discarded – undo
373 373
         $this->logger(
374 374
             array(
375 375
                 'debug',
376
-                $subject . ' | ' . $htmlBody,
376
+                $subject.' | '.$htmlBody,
377 377
             )
378 378
         );
379 379
       } elseif ($priority > 3) {
380 380
         $this->logger(
381 381
             array(
382 382
                 'error',
383
-                $subject . ' | ' . $htmlBody,
383
+                $subject.' | '.$htmlBody,
384 384
             )
385 385
         );
386 386
       } elseif ($priority < 3) {
387 387
         $this->logger(
388 388
             array(
389 389
                 'info',
390
-                $subject . ' | ' . $htmlBody,
390
+                $subject.' | '.$htmlBody,
391 391
             )
392 392
         );
393 393
       }
Please login to merge, or discard this patch.
src/voku/db/Result.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -340,7 +340,7 @@
 block discarded – undo
340 340
    * Fetch as object.
341 341
    *
342 342
    * @param string     $class
343
-   * @param null|array $params
343
+   * @param string $params
344 344
    * @param bool       $reset
345 345
    *
346 346
    * @return object|false <p><strong>false</strong> on error</p>
Please login to merge, or discard this patch.
src/voku/db/Helper.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
   /**
13 13
    * Check if "mysqlnd"-driver is used.
14 14
    *
15
-   * @return bool
15
+   * @return boolean|null
16 16
    */
17 17
   public static function isMysqlndIsUsed()
18 18
   {
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
    *
77 77
    * @param DB $db
78 78
    *
79
-   * @return string
79
+   * @return integer|null
80 80
    */
81 81
   public static function get_mysql_client_version(DB $db)
82 82
   {
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
    *
96 96
    * @param DB $db
97 97
    *
98
-   * @return string
98
+   * @return integer|null
99 99
    */
100 100
   public static function get_mysql_server_version(DB $db)
101 101
   {
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -146,10 +146,10 @@  discard block
 block discarded – undo
146 146
     }
147 147
 
148 148
     if ($databaseName) {
149
-      $databaseName = $dbConnection->quote_string(trim($databaseName)) . '.';
149
+      $databaseName = $dbConnection->quote_string(trim($databaseName)).'.';
150 150
     }
151 151
 
152
-    $sql = 'SHOW COLUMNS FROM ' . $databaseName . $dbConnection->escape($table);
152
+    $sql = 'SHOW COLUMNS FROM '.$databaseName.$dbConnection->escape($table);
153 153
     $result = $dbConnection->query($sql);
154 154
 
155 155
     if ($result && $result->num_rows > 0) {
@@ -195,17 +195,17 @@  discard block
 block discarded – undo
195 195
 
196 196
     $whereSQL = '';
197 197
     foreach ($whereArray as $key => $value) {
198
-      $whereSQL .= ' AND ' . $dbConnection->escape($key) . ' = ' . $dbConnection->escape($value);
198
+      $whereSQL .= ' AND '.$dbConnection->escape($key).' = '.$dbConnection->escape($value);
199 199
     }
200 200
 
201 201
     if ($databaseName) {
202
-      $databaseName = $dbConnection->quote_string(trim($databaseName)) . '.';
202
+      $databaseName = $dbConnection->quote_string(trim($databaseName)).'.';
203 203
     }
204 204
 
205 205
     // get the row
206
-    $query = 'SELECT * FROM ' . $databaseName . $dbConnection->quote_string($table) . '
206
+    $query = 'SELECT * FROM '.$databaseName.$dbConnection->quote_string($table).'
207 207
       WHERE 1 = 1
208
-      ' . $whereSQL . '
208
+      ' . $whereSQL.'
209 209
     ';
210 210
     $result = $dbConnection->query($query);
211 211
 
@@ -225,11 +225,11 @@  discard block
 block discarded – undo
225 225
 
226 226
           if (!in_array($fieldName, $ignoreArray, true)) {
227 227
             if (array_key_exists($fieldName, $updateArray)) {
228
-              $insert_keys .= ',' . $fieldName;
228
+              $insert_keys .= ','.$fieldName;
229 229
               $insert_values .= ',?';
230 230
               $bindings[] = $updateArray[$fieldName]; // INFO: do not escape non selected data
231 231
             } else {
232
-              $insert_keys .= ',' . $fieldName;
232
+              $insert_keys .= ','.$fieldName;
233 233
               $insert_values .= ',?';
234 234
               $bindings[] = $value; // INFO: do not escape non selected data
235 235
             }
@@ -240,10 +240,10 @@  discard block
 block discarded – undo
240 240
         $insert_values = ltrim($insert_values, ',');
241 241
 
242 242
         // insert the "copied" row
243
-        $new_query = 'INSERT INTO ' . $databaseName . $dbConnection->quote_string($table) . ' 
244
-          (' . $insert_keys . ')
243
+        $new_query = 'INSERT INTO '.$databaseName.$dbConnection->quote_string($table).' 
244
+          (' . $insert_keys.')
245 245
           VALUES 
246
-          (' . $insert_values . ')
246
+          (' . $insert_values.')
247 247
         ';
248 248
         return $dbConnection->query($new_query, $bindings);
249 249
       }
Please login to merge, or discard this patch.
src/voku/db/DB.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -282,12 +282,12 @@  discard block
 block discarded – undo
282 282
           $this->socket
283 283
       );
284 284
     } catch (\Exception $e) {
285
-      $this->_debug->displayError('Error connecting to mysql server: ' . $e->getMessage(), true);
285
+      $this->_debug->displayError('Error connecting to mysql server: '.$e->getMessage(), true);
286 286
     }
287 287
     \mysqli_report(MYSQLI_REPORT_OFF);
288 288
 
289 289
     if (!$this->connected) {
290
-      $this->_debug->displayError('Error connecting to mysql server: ' . \mysqli_connect_error(), true);
290
+      $this->_debug->displayError('Error connecting to mysql server: '.\mysqli_connect_error(), true);
291 291
     } else {
292 292
       $this->set_charset($this->charset);
293 293
     }
@@ -382,7 +382,7 @@  discard block
 block discarded – undo
382 382
     static $firstInstance = null;
383 383
 
384 384
     if (
385
-        $hostname . $username . $password . $database . $port . $charset == ''
385
+        $hostname.$username.$password.$database.$port.$charset == ''
386 386
         &&
387 387
         null !== $firstInstance
388 388
     ) {
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
     }
391 391
 
392 392
     $connection = md5(
393
-        $hostname . $username . $password . $database . $port . $charset . (int)$exit_on_error . (int)$echo_on_error . $logger_class_name . $logger_level . (int)$session_to_db
393
+        $hostname.$username.$password.$database.$port.$charset.(int)$exit_on_error.(int)$echo_on_error.$logger_class_name.$logger_level.(int)$session_to_db
394 394
     );
395 395
 
396 396
     if (!isset($instance[$connection])) {
@@ -600,7 +600,7 @@  discard block
 block discarded – undo
600 600
     $var = $this->escape($var, false, false, null);
601 601
 
602 602
     if (is_string($var)) {
603
-      $var = "'" . trim($var, "'") . "'";
603
+      $var = "'".trim($var, "'")."'";
604 604
     }
605 605
 
606 606
     return $var;
@@ -786,11 +786,11 @@  discard block
 block discarded – undo
786 786
 
787 787
       // exit if we have more then 3 "DB server has gone away"-errors
788 788
       if ($RECONNECT_COUNTER > 3) {
789
-        $this->_debug->mailToAdmin('SQL-Fatal-Error', $errorMsg . ":\n<br />" . $sql, 5);
789
+        $this->_debug->mailToAdmin('SQL-Fatal-Error', $errorMsg.":\n<br />".$sql, 5);
790 790
         throw new \Exception($errorMsg);
791 791
       }
792 792
 
793
-      $this->_debug->mailToAdmin('SQL-Error', $errorMsg . ":\n<br />" . $sql);
793
+      $this->_debug->mailToAdmin('SQL-Error', $errorMsg.":\n<br />".$sql);
794 794
 
795 795
       // reconnect
796 796
       $RECONNECT_COUNTER++;
@@ -800,10 +800,10 @@  discard block
 block discarded – undo
800 800
       return $this->query($sql, $sqlParams);
801 801
     }
802 802
 
803
-    $this->_debug->mailToAdmin('SQL-Warning', $errorMsg . ":\n<br />" . $sql);
803
+    $this->_debug->mailToAdmin('SQL-Warning', $errorMsg.":\n<br />".$sql);
804 804
 
805 805
     // this query returned an error, we must display it (only for dev) !!!
806
-    $this->_debug->displayError($errorMsg . ' | ' . $sql);
806
+    $this->_debug->displayError($errorMsg.' | '.$sql);
807 807
 
808 808
     return false;
809 809
   }
@@ -872,7 +872,7 @@  discard block
 block discarded – undo
872 872
 
873 873
     if ($useCache === true) {
874 874
       $cache = new Cache(null, null, false, $useCache);
875
-      $cacheKey = 'sql-' . md5($query);
875
+      $cacheKey = 'sql-'.md5($query);
876 876
 
877 877
       if (
878 878
           $cache->getCacheIsReady() === true
@@ -987,9 +987,9 @@  discard block
 block discarded – undo
987 987
 
988 988
     $return = mysqli_set_charset($this->link, $charset);
989 989
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
990
-    @\mysqli_query($this->link, 'SET CHARACTER SET ' . $charset);
990
+    @\mysqli_query($this->link, 'SET CHARACTER SET '.$charset);
991 991
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
992
-    @\mysqli_query($this->link, "SET NAMES '" . $charset . "'");
992
+    @\mysqli_query($this->link, "SET NAMES '".$charset."'");
993 993
 
994 994
     return $return;
995 995
   }
@@ -1076,10 +1076,10 @@  discard block
 block discarded – undo
1076 1076
 
1077 1077
       if ($this->_debug->checkForDev() === true) {
1078 1078
         echo "Info: maybe you have to increase your 'max_allowed_packet = 30M' in the config: 'my.conf' \n<br />";
1079
-        echo 'Error:' . $errorMsg;
1079
+        echo 'Error:'.$errorMsg;
1080 1080
       }
1081 1081
 
1082
-      $this->_debug->mailToAdmin('SQL-Error in mysqli_multi_query', $errorMsg . ":\n<br />" . $sql);
1082
+      $this->_debug->mailToAdmin('SQL-Error in mysqli_multi_query', $errorMsg.":\n<br />".$sql);
1083 1083
     }
1084 1084
 
1085 1085
     // return the result only if there was a "SELECT"-query
@@ -1118,7 +1118,7 @@  discard block
 block discarded – undo
1118 1118
     }
1119 1119
 
1120 1120
     if (\mysqli_connect_errno()) {
1121
-      $this->_debug->displayError('Error connecting to mysql server: ' . \mysqli_connect_error(), true);
1121
+      $this->_debug->displayError('Error connecting to mysql server: '.\mysqli_connect_error(), true);
1122 1122
 
1123 1123
       return false;
1124 1124
     }
@@ -1229,10 +1229,10 @@  discard block
 block discarded – undo
1229 1229
     $SET = $this->_parseArrayPair($data);
1230 1230
 
1231 1231
     if ($databaseName) {
1232
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1232
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1233 1233
     }
1234 1234
 
1235
-    $sql = 'INSERT INTO ' . $databaseName . $this->quote_string($table) . " SET $SET;";
1235
+    $sql = 'INSERT INTO '.$databaseName.$this->quote_string($table)." SET $SET;";
1236 1236
 
1237 1237
     return $this->query($sql);
1238 1238
   }
@@ -1329,9 +1329,9 @@  discard block
 block discarded – undo
1329 1329
           }
1330 1330
 
1331 1331
           if ($_connector === 'NOT IN' || $_connector === 'IN') {
1332
-            $_value = '(' . implode(',', $_value) . ')';
1332
+            $_value = '('.implode(',', $_value).')';
1333 1333
           } elseif ($_connector === 'NOT BETWEEN' || $_connector === 'BETWEEN') {
1334
-            $_value = '(' . implode(' AND ', $_value) . ')';
1334
+            $_value = '('.implode(' AND ', $_value).')';
1335 1335
           }
1336 1336
 
1337 1337
         } else {
@@ -1376,7 +1376,7 @@  discard block
 block discarded – undo
1376 1376
             $_glueHelperInner = 'AND ('; // inner-loop "OR"-query glue
1377 1377
           }
1378 1378
 
1379
-          $sql .= ' ' . $_glueHelperInner . ' ' . $quoteString . ' ' . $_connector . ' ' . $valueInner . " \n";
1379
+          $sql .= ' '.$_glueHelperInner.' '.$quoteString.' '.$_connector.' '.$valueInner." \n";
1380 1380
           $tmpCounter++;
1381 1381
         }
1382 1382
 
@@ -1409,7 +1409,7 @@  discard block
 block discarded – undo
1409 1409
         )
1410 1410
     );
1411 1411
 
1412
-    return '`' . $str . '`';
1412
+    return '`'.$str.'`';
1413 1413
   }
1414 1414
 
1415 1415
   /**
@@ -1465,10 +1465,10 @@  discard block
 block discarded – undo
1465 1465
     $values = implode(',', $data);
1466 1466
 
1467 1467
     if ($databaseName) {
1468
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1468
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1469 1469
     }
1470 1470
 
1471
-    $sql = 'REPLACE INTO ' . $databaseName . $this->quote_string($table) . " ($columns) VALUES ($values);";
1471
+    $sql = 'REPLACE INTO '.$databaseName.$this->quote_string($table)." ($columns) VALUES ($values);";
1472 1472
 
1473 1473
     return $this->query($sql);
1474 1474
   }
@@ -1511,10 +1511,10 @@  discard block
 block discarded – undo
1511 1511
     }
1512 1512
 
1513 1513
     if ($databaseName) {
1514
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1514
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1515 1515
     }
1516 1516
 
1517
-    $sql = 'UPDATE ' . $databaseName . $this->quote_string($table) . " SET $SET WHERE ($WHERE);";
1517
+    $sql = 'UPDATE '.$databaseName.$this->quote_string($table)." SET $SET WHERE ($WHERE);";
1518 1518
 
1519 1519
     return $this->query($sql);
1520 1520
   }
@@ -1548,10 +1548,10 @@  discard block
 block discarded – undo
1548 1548
     }
1549 1549
 
1550 1550
     if ($databaseName) {
1551
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1551
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1552 1552
     }
1553 1553
 
1554
-    $sql = 'DELETE FROM ' . $databaseName . $this->quote_string($table) . " WHERE ($WHERE);";
1554
+    $sql = 'DELETE FROM '.$databaseName.$this->quote_string($table)." WHERE ($WHERE);";
1555 1555
 
1556 1556
     return $this->query($sql);
1557 1557
   }
@@ -1585,10 +1585,10 @@  discard block
 block discarded – undo
1585 1585
     }
1586 1586
 
1587 1587
     if ($databaseName) {
1588
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1588
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1589 1589
     }
1590 1590
 
1591
-    $sql = 'SELECT * FROM ' . $databaseName . $this->quote_string($table) . " WHERE ($WHERE);";
1591
+    $sql = 'SELECT * FROM '.$databaseName.$this->quote_string($table)." WHERE ($WHERE);";
1592 1592
 
1593 1593
     return $this->query($sql);
1594 1594
   }
Please login to merge, or discard this patch.