Inspection of "[*]: add one more test case + small code clean-up..." - voku/HtmlMin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 62a1f2...d70753 )

by Lars

created 2019-08-17 21:50 UTC

Status

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1175,8 +1175,8 @@
 block discarded – undo
     }
 
     /**
-     * @param $html
-     * @param $decodeUtf8Specials
+     * @param string $html
+     * @param boolean $decodeUtf8Specials
      *
      * @return string
      */

Please login to merge, or discard this patch.

Indentation +109 added lines, -109 removed lines patch added patch discarded remove patch

@@ -736,184 +736,184 @@  discard block
 block discarded – undo
         return \in_array($tag_name, self::$optional_end_tags, true)
                ||
                (
-                   $tag_name === 'li'
+                    $tag_name === 'li'
                    &&
                    (
-                       $nextSibling === null
+                        $nextSibling === null
                        ||
                        (
-                           $nextSibling instanceof \DOMElement
+                            $nextSibling instanceof \DOMElement
                            &&
                            $nextSibling->tagName === 'li'
-                       )
-                   )
-               )
+                        )
+                    )
+                )
                ||
                (
-                   (
-                       $tag_name === 'rp'
-                   )
+                    (
+                        $tag_name === 'rp'
+                    )
                    &&
                    (
-                       $nextSibling === null
+                        $nextSibling === null
                        ||
                        (
-                           $nextSibling instanceof \DOMElement
+                            $nextSibling instanceof \DOMElement
                            &&
                            (
-                               $nextSibling->tagName === 'rp'
+                                $nextSibling->tagName === 'rp'
                                ||
                                $nextSibling->tagName === 'rt'
-                           )
-                       )
-                   )
-               )
+                            )
+                        )
+                    )
+                )
                ||
                (
-                   $tag_name === 'tr'
+                    $tag_name === 'tr'
                    &&
                    (
-                       $nextSibling === null
+                        $nextSibling === null
                        ||
                        (
-                           $nextSibling instanceof \DOMElement
+                            $nextSibling instanceof \DOMElement
                            &&
                            $nextSibling->tagName === 'tr'
-                       )
-                   )
-               )
+                        )
+                    )
+                )
                ||
                (
-                   (
-                       $tag_name === 'td'
+                    (
+                        $tag_name === 'td'
                        ||
                        $tag_name === 'th'
-                   )
+                    )
                    &&
                    (
-                       $nextSibling === null
+                        $nextSibling === null
                        ||
                        (
-                           $nextSibling instanceof \DOMElement
+                            $nextSibling instanceof \DOMElement
                            &&
                            (
-                               $nextSibling->tagName === 'td'
+                                $nextSibling->tagName === 'td'
                                ||
                                $nextSibling->tagName === 'th'
-                           )
-                       )
-                   )
-               )
+                            )
+                        )
+                    )
+                )
                ||
                (
-                   (
-                       $tag_name === 'dd'
+                    (
+                        $tag_name === 'dd'
                        ||
                        $tag_name === 'dt'
-                   )
+                    )
                    &&
                    (
-                       (
-                           $nextSibling === null
+                        (
+                            $nextSibling === null
                            &&
                            $tag_name === 'dd'
-                       )
+                        )
                        ||
                        (
-                           $nextSibling instanceof \DOMElement
+                            $nextSibling instanceof \DOMElement
                            &&
                            (
-                               $nextSibling->tagName === 'dd'
+                                $nextSibling->tagName === 'dd'
                                ||
                                $nextSibling->tagName === 'dt'
-                           )
-                       )
-                   )
-               )
+                            )
+                        )
+                    )
+                )
                ||
                (
-                   $tag_name === 'option'
+                    $tag_name === 'option'
                    &&
                    (
-                       $nextSibling === null
+                        $nextSibling === null
                        ||
                        (
-                           $nextSibling instanceof \DOMElement
+                            $nextSibling instanceof \DOMElement
                            &&
                            (
-                               $nextSibling->tagName === 'option'
+                                $nextSibling->tagName === 'option'
                                ||
                                $nextSibling->tagName === 'optgroup'
-                           )
-                       )
-                   )
-               )
+                            )
+                        )
+                    )
+                )
                ||
                (
-                   $tag_name === 'p'
+                    $tag_name === 'p'
                    &&
                    (
-                       (
-                           $nextSibling === null
+                        (
+                            $nextSibling === null
                            &&
                            (
-                               $node->parentNode !== null
+                                $node->parentNode !== null
                                &&
                                !\in_array(
-                                   $node->parentNode->nodeName,
-                                   [
-                                       'a',
-                                       'audio',
-                                       'del',
-                                       'ins',
-                                       'map',
-                                       'noscript',
-                                       'video',
-                                   ],
-                                   true
-                               )
-                           )
-                       )
+                                    $node->parentNode->nodeName,
+                                    [
+                                        'a',
+                                        'audio',
+                                        'del',
+                                        'ins',
+                                        'map',
+                                        'noscript',
+                                        'video',
+                                    ],
+                                    true
+                                )
+                            )
+                        )
                        ||
                        (
-                           $nextSibling instanceof \DOMElement
+                            $nextSibling instanceof \DOMElement
                            &&
                            \in_array(
-                               $nextSibling->tagName,
-                               [
-                                   'address',
-                                   'article',
-                                   'aside',
-                                   'blockquote',
-                                   'dir',
-                                   'div',
-                                   'dl',
-                                   'fieldset',
-                                   'footer',
-                                   'form',
-                                   'h1',
-                                   'h2',
-                                   'h3',
-                                   'h4',
-                                   'h5',
-                                   'h6',
-                                   'header',
-                                   'hgroup',
-                                   'hr',
-                                   'menu',
-                                   'nav',
-                                   'ol',
-                                   'p',
-                                   'pre',
-                                   'section',
-                                   'table',
-                                   'ul',
-                               ],
-                               true
-                           )
-                       )
-                   )
-               );
+                                $nextSibling->tagName,
+                                [
+                                    'address',
+                                    'article',
+                                    'aside',
+                                    'blockquote',
+                                    'dir',
+                                    'div',
+                                    'dl',
+                                    'fieldset',
+                                    'footer',
+                                    'form',
+                                    'h1',
+                                    'h2',
+                                    'h3',
+                                    'h4',
+                                    'h5',
+                                    'h6',
+                                    'header',
+                                    'hgroup',
+                                    'hr',
+                                    'menu',
+                                    'nav',
+                                    'ol',
+                                    'p',
+                                    'pre',
+                                    'section',
+                                    'table',
+                                    'ul',
+                                ],
+                                true
+                            )
+                        )
+                    )
+                );
     }
 
     protected function domNodeToString(\DOMNode $node): string
@@ -945,9 +945,9 @@  discard block
 block discarded – undo
                     }
 
                     $html .= '<!DOCTYPE ' . $child->name . ''
-                             . ($child->publicId ? ' ' . $tmpTypePublic . ' "' . $child->publicId . '"' : '')
-                             . ($child->systemId ? ' ' . $tmpTypeSystem . ' "' . $child->systemId . '"' : '')
-                             . '>';
+                              . ($child->publicId ? ' ' . $tmpTypePublic . ' "' . $child->publicId . '"' : '')
+                              . ($child->systemId ? ' ' . $tmpTypeSystem . ' "' . $child->systemId . '"' : '')
+                              . '>';
                 }
             } elseif ($child instanceof \DOMElement) {
                 $html .= \rtrim('<' . $child->tagName . ' ' . $this->domNodeAttributesToString($child));

Please login to merge, or discard this patch.

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -714,7 +714,7 @@  discard block
 block discarded – undo
                     $attr_val = $attribute->value;
                 }
 
-                $attr_str .= ($omit_quotes ? '' : $quoteTmp) . $attr_val . ($omit_quotes ? '' : $quoteTmp);
+                $attr_str .= ($omit_quotes ? '' : $quoteTmp).$attr_val.($omit_quotes ? '' : $quoteTmp);
                 $attr_str .= ' ';
             }
         }
@@ -979,21 +979,21 @@  discard block
 block discarded – undo
                         $tmpTypePublic = 'PUBLIC';
                     }
 
-                    $html .= '<!DOCTYPE ' . $child->name . ''
-                             . ($child->publicId ? ' ' . $tmpTypePublic . ' "' . $child->publicId . '"' : '')
-                             . ($child->systemId ? ' ' . $tmpTypeSystem . ' "' . $child->systemId . '"' : '')
+                    $html .= '<!DOCTYPE '.$child->name.''
+                             . ($child->publicId ? ' '.$tmpTypePublic.' "'.$child->publicId.'"' : '')
+                             . ($child->systemId ? ' '.$tmpTypeSystem.' "'.$child->systemId.'"' : '')
                              . '>';
                 }
             } elseif ($child instanceof \DOMElement) {
-                $html .= \rtrim('<' . $child->tagName . ' ' . $this->domNodeAttributesToString($child));
-                $html .= '>' . $this->domNodeToString($child);
+                $html .= \rtrim('<'.$child->tagName.' '.$this->domNodeAttributesToString($child));
+                $html .= '>'.$this->domNodeToString($child);
 
                 if (
                     !$this->doRemoveOmittedHtmlTags
                     ||
                     !$this->domNodeClosingTagOptional($child)
                 ) {
-                    $html .= '</' . $child->tagName . '>';
+                    $html .= '</'.$child->tagName.'>';
                 }
 
                 if (!$this->doRemoveWhitespaceAroundTags) {
@@ -1033,7 +1033,7 @@  discard block
 block discarded – undo
                     $html .= $child->wholeText;
                 }
             } elseif ($child instanceof \DOMComment) {
-                $html .= '<!--' . $child->textContent . '-->';
+                $html .= '<!--'.$child->textContent.'-->';
             }
         }
 
@@ -1125,8 +1125,8 @@  discard block
 block discarded – undo
         // Remove extra white-space(s) between HTML attribute(s)
         $html = (string) \preg_replace_callback(
             '#<([^/\s<>!]+)(?:\s+([^<>]*?)\s*|\s*)(/?)>#',
-            static function ($matches) {
-                return '<' . $matches[1] . \preg_replace('#([^\s=]+)(\=([\'"]?)(.*?)\3)?(\s+|$)#s', ' $1$2', $matches[2]) . $matches[3] . '>';
+            static function($matches) {
+                return '<'.$matches[1].\preg_replace('#([^\s=]+)(\=([\'"]?)(.*?)\3)?(\s+|$)#s', ' $1$2', $matches[2]).$matches[3].'>';
             },
             $html
         );
@@ -1141,7 +1141,7 @@  discard block
 block discarded – undo
         // -------------------------------------------------------------------------
 
         $html = (string) \preg_replace_callback(
-            '/<(?<element>' . $this->protectedChildNodesHelper . ')(?<attributes> [^>]*)?>(?<value>.*?)<\/' . $this->protectedChildNodesHelper . '>/',
+            '/<(?<element>'.$this->protectedChildNodesHelper.')(?<attributes> [^>]*)?>(?<value>.*?)<\/'.$this->protectedChildNodesHelper.'>/',
             [$this, 'restoreProtectedHtml'],
             $html
         );
@@ -1160,14 +1160,14 @@  discard block
 block discarded – undo
 
         $html = \str_replace(
             [
-                'html>' . "\n",
-                "\n" . '<html',
-                'html/>' . "\n",
-                "\n" . '</html',
-                'head>' . "\n",
-                "\n" . '<head',
-                'head/>' . "\n",
-                "\n" . '</head',
+                'html>'."\n",
+                "\n".'<html',
+                'html/>'."\n",
+                "\n".'</html',
+                'head>'."\n",
+                "\n".'<head',
+                'head/>'."\n",
+                "\n".'</head',
             ],
             [
                 'html>',
@@ -1186,10 +1186,10 @@  discard block
 block discarded – undo
         $replace = [];
         $replacement = [];
         foreach (self::$selfClosingTags as $selfClosingTag) {
-            $replace[] = '<' . $selfClosingTag . '/>';
-            $replacement[] = '<' . $selfClosingTag . '>';
-            $replace[] = '<' . $selfClosingTag . ' />';
-            $replacement[] = '<' . $selfClosingTag . '>';
+            $replace[] = '<'.$selfClosingTag.'/>';
+            $replacement[] = '<'.$selfClosingTag.'>';
+            $replace[] = '<'.$selfClosingTag.' />';
+            $replacement[] = '<'.$selfClosingTag.'>';
         }
         $html = \str_replace(
             $replace,
@@ -1197,7 +1197,7 @@  discard block
 block discarded – undo
             $html
         );
 
-        $html = (string) \preg_replace('#<\b(' . $CACHE_SELF_CLOSING_TAGS . ')([^>]*+)><\/\b\1>#', '<\\1\\2>', $html);
+        $html = (string) \preg_replace('#<\b('.$CACHE_SELF_CLOSING_TAGS.')([^>]*+)><\/\b\1>#', '<\\1\\2>', $html);
 
         // ------------------------------------
         // check if compression worked
@@ -1304,7 +1304,7 @@  discard block
 block discarded – undo
             }
 
             $this->protectedChildNodes[$counter] = $element->innerhtml;
-            $element->getNode()->nodeValue = '<' . $this->protectedChildNodesHelper . ' data-' . $this->protectedChildNodesHelper . '="' . $counter . '"></' . $this->protectedChildNodesHelper . '>';
+            $element->getNode()->nodeValue = '<'.$this->protectedChildNodesHelper.' data-'.$this->protectedChildNodesHelper.'="'.$counter.'"></'.$this->protectedChildNodesHelper.'>';
 
             ++$counter;
         }
@@ -1315,7 +1315,7 @@  discard block
 block discarded – undo
             }
 
             $this->protectedChildNodes[$counter] = $element->parentNode()->innerHtml();
-            $element->getNode()->parentNode->nodeValue = '<' . $this->protectedChildNodesHelper . ' data-' . $this->protectedChildNodesHelper . '="' . $counter . '"></' . $this->protectedChildNodesHelper . '>';
+            $element->getNode()->parentNode->nodeValue = '<'.$this->protectedChildNodesHelper.' data-'.$this->protectedChildNodesHelper.'="'.$counter.'"></'.$this->protectedChildNodesHelper.'>';
 
             ++$counter;
         }
@@ -1328,11 +1328,11 @@  discard block
 block discarded – undo
                 continue;
             }
 
-            $this->protectedChildNodes[$counter] = '<!--' . $text . '-->';
+            $this->protectedChildNodes[$counter] = '<!--'.$text.'-->';
 
             /* @var $node \DOMComment */
             $node = $element->getNode();
-            $child = new \DOMText('<' . $this->protectedChildNodesHelper . ' data-' . $this->protectedChildNodesHelper . '="' . $counter . '"></' . $this->protectedChildNodesHelper . '>');
+            $child = new \DOMText('<'.$this->protectedChildNodesHelper.' data-'.$this->protectedChildNodesHelper.'="'.$counter.'"></'.$this->protectedChildNodesHelper.'>');
             /** @noinspection UnusedFunctionResultInspection */
             $element->getNode()->parentNode->replaceChild($child, $node);
 

Please login to merge, or discard this patch.

src/voku/helper/HtmlMinDomObserverOptimizeAttributes.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -202,7 +202,7 @@
 block discarded – undo
                 continue;
             }
 
-            $attrValue .= \trim($class) . ' ';
+            $attrValue .= \trim($class).' ';
         }
 
         return \trim($attrValue);

Please login to merge, or discard this patch.

		@@ -1175,8 +1175,8 @@
		block discarded – undo
1175	1175	}
1176	1176
1177	1177	/**
1178		- * @param $html
1179		- * @param $decodeUtf8Specials
	1178	+ * @param string $html
	1179	+ * @param boolean $decodeUtf8Specials
1180	1180	*
1181	1181	* @return string
1182	1182	*/

		@@ -714,7 +714,7 @@ discard block
		block discarded – undo
714	714	$attr_val = $attribute->value;
715	715	}
716	716
717		- $attr_str .= ($omit_quotes ? '' : $quoteTmp) . $attr_val . ($omit_quotes ? '' : $quoteTmp);
	717	+ $attr_str .= ($omit_quotes ? '' : $quoteTmp).$attr_val.($omit_quotes ? '' : $quoteTmp);
718	718	$attr_str .= ' ';
719	719	}
720	720	}
		@@ -979,21 +979,21 @@ discard block
		block discarded – undo
979	979	$tmpTypePublic = 'PUBLIC';
980	980	}
981	981
982		- $html .= '<!DOCTYPE ' . $child->name . ''
983		- . ($child->publicId ? ' ' . $tmpTypePublic . ' "' . $child->publicId . '"' : '')
984		- . ($child->systemId ? ' ' . $tmpTypeSystem . ' "' . $child->systemId . '"' : '')
	982	+ $html .= '<!DOCTYPE '.$child->name.''
	983	+ . ($child->publicId ? ' '.$tmpTypePublic.' "'.$child->publicId.'"' : '')
	984	+ . ($child->systemId ? ' '.$tmpTypeSystem.' "'.$child->systemId.'"' : '')
985	985	. '>';
986	986	}
987	987	} elseif ($child instanceof \DOMElement) {
988		- $html .= \rtrim('<' . $child->tagName . ' ' . $this->domNodeAttributesToString($child));
989		- $html .= '>' . $this->domNodeToString($child);
	988	+ $html .= \rtrim('<'.$child->tagName.' '.$this->domNodeAttributesToString($child));
	989	+ $html .= '>'.$this->domNodeToString($child);
990	990
991	991	if (
992	992	!$this->doRemoveOmittedHtmlTags
993	993	\|\|
994	994	!$this->domNodeClosingTagOptional($child)
995	995	) {
996		- $html .= '</' . $child->tagName . '>';
	996	+ $html .= '</'.$child->tagName.'>';
997	997	}
998	998
999	999	if (!$this->doRemoveWhitespaceAroundTags) {
		@@ -1033,7 +1033,7 @@ discard block
		block discarded – undo
1033	1033	$html .= $child->wholeText;
1034	1034	}
1035	1035	} elseif ($child instanceof \DOMComment) {
1036		- $html .= '<!--' . $child->textContent . '-->';
	1036	+ $html .= '<!--'.$child->textContent.'-->';
1037	1037	}
1038	1038	}
1039	1039
		@@ -1125,8 +1125,8 @@ discard block
		block discarded – undo
1125	1125	// Remove extra white-space(s) between HTML attribute(s)
1126	1126	$html = (string) \preg_replace_callback(
1127	1127	'#<([^/\s<>!]+)(?:\s+([^<>]?)\s\|\s*)(/?)>#',
1128		- static function ($matches) {
1129		- return '<' . $matches[1] . \preg_replace('#([^\s=]+)(\=([\'"]?)(.*?)\3)?(\s+\|$)#s', ' $1$2', $matches[2]) . $matches[3] . '>';
	1128	+ static function($matches) {
	1129	+ return '<'.$matches[1].\preg_replace('#([^\s=]+)(\=([\'"]?)(.*?)\3)?(\s+\|$)#s', ' $1$2', $matches[2]).$matches[3].'>';
1130	1130	},
1131	1131	$html
1132	1132	);
		@@ -1141,7 +1141,7 @@ discard block
		block discarded – undo
1141	1141	// -------------------------------------------------------------------------
1142	1142
1143	1143	$html = (string) \preg_replace_callback(
1144		- '/<(?<element>' . $this->protectedChildNodesHelper . ')(?<attributes> [^>])?>(?<value>.?)<\/' . $this->protectedChildNodesHelper . '>/',
	1144	+ '/<(?<element>'.$this->protectedChildNodesHelper.')(?<attributes> [^>])?>(?<value>.?)<\/'.$this->protectedChildNodesHelper.'>/',
1145	1145	[$this, 'restoreProtectedHtml'],
1146	1146	$html
1147	1147	);
		@@ -1160,14 +1160,14 @@ discard block
		block discarded – undo
1160	1160
1161	1161	$html = \str_replace(
1162	1162	[
1163		- 'html>' . "\n",
1164		- "\n" . '<html',
1165		- 'html/>' . "\n",
1166		- "\n" . '</html',
1167		- 'head>' . "\n",
1168		- "\n" . '<head',
1169		- 'head/>' . "\n",
1170		- "\n" . '</head',
	1163	+ 'html>'."\n",
	1164	+ "\n".'<html',
	1165	+ 'html/>'."\n",
	1166	+ "\n".'</html',
	1167	+ 'head>'."\n",
	1168	+ "\n".'<head',
	1169	+ 'head/>'."\n",
	1170	+ "\n".'</head',
1171	1171	],
1172	1172	[
1173	1173	'html>',
		@@ -1186,10 +1186,10 @@ discard block
		block discarded – undo
1186	1186	$replace = [];
1187	1187	$replacement = [];
1188	1188	foreach (self::$selfClosingTags as $selfClosingTag) {
1189		- $replace[] = '<' . $selfClosingTag . '/>';
1190		- $replacement[] = '<' . $selfClosingTag . '>';
1191		- $replace[] = '<' . $selfClosingTag . ' />';
1192		- $replacement[] = '<' . $selfClosingTag . '>';
	1189	+ $replace[] = '<'.$selfClosingTag.'/>';
	1190	+ $replacement[] = '<'.$selfClosingTag.'>';
	1191	+ $replace[] = '<'.$selfClosingTag.' />';
	1192	+ $replacement[] = '<'.$selfClosingTag.'>';
1193	1193	}
1194	1194	$html = \str_replace(
1195	1195	$replace,
		@@ -1197,7 +1197,7 @@ discard block
		block discarded – undo
1197	1197	$html
1198	1198	);
1199	1199
1200		- $html = (string) \preg_replace('#<\b(' . $CACHE_SELF_CLOSING_TAGS . ')([^>]*+)><\/\b\1>#', '<\\1\\2>', $html);
	1200	+ $html = (string) \preg_replace('#<\b('.$CACHE_SELF_CLOSING_TAGS.')([^>]*+)><\/\b\1>#', '<\\1\\2>', $html);
1201	1201
1202	1202	// ------------------------------------
1203	1203	// check if compression worked
		@@ -1304,7 +1304,7 @@ discard block
		block discarded – undo
1304	1304	}
1305	1305
1306	1306	$this->protectedChildNodes[$counter] = $element->innerhtml;
1307		- $element->getNode()->nodeValue = '<' . $this->protectedChildNodesHelper . ' data-' . $this->protectedChildNodesHelper . '="' . $counter . '"></' . $this->protectedChildNodesHelper . '>';
	1307	+ $element->getNode()->nodeValue = '<'.$this->protectedChildNodesHelper.' data-'.$this->protectedChildNodesHelper.'="'.$counter.'"></'.$this->protectedChildNodesHelper.'>';
1308	1308
1309	1309	++$counter;
1310	1310	}
		@@ -1315,7 +1315,7 @@ discard block
		block discarded – undo
1315	1315	}
1316	1316
1317	1317	$this->protectedChildNodes[$counter] = $element->parentNode()->innerHtml();
1318		- $element->getNode()->parentNode->nodeValue = '<' . $this->protectedChildNodesHelper . ' data-' . $this->protectedChildNodesHelper . '="' . $counter . '"></' . $this->protectedChildNodesHelper . '>';
	1318	+ $element->getNode()->parentNode->nodeValue = '<'.$this->protectedChildNodesHelper.' data-'.$this->protectedChildNodesHelper.'="'.$counter.'"></'.$this->protectedChildNodesHelper.'>';
1319	1319
1320	1320	++$counter;
1321	1321	}
		@@ -1328,11 +1328,11 @@ discard block
		block discarded – undo
1328	1328	continue;
1329	1329	}
1330	1330
1331		- $this->protectedChildNodes[$counter] = '<!--' . $text . '-->';
	1331	+ $this->protectedChildNodes[$counter] = '<!--'.$text.'-->';
1332	1332
1333	1333	/* @var $node \DOMComment */
1334	1334	$node = $element->getNode();
1335		- $child = new \DOMText('<' . $this->protectedChildNodesHelper . ' data-' . $this->protectedChildNodesHelper . '="' . $counter . '"></' . $this->protectedChildNodesHelper . '>');
	1335	+ $child = new \DOMText('<'.$this->protectedChildNodesHelper.' data-'.$this->protectedChildNodesHelper.'="'.$counter.'"></'.$this->protectedChildNodesHelper.'>');
1336	1336	/** @noinspection UnusedFunctionResultInspection */
1337	1337	$element->getNode()->parentNode->replaceChild($child, $node);
1338	1338

		@@ -202,7 +202,7 @@
		block discarded – undo
202	202	continue;
203	203	}
204	204
205		- $attrValue .= \trim($class) . ' ';
	205	+ $attrValue .= \trim($class).' ';
206	206	}
207	207
208	208	return \trim($attrValue);

		@@ -736,184 +736,184 @@ discard block
		block discarded – undo
736	736	return \in_array($tag_name, self::$optional_end_tags, true)
737	737	\|\|
738	738	(
739		- $tag_name === 'li'
	739	+ $tag_name === 'li'
740	740	&&
741	741	(
742		- $nextSibling === null
	742	+ $nextSibling === null
743	743	\|\|
744	744	(
745		- $nextSibling instanceof \DOMElement
	745	+ $nextSibling instanceof \DOMElement
746	746	&&
747	747	$nextSibling->tagName === 'li'
748		- )
749		- )
750		- )
	748	+ )
	749	+ )
	750	+ )
751	751	\|\|
752	752	(
753		- (
754		- $tag_name === 'rp'
755		- )
	753	+ (
	754	+ $tag_name === 'rp'
	755	+ )
756	756	&&
757	757	(
758		- $nextSibling === null
	758	+ $nextSibling === null
759	759	\|\|
760	760	(
761		- $nextSibling instanceof \DOMElement
	761	+ $nextSibling instanceof \DOMElement
762	762	&&
763	763	(
764		- $nextSibling->tagName === 'rp'
	764	+ $nextSibling->tagName === 'rp'
765	765	\|\|
766	766	$nextSibling->tagName === 'rt'
767		- )
768		- )
769		- )
770		- )
	767	+ )
	768	+ )
	769	+ )
	770	+ )
771	771	\|\|
772	772	(
773		- $tag_name === 'tr'
	773	+ $tag_name === 'tr'
774	774	&&
775	775	(
776		- $nextSibling === null
	776	+ $nextSibling === null
777	777	\|\|
778	778	(
779		- $nextSibling instanceof \DOMElement
	779	+ $nextSibling instanceof \DOMElement
780	780	&&
781	781	$nextSibling->tagName === 'tr'
782		- )
783		- )
784		- )
	782	+ )
	783	+ )
	784	+ )
785	785	\|\|
786	786	(
787		- (
788		- $tag_name === 'td'
	787	+ (
	788	+ $tag_name === 'td'
789	789	\|\|
790	790	$tag_name === 'th'
791		- )
	791	+ )
792	792	&&
793	793	(
794		- $nextSibling === null
	794	+ $nextSibling === null
795	795	\|\|
796	796	(
797		- $nextSibling instanceof \DOMElement
	797	+ $nextSibling instanceof \DOMElement
798	798	&&
799	799	(
800		- $nextSibling->tagName === 'td'
	800	+ $nextSibling->tagName === 'td'
801	801	\|\|
802	802	$nextSibling->tagName === 'th'
803		- )
804		- )
805		- )
806		- )
	803	+ )
	804	+ )
	805	+ )
	806	+ )
807	807	\|\|
808	808	(
809		- (
810		- $tag_name === 'dd'
	809	+ (
	810	+ $tag_name === 'dd'
811	811	\|\|
812	812	$tag_name === 'dt'
813		- )
	813	+ )
814	814	&&
815	815	(
816		- (
817		- $nextSibling === null
	816	+ (
	817	+ $nextSibling === null
818	818	&&
819	819	$tag_name === 'dd'
820		- )
	820	+ )
821	821	\|\|
822	822	(
823		- $nextSibling instanceof \DOMElement
	823	+ $nextSibling instanceof \DOMElement
824	824	&&
825	825	(
826		- $nextSibling->tagName === 'dd'
	826	+ $nextSibling->tagName === 'dd'
827	827	\|\|
828	828	$nextSibling->tagName === 'dt'
829		- )
830		- )
831		- )
832		- )
	829	+ )
	830	+ )
	831	+ )
	832	+ )
833	833	\|\|
834	834	(
835		- $tag_name === 'option'
	835	+ $tag_name === 'option'
836	836	&&
837	837	(
838		- $nextSibling === null
	838	+ $nextSibling === null
839	839	\|\|
840	840	(
841		- $nextSibling instanceof \DOMElement
	841	+ $nextSibling instanceof \DOMElement
842	842	&&
843	843	(
844		- $nextSibling->tagName === 'option'
	844	+ $nextSibling->tagName === 'option'
845	845	\|\|
846	846	$nextSibling->tagName === 'optgroup'
847		- )
848		- )
849		- )
850		- )
	847	+ )
	848	+ )
	849	+ )
	850	+ )
851	851	\|\|
852	852	(
853		- $tag_name === 'p'
	853	+ $tag_name === 'p'
854	854	&&
855	855	(
856		- (
857		- $nextSibling === null
	856	+ (
	857	+ $nextSibling === null
858	858	&&
859	859	(
860		- $node->parentNode !== null
	860	+ $node->parentNode !== null
861	861	&&
862	862	!\in_array(
863		- $node->parentNode->nodeName,
864		- [
865		- 'a',
866		- 'audio',
867		- 'del',
868		- 'ins',
869		- 'map',
870		- 'noscript',
871		- 'video',
872		- ],
873		- true
874		- )
875		- )
876		- )
	863	+ $node->parentNode->nodeName,
	864	+ [
	865	+ 'a',
	866	+ 'audio',
	867	+ 'del',
	868	+ 'ins',
	869	+ 'map',
	870	+ 'noscript',
	871	+ 'video',
	872	+ ],
	873	+ true
	874	+ )
	875	+ )
	876	+ )
877	877	\|\|
878	878	(
879		- $nextSibling instanceof \DOMElement
	879	+ $nextSibling instanceof \DOMElement
880	880	&&
881	881	\in_array(
882		- $nextSibling->tagName,
883		- [
884		- 'address',
885		- 'article',
886		- 'aside',
887		- 'blockquote',
888		- 'dir',
889		- 'div',
890		- 'dl',
891		- 'fieldset',
892		- 'footer',
893		- 'form',
894		- 'h1',
895		- 'h2',
896		- 'h3',
897		- 'h4',
898		- 'h5',
899		- 'h6',
900		- 'header',
901		- 'hgroup',
902		- 'hr',
903		- 'menu',
904		- 'nav',
905		- 'ol',
906		- 'p',
907		- 'pre',
908		- 'section',
909		- 'table',
910		- 'ul',
911		- ],
912		- true
913		- )
914		- )
915		- )
916		- );
	882	+ $nextSibling->tagName,
	883	+ [
	884	+ 'address',
	885	+ 'article',
	886	+ 'aside',
	887	+ 'blockquote',
	888	+ 'dir',
	889	+ 'div',
	890	+ 'dl',
	891	+ 'fieldset',
	892	+ 'footer',
	893	+ 'form',
	894	+ 'h1',
	895	+ 'h2',
	896	+ 'h3',
	897	+ 'h4',
	898	+ 'h5',
	899	+ 'h6',
	900	+ 'header',
	901	+ 'hgroup',
	902	+ 'hr',
	903	+ 'menu',
	904	+ 'nav',
	905	+ 'ol',
	906	+ 'p',
	907	+ 'pre',
	908	+ 'section',
	909	+ 'table',
	910	+ 'ul',
	911	+ ],
	912	+ true
	913	+ )
	914	+ )
	915	+ )
	916	+ );
917	917	}
918	918
919	919	protected function domNodeToString(\DOMNode $node): string
		@@ -945,9 +945,9 @@ discard block
		block discarded – undo
945	945	}
946	946
947	947	$html .= '<!DOCTYPE ' . $child->name . ''
948		- . ($child->publicId ? ' ' . $tmpTypePublic . ' "' . $child->publicId . '"' : '')
949		- . ($child->systemId ? ' ' . $tmpTypeSystem . ' "' . $child->systemId . '"' : '')
950		- . '>';
	948	+ . ($child->publicId ? ' ' . $tmpTypePublic . ' "' . $child->publicId . '"' : '')
	949	+ . ($child->systemId ? ' ' . $tmpTypeSystem . ' "' . $child->systemId . '"' : '')
	950	+ . '>';
951	951	}
952	952	} elseif ($child instanceof \DOMElement) {
953	953	$html .= \rtrim('<' . $child->tagName . ' ' . $this->domNodeAttributesToString($child));

voku / HtmlMin

Push — master ( 62a1f2...d70753 )

Status

Category

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +109 added lines, -109 removed lines patch added patch discarded remove patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch