vojtasvoboda / oc-twigextensions-plugin

Plugin.php

Unused Use Statements -2 removed lines

@@ -1,7 +1,5 @@
 <?php namespace VojtaSvoboda\TwigExtensions;
 
-use App;
-use Backend;
 use Carbon\Carbon;
 use System\Classes\PluginBase;
 use Twig_Extension_StringLoader;

Doc Comments -1 removed lines

@@ -406,7 +406,6 @@
      *
      * See: https://github.com/vojtasvoboda/oc-twigextensions-plugin/issues/25
      *
-     * @param string $filename Filename of the asset file
      *
      * @return string
      */

Indentation +5 added lines, -5 removed lines

@@ -419,14 +419,14 @@
                     $filename_ = trim(preg_replace('/^' . preg_quote($prefix, '/') . '/', '', $filename), '/');
                     if (file_exists($filename_))
                     {
-                      $timestamp = filemtime($filename_);
-                      $prepend = ($format) ? date($fomat, $timestamp) : $timestamp;
-                      return $filename . "?" . $prepend;
+                        $timestamp = filemtime($filename_);
+                        $prepend = ($format) ? date($fomat, $timestamp) : $timestamp;
+                        return $filename . "?" . $prepend;
                     }else
                     {
-                      return $filename;
+                        return $filename;
                     }
                 },
-             ];
+                ];
     }
 }

Spacing +12 added lines, -12 removed lines

@@ -373,30 +373,30 @@ 
 
         // if we want just unprotected link
         if (!$protected) {
-            return $link ? '<a href="mailto:' . $email . '">' . $linkText . '</a>' : $linkText;
+            return $link ? '<a href="mailto:'.$email.'">'.$linkText.'</a>' : $linkText;
         }
 
         // turn on protection
         $character_set = '+-.0123456789@ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz';
         $key = str_shuffle($character_set);
         $cipher_text = '';
-        $id = 'e' . rand(1, 999999999);
+        $id = 'e'.rand(1, 999999999);
         for ($i = 0; $i < strlen($email); $i += 1) $cipher_text .= $key[strpos($character_set, $email[$i])];
-        $script = 'var a="' . $key . '";var b=a.split("").sort().join("");var c="' . $cipher_text . '";var d="";';
+        $script = 'var a="'.$key.'";var b=a.split("").sort().join("");var c="'.$cipher_text.'";var d="";';
         $script .= 'for(var e=0;e<c.length;e++)d+=b.charAt(a.indexOf(c.charAt(e)));';
         $script .= 'var y = d;';
         if ($text !== null) {
             $script .= 'var y = "'.$text.'";';
         }
         if ($link) {
-            $script .= 'document.getElementById("' . $id . '").innerHTML="<a href=\\"mailto:"+d+"\\">"+y+"</a>"';
+            $script .= 'document.getElementById("'.$id.'").innerHTML="<a href=\\"mailto:"+d+"\\">"+y+"</a>"';
         } else {
-            $script .= 'document.getElementById("' . $id . '").innerHTML=y';
+            $script .= 'document.getElementById("'.$id.'").innerHTML=y';
         }
-        $script = "eval(\"" . str_replace(array("\\", '"'), array("\\\\", '\"'), $script) . "\")";
-        $script = '<script type="text/javascript">/*<![CDATA[*/' . $script . '/*]]>*/</script>';
+        $script = "eval(\"".str_replace(array("\\", '"'), array("\\\\", '\"'), $script)."\")";
+        $script = '<script type="text/javascript">/*<![CDATA[*/'.$script.'/*]]>*/</script>';
 
-        return '<span id="' . $id . '">[javascript protected email address]</span>' . $script;
+        return '<span id="'.$id.'">[javascript protected email address]</span>'.$script;
     }
 
     /**
@@ -413,16 +413,16 @@ 
     private function getFileRevision()
     {
         return  [
-                'revision' => function($filename, $format = null){
+                'revision' => function($filename, $format = null) {
                     // Remove http/web address from the file name if there is one to load it locally
                     $prefix = url("/");
-                    $filename_ = trim(preg_replace('/^' . preg_quote($prefix, '/') . '/', '', $filename), '/');
+                    $filename_ = trim(preg_replace('/^'.preg_quote($prefix, '/').'/', '', $filename), '/');
                     if (file_exists($filename_))
                     {
                       $timestamp = filemtime($filename_);
                       $prepend = ($format) ? date($fomat, $timestamp) : $timestamp;
-                      return $filename . "?" . $prepend;
-                    }else
+                      return $filename."?".$prepend;
+                    } else
                     {
                       return $filename;
                     }

Braces +4 added lines, -2 removed lines

@@ -381,7 +381,9 @@ 
         $key = str_shuffle($character_set);
         $cipher_text = '';
         $id = 'e' . rand(1, 999999999);
-        for ($i = 0; $i < strlen($email); $i += 1) $cipher_text .= $key[strpos($character_set, $email[$i])];
+        for ($i = 0; $i < strlen($email); $i += 1) {
+            $cipher_text .= $key[strpos($character_set, $email[$i])];
+        }
         $script = 'var a="' . $key . '";var b=a.split("").sort().join("");var c="' . $cipher_text . '";var d="";';
         $script .= 'for(var e=0;e<c.length;e++)d+=b.charAt(a.indexOf(c.charAt(e)));';
         $script .= 'var y = d;';
@@ -422,7 +424,7 @@ 
                       $timestamp = filemtime($filename_);
                       $prepend = ($format) ? date($fomat, $timestamp) : $timestamp;
                       return $filename . "?" . $prepend;
-                    }else
+                    } else
                     {
                       return $filename;
                     }

classes/TimeDiffTranslator.php

Spacing +2 added lines, -2 removed lines

@@ -7,11 +7,11 @@
 {
     public function trans($id, array $parameters = [], $domain = 'messages', $locale = null)
     {
-        return $this->get('vojtasvoboda.twigextensions::lang.' . $id, $parameters, $locale);
+        return $this->get('vojtasvoboda.twigextensions::lang.'.$id, $parameters, $locale);
     }
 
     public function transChoice($id, $number, array $parameters = [], $domain = 'messages', $locale = null)
     {
-        return $this->choice('vojtasvoboda.twigextensions::lang.' . $id, $number, $parameters, $locale);
+        return $this->choice('vojtasvoboda.twigextensions::lang.'.$id, $number, $parameters, $locale);
     }
 }

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php namespace VojtaSvoboda\TwigExtensions\Classes;
 
-use App;
 use October\Rain\Translation\Translator;
 use Symfony\Component\Translation\TranslatorInterface;
 

tests/PluginTest.php

Spacing +3 added lines, -3 removed lines

@@ -9,7 +9,7 @@ 
 use Twig_Environment;
 use VojtaSvoboda\TwigExtensions\Classes\TimeDiffTranslator;
 
-require_once __DIR__ . '/../vendor/autoload.php';
+require_once __DIR__.'/../vendor/autoload.php';
 
 class PluginTest extends PluginTestCase
 {
@@ -116,7 +116,7 @@ 
         $twig = $this->getTwig();
 
         $now = Carbon::now()->subMinute();
-        $template = "{{ '" . $now->format('Y-m-d H:i:s') . "' | time_diff }}";
+        $template = "{{ '".$now->format('Y-m-d H:i:s')."' | time_diff }}";
 
         // this test fails at TravisCI and I don't know why
         $twigTemplate = $twig->createTemplate($template);
@@ -316,7 +316,7 @@ 
         $key = 'app.custom.key';
         $value = 'test value';
         Config::set($key, $value);
-        $template = "{{ config('" . $key . "') }}";
+        $template = "{{ config('".$key."') }}";
 
         $twigTemplate = $twig->createTemplate($template);
         $this->assertEquals($twigTemplate->render([]), $value);