vojtasvoboda / oc-cnbrates-plugin

Plugin.php

Spacing +4 added lines, -4 removed lines

@@ -45,20 +45,20 @@
     public function registerSchedule($schedule)
     {
         // Exchange service daily update when allowed by Settings
-        $schedule->call(function () {
+        $schedule->call(function() {
             $cnb = $this->app->make('cnb');
             $cnb->updateTodayExchangeRates();
 
-        })->daily()->when(function () {
+        })->daily()->when(function() {
             return !!Settings::get('exchange', true);
         });
 
         // PRIBOR service daily update when allowed by Settings
-        $schedule->call(function () {
+        $schedule->call(function() {
             $cnb = $this->app->make('cnb');
             $cnb->updateTodayPriborRates();
 
-        })->daily()->when(function () {
+        })->daily()->when(function() {
             return !!Settings::get('pribor', true);
         });
     }

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php namespace VojtaSvoboda\CnbRates;
 
-use Backend;
 use System\Classes\PluginBase;
 use VojtaSvoboda\CnbRates\Models\Settings;
 

models/Settings.php

Indentation +5 added lines, -5 removed lines

@@ -6,12 +6,12 @@
 
 class Settings extends Model
 {
-	public $implement = ['System.Behaviors.SettingsModel'];
+    public $implement = ['System.Behaviors.SettingsModel'];
 
-	// A unique code
-	public $settingsCode = 'vojtasvoboda_cnbrates_settings';
+    // A unique code
+    public $settingsCode = 'vojtasvoboda_cnbrates_settings';
 
-	// Reference to field configuration
-	public $settingsFields = 'fields.yaml';
+    // Reference to field configuration
+    public $settingsFields = 'fields.yaml';
 
 }

providers/CnbDataProvider.php

Spacing +6 added lines, -6 removed lines

@@ -26,14 +26,14 @@ 
      */
     public function getData($url, $date = null, $ident = null)
     {
-        if(!$url) {
+        if (!$url) {
             throw new \Exception("Service URL can't be empty.");
         }
 
         $dateObj = new \DateTime($date);
         $date = $dateObj->format('d.m.Y');
 
-        if(!$this->isFileExists($date, $ident)) {
+        if (!$this->isFileExists($date, $ident)) {
             $this->saveDataToFile($this->loadDataFromUrl($url), $date, $ident);
         }
 
@@ -107,7 +107,7 @@ 
      */
     private function getFilePath($date, $ident = null)
     {
-        if(!$ident) {
+        if (!$ident) {
             $ident = $this->undefinedFolderName;
         }
 
@@ -122,16 +122,16 @@ 
     private function checkCacheFolder($ident)
     {
         $cacheFolder = temp_path($this->cachePathPrefix . '/');
-        if(!file_exists($cacheFolder)) {
+        if (!file_exists($cacheFolder)) {
             mkdir($cacheFolder);
         }
 
-        if(!$ident) {
+        if (!$ident) {
             $ident = $this->undefinedFolderName;
         }
 
         $identFolder = temp_path($this->cachePathPrefix . '/' . $ident . '/');
-        if(!file_exists($identFolder)) {
+        if (!file_exists($identFolder)) {
             mkdir($identFolder);
         }
     }

services/BaseService.php

Spacing +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
     {
         $r = [];
         $lines = preg_split('/\r\n|\n|\r/', trim($source));
-        foreach($lines as $key => $line)
+        foreach ($lines as $key => $line)
         {
             // file headers
             if ($key < 3) {

Doc Comments +3 added lines, -3 removed lines

@@ -22,7 +22,7 @@ 
      *
      * @param $date
      *
-     * @return array
+     * @return string
      */
     public function getDataSource($date = null)
     {
@@ -61,7 +61,7 @@ 
      *
      * @param $date
      *
-     * @return mixed
+     * @return string
      */
     public function getSourceUrl($date = null)
     {
@@ -101,7 +101,7 @@ 
     /**
      * Transform data source to array
      *
-     * @param $source
+     * @param string $source
      * @param int $keyIndex
      *
      * @return array

services/ExchangeRateService.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
         $rates = $this->getData($date, $keyIndex = 3);
         $r = [];
 
-        foreach($rates as $key => $rate)
+        foreach ($rates as $key => $rate)
         {
             if (sizeof($rate) >= 4)
             {

services/PriborService.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
         $intervalKeys = $this->getIntervalKeys();
         $r = [];
 
-        foreach($data as $key => $rate) {
+        foreach ($data as $key => $rate) {
             if (isset($intervalKeys[$key])) {
                 $r[$intervalKeys[$key]] = round(floatval(strtr($rate[2], [',' => '.'])), 2);
             }