vimeo / psalm

src/Psalm/Codebase.php

Doc Comments +2 added lines, -2 removed lines

@@ -880,7 +880,7 @@ 
     /**
      * Whether or not a given method exists
      *
-     * @param  string|\Psalm\Internal\MethodIdentifier       $method_id
+     * @param  string       $method_id
      * @param  string|\Psalm\Internal\MethodIdentifier|null $calling_method_id
      *
      @return bool
@@ -988,7 +988,7 @@ 
     /**
      * @param  string|\Psalm\Internal\MethodIdentifier $method_id
      *
-     * @return array<string>
+     * @return Internal\MethodIdentifier[]
      */
     public function getOverriddenMethodIds($method_id)
     {

src/Psalm/Context.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use function preg_replace;
 use Psalm\Internal\Analyzer\StatementsAnalyzer;
 use Psalm\Internal\Clause;
-use Psalm\Internal\MethodIdentifier;
 use Psalm\Storage\FunctionLikeStorage;
 use Psalm\Internal\Type\AssertionReconciler;
 use Psalm\Type\Union;

src/Psalm/Internal/Analyzer/ClassAnalyzer.php

Doc Comments +3 added lines

@@ -958,6 +958,9 @@
         }
     }
 
+    /**
+     * @param string|null $parent_fq_class_name
+     */
     public static function addContextProperties(
         StatementsSource $statements_source,
         ClassLikeStorage $storage,

src/Psalm/Internal/Analyzer/ClassLikeAnalyzer.php

Doc Comments +1 added lines, -1 removed lines

@@ -211,6 +211,7 @@ 
      * @param  string           $fq_class_name
      * @param  array<string>    $suppressed_issues
      * @param  bool             $inferred - whether or not the type was inferred
+     * @param null|string $calling_fq_class_name
      *
      * @return bool|null
      */
@@ -538,7 +539,6 @@ 
 
     /**
      * @param  string           $property_id
-     * @param  string|null      $calling_context
      * @param  SourceAnalyzer   $source
      * @param  CodeLocation     $code_location
      * @param  string[]         $suppressed_issues

src/Psalm/Internal/Analyzer/MethodAnalyzer.php

Doc Comments +1 added lines, -1 removed lines

@@ -141,7 +141,7 @@
     /**
      * @param  CodeLocation $code_location
      * @param  string[]     $suppressed_issues
-     * @param  lowercase-string|null  $calling_method_id
+     * @param  string  $calling_method_id
      *
      * @return bool|null
      */

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use Psalm\IssueBuffer;
 use Psalm\StatementsSource;
 use Psalm\Storage\MethodStorage;
-use Psalm\Type;
 use function strtolower;
 use function in_array;
 

src/Psalm/Internal/Analyzer/ProjectAnalyzer.php

Doc Comments -4 removed lines

@@ -232,7 +232,6 @@ 
     /**
      * @param array<ReportOptions> $generated_report_options
      * @param int           $threads
-     * @param string        $reports
      */
     public function __construct(
         Config $config,
@@ -1018,7 +1017,6 @@ 
     }
 
     /**
-     * @param  string  $dir_name
      *
      * @return void
      */
@@ -1224,8 +1222,6 @@ 
     }
 
     /**
-     * @param int $php_major_version
-     * @param int $php_minor_version
      * @param bool $dry_run
      * @param bool $safe_types
      *

src/Psalm/Internal/Analyzer/ScopeAnalyzer.php

Doc Comments +1 added lines

@@ -73,6 +73,7 @@
      * @param   array<PhpParser\Node> $stmts
      * @param   bool $return_is_exit Exit and Throw statements are treated differently from return if this is false
      * @param   list<'loop'|'switch'> $break_types
+     * @param \Psalm\Internal\Provider\NodeDataProvider|null $nodes
      *
      * @return  list<value-of<self::ACTIONS>>
      */

src/Psalm/Internal/Analyzer/Statements/Block/ForeachAnalyzer.php

Doc Comments +3 added lines

@@ -1004,6 +1004,9 @@
         }
     }
 
+    /**
+     * @return Type\Union
+     */
     private static function getFakeMethodCallType(
         StatementsAnalyzer $statements_analyzer,
         PhpParser\Node\Expr $foreach_expr,

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Psalm\Codebase;
 use Psalm\Internal\Analyzer\ClassLikeAnalyzer;
 use Psalm\Internal\Analyzer\CommentAnalyzer;
-use Psalm\Internal\Analyzer\ScopeAnalyzer;
 use Psalm\Internal\Analyzer\Statements\Expression\AssignmentAnalyzer;
 use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
 use Psalm\Internal\Analyzer\Statements\Expression\ExpressionIdentifier;

src/Psalm/Internal/Analyzer/Statements/Block/IfAnalyzer.php

Doc Comments +9 added lines, -9 removed lines

@@ -122,7 +122,7 @@ 
         $if_clauses = array_values(
             array_map(
                 /**
-                 * @return Clause
+                 * @return false|null
                  */
                 function (Clause $c) use ($mixed_var_ids) {
                     $keys = array_keys($c->possibilities);
@@ -217,8 +217,8 @@ 
             $omit_keys = array_reduce(
                 $context->clauses,
                 /**
-                 * @param array<string> $carry
-                 * @return array<string>
+                 * @param StatementsAnalyzer $carry
+                 * @return false|null
                  */
                 function ($carry, Clause $clause) {
                     return array_merge($carry, array_keys($clause->possibilities));
@@ -553,7 +553,7 @@ 
                     $entry_clauses = array_values(
                         array_filter(
                             $entry_clauses,
-                            /** @return bool */
+                            /** @return \Psalm\Internal\Scope\IfConditionalScope */
                             function (Clause $c) use ($changed_var_ids) {
                                 return count($c->possibilities) > 1
                                     || $c->wedge
@@ -683,9 +683,9 @@ 
 
         $newish_var_ids = array_map(
             /**
-             * @param Type\Union $_
+             * @param StatementsAnalyzer $_
              *
-             * @return true
+             * @return \Psalm\Internal\Scope\IfConditionalScope
              */
             function (Type\Union $_) {
                 return true;
@@ -1044,7 +1044,7 @@ 
      * @param  StatementsAnalyzer           $statements_analyzer
      * @param  PhpParser\Node\Stmt\ElseIf_ $elseif
      * @param  IfScope                     $if_scope
-     * @param  Context                     $elseif_context
+     * @param  Context                     $else_context
      * @param  Context                     $outer_context
      *
      * @return false|null
@@ -1096,7 +1096,7 @@ 
 
         $elseif_clauses = array_map(
             /**
-             * @return Clause
+             * @return false|null
              */
             function (Clause $c) use ($mixed_var_ids) {
                 $keys = array_keys($c->possibilities);
@@ -1118,7 +1118,7 @@ 
 
         $entry_clauses = array_map(
             /**
-             * @return Clause
+             * @return false|null
              */
             function (Clause $c) use ($cond_assigned_var_ids) {
                 $keys = array_keys($c->possibilities);