vimeo / psalm

src/Psalm/Checker/ClassChecker.php

Doc Comments +2 added lines, -3 removed lines

@@ -63,7 +63,6 @@ 
      * Determine whether or not a given class exists
      *
      * @param  string       $fq_class_name
-     * @param  FileChecker  $file_checker
      *
      * @return bool
      */
@@ -564,7 +563,7 @@ 
                         $constructor_storage = $constructor_class_storage->methods['__construct'];
 
                         $fake_constructor_params = array_map(
-                            /** @return PhpParser\Node\Param */
+                            /** @return null|false */
                             function (\Psalm\FunctionLikeParameter $param) {
                                 $fake_param = (new PhpParser\Builder\Param($param->name));
                                 if ($param->signature_type) {
@@ -577,7 +576,7 @@ 
                         );
 
                         $fake_constructor_stmt_args = array_map(
-                            /** @return PhpParser\Node\Arg */
+                            /** @return null|false */
                             function (\Psalm\FunctionLikeParameter $param) {
                                 return new PhpParser\Node\Arg(new PhpParser\Node\Expr\Variable($param->name));
                             },

src/Psalm/Checker/ClassLikeChecker.php

Doc Comments +1 added lines, -1 removed lines

@@ -625,7 +625,7 @@
      * @param  string|null      $calling_context
      * @param  StatementsSource $source
      * @param  CodeLocation     $code_location
-     * @param  array            $suppressed_issues
+     * @param  string[]            $suppressed_issues
      * @param  bool             $emit_issues
      *
      * @return bool|null

src/Psalm/Checker/FunctionChecker.php

Doc Comments +1 added lines, -1 removed lines

@@ -146,7 +146,7 @@
      * @param  string                      $function_id
      * @param  array<PhpParser\Node\Arg>   $call_args
      * @param  CodeLocation                $code_location
-     * @param  array                       $suppressed_issues
+     * @param  string[]                       $suppressed_issues
      *
      * @return Type\Union
      */

src/Psalm/Checker/MethodChecker.php

Doc Comments +3 added lines, -3 removed lines

@@ -220,7 +220,7 @@ 
     /**
      * @param  string       $method_id
      * @param  CodeLocation $code_location
-     * @param  array        $suppressed_issues
+     * @param  string[]        $suppressed_issues
      *
      * @return bool|null
      */
@@ -331,7 +331,7 @@ 
     /**
      * @param  string       $method_id
      * @param  CodeLocation $code_location
-     * @param  array        $suppressed_issues
+     * @param  string[]        $suppressed_issues
      *
      * @return false|null
      */
@@ -444,7 +444,7 @@ 
      * @param  string|null      $calling_context
      * @param  StatementsSource $source
      * @param  CodeLocation     $code_location
-     * @param  array            $suppressed_issues
+     * @param  string[]            $suppressed_issues
      *
      * @return false|null
      */

src/Psalm/Checker/Statements/Block/IfChecker.php

Doc Comments +3 added lines, -3 removed lines

@@ -163,7 +163,7 @@ 
         $if_clauses = array_values(
             array_filter(
                 $if_clauses,
-                /** @return bool */
+                /** @return false|null */
                 function (Clause $c) use ($mixed_var_ids) {
                     $keys = array_keys($c->possibilities);
 
@@ -678,7 +678,7 @@ 
             if ($changed_var_ids) {
                 $entry_clauses = array_filter(
                     $entry_clauses,
-                    /** @return bool */
+                    /** @return false|null */
                     function (Clause $c) use ($changed_var_ids) {
                         return count($c->possibilities) > 1
                             || !in_array(array_keys($c->possibilities)[0], $changed_var_ids, true);
@@ -730,7 +730,7 @@ 
         $elseif_clauses = array_values(
             array_filter(
                 $elseif_clauses,
-                /** @return bool */
+                /** @return false|null */
                 function (Clause $c) use ($mixed_var_ids) {
                     $keys = array_keys($c->possibilities);
 

src/Psalm/Checker/Statements/Block/LoopChecker.php

Doc Comments +1 added lines, -3 removed lines

@@ -19,11 +19,9 @@
     /**
      * Checks an array of statements in a loop
      *
-     * @param  array<PhpParser\Node\Stmt|PhpParser\Node\Expr>   $stmts
+     * @param  PhpParser\Node[]   $stmts
      * @param  PhpParser\Node\Expr[]                            $pre_conditions
      * @param  PhpParser\Node\Expr[]                            $post_conditions
-     * @param  Context                                          $loop_scope->loop_context
-     * @param  Context                                          $loop_scope->loop_parent_context
      *
      * @return false|null
      */

src/Psalm/Checker/Statements/Block/TryChecker.php

Doc Comments +2 added lines, -2 removed lines

@@ -147,9 +147,9 @@
             $catch_context->vars_in_scope[$catch_var_id] = new Type\Union(
                 array_map(
                     /**
-                     * @param string $fq_catch_class
+                     * @param StatementsChecker $fq_catch_class
                      *
-                     * @return Type\Atomic
+                     * @return false|null
                      */
                     function ($fq_catch_class) use ($project_checker) {
                         $catch_class_type = new TNamedObject($fq_catch_class);

src/Psalm/Checker/Statements/Expression/CallChecker.php

Doc Comments +2 added lines, -2 removed lines

@@ -685,7 +685,7 @@ 
      * @param   PhpParser\Node\Expr\MethodCall  $stmt
      * @param   Context                         $context
      *
-     * @return  false|null
+     * @return  null|boolean
      */
     public static function analyzeMethodCall(
         StatementsChecker $statements_checker,
@@ -1293,7 +1293,7 @@ 
      * @param   PhpParser\Node\Expr\StaticCall  $stmt
      * @param   Context                         $context
      *
-     * @return  false|null
+     * @return  null|boolean
      */
     public static function analyzeStaticCall(
         StatementsChecker $statements_checker,

src/Psalm/Checker/Statements/Expression/Fetch/ArrayFetchChecker.php

Doc Comments +1 added lines, -1 removed lines

@@ -138,7 +138,7 @@
     /**
      * @param  Type\Union $array_type
      * @param  Type\Union $offset_type
-     * @param  ?string    $array_var_id
+     * @param  string|null    $array_var_id
      * @param  bool       $in_assignment
      * @param  bool       $inside_isset
      *