VideoGamesRecords\CoreBundle\Command\Ranking\TeamScoringRankingUpdateCommand::execute()

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $store = new SemaphoreStore();
        $factory = new LockFactory($store);

        $lock = $factory->createLock($this->getName());

It seems like $this->getName() can also be of type null; however, parameter $resource of Symfony\Component\Lock\LockFactory::createLock() does only seem to accept string, maybe add an additional type check?

        if ($lock->acquire()) {
            $this->scoringTeamRankingHandler->handle();
            $lock->release();
        } else {
            echo self::$defaultName . " IS LOCKED\n";
        }
        return Command::SUCCESS;
    }