VideoGamesRecords\CoreBundle\Command\Ranking\TeamScoringRankingUpdateCommand

Complexity

Total Complexity

3

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	execute()	0	14	2

<?php

declare(strict_types=1);

namespace VideoGamesRecords\CoreBundle\Command\Ranking;

use Doctrine\ORM\NonUniqueResultException;
use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Lock\LockFactory;
use Symfony\Component\Lock\Store\SemaphoreStore;
use VideoGamesRecords\CoreBundle\Ranking\Command\ScoringTeamRankingHandler;

#[AsCommand(
    name: 'vgr-core:team-scoring-ranking-update',
    description: 'Command to update all team rankings after scroring'
)]
class TeamScoringRankingUpdateCommand extends Command
{
    private ScoringTeamRankingHandler $scoringTeamRankingHandler;

    public function __construct(ScoringTeamRankingHandler $scoringTeamRankingHandler)
    {
        $this->scoringTeamRankingHandler = $scoringTeamRankingHandler;
        parent::__construct();
    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     * @return int
     * @throws NonUniqueResultException
     */
    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $store = new SemaphoreStore();
        $factory = new LockFactory($store);

        $lock = $factory->createLock($this->getName());

It seems like $this->getName() can also be of type null; however, parameter $resource of Symfony\Component\Lock\LockFactory::createLock() does only seem to accept string, maybe add an additional type check?

        if ($lock->acquire()) {
            $this->scoringTeamRankingHandler->handle();
            $lock->release();
        } else {
            echo self::$defaultName . " IS LOCKED\n";
        }
        return Command::SUCCESS;
    }
}