Completed
Pull Request — master (#358)
by John
11:45
created
PhpAmqpLib/Channel/AbstractChannel.php 2 patches
Doc Comments   +12 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
     /**
72 72
      * @param AbstractConnection $connection
73
-     * @param $channel_id
73
+     * @param integer|null $channel_id
74 74
      * @throws \PhpAmqpLib\Exception\AMQPRuntimeException
75 75
      */
76 76
     public function __construct(AbstractConnection $connection, $channel_id)
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
      * @param $method_sig
235 235
      * @param string $args
236 236
      * @param null $pkt
237
-     * @return null|\PhpAmqpLib\Wire\AMQPWriter
237
+     * @return \PhpAmqpLib\Wire\AMQPWriter
238 238
      */
239 239
     protected function prepare_method_frame($method_sig, $args = '', $pkt = null)
240 240
     {
@@ -408,6 +408,10 @@  discard block
 block discarded – undo
408 408
         $this->validate_frame($frame_type, 3, 'AMQP Content body');
409 409
     }
410 410
 
411
+    /**
412
+     * @param integer $expected_type
413
+     * @param string $expected_msg
414
+     */
411 415
     protected function validate_frame($frame_type, $expected_type, $expected_msg)
412 416
     {
413 417
         if ($frame_type != $expected_type) {
@@ -444,6 +448,9 @@  discard block
 block discarded – undo
444 448
         return mb_substr($payload, 4, mb_strlen($payload, 'ASCII') - 4, 'ASCII');
445 449
     }
446 450
 
451
+    /**
452
+     * @param string $method_sig
453
+     */
447 454
     protected function should_dispatch_method($allowed_methods, $method_sig)
448 455
     {
449 456
         $PROTOCOL_CONSTANTS_CLASS = self::$PROTOCOL_CONSTANTS_CLASS;
@@ -453,6 +460,9 @@  discard block
 block discarded – undo
453 460
             || in_array($method_sig, $PROTOCOL_CONSTANTS_CLASS::$CLOSE_METHODS);
454 461
     }
455 462
 
463
+    /**
464
+     * @param string $method_sig
465
+     */
456 466
     protected function maybe_wait_for_content($method_sig)
457 467
     {
458 468
         $PROTOCOL_CONSTANTS_CLASS = self::$PROTOCOL_CONSTANTS_CLASS;
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 use PhpAmqpLib\Exception\AMQPBasicCancelException;
5 5
 use PhpAmqpLib\Exception\AMQPProtocolChannelException;
6 6
 use PhpAmqpLib\Exception\AMQPRuntimeException;
7
-use PhpAmqpLib\Helper\MiscHelper;
8 7
 use PhpAmqpLib\Message\AMQPMessage;
9 8
 use PhpAmqpLib\Wire\AMQPReader;
10 9
 use PhpAmqpLib\Wire\AMQPWriter;
Please login to merge, or discard this patch.
PhpAmqpLib/Channel/AMQPChannel.php 1 patch
Doc Comments   +10 added lines, -6 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
     }
227 227
 
228 228
     /**
229
-     * @param $active
229
+     * @param boolean $active
230 230
      */
231 231
     protected function x_flow_ok($active)
232 232
     {
@@ -634,7 +634,7 @@  discard block
 block discarded – undo
634 634
      * Confirms a queue definition
635 635
      *
636 636
      * @param AMQPReader $args
637
-     * @return array
637
+     * @return string[]
638 638
      */
639 639
     protected function queue_declare_ok($args)
640 640
     {
@@ -783,7 +783,7 @@  discard block
 block discarded – undo
783 783
      *
784 784
      * @param string $delivery_tag
785 785
      * @param bool $multiple
786
-     * @param $handler
786
+     * @param callable $handler
787 787
      */
788 788
     protected function internal_ack_handler($delivery_tag, $multiple, $handler)
789 789
     {
@@ -801,14 +801,18 @@  discard block
 block discarded – undo
801 801
     }
802 802
 
803 803
     /**
804
-     * @param array $array
805
-     * @param $value
804
+     * @param AMQPMessage[] $array
805
+     * @param string $value
806 806
      * @return mixed
807 807
      */
808 808
     protected function get_keys_less_or_equal(array $array, $value)
809 809
     {
810 810
         $keys = array_reduce(
811 811
             array_keys($array),
812
+
813
+            /**
814
+             * @param string $key
815
+             */
812 816
             function ($keys, $key) use ($value) {
813 817
                 if (bccomp($key, $value, 0) <= 0) {
814 818
                     $keys[] = $key;
@@ -1418,7 +1422,7 @@  discard block
 block discarded – undo
1418 1422
     /**
1419 1423
      * Helper method to get a particular method from $this->publishedMessages, removes it from the array and returns it.
1420 1424
      *
1421
-     * @param $index
1425
+     * @param string $index
1422 1426
      * @return AMQPMessage
1423 1427
      */
1424 1428
     protected function get_and_unset_message($index)
Please login to merge, or discard this patch.
PhpAmqpLib/Connection/AbstractConnection.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -435,7 +435,7 @@  discard block
 block discarded – undo
435 435
     }
436 436
 
437 437
     /**
438
-     * @param $channel
438
+     * @param string $channel
439 439
      * @param $method_sig
440 440
      * @param string $args
441 441
      * @param null $pkt
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
      * @param $method_sig
455 455
      * @param string $args
456 456
      * @param AMQPWriter $pkt
457
-     * @return null|AMQPWriter
457
+     * @return AMQPWriter
458 458
      */
459 459
     protected function prepare_channel_method_frame($channel, $method_sig, $args = '', $pkt = null)
460 460
     {
@@ -769,9 +769,9 @@  discard block
 block discarded – undo
769 769
 
770 770
     /**
771 771
      * @param $client_properties
772
-     * @param $mechanism
773
-     * @param $response
774
-     * @param $locale
772
+     * @param string $mechanism
773
+     * @param AMQPWriter $response
774
+     * @param string $locale
775 775
      */
776 776
     protected function x_start_ok($client_properties, $mechanism, $response, $locale)
777 777
     {
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace PhpAmqpLib\Connection;
3 3
 
4
-use PhpAmqpLib\Channel\AbstractChannel;
5 4
 use PhpAmqpLib\Channel\AMQPChannel;
5
+use PhpAmqpLib\Channel\AbstractChannel;
6 6
 use PhpAmqpLib\Exception\AMQPProtocolConnectionException;
7 7
 use PhpAmqpLib\Exception\AMQPRuntimeException;
8 8
 use PhpAmqpLib\Exception\AMQPTimeoutException;
Please login to merge, or discard this patch.
PhpAmqpLib/Helper/Protocol/Protocol080.php 2 patches
Doc Comments   +26 added lines, -18 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 
57 57
     /**
58 58
      * @param AMQPReader $args
59
-     * @return array
59
+     * @return string[]
60 60
      */
61 61
     public static function connectionSecureOk($args)
62 62
     {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 
113 113
     /**
114 114
      * @param AMQPReader $args
115
-     * @return array
115
+     * @return string[]
116 116
      */
117 117
     public static function connectionOpenOk($args)
118 118
     {
@@ -137,6 +137,7 @@  discard block
 block discarded – undo
137 137
 
138 138
 
139 139
     /**
140
+     * @param integer $reply_code
140 141
      * @return array
141 142
      */
142 143
     public function connectionClose($reply_code, $reply_text = '', $class_id, $method_id)
@@ -201,7 +202,7 @@  discard block
 block discarded – undo
201 202
 
202 203
     /**
203 204
      * @param AMQPReader $args
204
-     * @return array
205
+     * @return boolean[]
205 206
      */
206 207
     public static function channelFlowOk($args)
207 208
     {
@@ -227,6 +228,7 @@  discard block
 block discarded – undo
227 228
 
228 229
 
229 230
     /**
231
+     * @param integer $reply_code
230 232
      * @return array
231 233
      */
232 234
     public function channelClose($reply_code, $reply_text = '', $class_id, $method_id)
@@ -280,6 +282,7 @@  discard block
 block discarded – undo
280 282
 
281 283
 
282 284
     /**
285
+     * @param string $exchange
283 286
      * @return array
284 287
      */
285 288
     public function exchangeDeclare($ticket = 1, $exchange, $type = 'direct', $passive = false, $durable = false, $auto_delete = false, $internal = false, $nowait = false, $arguments = array())
@@ -308,6 +311,7 @@  discard block
 block discarded – undo
308 311
 
309 312
 
310 313
     /**
314
+     * @param string $exchange
311 315
      * @return array
312 316
      */
313 317
     public function exchangeDelete($ticket = 1, $exchange, $if_unused = false, $nowait = false)
@@ -350,7 +354,7 @@  discard block
 block discarded – undo
350 354
 
351 355
     /**
352 356
      * @param AMQPReader $args
353
-     * @return array
357
+     * @return string[]
354 358
      */
355 359
     public static function queueDeclareOk($args)
356 360
     {
@@ -364,6 +368,7 @@  discard block
 block discarded – undo
364 368
 
365 369
 
366 370
     /**
371
+     * @param string $exchange
367 372
      * @return array
368 373
      */
369 374
     public function queueBind($ticket = 1, $queue = '', $exchange, $routing_key = '', $nowait = false, $arguments = array())
@@ -408,7 +413,7 @@  discard block
 block discarded – undo
408 413
 
409 414
     /**
410 415
      * @param AMQPReader $args
411
-     * @return array
416
+     * @return string[]
412 417
      */
413 418
     public static function queuePurgeOk($args)
414 419
     {
@@ -435,7 +440,7 @@  discard block
 block discarded – undo
435 440
 
436 441
     /**
437 442
      * @param AMQPReader $args
438
-     * @return array
443
+     * @return string[]
439 444
      */
440 445
     public static function queueDeleteOk($args)
441 446
     {
@@ -447,6 +452,7 @@  discard block
 block discarded – undo
447 452
 
448 453
 
449 454
     /**
455
+     * @param string $exchange
450 456
      * @return array
451 457
      */
452 458
     public function queueUnbind($ticket = 1, $queue = '', $exchange, $routing_key = '', $arguments = array())
@@ -517,7 +523,7 @@  discard block
 block discarded – undo
517 523
 
518 524
     /**
519 525
      * @param AMQPReader $args
520
-     * @return array
526
+     * @return string[]
521 527
      */
522 528
     public static function basicConsumeOk($args)
523 529
     {
@@ -529,6 +535,7 @@  discard block
 block discarded – undo
529 535
 
530 536
 
531 537
     /**
538
+     * @param string $consumer_tag
532 539
      * @return array
533 540
      */
534 541
     public function basicCancel($consumer_tag, $nowait = false)
@@ -543,7 +550,7 @@  discard block
 block discarded – undo
543 550
 
544 551
     /**
545 552
      * @param AMQPReader $args
546
-     * @return array
553
+     * @return string[]
547 554
      */
548 555
     public static function basicCancelOk($args)
549 556
     {
@@ -633,7 +640,7 @@  discard block
 block discarded – undo
633 640
 
634 641
     /**
635 642
      * @param AMQPReader $args
636
-     * @return array
643
+     * @return string[]
637 644
      */
638 645
     public static function basicGetEmpty($args)
639 646
     {
@@ -658,6 +665,7 @@  discard block
 block discarded – undo
658 665
 
659 666
 
660 667
     /**
668
+     * @param string $delivery_tag
661 669
      * @return array
662 670
      */
663 671
     public function basicReject($delivery_tag, $requeue = true)
@@ -749,7 +757,7 @@  discard block
 block discarded – undo
749 757
 
750 758
     /**
751 759
      * @param AMQPReader $args
752
-     * @return array
760
+     * @return string[]
753 761
      */
754 762
     public static function fileConsumeOk($args)
755 763
     {
@@ -775,7 +783,7 @@  discard block
 block discarded – undo
775 783
 
776 784
     /**
777 785
      * @param AMQPReader $args
778
-     * @return array
786
+     * @return string[]
779 787
      */
780 788
     public static function fileCancelOk($args)
781 789
     {
@@ -801,7 +809,7 @@  discard block
 block discarded – undo
801 809
 
802 810
     /**
803 811
      * @param AMQPReader $args
804
-     * @return array
812
+     * @return string[]
805 813
      */
806 814
     public static function fileOpenOk($args)
807 815
     {
@@ -941,7 +949,7 @@  discard block
 block discarded – undo
941 949
 
942 950
     /**
943 951
      * @param AMQPReader $args
944
-     * @return array
952
+     * @return string[]
945 953
      */
946 954
     public static function streamConsumeOk($args)
947 955
     {
@@ -967,7 +975,7 @@  discard block
 block discarded – undo
967 975
 
968 976
     /**
969 977
      * @param AMQPReader $args
970
-     * @return array
978
+     * @return string[]
971 979
      */
972 980
     public static function streamCancelOk($args)
973 981
     {
@@ -1169,7 +1177,7 @@  discard block
 block discarded – undo
1169 1177
 
1170 1178
     /**
1171 1179
      * @param AMQPReader $args
1172
-     * @return array
1180
+     * @return string[]
1173 1181
      */
1174 1182
     public static function testIntegerOk($args)
1175 1183
     {
@@ -1196,7 +1204,7 @@  discard block
 block discarded – undo
1196 1204
 
1197 1205
     /**
1198 1206
      * @param AMQPReader $args
1199
-     * @return array
1207
+     * @return string[]
1200 1208
      */
1201 1209
     public static function testStringOk($args)
1202 1210
     {
@@ -1223,7 +1231,7 @@  discard block
 block discarded – undo
1223 1231
 
1224 1232
     /**
1225 1233
      * @param AMQPReader $args
1226
-     * @return array
1234
+     * @return string[]
1227 1235
      */
1228 1236
     public static function testTableOk($args)
1229 1237
     {
@@ -1248,7 +1256,7 @@  discard block
 block discarded – undo
1248 1256
 
1249 1257
     /**
1250 1258
      * @param AMQPReader $args
1251
-     * @return array
1259
+     * @return string[]
1252 1260
      */
1253 1261
     public static function testContentOk($args)
1254 1262
     {
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@
 block discarded – undo
4 4
 
5 5
 namespace PhpAmqpLib\Helper\Protocol;
6 6
 
7
-use PhpAmqpLib\Wire\AMQPWriter;
8 7
 use PhpAmqpLib\Wire\AMQPReader;
8
+use PhpAmqpLib\Wire\AMQPWriter;
9 9
 
10 10
 class Protocol091
11 11
 {
Please login to merge, or discard this patch.
PhpAmqpLib/Helper/Protocol/Protocol091.php 2 patches
Doc Comments   +22 added lines, -10 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 
57 57
     /**
58 58
      * @param AMQPReader $args
59
-     * @return array
59
+     * @return string[]
60 60
      */
61 61
     public static function connectionSecureOk($args)
62 62
     {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 
113 113
     /**
114 114
      * @param AMQPReader $args
115
-     * @return array
115
+     * @return string[]
116 116
      */
117 117
     public static function connectionOpenOk($args)
118 118
     {
@@ -124,6 +124,7 @@  discard block
 block discarded – undo
124 124
 
125 125
 
126 126
     /**
127
+     * @param integer $reply_code
127 128
      * @return array
128 129
      */
129 130
     public function connectionClose($reply_code, $reply_text = '', $class_id, $method_id)
@@ -188,7 +189,7 @@  discard block
 block discarded – undo
188 189
 
189 190
     /**
190 191
      * @param AMQPReader $args
191
-     * @return array
192
+     * @return string[]
192 193
      */
193 194
     public static function channelOpenOk($args)
194 195
     {
@@ -213,7 +214,7 @@  discard block
 block discarded – undo
213 214
 
214 215
     /**
215 216
      * @param AMQPReader $args
216
-     * @return array
217
+     * @return boolean[]
217 218
      */
218 219
     public static function channelFlowOk($args)
219 220
     {
@@ -225,6 +226,7 @@  discard block
 block discarded – undo
225 226
 
226 227
 
227 228
     /**
229
+     * @param integer $reply_code
228 230
      * @return array
229 231
      */
230 232
     public function channelClose($reply_code, $reply_text = '', $class_id, $method_id)
@@ -278,6 +280,7 @@  discard block
 block discarded – undo
278 280
 
279 281
 
280 282
     /**
283
+     * @param string $exchange
281 284
      * @return array
282 285
      */
283 286
     public function exchangeDeclare($ticket = 0, $exchange, $type = 'direct', $passive = false, $durable = false, $auto_delete = false, $internal = false, $nowait = false, $arguments = array())
@@ -306,6 +309,7 @@  discard block
 block discarded – undo
306 309
 
307 310
 
308 311
     /**
312
+     * @param string $exchange
309 313
      * @return array
310 314
      */
311 315
     public function exchangeDelete($ticket = 0, $exchange, $if_unused = false, $nowait = false)
@@ -332,6 +336,8 @@  discard block
 block discarded – undo
332 336
 
333 337
 
334 338
     /**
339
+     * @param string $destination
340
+     * @param string $source
335 341
      * @return array
336 342
      */
337 343
     public function exchangeBind($ticket = 0, $destination, $source, $routing_key = '', $nowait = false, $arguments = array())
@@ -361,6 +367,8 @@  discard block
 block discarded – undo
361 367
 
362 368
 
363 369
     /**
370
+     * @param string $destination
371
+     * @param string $source
364 372
      * @return array
365 373
      */
366 374
     public function exchangeUnbind($ticket = 0, $destination, $source, $routing_key = '', $nowait = false, $arguments = array())
@@ -406,7 +414,7 @@  discard block
 block discarded – undo
406 414
 
407 415
     /**
408 416
      * @param AMQPReader $args
409
-     * @return array
417
+     * @return string[]
410 418
      */
411 419
     public static function queueDeclareOk($args)
412 420
     {
@@ -420,6 +428,7 @@  discard block
 block discarded – undo
420 428
 
421 429
 
422 430
     /**
431
+     * @param string $exchange
423 432
      * @return array
424 433
      */
425 434
     public function queueBind($ticket = 0, $queue = '', $exchange, $routing_key = '', $nowait = false, $arguments = array())
@@ -464,7 +473,7 @@  discard block
 block discarded – undo
464 473
 
465 474
     /**
466 475
      * @param AMQPReader $args
467
-     * @return array
476
+     * @return string[]
468 477
      */
469 478
     public static function queuePurgeOk($args)
470 479
     {
@@ -491,7 +500,7 @@  discard block
 block discarded – undo
491 500
 
492 501
     /**
493 502
      * @param AMQPReader $args
494
-     * @return array
503
+     * @return string[]
495 504
      */
496 505
     public static function queueDeleteOk($args)
497 506
     {
@@ -503,6 +512,7 @@  discard block
 block discarded – undo
503 512
 
504 513
 
505 514
     /**
515
+     * @param string $exchange
506 516
      * @return array
507 517
      */
508 518
     public function queueUnbind($ticket = 0, $queue = '', $exchange, $routing_key = '', $arguments = array())
@@ -574,7 +584,7 @@  discard block
 block discarded – undo
574 584
 
575 585
     /**
576 586
      * @param AMQPReader $args
577
-     * @return array
587
+     * @return string[]
578 588
      */
579 589
     public static function basicConsumeOk($args)
580 590
     {
@@ -586,6 +596,7 @@  discard block
 block discarded – undo
586 596
 
587 597
 
588 598
     /**
599
+     * @param string $consumer_tag
589 600
      * @return array
590 601
      */
591 602
     public function basicCancel($consumer_tag, $nowait = false)
@@ -600,7 +611,7 @@  discard block
 block discarded – undo
600 611
 
601 612
     /**
602 613
      * @param AMQPReader $args
603
-     * @return array
614
+     * @return string[]
604 615
      */
605 616
     public static function basicCancelOk($args)
606 617
     {
@@ -690,7 +701,7 @@  discard block
 block discarded – undo
690 701
 
691 702
     /**
692 703
      * @param AMQPReader $args
693
-     * @return array
704
+     * @return string[]
694 705
      */
695 706
     public static function basicGetEmpty($args)
696 707
     {
@@ -715,6 +726,7 @@  discard block
 block discarded – undo
715 726
 
716 727
 
717 728
     /**
729
+     * @param string $delivery_tag
718 730
      * @return array
719 731
      */
720 732
     public function basicReject($delivery_tag, $requeue = true)
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@
 block discarded – undo
4 4
 
5 5
 namespace PhpAmqpLib\Helper\Protocol;
6 6
 
7
-use PhpAmqpLib\Wire\AMQPWriter;
8 7
 use PhpAmqpLib\Wire\AMQPReader;
8
+use PhpAmqpLib\Wire\AMQPWriter;
9 9
 
10 10
 class Protocol091
11 11
 {
Please login to merge, or discard this patch.
PhpAmqpLib/Wire/AMQPReader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -521,7 +521,7 @@
 block discarded – undo
521 521
     /**
522 522
      * Sets the timeout (second)
523 523
      *
524
-     * @param $timeout
524
+     * @param integer $timeout
525 525
      */
526 526
     public function setTimeout($timeout)
527 527
     {
Please login to merge, or discard this patch.
PhpAmqpLib/Wire/AMQPWriter.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     /**
132 132
      * Write multiple bits as an octet
133 133
      *
134
-     * @param $bits
134
+     * @param boolean[] $bits
135 135
      * @return $this
136 136
      */
137 137
     public function write_bits($bits)
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 
307 307
     /**
308 308
      * @param int $n
309
-     * @return array
309
+     * @return integer[]
310 310
      */
311 311
     private function splitIntoQuads($n)
312 312
     {
Please login to merge, or discard this patch.
PhpAmqpLib/Wire/IO/StreamIO.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     /**
185 185
      * @param $len
186 186
      * @throws \PhpAmqpLib\Exception\AMQPIOException
187
-     * @return mixed|string
187
+     * @return string
188 188
      */
189 189
     public function read($len)
190 190
     {
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
     }
240 240
 
241 241
     /**
242
-     * @param $data
242
+     * @param string $data
243 243
      * @return mixed|void
244 244
      * @throws \PhpAmqpLib\Exception\AMQPRuntimeException
245 245
      * @throws \PhpAmqpLib\Exception\AMQPTimeoutException
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
     /**
375 375
      * @param $sec
376 376
      * @param $usec
377
-     * @return int|mixed
377
+     * @return integer
378 378
      */
379 379
     public function select($sec, $usec)
380 380
     {
Please login to merge, or discard this patch.