venta / framework

src/Console/src/Command.php

Doc Comments +4 added lines, -4 removed lines

@@ -36,7 +36,7 @@ 
      * Helper method to get input argument
      *
      * @param string $name
-     * @return mixed
+     * @return string
      */
     public function arg(string $name)
     {
@@ -83,7 +83,7 @@ 
      * Helper method to get input option
      *
      * @param string $name
-     * @return mixed
+     * @return string
      */
     public function opt(string $name)
     {
@@ -94,7 +94,7 @@ 
      * Returns command arguments array
      * Values must be instances of InputArgument
      *
-     * @return array|InputArgument[]
+     * @return \Symfony\Component\Console\Input\InputArgument[]
      */
     public function returnArguments(): array
     {
@@ -105,7 +105,7 @@ 
      * Returns command options array
      * Values must be instances of InputOption
      *
-     * @return array|InputOption[]
+     * @return \Symfony\Component\Console\Input\InputOption[]
      */
     public function returnOptions(): array
     {

src/Container/spec/ArgumentResolverSpec.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Venta\Container\ArgumentResolver;
 use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
 use Venta\Contracts\Container\ArgumentResolver as ArgumentResolverContract;
 use Venta\Contracts\Container\Container;
 

src/Container/src/Container.php

Doc Comments +1 added lines, -1 removed lines

@@ -397,7 +397,7 @@
     /**
      * Verifies that provided callable can be called by service container.
      *
-     * @param $normalizedCallable
+     * @param callable $normalizedCallable
      * @return bool
      */
     private function isResolvableCallable($normalizedCallable): bool

Indentation +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
     public function __construct()
     {
         $this->setArgumentResolver(new ArgumentResolver($this))
-             ->setObjectInflector(new ObjectInflector($this->argumentResolver));
+                ->setObjectInflector(new ObjectInflector($this->argumentResolver));
     }
 
     /**

Spacing +6 added lines, -6 removed lines

@@ -118,7 +118,7 @@ 
         if (!$this->isResolvableService($class)) {
             throw new InvalidArgumentException(sprintf('Class "%s" does not exist.', $class));
         }
-        $this->register($id, $shared, function ($id) use ($class) {
+        $this->register($id, $shared, function($id) use ($class) {
             $this->classDefinitions[$id] = $class;
         });
     }
@@ -133,7 +133,7 @@ 
             throw new InvalidArgumentException('Invalid callable provided.');
         }
 
-        $this->register($id, $shared, function ($id) use ($normalizedCallable) {
+        $this->register($id, $shared, function($id) use ($normalizedCallable) {
             $this->callableDefinitions[$id] = $normalizedCallable;
         });
     }
@@ -146,7 +146,7 @@ 
         if (!$this->isConcrete($instance)) {
             throw new InvalidArgumentException('Invalid instance provided.');
         }
-        $this->register($id, true, function ($id) use ($instance) {
+        $this->register($id, true, function($id) use ($instance) {
             $this->instances[$id] = $instance;
         });
     }
@@ -317,13 +317,13 @@ 
             }
 
             // Wrap with Closure to save reflection resolve results.
-            return function (array $arguments = []) use ($object, $method, $resolve) {
+            return function(array $arguments = []) use ($object, $method, $resolve) {
                 return ([$object, $method])(...$resolve($arguments));
             };
         }
 
         // We have Closure or "functionName" string.
-        return function (array $arguments = []) use ($callable, $resolve) {
+        return function(array $arguments = []) use ($callable, $resolve) {
             return $callable(...$resolve($arguments));
         };
     }
@@ -346,7 +346,7 @@ 
             ? $this->argumentResolver->resolveArguments($constructor)
             : null;
 
-        return function (array $arguments = []) use ($class, $resolve) {
+        return function(array $arguments = []) use ($class, $resolve) {
             $object = $resolve ? new $class(...$resolve($arguments)) : new $class();
 
             return $object;

src/Container/src/Exception/UnresolvableDependencyException.php

Doc Comments +1 added lines

@@ -18,6 +18,7 @@
     /**
      * @inheritDoc
      * @param ArgumentResolverException $previous
+     * @param string $entryId
      */
     public function __construct($entryId, array $referenceChain, ArgumentResolverException $previous)
     {

Spacing +2 added lines, -4 removed lines

@@ -48,8 +48,7 @@ 
     private function formatFunction(ReflectionFunctionAbstract $function)
     {
         return $function instanceof ReflectionMethod ?
-            $function->getDeclaringClass()->getName() . '::' . $function->getName() :
-            $function->getName();
+            $function->getDeclaringClass()->getName() . '::' . $function->getName() : $function->getName();
     }
 
     /**
@@ -61,7 +60,6 @@ 
     private function formatParameter(ReflectionParameter $parameter): string
     {
         return $parameter->hasType() ?
-            sprintf('%s $%s', $parameter->getType(), $parameter->getName()) :
-            sprintf('$%s', $parameter->getName());
+            sprintf('%s $%s', $parameter->getType(), $parameter->getName()) : sprintf('$%s', $parameter->getName());
     }
 }
\ No newline at end of file

src/Contracts/src/Http/Cookie.php

Doc Comments +2 added lines, -2 removed lines

@@ -53,7 +53,7 @@ 
     /**
      * Method that transforms Class to a plain text to include it in Response header
      *
-     * @return mixed
+     * @return string
      */
     public function asPlainText();
 
@@ -73,7 +73,7 @@ 
     public function getName();
 
     /**
-     * @return string;
+     * @return string|null
      */
     public function getValue();
 

src/Framework/Commands/RouteMatch.php

Doc Comments +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
     /**
      * RouteMatch constructor.
      *
-     * @param RouteCollector $collector
+     * @param \Mockery\MockInterface $collector
      * @param \Venta\Contracts\Routing\RouteMatcher $matcher
      * @param RequestFactory $requestFactory
      */

src/Framework/ErrorHandler/ErrorHandlerLogger.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * ErrorHandlerLogger constructor.
      *
-     * @param LoggerInterface $logger
+     * @param \Psr\Log\LoggerInterface $logger
      */
     public function __construct(LoggerInterface $logger)
     {

src/Framework/ErrorHandler/ErrorHandlerProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
     /**
      * Adding error handling middleware
      *
-     * @param \Venta\Contracts\Routing\MiddlewareCollector $middlewareCollector
+     * @param \Mockery\MockInterface $middlewareCollector
      * @return void
      */
     public function provideMiddlewares(MiddlewareCollector $middlewareCollector)

Spacing +3 added lines, -4 removed lines

@@ -82,8 +82,7 @@ 
             // Push pretty page handler only for local environment
             $whoops->pushHandler(
                 $kernel->getEnvironment() === 'local' ?
-                    new PrettyPageHandler() :
-                    new PlainTextHandler()
+                    new PrettyPageHandler() : new PlainTextHandler()
             );
         }
         /**
@@ -94,10 +93,10 @@ 
         /*
          * Bind PSR-3 logger
          */
-        $container->share(\Monolog\Logger::class, function (Container $c) {
+        $container->share(\Monolog\Logger::class, function(Container $c) {
             $logger = new \Monolog\Logger('venta');
             $handler = new \Monolog\Handler\StreamHandler(__DIR__ . '/../storage/logs/app.log');
-            $handler->pushProcessor(function ($record) use ($c) {
+            $handler->pushProcessor(function($record) use ($c) {
                 /** @var \Venta\Contracts\Kernel\Kernel $kernel */
                 $kernel = $c->get(Kernel::class);
                 if ($kernel->isCli()) {

src/Framework/tests/KernelTest.php

Doc Comments +4 added lines

@@ -82,6 +82,10 @@
         $kernel = new class($container, __DIR__, 'providers.php') extends \Venta\Framework\Kernel\AbstractKernel
         {
 
+            /**
+             * @param string $name
+             * @param Mockery\MockInterface $instance
+             */
             public function addExtensionProviderInstance($name, $instance)
             {
                 $this->extensions[$name] = $instance;

Indentation +8 added lines, -8 removed lines

@@ -42,17 +42,17 @@
         $container->shouldReceive('share')->with(Container::class, $container, ['container'])->passthru();
         $container->shouldReceive('share')->with(Kernel::class, Mockery::type(Kernel::class), ['kernel']);
         $container->shouldReceive('share')
-                  ->with(RouteCollectorContract::class, Mockery::type(Closure::class))
-                  ->passthru();
+                    ->with(RouteCollectorContract::class, Mockery::type(Closure::class))
+                    ->passthru();
         $container->shouldReceive('share')
-                  ->with(MiddlewareCollectorContract::class, Mockery::type(Closure::class))
-                  ->passthru();
+                    ->with(MiddlewareCollectorContract::class, Mockery::type(Closure::class))
+                    ->passthru();
         $container->shouldReceive('share')
-                  ->with(CommandCollectorContract::class, Mockery::type(Closure::class))
-                  ->passthru();
+                    ->with(CommandCollectorContract::class, Mockery::type(Closure::class))
+                    ->passthru();
         $container->shouldReceive('share')
-                  ->with(ConfigContract::class, Mockery::type(Closure::class), ['config'])
-                  ->passthru();
+                    ->with(ConfigContract::class, Mockery::type(Closure::class), ['config'])
+                    ->passthru();
 
         $routeCollector = Mockery::mock(RouteGroup::class);
         $routeCollector->shouldReceive('group')->with('/', Mockery::type('callable'))->twice();

Spacing +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
     {
         $container = Mockery::mock(Container::class);
         $container->shouldReceive('share')->with(Container::class, $container, ['container'])->once();
-        $container->shouldReceive('share')->with(Kernel::class, Mockery::on(function ($arg) {
+        $container->shouldReceive('share')->with(Kernel::class, Mockery::on(function($arg) {
             return $arg instanceof Kernel;
         }), ['kernel'])->once();