Json::fromFile() - Code Metrics - Inspection of "Merge branch 'master' into config" - venta/framework - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( b5ddc7...73c405 )

by Konstantins

created 2016-12-19 08:54 UTC

Json::fromFile() A

↳ Parent: Json

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	0
cts	0
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1
crap	6

<?php declare(strict_types = 1);

namespace Venta\Config\Parser;

use League\Flysystem\FilesystemInterface;
use Venta\Contracts\Config\ConfigFileParser;

/**
 * Class Json
 *
 * @package Venta\Config\Parser
 */
class Json implements ConfigFileParser
{
    /**
     * @var FilesystemInterface
     */
    private $filesystem;

    /**
     * Construct function.
     *
     * @param FilesystemInterface $filesystem
     */
    public function __construct(FilesystemInterface $filesystem)
    {
        $this->filesystem = $filesystem;
    }

    /**
     * @inheritDoc
     */
    public function fromFile(string $filename): array
    {
        if ($this->filesystem->has($filename)) {
            return $this->fromString($this->filesystem->read($filename));

        }

        throw new \RuntimeException(sprintf('Unable to parse configuration file: "%s".', $filename));
    }

    /**
     * @inheritDoc
     */
    public function fromString(string $configuration): array
    {
        $array = json_decode($configuration, true);
        if (json_last_error() !== JSON_ERROR_NONE) {
            throw new \RuntimeException(
                sprintf('Unable to parse configuration string: "%s".', json_last_error_msg()),
                json_last_error()
            );
        }

        return $array;
    }

    /**
     * @inheritDoc
     */
    public function supportedExtensions(): array
    {
        return ['json'];
    }
}

1		<?php declare(strict_types = 1);
2
3		namespace Venta\Config\Parser;
4
5		use League\Flysystem\FilesystemInterface;
6		use Venta\Contracts\Config\ConfigFileParser;
7
8		/**
9		* Class Json
10		*
11		* @package Venta\Config\Parser
12		*/
13		class Json implements ConfigFileParser
14		{
15		/**
16		* @var FilesystemInterface
17		*/
18		private $filesystem;
19	3
20		/**
21	3	* Construct function.
22	3	*
23	1	* @param FilesystemInterface $filesystem
24	1	*/
25		public function __construct(FilesystemInterface $filesystem)
26		{
27		$this->filesystem = $filesystem;
28		}
29	2
30		/**
31		* @inheritDoc
32		*/
33		public function fromFile(string $filename): array
34		{
35		if ($this->filesystem->has($filename)) {
36		return $this->fromString($this->filesystem->read($filename));
		0 ignored issues – show Security Bug introduced 2016-12-19 09:00 UTC by Report Bug Copy Issue Report It seems like `$this->filesystem->read($filename)` targeting `League\Flysystem\FilesystemInterface::read()` can also be of type `false`; however, `Venta\Config\Parser\Json::fromString()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history...
37		}
38
39		throw new \RuntimeException(sprintf('Unable to parse configuration file: "%s".', $filename));
40		}
41
42		/**
43		* @inheritDoc
44		*/
45		public function fromString(string $configuration): array
46		{
47		$array = json_decode($configuration, true);
48		if (json_last_error() !== JSON_ERROR_NONE) {
49		throw new \RuntimeException(
50		sprintf('Unable to parse configuration string: "%s".', json_last_error_msg()),
51		json_last_error()
52		);
53		}
54
55		return $array;
56		}
57
58		/**
59		* @inheritDoc
60		*/
61		public function supportedExtensions(): array
62		{
63		return ['json'];
64		}
65		}

venta / framework

Push — master ( b5ddc7...73c405 )

Json::fromFile() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like